Commit graph

177 commits

Author SHA1 Message Date
Brandon Low
74cbb0a1b2 Give color targets the ability to display each LCD line a different color and use this newfangled ability to provide themable colored file types. See the comments on read_color_theme_file and the sample.colors file provided for how to use this. .colors files go in themes directory for now. This separate line color function should be trivial to add to menus and wpss.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13656 a1c6a512-1295-4272-9138-f99709370657
2007-06-17 21:16:34 +00:00
Jonathan Gordon
57440d5292 Fix a minor annoyance with the last commit where selecting an item could result in having empty space under the list.
Also very very minor code reduction.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13607 a1c6a512-1295-4272-9138-f99709370657
2007-06-10 08:18:19 +00:00
Jonathan Gordon
f4d0f053e6 Really fix FS#7274
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13606 a1c6a512-1295-4272-9138-f99709370657
2007-06-10 07:12:39 +00:00
Jonathan Gordon
f3145ba07c simple fix for FS#7274 - selected item might not be shown when a list is drawn in paged scroll mode
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13602 a1c6a512-1295-4272-9138-f99709370657
2007-06-09 09:41:13 +00:00
Jonathan Gordon
3823486a58 Add a mode the lists which doesnt show the selection marker.
Useful for the debug menus where users shouldn't think pressing select would do anything.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13588 a1c6a512-1295-4272-9138-f99709370657
2007-06-07 12:14:31 +00:00
Jonathan Gordon
fea88888f0 Fix most (all) known list wierdness bugs, hopefully simplifies the code a bit, plenty of room for optimizing, but wanted to get it working first. (fixes FS#7255 and possibly others)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13556 a1c6a512-1295-4272-9138-f99709370657
2007-06-05 02:57:43 +00:00
Jonathan Gordon
20a8a9a3c8 Move the old api out of the core and into the plugin lib.
ew plugins shuold use the new api and not this one.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13537 a1c6a512-1295-4272-9138-f99709370657
2007-06-03 04:06:58 +00:00
Nils Wallménius
fbdbd2112c Fix warning
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13525 a1c6a512-1295-4272-9138-f99709370657
2007-05-30 18:08:29 +00:00
Nils Wallménius
f46657ec5a Move the setvol wrapper function to misc.c and use it in more places instead of doing the same checks everywhere
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13524 a1c6a512-1295-4272-9138-f99709370657
2007-05-30 17:57:32 +00:00
Jonathan Gordon
dfb071d92e Last list commit for a while. fix the multi-item lists at the very end of the list
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13523 a1c6a512-1295-4272-9138-f99709370657
2007-05-30 09:25:59 +00:00
Jonathan Gordon
0178568325 fix non-paged scrolling aroun the ends of lists
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13522 a1c6a512-1295-4272-9138-f99709370657
2007-05-30 09:11:59 +00:00
Jonathan Gordon
5983e7fa42 few more list anomolys fixed..
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13521 a1c6a512-1295-4272-9138-f99709370657
2007-05-30 08:29:44 +00:00
Jonathan Gordon
155e3d33d6 Fix the last (?) of the selction wierdness, this time when moving at the begining of the list
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13520 a1c6a512-1295-4272-9138-f99709370657
2007-05-30 02:08:35 +00:00
Jonathan Gordon
6fd3d96309 fix selection wierdness when scrolling down at the end of lists
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13514 a1c6a512-1295-4272-9138-f99709370657
2007-05-29 13:06:41 +00:00
Jonathan Gordon
20202017f4 Really fix FS#7230 this time.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13513 a1c6a512-1295-4272-9138-f99709370657
2007-05-29 12:28:02 +00:00
Jonathan Gordon
195ac12296 Fix FS#7230 - the second line in a multi-line item could be the selected item
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13512 a1c6a512-1295-4272-9138-f99709370657
2007-05-29 12:16:31 +00:00
Jonathan Gordon
42698e4e47 Accept FS#6798 - scan acceleration for the lists.
Settings are in display > scrolling


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13499 a1c6a512-1295-4272-9138-f99709370657
2007-05-27 15:08:56 +00:00
Jonathan Gordon
c9ed673c81 only show the cursor for the first line of the selected item (if selection is more than one line). doesnt effect inverted cursor mode
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13375 a1c6a512-1295-4272-9138-f99709370657
2007-05-12 14:13:23 +00:00
Jonathan Gordon
39a6b5d643 Stop using the old menu API in the debug menu (using the new api causes massive bin increase, so fake the old api with existing code instead) (onplay.c and plugins are the only parts using th eold api now)
Fix a bug where the menu title was sometimes shown in the system font


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13286 a1c6a512-1295-4272-9138-f99709370657
2007-04-29 15:31:43 +00:00
Jonathan Gordon
7f3c66f1cb Fix the playlist viewer so only 1 line flashes when you move a track
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13231 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 11:14:57 +00:00
Jonathan Gordon
6a5cc0bd25 Customizable icons for all bitmap targets. (FS#7013)
http://www.rockbox.org/twiki/bin/view/Main/CustomIcons for info on format and how to load them


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13177 a1c6a512-1295-4272-9138-f99709370657
2007-04-16 09:14:36 +00:00
Jens Arnold
0b7bb31453 Simplification, queue pointers don't wrap (except at INT_MAX, but the calculation is still correct in this case). Implemented queue_count() for the simulator.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13154 a1c6a512-1295-4272-9138-f99709370657
2007-04-14 09:47:47 +00:00
Jonathan Gordon
08e633c25c Hide the list title if only one line would fit under it
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13107 a1c6a512-1295-4272-9138-f99709370657
2007-04-11 10:34:44 +00:00
Jonathan Gordon
a053e58894 minor actions cleanup:
- CONTEXT_MAINMENU is not actually needed, use CONTEXT_TREE which does the same actions
- (gigabeat) use vol+/- in the lists to control volume (every list!) (FS#6982 in a better way)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13062 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 01:33:01 +00:00
Magnus Holmgren
1329d7d3fd Fix occasional missing cursor when moving up in a list with a title when paged scrolling is on.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12814 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 07:30:33 +00:00
Miika Pekkarinen
2eefb5acb8 Optimized the gui list code performance, including automatic frame dropping and cpu boosting when button events are getting queued. Improved scrollwheel acceleration code is needed to notice a real change.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12721 a1c6a512-1295-4272-9138-f99709370657
2007-03-11 10:52:36 +00:00
Jonathan Gordon
f83d6eb145 revert FS#6747 — y-margin reset in gui_list_draw, it introduced a nasty
scroll bug which isnt so simple to fix.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12719 a1c6a512-1295-4272-9138-f99709370657
2007-03-11 08:05:05 +00:00
Jonathan Gordon
4949818c24 only call display->setmargins() once
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12706 a1c6a512-1295-4272-9138-f99709370657
2007-03-10 13:05:47 +00:00
Jonathan Gordon
a990ff2920 Accept FS#6747 by Timo Horstschäfer
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12704 a1c6a512-1295-4272-9138-f99709370657
2007-03-10 12:43:21 +00:00
Linus Nielsen Feltzing
298c2bbd83 Allow dynamic menu items to be spoken, especially the resume/now playing item
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12614 a1c6a512-1295-4272-9138-f99709370657
2007-03-05 00:32:33 +00:00
Jonathan Gordon
5ea43ce8a9 thats what happens when you commit between dinner courses :p
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12582 a1c6a512-1295-4272-9138-f99709370657
2007-03-04 08:35:20 +00:00
Jonathan Gordon
e6ba70548d Fix red builds.
(Previous commit was for FS#6713 btw)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12581 a1c6a512-1295-4272-9138-f99709370657
2007-03-04 08:05:33 +00:00
Jonathan Gordon
ca701bf62e Add a function to get the actual button that was pressed (and some
status codes) instead of the action. Use this to figure out which screen 
to do prev/next page on in the lists


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12580 a1c6a512-1295-4272-9138-f99709370657
2007-03-04 07:45:12 +00:00
Jonathan Gordon
7ae5f12449 The list should reset the x margin when it finishes drawing. Not leave
it up to the next screen


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12570 a1c6a512-1295-4272-9138-f99709370657
2007-03-03 13:42:12 +00:00
Steve Bavin
361a60c964 Centralise icon enabling to hopefully save a few bytes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12540 a1c6a512-1295-4272-9138-f99709370657
2007-03-01 18:25:13 +00:00
Nils Wallménius
7fdee10a70 Make private functions static. Remove some functions from the plugin api as they weren't used in any plugins and could then be declared static.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12462 a1c6a512-1295-4272-9138-f99709370657
2007-02-23 21:52:45 +00:00
Jonathan Gordon
eff0dc3e13 Allow the list to display a title icon even if no other icons will be
displayed


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12375 a1c6a512-1295-4272-9138-f99709370657
2007-02-18 00:52:34 +00:00
Daniel Stenberg
20a5926d2e build with -Wundef to make sure we have spelled the defines right in #if lines
and have the proper includes included etc


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12360 a1c6a512-1295-4272-9138-f99709370657
2007-02-17 21:54:17 +00:00
Jens Arnold
2597a13497 Next round of static'ing and related fixes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11836 a1c6a512-1295-4272-9138-f99709370657
2006-12-25 14:01:47 +00:00
Peter D'Hoye
3e1f837d11 Turned function back into define as that uses less bytes because gcc inlined the function.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11699 a1c6a512-1295-4272-9138-f99709370657
2006-12-09 12:27:04 +00:00
Peter D'Hoye
552ac5a724 Fix crash in browser when using very big fonts and show path option together. Solves FS#6397. Patch created by Mark Arigo and modified by me. Minor code ploicing while in there.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11696 a1c6a512-1295-4272-9138-f99709370657
2006-12-09 10:02:09 +00:00
Jonathan Gordon
6a1161b634 dont allow the volume setting to wrap
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11445 a1c6a512-1295-4272-9138-f99709370657
2006-11-06 10:11:51 +00:00
Jonathan Gordon
717f63e8e2 fixes fs# 5938 - scrollbar with title enabled shows one less than it should
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11412 a1c6a512-1295-4272-9138-f99709370657
2006-11-01 12:03:27 +00:00
Martin Scarratt
4a1d8d272a fix warning
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11043 a1c6a512-1295-4272-9138-f99709370657
2006-09-25 11:06:54 +00:00
Martin Scarratt
1ab1f02dfe fix the bug where when scrolling text left in the filebrowser you could suddenly find yourself in the root directory. A long press on the left scrolling button will still take you to the root quickly.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11042 a1c6a512-1295-4272-9138-f99709370657
2006-09-25 10:56:38 +00:00
Jonathan Gordon
4553069f9d holding left in the tree will quickly get back to root, as long as the text is in the left-most position (like before)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10965 a1c6a512-1295-4272-9138-f99709370657
2006-09-17 08:30:17 +00:00
Mark Arigo
34301bb37b Add optional icon to list title, current path display shows a dir icon, and list titles now left-justified.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10726 a1c6a512-1295-4272-9138-f99709370657
2006-08-23 20:02:06 +00:00
Jonathan Gordon
66c4bd6e63 Stop lists wrapping when using page up/down
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10712 a1c6a512-1295-4272-9138-f99709370657
2006-08-23 08:35:31 +00:00
Dan Everton
98c9f959e5 Clear file view title if the user turns it off.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10596 a1c6a512-1295-4272-9138-f99709370657
2006-08-15 22:14:35 +00:00
Jonathan Gordon
599fa9a627 fix "off-by-one" bug in paginated scrolling with the title
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10589 a1c6a512-1295-4272-9138-f99709370657
2006-08-15 14:06:29 +00:00
Linus Nielsen Feltzing
224c0a13eb Finally, the new button action system is here, thanks to Jonathan Gordon. Some button mappings have changed and other things may break. Comments should go to the forum, http://forums.rockbox.org/index.php?topic=5829.0 or the mailing list.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10582 a1c6a512-1295-4272-9138-f99709370657
2006-08-15 12:27:07 +00:00
Dan Everton
c0f8b18770 A few changes and fixes for the title in the file view: disable title string in tagcache view, strip leading / from current directory title, center title properly, scroll title if it's too long.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10581 a1c6a512-1295-4272-9138-f99709370657
2006-08-15 12:23:55 +00:00
Dave Chapman
079ad11896 Patch #5795 from Jonathan Gordon - change the settings display for enumerations and integers to use the list widget. Patch also adds an optional title to the list widget which is used in the settings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10576 a1c6a512-1295-4272-9138-f99709370657
2006-08-15 08:14:46 +00:00
Shachar Liberman
f53779d2f4 Committing FS#5182 - One button hold for Horizontal screen scrolling.
=>hold RIGHT or LEFT button on a GUI based list to scroll horizontally.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10545 a1c6a512-1295-4272-9138-f99709370657
2006-08-12 13:40:49 +00:00
Kevin Ferrare
f64280ff00 OOPS Forgot remote keys bindings for the ID3 info screen
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10176 a1c6a512-1295-4272-9138-f99709370657
2006-07-02 16:18:59 +00:00
Kevin Ferrare
f77ac7a6a7 added support remote support for the id3 infos screen (had to slightly change the list engine to use it here as well), corrected a mistake in the french translation
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10175 a1c6a512-1295-4272-9138-f99709370657
2006-07-02 12:28:27 +00:00
Hardeep Sidhu
d2a4762847 Added a yield() after each pgup/pgdn similar to what is done for prev/next. Fixes B#5354.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10054 a1c6a512-1295-4272-9138-f99709370657
2006-06-04 17:14:17 +00:00
Hristo Kovachev
38deb8f13a Patch #4864 by Jonathan Gordon: text editor plugin, with some changes by me.
Also correct a var clash between the rockbox's gui api and doom plugin


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9451 a1c6a512-1295-4272-9138-f99709370657
2006-04-03 08:51:08 +00:00
Dan Everton
5b854a9a23 Fix player target and sim.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8984 a1c6a512-1295-4272-9138-f99709370657
2006-03-09 22:26:22 +00:00
Dan Everton
4a9ac1497f Reset font before calculating number of lines to display in the list. Fixes returning to a list display from a plugin that changes the display font.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8982 a1c6a512-1295-4272-9138-f99709370657
2006-03-09 22:03:13 +00:00
Jens Arnold
237d3c4c4b Adaptive button repeat: adapts repeat rate depending on the ability of the application to cope. Avoids afterscroll and similar effects. * Yield while scrolling through lists.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8738 a1c6a512-1295-4272-9138-f99709370657
2006-02-19 13:34:12 +00:00
Dan Everton
dd39e33663 Don't leave whitespace on last screen when in paged scrolling mode.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8685 a1c6a512-1295-4272-9138-f99709370657
2006-02-13 20:48:44 +00:00
Dan Everton
869275f8ee Add paged scrolling option. Really helps when scrolling through large lists on targets with slow LCDs.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8682 a1c6a512-1295-4272-9138-f99709370657
2006-02-13 19:39:48 +00:00
Brandon Low
d3a03b679f Horizontal screen scrolling part 3 (by Shachar Liberman)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8414 a1c6a512-1295-4272-9138-f99709370657
2006-01-22 04:24:26 +00:00
Tomas Salfischberger
7fa39df427 Horizontal scrolling patch by Shachar Liberman
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8412 a1c6a512-1295-4272-9138-f99709370657
2006-01-22 01:42:05 +00:00
Linus Nielsen Feltzing
5caf36d122 Patch #1387569 by Stephan Wezel - page-down doesn't select the element before the last element
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8294 a1c6a512-1295-4272-9138-f99709370657
2005-12-29 00:21:55 +00:00
Daniel Stenberg
b05eec8b1e Big Code Police raid. Pretty pretty please, we do no macrofy simple
assignments and things just to make them appear as function calls. That makes
code harder to follow. Did some gcc4 warning fixes as well.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8163 a1c6a512-1295-4272-9138-f99709370657
2005-12-05 23:37:14 +00:00
Kevin Ferrare
15046f99b3 show/hide icons now works properly in playlist viewer
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7911 a1c6a512-1295-4272-9138-f99709370657
2005-11-16 17:23:49 +00:00
Kevin Ferrare
8517ed8939 Multi screen support for playlist viewer, some fixes in other gui files
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7901 a1c6a512-1295-4272-9138-f99709370657
2005-11-16 02:12:25 +00:00
Jens Arnold
edf5a70e27 Replaced the common for(i = 0; i < NB_SCREENS; i++) loop with a macro that just expands to i = 0; instead of the for() loop if NB_SCREENS == 1. Reduces binary size on platforms with only one screen.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7805 a1c6a512-1295-4272-9138-f99709370657
2005-11-09 22:47:15 +00:00
Kevin Ferrare
f7c97522a8 Fixed the icon for unknown file types on the archos Player, and the bug when removing the last file on the screen in filetree, added some code for playlists integration with multi-screen
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7800 a1c6a512-1295-4272-9138-f99709370657
2005-11-09 01:17:57 +00:00
Kevin Ferrare
4158ba1ff1 Changed back the copyright's name in onplay.c (silly UTF-8, sorry Björn ! ), changed the internal multi-screen API a little bit, in a cleaner way
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7716 a1c6a512-1295-4272-9138-f99709370657
2005-11-01 23:56:03 +00:00
Kevin Ferrare
db8415c99e Partial menus support on remote (only browsing is working, changing option isn't), corrected a bug in gui_list about scrollbar beeing displayed sometimes when it musn't
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7693 a1c6a512-1295-4272-9138-f99709370657
2005-10-30 22:34:51 +00:00
Kevin Ferrare
a3ed62b36f Corrected a bug on archos with buttonbar which was erased when filetree refreshed (mistake introduced in 2005/10/29 commit; Changed some copyrights in the files (I hope this time will be the good one and the last one ! )
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7684 a1c6a512-1295-4272-9138-f99709370657
2005-10-30 01:24:35 +00:00
Kevin Ferrare
e75cbdd2a8 Some changes to the remote code : some one lines function turned into macros ; changed pre-increment to post-increment since it's clearer that way ; added a data pointer to the list callback (global variables are baaaad) ; some more documentation of the API and minor cleanups
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7681 a1c6a512-1295-4272-9138-f99709370657
2005-10-29 02:33:19 +00:00
Kevin Ferrare
d452d26885 Changed some fn names, also corrected a bug with fonts and made the filetree work like the original one (stop on reaching list limits when pressing button)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7679 a1c6a512-1295-4272-9138-f99709370657
2005-10-28 23:52:49 +00:00
Linus Nielsen Feltzing
7da9477bc3 Initial multi screen support by Kévin Ferrare (Patch #1318081)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7666 a1c6a512-1295-4272-9138-f99709370657
2005-10-28 00:00:00 +00:00