Commit graph

26419 commits

Author SHA1 Message Date
Rafaël Carré
53b5abd93c aiff metadata: fix format string (%zd for size_t)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27572 a1c6a512-1295-4272-9138-f99709370657
2010-07-26 09:04:38 +00:00
Rafaël Carré
fc243f8e55 aiff codec: small clean up
- Use printf format width specifier for printing codecs
- Use sizeof() to get the number of supported formats
- Avoid a useless comparison

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27571 a1c6a512-1295-4272-9138-f99709370657
2010-07-26 08:59:21 +00:00
Rafaël Carré
cb86bc7e92 aiff metadata: skip chunks larger than buffer
Also use a stack temporary buffer bigger than id3->path

Fix FS#11494 which uses a (unparsed) 410 bytes comment chunk

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27570 a1c6a512-1295-4272-9138-f99709370657
2010-07-26 08:59:17 +00:00
Jonathan Gordon
839d62f255 Fix FS#11497 - switching from a .cue to fm would show the cuesheet bars on the frequency bar thingy
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27569 a1c6a512-1295-4272-9138-f99709370657
2010-07-26 08:43:01 +00:00
Thomas Martitz
f69e995bda Fix potential buffer overflow.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27568 a1c6a512-1295-4272-9138-f99709370657
2010-07-26 00:06:06 +00:00
Thomas Martitz
a3e6a865df Rewrite set_file() to be smaller and better readable, and a comment describing what it does.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27567 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 22:45:57 +00:00
Nils Wallménius
6325ef978b codecs: mark some local variables with 'static'
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27566 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 22:24:53 +00:00
Robert Bieber
d92f8174a1 Theme Editor: Added targetdb download to preferences dialog, fixed Cancel button on FontDownloader
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27565 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 21:59:35 +00:00
Robert Bieber
e1e51f9994 Theme Editor: Added recent docs/projects menus. Modified buildtargetdb.php to add a do-not-modify warning to the top of its output, and generated a new targetdb file with the warning in place
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27564 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 21:16:37 +00:00
Michael Chicoine
e024198305 Replace remaining printf in midi plugin (fix yellow/red)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27563 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 19:47:07 +00:00
Michael Chicoine
91a45d2ecc Rename printf to prevent naming conflict. Also change comment to conform with Rockbox standards.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27562 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 19:35:19 +00:00
Dominik Riebeling
803a0edb58 Fix USB ID retrieval on Windows 7.
The device string containing the USB IDs differs in casing on Windows 7
so always convert to upper case before scanning the string.  Use
DEVICEDESC instead of LOCATION_INFORMATION for the user visible device
string as the latter doesn't show anything useful to the user on W7, at
least for the devices I've tried. Unfortunately DEVICEDESC is less
descriptive than the previously used.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27561 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 19:25:38 +00:00
Thomas Martitz
d904597524 Use browse_folder() for browsing eq presets and languages.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27560 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 18:28:42 +00:00
Dominik Riebeling
62f661829b Theme Editor: fix building on Windows.
The imported qtfindreplacedialog assumes getting compiled as library.
Including the files directly causes problems on Windows because of its
__declspec() handling.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27559 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 18:06:41 +00:00
Thomas Martitz
4e8ef93509 Rockbox as an application: Fix a few yellows
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27558 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 17:07:56 +00:00
Thomas Martitz
c853097c2a Move the array to where it belongs
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27557 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 16:57:36 +00:00
Thomas Martitz
e513f69d25 Add default case back to silence gcc false positive abount ext and dir being used uninitialized.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27556 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 16:47:47 +00:00
Thomas Martitz
9ecfcb06ab A bit more cleanup in rockbox_browse().
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27555 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 16:40:35 +00:00
Thomas Martitz
d4b5922d3a Rewrite r21464 in a more compact/readable way. Reduces code duplication as well.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27554 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 16:27:41 +00:00
Rafaël Carré
5215773c9f bootchart.h doesn't need _ansi.h, especially not in a relative path
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27553 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 15:28:24 +00:00
Rafaël Carré
2e73e5fdcb database: fix include dirs
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27552 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 15:22:52 +00:00
Rafaël Carré
a2029a7bee Revert r27550 : we don't want to generate dependancies for firmware/
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27551 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 15:22:47 +00:00
Rafaël Carré
f1140dcdfa include firmware.make unconditionally
checkwps and database tools need to find their way to our headers

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27550 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 15:07:20 +00:00
Rafaël Carré
33f5b60999 strncpy.c / assert.h : need to include _ansi.h
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27549 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 14:53:06 +00:00
Rafaël Carré
a72aa856bd Move some gcc extensions to new gcc_extensions.h header
- Move ATTRIBUTE_PRINTF/ATTRIBUTE_SCANF from _ansi.h
  They are not related at all to this file, and this broke compilation
  with Code Sourcery GCC which ships its own _ansi.h
- Move LIKELY/UNLIKELY from system.h

There is likely a lot more GCC extensions used everywhere in the source,
conditionally on __GNUC__ or unconditionally

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27548 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 14:44:29 +00:00
Thomas Martitz
1828a753a8 Use MAX_PATH for array used for filename.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27547 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 14:29:06 +00:00
Rafaël Carré
ccdaf0a834 Remove rockbox 2.6 plugin API doc
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27546 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 13:54:13 +00:00
Thomas Martitz
67d61f2ba9 $rbdir => $temp_dir where appropriate, shadowing $rbdir with the temp dir broke wpsbuild.pl (for rbdir != ".rockbox")
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27545 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 13:44:30 +00:00
Marianne Arnold
6ce2c6753d Manual - Recording source settings description: replace target options with the correct features (needs one more in features.txt). Correct(s) wrong list of options in some manuals (e.g. Gigabeat S) at the same time.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27544 a1c6a512-1295-4272-9138-f99709370657
2010-07-25 00:27:07 +00:00
Robert Bieber
7a1a72a527 Theme Editor: Added resource check to project export
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27543 a1c6a512-1295-4272-9138-f99709370657
2010-07-24 22:41:45 +00:00
Alex Parker
1035fa95a3 Manual: Correct spelling (US-->UK) for "centre" in touchscreen keymaps.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27542 a1c6a512-1295-4272-9138-f99709370657
2010-07-24 19:24:13 +00:00
Nils Wallménius
7668c434a4 Fix FS#11204 logf build on h300 hung on bootup
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27541 a1c6a512-1295-4272-9138-f99709370657
2010-07-24 11:39:28 +00:00
Nils Wallménius
296ac7f716 Missed one.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27540 a1c6a512-1295-4272-9138-f99709370657
2010-07-24 10:53:58 +00:00
Nils Wallménius
d3fd3a372b s/HAVE_LCD_REMOTE/HAVE_REMOTE_LCD/
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27539 a1c6a512-1295-4272-9138-f99709370657
2010-07-24 10:51:58 +00:00
Nils Wallménius
4eda82ba58 Delete useless include.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27538 a1c6a512-1295-4272-9138-f99709370657
2010-07-24 08:19:25 +00:00
Robert Bieber
8556ad81bd Theme Editor: Implemented zip file project export
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27537 a1c6a512-1295-4272-9138-f99709370657
2010-07-24 08:10:44 +00:00
Nils Wallménius
97b9a4bad8 libatrac: Set the emac mode on coldfire, fixes whitenoise output if playing an atrac file after using a codec that sets macsr to integer mode.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27536 a1c6a512-1295-4272-9138-f99709370657
2010-07-23 23:47:22 +00:00
Andree Buschmann
7c33e1b4fe Introduce macros for identical multiply-add blocks.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27535 a1c6a512-1295-4272-9138-f99709370657
2010-07-23 22:06:45 +00:00
Robert Bieber
5297db9904 Theme Editor: Added interface for project export, exporting files to zip is still todo
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27534 a1c6a512-1295-4272-9138-f99709370657
2010-07-23 21:15:15 +00:00
Nils Wallménius
d15a4f617f Define CONFIG_REMOTE_KEYPAD for iaudio x5/m5 and add a keymap for that remote to the logo plugin. Fixes a warning when building with gcc 4.4.4.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27533 a1c6a512-1295-4272-9138-f99709370657
2010-07-23 20:20:40 +00:00
Thomas Martitz
ee166960b4 The previous commit was broken, not only because of the red. Fix it.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27532 a1c6a512-1295-4272-9138-f99709370657
2010-07-23 16:33:16 +00:00
Thomas Martitz
a0e83f3821 Make %tx work as intended, so that it ignores the true case for non-RDS targets.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27531 a1c6a512-1295-4272-9138-f99709370657
2010-07-23 16:24:12 +00:00
Nils Wallménius
28ba570e68 pdbox: disable strict aliasing optimizations since pdbox breaks the strict aliasing rules which causes warnings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27530 a1c6a512-1295-4272-9138-f99709370657
2010-07-23 08:56:18 +00:00
Nils Wallménius
f3a0ae59f5 libmad: small tweak to coldfire inline asm, gives a slight speedup and now builds fine with gcc 4.4.4
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27529 a1c6a512-1295-4272-9138-f99709370657
2010-07-23 08:47:31 +00:00
Robert Bieber
e6fd3d0318 Theme Editor: Switched back to Lorenzo Bettini's find/replace dialog (with some modifications) as he changed the license to LGPL v2.1
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27528 a1c6a512-1295-4272-9138-f99709370657
2010-07-23 07:31:53 +00:00
Robert Bieber
b21b771420 Theme Editor: Filled out the targets table in buildtargetdb.php and generated a new targetdb with it
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27527 a1c6a512-1295-4272-9138-f99709370657
2010-07-23 06:20:21 +00:00
Marianne Arnold
890295a6e0 Also fix Rockboy wrongly included in the Ipod Minis' manual. The option is just called 'ipodmini' because there is no difference between the two Minis important to the manual. Maybe the platform file should be renamed accordingly?.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27526 a1c6a512-1295-4272-9138-f99709370657
2010-07-23 04:21:54 +00:00
Marianne Arnold
7cb7c78346 Fix Rockboy wrongly included in the Ondio manuals - the linebreak after the opening { made TeX ignore the first following option, a comment also escapes the linebreak and helps here. Also change the option to ONDIO_PAD as the keypad is the important criteria here.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27525 a1c6a512-1295-4272-9138-f99709370657
2010-07-22 22:09:40 +00:00
Andree Buschmann
3f0b93c011 Submit FS#11491. Refactor coldfire inline asm within libmad's synth_full() to gain better readability. Thanks to Nils Wallménius for supporting.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27524 a1c6a512-1295-4272-9138-f99709370657
2010-07-22 18:57:31 +00:00
Rafaël Carré
f536f263c0 lcd-clip.h: mentions clipv2
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27523 a1c6a512-1295-4272-9138-f99709370657
2010-07-22 17:17:31 +00:00