Commit graph

69 commits

Author SHA1 Message Date
Magnus Holmgren
0b495f0a18 Improved Vorbis comment reader. The tags no longer need to fit in the first Ogg page to be fully read (album art can make the tags not fit).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21134 a1c6a512-1295-4272-9138-f99709370657
2009-05-30 14:24:16 +00:00
Mohamed Tarek
b68707d465 Add read_uint8() and read_uint16be() to metadata_common.c/h
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20968 a1c6a512-1295-4272-9138-f99709370657
2009-05-16 19:05:50 +00:00
Andrew Mahone
fd7002ae6c Attempt to fix yellow on sims (can't reproduce on my system).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20954 a1c6a512-1295-4272-9138-f99709370657
2009-05-16 02:06:22 +00:00
Dave Chapman
da3dc455f6 Change the type of read_uint32be to uint32_t and ensure all variables passed to that function are also of that type. No functional changes, but makes read_uint32be consistent with the other read_* functions and prevents warning in the upcoming RealAudio metadata parser.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20950 a1c6a512-1295-4272-9138-f99709370657
2009-05-15 22:45:03 +00:00
Robert Keevil
4f47b38938 Fix reading of Musicbrainz track IDs from ID3 tags - incorrect return values resulted in these tags being partially overwritten
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20719 a1c6a512-1295-4272-9138-f99709370657
2009-04-16 23:10:45 +00:00
Nils Wallménius
5a55772201 Small code reuse improvement
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19943 a1c6a512-1295-4272-9138-f99709370657
2009-02-08 11:09:55 +00:00
Magnus Holmgren
c54ddbd78c MP4/AAC: Add support for album artist tags written by Foobar2000. Closes FS#9723.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19669 a1c6a512-1295-4272-9138-f99709370657
2009-01-04 17:41:17 +00:00
Magnus Holmgren
5a00367a08 Fix FS#9522: stop reading an ID3v2 tag if a frame length is bad.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19005 a1c6a512-1295-4272-9138-f99709370657
2008-11-04 19:47:52 +00:00
Magnus Holmgren
ee378abe63 Add support for the album artist field used by Foobar2000 in ID3v2 tags.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18935 a1c6a512-1295-4272-9138-f99709370657
2008-10-30 19:00:24 +00:00
Bertrik Sikken
92683778f6 Add missing #include to mp3 metadata parser.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18885 a1c6a512-1295-4272-9138-f99709370657
2008-10-26 13:07:29 +00:00
Björn Stenberg
51b45d5602 Split id3.c/h into metadata.c/h and metadata/mp3.c. Updated all references. Moved mp3data.c/h from firmware to apps.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18814 a1c6a512-1295-4272-9138-f99709370657
2008-10-15 06:38:51 +00:00
Robert Keevil
2c170356f3 FS#9139 - support for ver 1.1 scrobbler log files. Upload any old files first - uploading software may need updating, see the LastFMLog wiki page
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18732 a1c6a512-1295-4272-9138-f99709370657
2008-10-07 18:39:44 +00:00
Nils Wallménius
1121af7b5e Print a helpful error in the sim for usupported formats in Ogg containers (f.e. Ogg/FLAC)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18623 a1c6a512-1295-4272-9138-f99709370657
2008-09-24 17:43:10 +00:00
Dominik Wenger
9b7566e3ec asap: fix stereo mode and hopefully fix metadata handling.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18140 a1c6a512-1295-4272-9138-f99709370657
2008-07-28 19:20:40 +00:00
Dave Chapman
0d2254f478 SAP codec: Ensure the module_info struct is correctly aligned - seems to fix the data aborts being reported on ARM targets (closes FS#9216).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18126 a1c6a512-1295-4272-9138-f99709370657
2008-07-27 10:49:43 +00:00
Dominik Wenger
49d318732f set svn:keywords on the new files.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18123 a1c6a512-1295-4272-9138-f99709370657
2008-07-26 15:32:08 +00:00
Dominik Wenger
25bb37bb68 commit asap codec. plays .sap files. At the moment it only plays the default song. So subSongs are ignored.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18121 a1c6a512-1295-4272-9138-f99709370657
2008-07-26 15:16:10 +00:00
Daniel Stenberg
2acc0ac542 Updated our source code header to explicitly mention that we are GPL v2 or
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 18:10:04 +00:00
Bertrik Sikken
17987addf8 Added missing header file to metadata/mod.c
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17645 a1c6a512-1295-4272-9138-f99709370657
2008-05-28 17:10:49 +00:00
Andree Buschmann
e1e0bc2675 We do not support mpc sv4-6 anymore.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17605 a1c6a512-1295-4272-9138-f99709370657
2008-05-22 10:08:24 +00:00
Thom Johansen
c0f7eb9f9d FS #8680. MOD codec by Rainer Sinsch.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17595 a1c6a512-1295-4272-9138-f99709370657
2008-05-21 11:19:58 +00:00
Bertrik Sikken
1273f95dab Added missing header file metadata_parsers.h to metadata parsers.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17308 a1c6a512-1295-4272-9138-f99709370657
2008-05-03 07:03:59 +00:00
Bertrik Sikken
2843469876 Moved atoi declaration to stdlib.h. Deleted atoi.h
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17280 a1c6a512-1295-4272-9138-f99709370657
2008-04-28 16:18:04 +00:00
Michael Giacomelli
1928ecf6d6 Opps.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17164 a1c6a512-1295-4272-9138-f99709370657
2008-04-18 23:19:28 +00:00
Michael Giacomelli
18cf59960f Inform the console when an unsupported WMA flavor is played.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17163 a1c6a512-1295-4272-9138-f99709370657
2008-04-18 23:18:06 +00:00
Jens Arnold
02580851ad Revert... stupid svn doesn't complain when passing -m twice :(
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16939 a1c6a512-1295-4272-9138-f99709370657
2008-04-02 22:45:23 +00:00
Jens Arnold
01a106dbfa Make the measured LCD scanrates from the greylib known to the scanrate test plugin.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16938 a1c6a512-1295-4272-9138-f99709370657
2008-04-02 22:42:21 +00:00
Dave Bryant
241fd0fbdb Fixes FS #8389 (wv error). For WavPack files that don't have the length stored in the header, guess a length on the
high-side as an interim fix. This plays fine (even gapless), but the progress bar is off and seeking is a little 
weird (but usable).


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16893 a1c6a512-1295-4272-9138-f99709370657
2008-03-30 19:28:31 +00:00
Jens Arnold
1f4bcc86da Revert accidental tree commit. /me needs a smaller enter key...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16805 a1c6a512-1295-4272-9138-f99709370657
2008-03-25 19:57:23 +00:00
Jens Arnold
9a7978aeab Cabbiev2 gigabeat background: reduce WPS backdrop filesize by storing it as 24 bit BMP instead of unnecessary 32 bit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16802 a1c6a512-1295-4272-9138-f99709370657
2008-03-25 19:43:08 +00:00
Jens Arnold
8c6920e343 Revert accidental tree commit. Sorry for that.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16574 a1c6a512-1295-4272-9138-f99709370657
2008-03-08 23:50:55 +00:00
Jens Arnold
d1ed7c37b1 No need to have \n here. panicf() won't output it anyway.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16570 a1c6a512-1295-4272-9138-f99709370657
2008-03-08 23:34:43 +00:00
Robert Kukla
893551e4ed remove reference to non-existing variable to make rockbox compile with logf enabled
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15930 a1c6a512-1295-4272-9138-f99709370657
2007-12-14 23:14:25 +00:00
Dan Everton
6fafb6cd98 Unify the Ogg Vorbis and Ogg Speex metadata parsers.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15897 a1c6a512-1295-4272-9138-f99709370657
2007-12-09 03:16:26 +00:00
Dave Chapman
d44c718e23 Correct the (C) info - I committed this on 15 June 2005 - r6715
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15878 a1c6a512-1295-4272-9138-f99709370657
2007-12-05 10:26:38 +00:00
Thom Johansen
ea4fc14a7f Set proper file attributes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15875 a1c6a512-1295-4272-9138-f99709370657
2007-12-04 21:07:11 +00:00
Thom Johansen
5915736dd5 Put A52/AC3 metadata parser in its own file. Cosmetic changes in metadata.c. Remove some unneeded headers from MPC metadata parser.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15874 a1c6a512-1295-4272-9138-f99709370657
2007-12-04 20:48:40 +00:00
Magnus Holmgren
50ea21132b ASF/WMA: Check if the file is encrypted. If so, don't try to play it.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15867 a1c6a512-1295-4272-9138-f99709370657
2007-12-02 12:52:00 +00:00
Magnus Holmgren
aee243e7d8 MPC: Simplify the ReplayGain parsing code.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15864 a1c6a512-1295-4272-9138-f99709370657
2007-12-01 11:55:19 +00:00
Thom Johansen
655fa16a9d Fix FS #8251, replaygain doesn't switch to track gain mode if album gain is missing from a file, also make unused replaygain entries not be displayed in track info.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15852 a1c6a512-1295-4272-9138-f99709370657
2007-11-30 01:10:28 +00:00
Magnus Holmgren
868d3ce39c Add ReplayGain support to WMA (based on tags written by Foobar2000).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15340 a1c6a512-1295-4272-9138-f99709370657
2007-10-28 11:09:55 +00:00
Thom Johansen
1129ed7faa Fix FS #7976. WMA metadata parser didn't store file size in metadata struct.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15150 a1c6a512-1295-4272-9138-f99709370657
2007-10-16 20:21:02 +00:00
Magnus Holmgren
9146f20ea2 MP4 tag parser: guard against problems when the buffer is full.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15105 a1c6a512-1295-4272-9138-f99709370657
2007-10-14 13:27:01 +00:00
Magnus Holmgren
5fc117ea4e Make the FLAC metadata parser a little more robust.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15093 a1c6a512-1295-4272-9138-f99709370657
2007-10-13 11:21:10 +00:00
Daniel Stenberg
c61e462ae3 read_mp4_tag_string() may return a NULL in the pointer so no code should rely
on the pointer being valid unless the return code is checked. This lead to the
year_string being accessed with atoi() even when being NULL => crash. This
fixes FS#7937.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15080 a1c6a512-1295-4272-9138-f99709370657
2007-10-11 22:53:08 +00:00
Magnus Holmgren
c5683b3c18 Correct another copyright line.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14450 a1c6a512-1295-4272-9138-f99709370657
2007-08-24 12:40:31 +00:00
Thom Johansen
1a24595446 Correct copyright line.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14449 a1c6a512-1295-4272-9138-f99709370657
2007-08-24 11:11:06 +00:00
Dave Bryant
bcf97a4801 Move WavPack metadata parsing to its own file and add handling of non-standard sampling rates
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14289 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 06:36:06 +00:00
Dan Everton
eecfe9f1cb Add support for grouping tags. From FS#7362.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14242 a1c6a512-1295-4272-9138-f99709370657
2007-08-08 10:19:56 +00:00
Dan Everton
60aeda07cc Fix ID3 struct member name for discnum in mp4 metadata parser.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14155 a1c6a512-1295-4272-9138-f99709370657
2007-08-03 10:06:52 +00:00