Magnus Holmgren
9c52c39528
Make some dependencies on id3.h explicit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18810 a1c6a512-1295-4272-9138-f99709370657
2008-10-14 18:40:52 +00:00
Björn Stenberg
9cf024c5a8
Red build fix: Moved PCM #defines from pcm_record.h to pcm.h. Added necessary #includes to statusbar.c and s1a0903x01.c.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18808 a1c6a512-1295-4272-9138-f99709370657
2008-10-14 11:43:32 +00:00
Nils Wallménius
68f6e83eb0
Alternate fix for the bug fixed by FS#9163, the selection in the playlist viewer was one line too low, which caused it to be off-screen if the last item was selected. The cause was that the selected item was set before the list title, fixed by re-calculating the position of the selected item after setting the title.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18797 a1c6a512-1295-4272-9138-f99709370657
2008-10-13 12:16:06 +00:00
Jonathan Gordon
8703cca459
Fix FS#9479 - "readonly" lists sometimes wrap when they shouldnt. part of the fix forced it to disable wrapping for these lists..
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18778 a1c6a512-1295-4272-9138-f99709370657
2008-10-12 10:21:44 +00:00
Jonathan Gordon
61c6526013
* Make %t stricter by aborting if a value is not given.
...
* Move the default value for %mv back into wps_parser.c where it belongs
* Add the debug line for the %mv tag
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18773 a1c6a512-1295-4272-9138-f99709370657
2008-10-11 13:49:38 +00:00
Jonathan Gordon
85600e629b
update the %mv wps tag to let you specify how long it should wait after being released to go back to false.
...
e.g %mv2 will stay true for 2 seconds or %mv3.5 is 3.5 seconds (same as the %t syntax)... if no number is specified it defaults to 1 second
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18769 a1c6a512-1295-4272-9138-f99709370657
2008-10-11 12:20:09 +00:00
Jonathan Gordon
98fa3913f9
change the %mv timeout to 1s which works better, also change the string to show "v" instead of .:| if its not used as a conditional
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18759 a1c6a512-1295-4272-9138-f99709370657
2008-10-09 23:15:16 +00:00
Jonathan Gordon
486869693c
FS#9460 - Add a tag %mv which can be used to check if the volume button is being pressed (e.g %?mv<yes|no> ). It will stay true after its released for a little over half a second (not configurable unless someone comes up with a nice way to add a parameter to the tag? 1s is too long and .5s is too short...
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18752 a1c6a512-1295-4272-9138-f99709370657
2008-10-09 11:10:26 +00:00
Jonathan Gordon
e8f7ad1b28
yes... i'm just trying to boost my ohloh score!
...
(also minor code policing again)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18716 a1c6a512-1295-4272-9138-f99709370657
2008-10-05 13:45:21 +00:00
Jonathan Gordon
6a81923e6e
bit of code police
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18715 a1c6a512-1295-4272-9138-f99709370657
2008-10-05 13:13:55 +00:00
Jonathan Gordon
1da2f0112e
Accept FS#9231 - viewportify the pitch screen by Thomas Martitz.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18714 a1c6a512-1295-4272-9138-f99709370657
2008-10-05 13:01:54 +00:00
Jonathan Gordon
2438d7881a
redo the previous commit so its actually useful.
...
if the callback returns ACTION_STD_CANCEL when the user presses ACTION_STD_OK the simple list will exit and set the selection. Otherwise, when ACTION_STD_CANCEL happens the selection will be set to -1
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18641 a1c6a512-1295-4272-9138-f99709370657
2008-09-25 08:12:25 +00:00
Jonathan Gordon
67df5f2434
have the info lists set the selection before they are exited, this is sometimes needed by the caller
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18640 a1c6a512-1295-4272-9138-f99709370657
2008-09-25 07:56:34 +00:00
Nils Wallménius
93a87685c3
Clean up use of snprintf where strncpy if suited, avoid useless copying of constant strings for wps token evaluator, minor const police too.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18625 a1c6a512-1295-4272-9138-f99709370657
2008-09-24 20:03:53 +00:00
Peter D'Hoye
3d0f01c0f7
fix red
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18442 a1c6a512-1295-4272-9138-f99709370657
2008-09-07 20:22:47 +00:00
Peter D'Hoye
3c1e9ca558
Change screens memebers char_width, char_height and nb_lines to functions returning a calculated value. Fixes FS #9361 because the values were calculated based on sysfont, not the user selected font.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18441 a1c6a512-1295-4272-9138-f99709370657
2008-09-07 20:09:11 +00:00
Nicolas Pennequin
7b514ffc68
A few comment updates and trailing spaces removals.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18433 a1c6a512-1295-4272-9138-f99709370657
2008-09-06 14:56:02 +00:00
Nicolas Pennequin
e0646947c9
Make %mm 0-based again (as described in CustomWPS), and change %cf accordingly.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18421 a1c6a512-1295-4272-9138-f99709370657
2008-09-04 22:08:03 +00:00
Nicolas Pennequin
939459e10e
Fix the bug reported in FS#9350: the WPS would crash on %mm or %cf if they weren't in conditionals.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18420 a1c6a512-1295-4272-9138-f99709370657
2008-09-04 21:57:01 +00:00
Frank Gevaerts
5d22e3cbdd
Add wpseditor, the Google Summer of Code 2008 project of Rostislav Chekan. Closes FS#9327
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18362 a1c6a512-1295-4272-9138-f99709370657
2008-08-29 21:08:38 +00:00
Maurus Cuelenaere
1392dc2144
Commit FS#9308: differentiate between TOUCHPAD & TOUCHSCREEN
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18338 a1c6a512-1295-4272-9138-f99709370657
2008-08-23 09:46:38 +00:00
Stéphane Doyon
58808b6216
Skip length: restore the ability to skip by just a few seconds
...
(which was the point of that feature).
See r18041.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18310 a1c6a512-1295-4272-9138-f99709370657
2008-08-18 01:03:07 +00:00
Stéphane Doyon
50512d696d
Fix for issues in speaking the time in Rockbox Info screen (B#9167).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18309 a1c6a512-1295-4272-9138-f99709370657
2008-08-18 00:58:47 +00:00
Nils Wallménius
01729e7a18
FS#9281 Rename of splash functions.
...
* Remove gui_splash()
* Rename gui_syncsplash() to splashf() and remove its voice
capabilities.
* Rename the internal splash() to splash_internal() and introduce an
externally visible splash() that handles simple splashing without
printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ,
"foo"); if a LANG_* id is passed it will be voiced.
* Adjust all places that called gui_syncsplash() to use the correct
variant from above.
* Export both new functions to plugins and adjust places calling
rb->splash() to use the correct variant so that we now have naming
consistency between the core and plugins.
* Fix one latent bug that would cause my sim to crash with the above
changes and correct P2STR and P2ID macros, thanks to pondlife.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18282 a1c6a512-1295-4272-9138-f99709370657
2008-08-15 08:27:39 +00:00
Bertrik Sikken
05945074d1
Fix FS#8689 (the peak meter does not work during a playing after a recording not followed by a reboot) by applying the patch from FS#9227.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18249 a1c6a512-1295-4272-9138-f99709370657
2008-08-11 22:12:40 +00:00
Bertrik Sikken
a11f656d68
Apply fix for FS#9203 (WPS gets corrupted after changing status bar setting) by Thomas Schott
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18192 a1c6a512-1295-4272-9138-f99709370657
2008-08-04 17:45:39 +00:00
Dominik Riebeling
02103a2fa7
Unify opening of utf-8 files (FS#6203). This also adds ignoring the BOM in several places it has been missing (as FS#6071).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18185 a1c6a512-1295-4272-9138-f99709370657
2008-08-02 20:39:03 +00:00
Bertrik Sikken
5356e6205b
Simplified function option_screen
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18083 a1c6a512-1295-4272-9138-f99709370657
2008-07-17 13:04:11 +00:00
Jonathan Gordon
d3cb2aca44
dont show the "cancelled" splash if the setting wasnt changed (only affects settings which have the F_TEMPVAR flag set)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18047 a1c6a512-1295-4272-9138-f99709370657
2008-07-15 14:25:16 +00:00
Thom Johansen
4a7e0c7949
Rename and rework the "Study Mode" menu into the "Skip Length" setting. Update manual. Bump plugin API thanks to having changed global_settings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18041 a1c6a512-1295-4272-9138-f99709370657
2008-07-14 20:39:30 +00:00
Nicolas Pennequin
ae05501716
Introduce a new WPS parsing error case: limits exceeded. It includes the cases when there are too many tokens, lines, sublines, viewports, strings, characters or conditional levels. This prevents the parser from failing silently or going on, as it used to do in those cases. Thanks to fml (Alexander Levin) for mentioning this issue.
...
I also changed the error types from #defines to an enum, for cleanliness.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18015 a1c6a512-1295-4272-9138-f99709370657
2008-07-12 15:12:09 +00:00
Magnus Holmgren
aae69dff45
Fix FS #9181 , allowing the documented 3 progress bars per WPS. Also simplify the code a little.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18008 a1c6a512-1295-4272-9138-f99709370657
2008-07-11 07:33:56 +00:00
Marc Guay
2bfcb95fea
Clean up the A-B repeat keymaps and add a note to gwps.c describing the ACTION_WPSAB_SINGLE #define. The Archos Player keypresses remain at large - if you have any info on their whereabouts please contact your local law enforcement.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17974 a1c6a512-1295-4272-9138-f99709370657
2008-07-07 05:17:15 +00:00
Jonathan Gordon
d035f255c9
get checkwps building again (FS#9150) - still doesnt compile on d2 and mr500 though
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17957 a1c6a512-1295-4272-9138-f99709370657
2008-07-06 13:23:28 +00:00
Jonathan Gordon
311d048f6f
fix FS#9144 hopefully for good... only update the screen if the time line is selected, or if talking menus are disabled, only update if the time line is actually on the screen. Also only update every 5s so scrolling lines still scroll. (turns out scroll_all was broken! fixed now)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17944 a1c6a512-1295-4272-9138-f99709370657
2008-07-05 12:31:04 +00:00
Jonathan Gordon
144f39b4ea
revert that scroll engine stuff... good in theory, but broken.
...
commit a band-aid fix for FS#9140 which is fine untill someone decides to not use the whole screen for it...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17916 a1c6a512-1295-4272-9138-f99709370657
2008-07-02 13:02:57 +00:00
Jens Arnold
4dab6235cf
The second part of this expression always becomes true before the first part, so the first part is unnecessary.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17907 a1c6a512-1295-4272-9138-f99709370657
2008-07-01 17:45:16 +00:00
Jonathan Gordon
272f79aa1a
Fix the bug where the german language would crash the quickscreen on the nano.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17889 a1c6a512-1295-4272-9138-f99709370657
2008-06-30 11:26:33 +00:00
Maurus Cuelenaere
475c2e7d05
Simplify touchscreen scrollbar handling code
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17861 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 23:48:37 +00:00
Peter D'Hoye
4af5dd84a2
fix red
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17859 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 21:02:43 +00:00
Peter D'Hoye
205f3df781
Remove a viewport ambiguity by changing the screens width/heigth members into lcdwidth/lcdheight. Normal usercode should always use getwidth()/getheigth() as that returns the viewport width/height. Fixes issues that would have appeared in many places when introducing viewports with sizes != lcd sizes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17857 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 20:45:21 +00:00
Maurus Cuelenaere
3d240f1e2a
Small fix for touchscreen interface
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17856 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 20:11:51 +00:00
Daniel Stenberg
2acc0ac542
Updated our source code header to explicitly mention that we are GPL v2 or
...
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 18:10:04 +00:00
Marcoen Hirschberg
2fb70bcabb
implement smooth seeking acceleration for audio playback and mpegplayer
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17843 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 17:55:53 +00:00
Jonathan Gordon
d8e56e30d7
allow the full lowercase a-z to be used as conditional viewport grouping id's
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17789 a1c6a512-1295-4272-9138-f99709370657
2008-06-25 08:08:39 +00:00
Jonathan Gordon
e0b957fd51
quick fix for FS#8729
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17780 a1c6a512-1295-4272-9138-f99709370657
2008-06-24 08:09:35 +00:00
Jonathan Gordon
bdbdb97f19
FS#9051 - remove LCD margins... use viewports if you need them...
...
NOTE to WPS people....
%m has been removed, but (i think) because of the other %m tags it wont fail if you try loading a wps with %m|..|, it will just be ignored.
Also note that if the statusbar is enabled the default viewport is 8 pixels shorter than when its not, i.e (0,0) is really (0,8) if the statusbar is shown... I dont think this will be a major issue because almost no WPS show the bar and use bitmaps... text only WPS shouldnt be affected.
Please report problem screens in http://forums.rockbox.org/index.php?topic=17358.0
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17763 a1c6a512-1295-4272-9138-f99709370657
2008-06-23 13:20:35 +00:00
Jonathan Gordon
082f50b947
fix yellow
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17760 a1c6a512-1295-4272-9138-f99709370657
2008-06-23 06:17:22 +00:00
Jonathan Gordon
5a169bb717
commit FS#9027 - conditional viewports
...
** BREAKS CURRENT WPS's **
* %P has been removed, merged with the new %pb
* %pb is now %pb or %pb|bitmap|x|y|width|height| (any of those params can be - to use sane defaults... check wiki/task for more explaination)
* New %Vl and %Vd tags which are used to setup and display conditionaly displayed viewports (%Vl|<id>|<usual %V params>| to set up, then %Vd<id> to enable the viewport
* bumps the max allowed viewport count to 24
* you can setup 3 different progressbars in a WPS... max of one per viewport though
http://www.rockbox.org/tracker/task/9027?getfile=16785 is a simple perl script to convert old %P/%pb to the new %pb syntax
I'll commit changes to the cabbie wps soon which shows how to use %Vl/%Vd properly...
Reminder: %m will be removed soonish also so when fixing your WPS's remember to use conditional viewports to replace %m
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17759 a1c6a512-1295-4272-9138-f99709370657
2008-06-23 06:04:17 +00:00
Jonathan Gordon
6653072292
bah, fix yellow
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17758 a1c6a512-1295-4272-9138-f99709370657
2008-06-23 02:57:24 +00:00