Commit graph

17 commits

Author SHA1 Message Date
Thomas Jarosch
c907e127f8 jz4740 usbtool: Fix undefined behavior in set_reg()
The variable 'i' should actually be 'size'.
See the read_reg() function above it.

Confirmed via private email from Maurus Cuelenaere. Thanks!
(who also remembered having trouble reading/setting
 registers over USB back then ;))

cppcheck reported:
[rockbox/utils/jz4740_tools/jz4740_usbtool.c:281]: (error) Uninitialized variable: i

Change-Id: I0f34834335e89d2504e7597e8db22cf69b5ca7e7
2015-01-04 18:16:44 +01:00
Thomas Jarosch
eac291348d Fix off-by-one buffer error
The _GET_CPU macro will write a terminating zero at cpu[8].

Detected by cppcheck

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30749 a1c6a512-1295-4272-9138-f99709370657
2011-10-14 12:07:47 +00:00
Maurus Cuelenaere
c5a3c8c670 Jz4740 USB tool:
* Add a slight delay, so that the pre-boot code gets time to execute
 * Remove an unneeded check


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20616 a1c6a512-1295-4272-9138-f99709370657
2009-04-04 17:53:59 +00:00
Maurus Cuelenaere
d99913289b Fix Jz4740 USB tools warnings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20592 a1c6a512-1295-4272-9138-f99709370657
2009-03-31 17:08:33 +00:00
Maurus Cuelenaere
c7b6ad5fdf Make Jz4740 USB tools a bit more configurable by letting you choose what file you want to upload when doing usbtool 10
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20415 a1c6a512-1295-4272-9138-f99709370657
2009-03-20 22:50:08 +00:00
Frank Gevaerts
f6ac3ec7ed Fix array sizes
Fix some error handling


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19406 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 20:13:50 +00:00
Maurus Cuelenaere
f3d5700df7 ... but still be compatible with OF..
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18396 a1c6a512-1295-4272-9138-f99709370657
2008-09-03 12:47:45 +00:00
Maurus Cuelenaere
aefbd6301a * Clean up Jz4740 USB tool a bit
* Make IHFSsplit compile under Windows
 * Change SDRAM base address + remove hack for Onda VX747


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18395 a1c6a512-1295-4272-9138-f99709370657
2008-09-03 12:42:14 +00:00
Maurus Cuelenaere
c9e31fba4d Fix compiling of Jz4740 usbtool
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18380 a1c6a512-1295-4272-9138-f99709370657
2008-09-01 19:56:12 +00:00
Maurus Cuelenaere
606c798b9b Jz4740 USB tool:
* Add preliminary support for NAND & ROM dump


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18341 a1c6a512-1295-4272-9138-f99709370657
2008-08-24 21:18:22 +00:00
Maurus Cuelenaere
72bc4e30e2 Jz4740 tools:
* Add HXF2IHFS by William Poetra Yoga Hadisoeseno
* Don't do usb_set_configuration() calls on Linux in USB tool


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18256 a1c6a512-1295-4272-9138-f99709370657
2008-08-12 16:55:59 +00:00
Maurus Cuelenaere
438e36337c Jz4740 USB utility:
* Fix potential segmentation faults
* Add support for the VX767


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18252 a1c6a512-1295-4272-9138-f99709370657
2008-08-12 12:58:24 +00:00
Maurus Cuelenaere
c8bdcbf8ff jz4740 utilities:
* Fix TABs problem
* Add IHFSsplit made by William Poetra Yoga Hadisoeseno
* Fix compilation warnings


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18206 a1c6a512-1295-4272-9138-f99709370657
2008-08-07 10:24:11 +00:00
Maurus Cuelenaere
0a35976a61 Don't erase people's NAND flash...
(aka fix usbtool)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18150 a1c6a512-1295-4272-9138-f99709370657
2008-07-30 10:19:33 +00:00
Maurus Cuelenaere
6fd40a57b8 Jz4740 Tools:
* update Makefile
 * add README
 * update svn properties
 * fix small mistakes


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17926 a1c6a512-1295-4272-9138-f99709370657
2008-07-03 12:17:56 +00:00
Daniel Stenberg
2acc0ac542 Updated our source code header to explicitly mention that we are GPL v2 or
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 18:10:04 +00:00
Maurus Cuelenaere
d951e169f5 Rename jz4740 tools + add some new ones
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17840 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 16:49:46 +00:00
Renamed from utils/jz4740_usbtool/jz4740_usbtool.c (Browse further)