Commit graph

59 commits

Author SHA1 Message Date
Stéphane Doyon
6d08116691 Fix a bug whereby ACTION_TREE_WPS (GO_TO_PREVIOUS_MUSIC) brings us to the
radio, despite playback having been started since we last visited the radio.

To reproduce:
-go to the radio,
-stop and exit it,
-go to the browser, and do a playlist insert,
    or start a playlist from the playlist catalog,
    anything that starts playback without going to the WPS.
-Press ACTION_TREE_WPS.
Find yourself back into the radio.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15085 a1c6a512-1295-4272-9138-f99709370657
2007-10-12 04:20:20 +00:00
Stéphane Doyon
84ed3fd50f Go to the WPS on a successful bookmark_mrb_load() from the MRB,
rather than popping back to the root menu.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15084 a1c6a512-1295-4272-9138-f99709370657
2007-10-12 04:10:08 +00:00
Stéphane Doyon
2ee85c5056 Voice already gets shutup when starting playback. It's also appropriate
to shut it up when returning to the WPS (GO_TO_WPS).


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15083 a1c6a512-1295-4272-9138-f99709370657
2007-10-12 02:23:52 +00:00
Stéphane Doyon
5acf091046 Add a voice callback to dynamic menus, along side the text_callback.
From FS#7563.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15042 a1c6a512-1295-4272-9138-f99709370657
2007-10-09 03:48:56 +00:00
Jonathan Gordon
fda7d720c0 Accept FS#5464 - organise the rocks directory.
If any plugins or "open with" optoins dont work please let me know...


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14214 a1c6a512-1295-4272-9138-f99709370657
2007-08-06 13:42:52 +00:00
Nils Wallménius
5b76936a44 Accept FS#6159 'Add voice to roughly 100 splash screens and yes-no menus' by Stephane Doyon with some minor tweaks by me. Rerun 'configure' and do a 'make clean' before rebuilding your voice files.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14213 a1c6a512-1295-4272-9138-f99709370657
2007-08-06 13:08:36 +00:00
Nils Wallménius
b311367481 *** Lang v2 cleanup (FS#6574) ***
1) Introduces apps/features.txt that controls which strings are included 
for each target based on defines.
2) .lng and .voice files are now target specific and the format versions 
of both these file types have been bumped, which means that new voice 
files are needed. 
3) Use the 'features' mechanism to exclude strings for targets that 
didn't use them.
4) Delete unused and deprecated and duplicated strings, sort strings in 
english.lang

Some string IDs were changed so translations will be slightly worse than 
before.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14198 a1c6a512-1295-4272-9138-f99709370657
2007-08-05 19:19:39 +00:00
Jonathan Gordon
f7675a244b remove the need for action_signalscreenchange().
Fixes problems with targets where the ACTION_STD_CANCEL event is a combo


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13956 a1c6a512-1295-4272-9138-f99709370657
2007-07-22 06:05:53 +00:00
Peter D'Hoye
5737254429 Give the plugin menu its own title (when configured). Fixes FS #7371
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13856 a1c6a512-1295-4272-9138-f99709370657
2007-07-11 22:05:38 +00:00
Jonathan Gordon
411f3e2b2b If the action handler for the menu returns ACTION_REDRAW the list will be redrawn. Fixes the Now Playing/Resume Playback text not updating
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13848 a1c6a512-1295-4272-9138-f99709370657
2007-07-11 02:22:03 +00:00
Peter D'Hoye
9337efdb7a Accept FS #7303 by Christoph Reiter: add context menu to FM radio entry in main menu. Also changes a small naming inconsistency.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13778 a1c6a512-1295-4272-9138-f99709370657
2007-07-03 18:31:13 +00:00
Jonathan Gordon
2ca895bae7 Fix FS#7387 - trying to go into the file browser when the last folder was on the MMC/mSD card (which was removed) would go into an infinite loop.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13768 a1c6a512-1295-4272-9138-f99709370657
2007-07-03 08:43:38 +00:00
Nils Wallménius
f31e123133 Remove unused function and unused header
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13424 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 19:54:11 +00:00
Nicolas Pennequin
1cf2ec38b1 Change some ifdefs for the recent backdrop changes (fixes the yellow builds) and move the backdrop files.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13265 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 22:08:00 +00:00
Nicolas Pennequin
7fdfa56454 Add backdrop support for LCD remotes with depth > 1-bit. Only WPS backdrops, but the groundwork is laid for main backdrops too (all that's really needed are menus to set/clear them).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13263 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 21:44:56 +00:00
Jonathan Gordon
680acbf71b fix a stupid bug which didnt check the flag correctly (caused the player to crash trying to access the shutdown options context menu)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13258 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 10:41:17 +00:00
Brandon Low
b44b660ac4 Fix build for those who don't want to build tagcache
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13203 a1c6a512-1295-4272-9138-f99709370657
2007-04-18 19:46:34 +00:00
Jonathan Gordon
f9fb49284e Give most of the items in the main menu a context menu
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13126 a1c6a512-1295-4272-9138-f99709370657
2007-04-12 15:28:51 +00:00
Jens Arnold
5764ff571a Fix yellow player build. Sims have no charging...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13080 a1c6a512-1295-4272-9138-f99709370657
2007-04-09 13:54:38 +00:00
Jens Arnold
178c565beb Stop/shutdown logic rework in browsers and menus. Recorder V1: Double-Off shutdown is now possible from menus and sub-browsers as well. Player, other targets which are always powered during charging: Attempted shutdown from menu with charger plugged now displays the charging splash.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13079 a1c6a512-1295-4272-9138-f99709370657
2007-04-09 13:39:37 +00:00
Jonathan Gordon
ec7ca33a0c Fix the root menu for any targets without a radio (we are using #if not #ifdef for CONFIG_TUNER). Fixes the bookmark issue in FS#6965)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13027 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 02:50:43 +00:00
Robert Kukla
1f33735097 FS#6948 - Fix the broken 'follow playlist' feature
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12985 a1c6a512-1295-4272-9138-f99709370657
2007-03-31 21:59:57 +00:00
Peter D'Hoye
d2b305571e Check if a new version got installed after usb disconnect and ask if user wants to reboot. Causes disk spinup before showing the usb logo. Also fixes do_menu() not returning to root_menu after usb disconnect.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12972 a1c6a512-1295-4272-9138-f99709370657
2007-03-30 21:54:48 +00:00
Peter D'Hoye
4d28b2f043 set correct eol-style and keywords properties
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12966 a1c6a512-1295-4272-9138-f99709370657
2007-03-29 22:51:03 +00:00
Jonathan Gordon
678705c732 Hopefully fix FS#6863 for good. (possible to get into infinite loop in the menu with screens returning GO_TO_PREVIOUS)
Also clean up root_menu.c a bit


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12960 a1c6a512-1295-4272-9138-f99709370657
2007-03-29 14:19:28 +00:00
Jonathan Gordon
91e726a1c1 Move all valid menu return codes to a single file (root_menu.h) so we don't need to rely on GO_TO_ROOT == MENU_ATTACHED_USB.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12937 a1c6a512-1295-4272-9138-f99709370657
2007-03-27 06:38:11 +00:00
Dominik Riebeling
c3bef27cbd Temporary workaround hard lockup with "nothing to resume" splash at end of the playlist if the last active screen was the main menu. A proper fix should come soon.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12896 a1c6a512-1295-4272-9138-f99709370657
2007-03-23 08:09:28 +00:00
Jonathan Gordon
59649b888a Fix FS#6863 - infinite looping with "Nothing to resume"
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12872 a1c6a512-1295-4272-9138-f99709370657
2007-03-21 05:45:34 +00:00
Jonathan Gordon
458648bd23 fix red
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12828 a1c6a512-1295-4272-9138-f99709370657
2007-03-18 07:25:01 +00:00
Jonathan Gordon
3d39c4de28 Fix it dropping back to the file browser.
Fix yellow


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12823 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 14:16:11 +00:00
Jonathan Gordon
daf66940b1 Unify the way functions are called from menus.
Optionally, the functions return value can be checked for a value to 
tell the menu to quit.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12821 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 12:33:34 +00:00
Jens Arnold
bd5c0ad7bb Cast some more to keep both 32 bit and 64 bit simulator platforms happy.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12819 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 10:50:58 +00:00
Jens Arnold
f68362ad6f Fix simulator builds, and some debugf() format strings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12817 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 09:54:28 +00:00
Jens Arnold
4d6374c923 Get rid of the 'center' parameter for splashes. There were only 2 of almost 500 splashes which were not centered.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12807 a1c6a512-1295-4272-9138-f99709370657
2007-03-16 21:56:08 +00:00
Jonathan Gordon
fd30be5545 Fix the database browser not remembering its selected item
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12705 a1c6a512-1295-4272-9138-f99709370657
2007-03-10 12:51:08 +00:00
Steve Bavin
888890ad60 Fix and simplify previous browser tracking. Auto-init the database when selected but not ready for use.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12698 a1c6a512-1295-4272-9138-f99709370657
2007-03-09 16:54:35 +00:00
Steve Bavin
993f5896f6 Temporarily revert the database auto-init as it causes navigation problems that I don't have time to fix yet
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12686 a1c6a512-1295-4272-9138-f99709370657
2007-03-08 10:16:43 +00:00
Steve Bavin
149bc03d86 Really don't try to initialise while the database status is unknown
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12684 a1c6a512-1295-4272-9138-f99709370657
2007-03-08 08:20:30 +00:00
Jonathan Gordon
7ce492e693 Hopefully fix FS#6757
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12680 a1c6a512-1295-4272-9138-f99709370657
2007-03-08 00:37:58 +00:00
Steve Bavin
f61b7948f9 Don't try to initialise while the database status is unknown
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12679 a1c6a512-1295-4272-9138-f99709370657
2007-03-07 21:36:43 +00:00
Steve Bavin
8137489e2b Lead user through database initialisation
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12678 a1c6a512-1295-4272-9138-f99709370657
2007-03-07 19:56:15 +00:00
Jonathan Gordon
43b2d091ba Fix the various bugs associated with pressing MENU to move in and out of
the Rockbox Menu


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12666 a1c6a512-1295-4272-9138-f99709370657
2007-03-07 10:13:07 +00:00
Magnus Holmgren
2c94c1afc3 Small '#ifdef HAVE_TAGCACHE' fix
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12657 a1c6a512-1295-4272-9138-f99709370657
2007-03-07 05:23:10 +00:00
Jonathan Gordon
798ddf201c #ifdef HAVE_TAGCACHE
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12656 a1c6a512-1295-4272-9138-f99709370657
2007-03-07 04:36:02 +00:00
Jonathan Gordon
e900a90e11 Accept FS#6750, allow recording to start automatically (If alarm wakeup
is set to recording)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12655 a1c6a512-1295-4272-9138-f99709370657
2007-03-07 01:59:29 +00:00
Jonathan Gordon
9e554a87fc Fix alarm wake up. If the target has fm or recording (or both) an option is in the System menu to choose what to start when the alarm wakes up,
otherwise the WPS will start


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12654 a1c6a512-1295-4272-9138-f99709370657
2007-03-07 01:16:25 +00:00
Jonathan Gordon
a74eefe1b2 Pressing Menu in the Rockbox Menu puts you back in the previous screen.
Hopefully simplify the code a bit


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12643 a1c6a512-1295-4272-9138-f99709370657
2007-03-06 13:35:15 +00:00
Jonathan Gordon
1b07ed05a4 Fix FS#6716 - make it easier to follow the selected file going in and
out of the trees


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12638 a1c6a512-1295-4272-9138-f99709370657
2007-03-06 08:21:18 +00:00
Jonathan Gordon
ff5756a248 Fix the problem where you can get stuck in the plugin browser after
stopping music in the WPS


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12632 a1c6a512-1295-4272-9138-f99709370657
2007-03-06 00:53:48 +00:00
Jonathan Gordon
6bb473d291 Always try to select the last screen when enetering the Rockbox Menu
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12623 a1c6a512-1295-4272-9138-f99709370657
2007-03-05 13:36:00 +00:00