Commit graph

112 commits

Author SHA1 Message Date
Dominik Riebeling
be0e197190 Split up encoders sources.
Create a separate source / header file for each supported encoder and the base
class and rename classes for better readability. This should also make it
easier adding new encoders.

Remove a few trailing spaces while at it.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31592 a1c6a512-1295-4272-9138-f99709370657
2012-01-06 19:19:32 +00:00
Dominik Riebeling
7263ccb105 Remove svn keyword lines from sources.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30806 a1c6a512-1295-4272-9138-f99709370657
2011-10-19 20:51:16 +00:00
Dominik Riebeling
9f2a71bb12 Rockbox Utility: handle layout direction on language changes as well.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30638 a1c6a512-1295-4272-9138-f99709370657
2011-10-02 15:27:52 +00:00
Dominik Riebeling
9e016c4791 Update cache information after translation change.
Since a translation change can affect the locale the locale-dependent strings
need to be refreshed explicitly.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30634 a1c6a512-1295-4272-9138-f99709370657
2011-10-02 14:36:38 +00:00
Dominik Riebeling
2e3de70401 Rockbox Utility: listen to translation change events.
When changing the language don't require a restart anymore. Instead listen to
the appropriate changeEvent and retranslate the UI. Designer generated UI files
already provide such a function.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30633 a1c6a512-1295-4272-9138-f99709370657
2011-10-02 14:30:05 +00:00
Dominik Riebeling
4f56b50df4 Voicefile generation: implement string corrections.
Voicefile generation now can correct strings for the TTS system similar
to what voice.pl does. The current implementation has some limitations:
- only implemented for voicefile creation.
- the corrections file is built in and can't get changed.
- string corrections can be disabled in the configuration dialog.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30628 a1c6a512-1295-4272-9138-f99709370657
2011-10-01 19:48:58 +00:00
Dominik Riebeling
9c9bc1216c Move some helper functions out of Autodetection.
Those functions are rather general, so put them into the Utils class instead.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30146 a1c6a512-1295-4272-9138-f99709370657
2011-07-17 08:08:58 +00:00
Dominik Riebeling
b7fe90aa36 The mountpoint is stored with normalized separators.
Make sure to convert it on reading to avoid not finding it even if stored with
native separators in the configuration. Fix a warning on Windows.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30145 a1c6a512-1295-4272-9138-f99709370657
2011-07-17 08:08:51 +00:00
Dominik Riebeling
99408dd45e Add custom delegate for showing the mountpoint combo box entries.
The delegate will be used for the dropdown list and show both mountpoint (left
aligned) and label / size information (right aligned). This improves
readability compared to the previous implementation. Also, the mountpoint
itself is now the text of the combo box and the additional information is in
the Qt::UserRole to avoid having to handle a user entered mountpoint separately
(since previously the mountpoint was stored in Qt::UserRole, but an edited item
would have the value in Qt::TextRole).

Disable editing the combo box entry for release builds, it shouldn't be needed
by users.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30144 a1c6a512-1295-4272-9138-f99709370657
2011-07-16 22:08:03 +00:00
Dominik Riebeling
c9f70fe304 Show volume labels on Windows.
In mountpoint selection and system info dialog show the volume name to make it
easier to identify a specific device.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30141 a1c6a512-1295-4272-9138-f99709370657
2011-07-15 20:03:05 +00:00
Dominik Riebeling
241f28eefc Replace mountpoint selection with combo box.
Instead of entering the mountpoint via a tree browser or manually use a combo
box that lists all available drives / mountpoints. This also allows to easily
add more information like the free and total size for each mountpoint. For
development this can still be overriden by editing the dropdown value manually.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30140 a1c6a512-1295-4272-9138-f99709370657
2011-07-15 19:14:26 +00:00
Dominik Riebeling
a3875d7dfe Rockbox Utility: fix proxy password getting lost (FS#12166).
The proxy settings are stored as string representation in the configuration
file. If username / password contains characters used as separators parsing the
string again will cause wrong results. Percent-encode them before storing, and
parse it as percent-encoded string when reading it back.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30071 a1c6a512-1295-4272-9138-f99709370657
2011-06-25 17:21:06 +00:00
Dominik Riebeling
afa6afc3bc Better hilight detected item after autodetection.
To have a better indication what player has been detected and to keep this
information in view make the entry for the detected player bold. This also
(partly) addresses FS#10694.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29761 a1c6a512-1295-4272-9138-f99709370657
2011-04-22 17:39:05 +00:00
Dominik Riebeling
4d25fb8fe1 Fix "Test TTS" button not working.
Make sure the temporary file doesn't get destroyed before it has been played.
Fixes the "Test TTS" button not giving a test playback anymore for TTS systems
that cannot do the playback themselves.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29760 a1c6a512-1295-4272-9138-f99709370657
2011-04-22 15:38:41 +00:00
Dominik Riebeling
86f70de809 Properly remove the configuration dialog.
The configuration dialog isn't needed anymore once the finished() signal is
emitted. In that case schedule it for deletion by the event loop.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29674 a1c6a512-1295-4272-9138-f99709370657
2011-04-03 14:04:21 +00:00
Dominik Riebeling
746f01dd77 Add capability to speak directly from the TTS engine.
The OS X TTS engine (and likely others) allows outputting its speech directly
to the sound system. This avoids the extra step of creating a temporary file to
play for TTS preview. Currently implemented as TTS capability reported.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29672 a1c6a512-1295-4272-9138-f99709370657
2011-04-03 08:06:59 +00:00
Dominik Riebeling
d1098f3100 Fix MTP detection only working on e200v1.
Autodetection only showed an MTP device error for e200v1 and an unspecified
error for all other players (except if the detected player is an Ipod, in which
case the error indicates a WinPod). Consider all non-Ipod errors as MTP error.
Fix wrong MTP USB ID for e200v1 which made that detection fail even for e200v1.
Should fix FS#11563.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29621 a1c6a512-1295-4272-9138-f99709370657
2011-03-20 10:26:05 +00:00
Dominik Riebeling
92183d2dd0 Improve visual feedback when testing TTS.
Disable the "Test TTS" button during a running test and on invalid TTS
configuration.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29581 a1c6a512-1295-4272-9138-f99709370657
2011-03-13 14:57:58 +00:00
Dominik Riebeling
988b3083df Replace list of languages with map.
- Use ISO codes as keys for voice languages instead of enumeration.
- Instead of trying to select a suitable voicefile language from the UI
  language use the ISO codes stored as UI language and match against the
  mapping.
- Always store the selected UI language. Fixes the voicefile creation
  language lookup to fail if the language used is the system language.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29207 a1c6a512-1295-4272-9138-f99709370657
2011-02-04 23:28:34 +00:00
Dominik Riebeling
9fedc8187f Move utils.cpp functions into separate class and split it up.
Move class-less functions in utils.cpp into a new Utils class and make the old
functions static. This prevents clashes with system C functions. Rename some
functions to avoid macro problems (check() is a macro on OS X). Split out the
RockboxInfo class into a separate file.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25441 a1c6a512-1295-4272-9138-f99709370657
2010-04-02 21:24:19 +00:00
Dominik Riebeling
b470303311 Implement system proxy values retrieval on OS X.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25439 a1c6a512-1295-4272-9138-f99709370657
2010-04-02 19:22:32 +00:00
Dominik Riebeling
98493fd398 Warn when selecting system proxy settings with invalid values.
Rockbox Utility doesn't support "proxy auto-config" (aka PAC) for system proxy
settings. This can result in users selecting system proxy and expecting it to
work even if their system uses PAC. While the configuration dialog displays the
proxy setting values retrieved from the system this is not totally obvious. Add
a message telling if the retrieved system proxy values are not useable. For now
this only checks if a proxy host and port are set which should catch the usual
cases when PAC is used.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25435 a1c6a512-1295-4272-9138-f99709370657
2010-04-02 10:59:38 +00:00
Dominik Wenger
a79fee019e Delete tts objects after use.
Author: Delyan Kratunov
Flyspray: FS#11155 part1

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25401 a1c6a512-1295-4272-9138-f99709370657
2010-03-30 17:43:49 +00:00
Dominik Riebeling
8c8703038b Refactor device tree setup a bit.
- reorder value retrieval (display names etc) to cut down the number of
  necessary accesses. While this is not critical it cuts down the noise
  generated in the trace noticably.
- match the old target by its internal name instead of the display name.
- remove two access functions in SystemInfo that are not really needed anymore.
  Accessing the values via platformValue() is much more logical and in line with
  the rest of the value accesses.
- try to scroll to the selected item in the device list after setup and
  detection.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24988 a1c6a512-1295-4272-9138-f99709370657
2010-03-01 22:45:17 +00:00
Dominik Riebeling
7f33b7d9fa Recognize and handle MacPods during autodetection.
Previously MacPods were detected but the mountpoint can't get resolved due to
the different partition layout, thus having a MacPod would only detect the Ipod
itself but not the mountpoint. Rockbox does not support MacPods, so inform the
user as soon as possible.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24799 a1c6a512-1295-4272-9138-f99709370657
2010-02-20 22:11:11 +00:00
Dominik Riebeling
7e91332e39 Use QFileDialog::getExistingDirectory() for path selection.
This makes it possible for native dialogs to get used on Windows and OS X. The
mountpoint selection dialog needs special handling and still uses the
BrowseDirtree class for now.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24703 a1c6a512-1295-4272-9138-f99709370657
2010-02-16 21:34:39 +00:00
Dominik Riebeling
a9ab407f84 Add option to show disabled targets in the configuration dialog.
Note that disabled targets support is not intended for use by end users.
This is to make development (and testing of svn) easier and should get
disabled for releases.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24513 a1c6a512-1295-4272-9138-f99709370657
2010-02-04 21:10:20 +00:00
Dominik Wenger
6128bd14e9 rbutil: split RbSettings. use Stable/unstable status from server.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24331 a1c6a512-1295-4272-9138-f99709370657
2010-01-24 21:12:11 +00:00
Tomer Shalev
a398e44680 rbutil: Explicitly set some widgets layout direction to LTR
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24173 a1c6a512-1295-4272-9138-f99709370657
2010-01-03 20:04:45 +00:00
Dominik Riebeling
23aecc4539 Don't set the layout direction twice in a row, one time is enough.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23448 a1c6a512-1295-4272-9138-f99709370657
2009-10-31 20:02:33 +00:00
Tomer Shalev
d011eecad4 FS#10748 - rbutil: Explicitly override GUI layout direction setting for some widgets
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23441 a1c6a512-1295-4272-9138-f99709370657
2009-10-31 17:16:34 +00:00
Dominik Wenger
3215c09462 rbutil: split tts.cpp/h into individual files.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23158 a1c6a512-1295-4272-9138-f99709370657
2009-10-13 19:54:27 +00:00
Dominik Riebeling
1644cd8741 Clean up a few source strings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22833 a1c6a512-1295-4272-9138-f99709370657
2009-09-25 15:51:17 +00:00
Dominik Riebeling
76100783af Improve notification about unsupported players.
- Display the name of a detected unsupported player when running autodetection from the configuration window.
- Extend the list of known-unsupported players.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22334 a1c6a512-1295-4272-9138-f99709370657
2009-08-15 21:29:31 +00:00
Dominik Riebeling
6cea3308d0 Clean up accessing system setting values for a specific player.
Remove the ugly "save, change and restore platform" accesses and extend the settings class to allow accessing player specific system values.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22254 a1c6a512-1295-4272-9138-f99709370657
2009-08-11 17:02:35 +00:00
Dominik Riebeling
e2f5086916 Clean up and rename Detect class.
Move check() function out of the Detect class and place it into utils.cpp for now. Rename Detect class to System, as it now only retrieves data about the underlying system and doesn't detect anything anymore. Cleans up with the confusion between Detect and Autodetection.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22238 a1c6a512-1295-4272-9138-f99709370657
2009-08-10 19:46:51 +00:00
Dominik Riebeling
bd5b744a6d Clean up some debug output, kill some trailing spaces and break some overly long lines.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22204 a1c6a512-1295-4272-9138-f99709370657
2009-08-08 12:12:49 +00:00
Dominik Wenger
b6143b053f rbutil: make the test TTS Function use aplay or play on Linux.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21530 a1c6a512-1295-4272-9138-f99709370657
2009-06-27 15:04:53 +00:00
Dominik Wenger
07a55a747d rbutil: add a Button to test a TTS Engine. Remove a old .ui file.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21525 a1c6a512-1295-4272-9138-f99709370657
2009-06-26 21:52:08 +00:00
Dominik Wenger
18e74c9d81 rbutil: improve accessibility a little bit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21300 a1c6a512-1295-4272-9138-f99709370657
2009-06-15 19:41:16 +00:00
Dominik Riebeling
7f17fce424 Clean up configuration dialog debug output.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21201 a1c6a512-1295-4272-9138-f99709370657
2009-06-07 10:17:03 +00:00
Dominik Wenger
33d9cf091a rbutil: make RbSettings a static class. (FS#10183 with improvements)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20890 a1c6a512-1295-4272-9138-f99709370657
2009-05-09 16:59:14 +00:00
Dominik Wenger
5b85ef6006 rbutil: completely rework how tts and encoders are configured. (FS#10070)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20824 a1c6a512-1295-4272-9138-f99709370657
2009-04-29 21:27:01 +00:00
Dominik Riebeling
3d2e42ab4c Completely rework RbSettings class.
- use a single member function for accessing a settings value.
- use an enum to figure the correct value in the settings file instead of functions.
- return the settings value as QVariant instead and leave converting to the caller.
- accept QVariant as value when setting values.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20823 a1c6a512-1295-4272-9138-f99709370657
2009-04-29 20:58:47 +00:00
Dominik Riebeling
42483bacc8 Fix cache path selection on Windows only allowing to select drives (FS#10013 by Yoshihisa Uchida).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20319 a1c6a512-1295-4272-9138-f99709370657
2009-03-13 16:53:28 +00:00
Dominik Riebeling
194fe0e6f0 Check configuration for validity in the configuration dialog.
If the configuration is invalid display information about the issues and don't accept the values. Fixes issue reported in FS#9944.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20100 a1c6a512-1295-4272-9138-f99709370657
2009-02-24 23:36:31 +00:00
Dominik Riebeling
af58ec63b6 Display cache path using native directory separators in configuration dialog.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19939 a1c6a512-1295-4272-9138-f99709370657
2009-02-07 15:59:20 +00:00
Dominik Riebeling
5c1b47dd1a Make autodetection show a busy cursor (hourglass) during detection to improve visual feedback.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19114 a1c6a512-1295-4272-9138-f99709370657
2008-11-16 11:00:27 +00:00
Dominik Riebeling
cbc9208e54 Don't reset the language setting if it wasn't changed but the configuration saved.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18279 a1c6a512-1295-4272-9138-f99709370657
2008-08-14 21:32:32 +00:00
Dominik Riebeling
c367c21a76 Make rbutil check the system language and try to use the correct translation. A language selection in the configuration file will override this.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18118 a1c6a512-1295-4272-9138-f99709370657
2008-07-25 19:28:24 +00:00