Commit graph

14008 commits

Author SHA1 Message Date
Miika Pekkarinen
2bc133dce9 Try to handle dircache rebuild event properly. Playlist should now
cache new pointers to dircache items when dircache goes
offline and comes back onlineagain (during tagcache commit). This
should prevent wrong filenames to appear in playlist.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30047 a1c6a512-1295-4272-9138-f99709370657
2011-06-21 17:42:31 +00:00
Alex Parker
c4f6e340f8 Update US English by Steven Panek.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30045 a1c6a512-1295-4272-9138-f99709370657
2011-06-20 21:14:29 +00:00
Thomas Martitz
6e8ffa92af Fix red in fft plugin.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30044 a1c6a512-1295-4272-9138-f99709370657
2011-06-20 20:45:39 +00:00
Alex Parker
548b34a180 Add US English by Steven Panek.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30043 a1c6a512-1295-4272-9138-f99709370657
2011-06-20 20:23:44 +00:00
Thomas Martitz
af7aaae478 Dircache: Don't expose struct dircache_entry and pointers into the cache, use IDs instead.
Only integer IDs are exposed from dircache with this. This way the cache is isolated from other modules.
This is needed for my buflib gsoc project.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30038 a1c6a512-1295-4272-9138-f99709370657
2011-06-20 20:12:42 +00:00
Thomas Martitz
e063725534 Dircache: Return the size of the result string in dircache_copy_path() so that callers don't need to call strlen on it.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30034 a1c6a512-1295-4272-9138-f99709370657
2011-06-20 20:12:15 +00:00
Thomas Martitz
ffee46a8b1 Fix yellow. Shouldn't have reordered struct members here.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30031 a1c6a512-1295-4272-9138-f99709370657
2011-06-20 19:33:08 +00:00
Thomas Martitz
1a86aab1a2 Remove unused code path from playlist_create_ex().
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30030 a1c6a512-1295-4272-9138-f99709370657
2011-06-20 19:33:03 +00:00
Thomas Martitz
316f9a0238 tagtree: Refactor memory allocation to local functions.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30029 a1c6a512-1295-4272-9138-f99709370657
2011-06-20 19:32:56 +00:00
Thomas Martitz
19d08c2664 Move struct search_instruction into struct menu root, as they're not allocated or used independently.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30028 a1c6a512-1295-4272-9138-f99709370657
2011-06-20 19:32:52 +00:00
Thomas Martitz
7b374b43b5 Use enum themable_icons in struct file_type and struct filetype (who made those names?).
It's the correct type and should save some memory due to struct padding (on eabi).

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30027 a1c6a512-1295-4272-9138-f99709370657
2011-06-20 19:32:48 +00:00
Miika Pekkarinen
f2ef42c1da Fixed a changelog export/import problem with tagcache where <CR> or <LF>
characters in a tag could cause the parser fail to import a track
statistics correctly. Now line feeds are escaped properly and carriage
returns ignored on import.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30021 a1c6a512-1295-4272-9138-f99709370657
2011-06-20 15:53:33 +00:00
Jens Arnold
c56cca261a Fix non-working .talk clips on hwcodec (follow-up to r28672 and r29432): .talk clips
must be evaluated as MP3. Also fix supported formats: hwcodec doesn't support MP1.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30019 a1c6a512-1295-4272-9138-f99709370657
2011-06-19 22:34:40 +00:00
Miika Pekkarinen
8d9b9d247b Removed redundant copy of tagcache master_header structure stored in
memory. One of these headers (current_tcmh) was not loaded in when
tagcache state was initialized from a hibernated state file (flashed
H1xx targets). That caused internal serial number to start always from
zero, rendering "recently played tracks" query not working as expected.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30016 a1c6a512-1295-4272-9138-f99709370657
2011-06-19 14:36:26 +00:00
Magnus Holmgren
6c8ef19dfd FS#12161: Correct the gapless processing for AAC, so that it doesn't remove too much from the start of a track. Also simplify the logic a bit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30012 a1c6a512-1295-4272-9138-f99709370657
2011-06-18 15:11:30 +00:00
Bertrik Sikken
21685577c7 FS#12162 - Second June update of Czech language by Marek Salaba
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30011 a1c6a512-1295-4272-9138-f99709370657
2011-06-17 23:36:49 +00:00
Rafaël Carré
7b605f0416 Fix 'unused-but-set-variable' warnings (doom, lua)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30008 a1c6a512-1295-4272-9138-f99709370657
2011-06-17 00:14:58 +00:00
Jonathan Gordon
142725ebc9 Fix FS#12158 - Make the "Mode: " line in the radio menu voice.
Translators need to verify the voice string, dumbly copied from the dest string

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30007 a1c6a512-1295-4272-9138-f99709370657
2011-06-16 13:28:15 +00:00
Michael Hohmuth
851cac848a Prevent out-of-bounds array access when a tagnavi config file defines too many %format specifications
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30006 a1c6a512-1295-4272-9138-f99709370657
2011-06-14 20:54:26 +00:00
Bertrik Sikken
4456abb601 FS#12157 - Little June update of Czech language by Marek Salaba
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30005 a1c6a512-1295-4272-9138-f99709370657
2011-06-14 20:02:43 +00:00
Bertrik Sikken
dfeab73f55 FS#12156 - Update Galician translation by Ismael Castiñeira Álvarez
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30002 a1c6a512-1295-4272-9138-f99709370657
2011-06-13 21:39:07 +00:00
Magnus Holmgren
de81c733bd Update Swedish translation.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30001 a1c6a512-1295-4272-9138-f99709370657
2011-06-13 17:37:35 +00:00
Thomas Martitz
3b18158688 Fix FS#11387 - PictureFlow runs jerkily while playing music on Nano2G after the recent feature addition
The problem r26713 addressed was not caused by missing yields but by too high
priority of the background loader thread. Undoing the yield() change and decreasing
the priority fixes the audio drop as well but doesn't cause jerkiness.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30000 a1c6a512-1295-4272-9138-f99709370657
2011-06-13 16:50:10 +00:00
Bertrik Sikken
e533635012 FS#12155 - Update espanol.lang Spanish translation
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29998 a1c6a512-1295-4272-9138-f99709370657
2011-06-13 16:16:40 +00:00
Jonathan Gordon
038fc8a66e Fix the %cs tag for the pitchscreen and playlist viewer
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29997 a1c6a512-1295-4272-9138-f99709370657
2011-06-13 07:33:20 +00:00
Nils Wallménius
3b04a85245 Remove a couple of dead inits and assignments found by the clang-static-analyzer.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29996 a1c6a512-1295-4272-9138-f99709370657
2011-06-12 22:17:45 +00:00
Nils Wallménius
f2e7c05c22 libtremor: comment out unused struct member.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29987 a1c6a512-1295-4272-9138-f99709370657
2011-06-09 06:46:44 +00:00
Nils Wallménius
d5ceb4ce2b codeclib: make selective inclusion of macros and inline functions from the codeclib_misc.h header easier and clean out some old libtremor stuff.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29985 a1c6a512-1295-4272-9138-f99709370657
2011-06-08 10:35:27 +00:00
Nils Wallménius
331b23d15b FS#12144, Use -fPIC -fvisibility=hidden only for plugins on sim and app builds and enable it for 32 bit too. Fixes linking errors on simbuilds.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29983 a1c6a512-1295-4272-9138-f99709370657
2011-06-07 11:56:23 +00:00
Michael Hohmuth
f9f96325e2 FS#12107: Remove track-number guessing code.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29982 a1c6a512-1295-4272-9138-f99709370657
2011-06-06 23:03:31 +00:00
Michael Hohmuth
6a0021cf20 FS#12132 patch 5: check_clauses: Optimizations.
* There's no need to reset the buffer argument to
  check_against_clauses to 0 when it's not needed.  We can always
  initialize str = buf and only change it on a RAM search hit.

* Do not memset buffer to 0 -- it's sufficient to make sure the
  retrieved tag string is zero-terminated.

* Factor out a call to check_virtual_tags from two branches of an if
  statement.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29981 a1c6a512-1295-4272-9138-f99709370657
2011-06-06 22:49:07 +00:00
Michael Hohmuth
b3a7f39c66 FS#12132 patch 4: Added a comment for the tagcache_search.type field.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29980 a1c6a512-1295-4272-9138-f99709370657
2011-06-06 22:49:02 +00:00
Michael Hohmuth
564a8ed1fd FS#12132 patch 3: Rename read_numeric_tag to find_tag, as it is indeed
used for nonnumeric tags as well.

Optimization for the nonnumeric case: Only numerics are ever updated,
so there's no need to scan the command queue for updates to nonnumeric
tags.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29979 a1c6a512-1295-4272-9138-f99709370657
2011-06-06 22:48:57 +00:00
Michael Hohmuth
509d6a901d FS#12132 patch 2: add_uniqbuf: Fix confusing indentation in if condition
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29978 a1c6a512-1295-4272-9138-f99709370657
2011-06-06 22:48:53 +00:00
Nils Wallménius
e62b9a9aae libtremor: Implement a memory configuration for targets that don't use separate iram for codecs.
Such targets would previously default to using the configuration for targets with small iram which uses an extra memcpy per block.
This saves 2MHz decoding a 128kbps vorbis file on the Gigabeat S and saves a bit of codec buffer.
Patch from FS#11268, also replaces patch from FS#12147.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29976 a1c6a512-1295-4272-9138-f99709370657
2011-06-06 13:27:12 +00:00
Nils Wallménius
684b74147f Safe part of FS#11268, saving some codec buffer space for targets that don't use separate iram.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29975 a1c6a512-1295-4272-9138-f99709370657
2011-06-05 20:18:31 +00:00
Nils Wallménius
965113ed50 FS#12146: Fix libcook bugs introduced in r22055 by Sean Bartell.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29973 a1c6a512-1295-4272-9138-f99709370657
2011-06-05 13:12:51 +00:00
Andree Buschmann
9f65f2b6ad Accept FS#12143 (NSF codec clean up): Declare local stuff static, comment unused variables and functions.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29972 a1c6a512-1295-4272-9138-f99709370657
2011-06-05 13:05:09 +00:00
Peter D'Hoye
82f4c60db4 Make the histogram code usable for playback as well. Move the recording histogram code to peakmeter, rename it to remove the recording reference, and rename anything referring to it as well. Change the drawing code so there are more options to position them. This may change your histogram settings, so check after upgrading.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29969 a1c6a512-1295-4272-9138-f99709370657
2011-06-05 12:36:27 +00:00
Thomas Martitz
62e06cc2a4 Accept FS#5153 - Doom Scrollwheel Patch
It hardcodes the scrollwheel for straving left/right.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29968 a1c6a512-1295-4272-9138-f99709370657
2011-06-05 11:23:53 +00:00
Marcin Bukat
dceceef052 Move dbg_hw_info() into target tree. FS#11735 by me
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29964 a1c6a512-1295-4272-9138-f99709370657
2011-06-05 10:26:06 +00:00
Nils Wallménius
03c12a7906 Delete old unused macro.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29962 a1c6a512-1295-4272-9138-f99709370657
2011-06-05 09:27:58 +00:00
Marianne Arnold
92afc96cc8 Languages: make the Clip+ use the microSD specific string to refer to the external card instead of only the general multivolume fallback.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29958 a1c6a512-1295-4272-9138-f99709370657
2011-06-04 19:33:01 +00:00
Dominik Riebeling
482e83d09a Center Rockbox logo when smaller than the screen size.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29954 a1c6a512-1295-4272-9138-f99709370657
2011-06-04 18:55:51 +00:00
Nils Wallménius
73d0e14f44 Disable some unused code in speex to save binsize.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29949 a1c6a512-1295-4272-9138-f99709370657
2011-06-02 20:52:54 +00:00
Nils Wallménius
d860c87800 Build the voice codec speex with core -O switch to save size on targets using -Os.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29948 a1c6a512-1295-4272-9138-f99709370657
2011-06-02 16:11:22 +00:00
Nils Wallménius
927361b4ae Fix define name.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29947 a1c6a512-1295-4272-9138-f99709370657
2011-06-02 15:25:50 +00:00
Nils Wallménius
4909e09267 FS#12141 by Sean Bartell
Some of these were found with http://www.samba.org/junkcode/#findstatic. Changes of note:
* The old MDCT has been removed.
* Makefile.test files that create test programs for libatrac, libcook, and libffmpegFLAC have been removed, as they don't work. My project will have a replacement that works with all codecs.
* I've tried not to remove anything useful. CLIP_TO_15 was removed from libtremor because there's another copy (also commented) in codeclib.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29945 a1c6a512-1295-4272-9138-f99709370657
2011-06-02 14:59:15 +00:00
Jonathan Gordon
b58d3656d7 FS#11925 - Add a proper system to keep track of the current screen/activity to make %cs far more useful
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29944 a1c6a512-1295-4272-9138-f99709370657
2011-06-01 14:41:49 +00:00
Nils Wallménius
7c6056b352 FS#12140 by Sean Bartell, Make various codec stuff static.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29942 a1c6a512-1295-4272-9138-f99709370657
2011-06-01 10:28:26 +00:00