Magnus Holmgren
7aa4ae6e45
Improved use of album name when locating the album art file: replace chars that are invalid in file names; double quotes to single quotes, other invalid chars to underscore (now only very long album names could cause a problem). Also removed some unecessary code and reduced stack usage a bit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15630 a1c6a512-1295-4272-9138-f99709370657
2007-11-15 20:22:03 +00:00
Nicolas Pennequin
1480d078e7
Add an error check, just to be safe.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15596 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 14:26:47 +00:00
Nicolas Pennequin
81dedee7d0
Various album art improvements:
...
* Make the album art display tag static instead of dynamic, making it be drawn less often, which is good.
* Add the possibility of clearing the album art bitmap instead of drawing it, and use this abaility when the display tag is inside a conditional construct.
* Add the album art display tag to wps_debug.c.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15592 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 01:31:42 +00:00
Barry Wardell
c495cdae59
FS#8046: H10 FM tuner support. Thanks to Przemyslaw Holubowski for doing the hard work in figuring out how to communicate with the tuner.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15578 a1c6a512-1295-4272-9138-f99709370657
2007-11-11 16:00:33 +00:00
Nicolas Pennequin
9d4bed7ff0
Album art support. Based on FS#3045, but heavily modified to adapt to MoB and for cleanness.
...
The cover pictures are loaded from external bitmaps. JPEG and embedded art are not supported. The pictures will only be drawn on the main display. There is no resizing but it is possible to specify the WPS bitmap size in the bitmap names (e.g. cover.100x100.bmp).
The bitmaps are stored in the main buffer and read directly from there. Currently, duplicate bitmaps will simply be present several times in the buffer, but this will be improved.
To enable for a target, #define HAVE_ALBUMART in its config file.
For more information, see the wiki page: http://www.rockbox.org/wiki/AlbumArt .
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15572 a1c6a512-1295-4272-9138-f99709370657
2007-11-11 12:29:37 +00:00
Nicolas Pennequin
ec6569ed22
Add read_bmp_fd and make the first parameter of read_bmp_file ("filename") const.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15553 a1c6a512-1295-4272-9138-f99709370657
2007-11-10 13:26:11 +00:00
Stéphane Doyon
d65f9f15f9
More voice for the radio: accept FS#6331.
...
In the radio screen, speak the mode (preset or scan) when switching mode.
When switching stations with the radio paused/muted, speak the current
preset (number, frequency if preset is default, or spell, depending
on talk_file setting). Also says the frequency if in scan mode.
Change the default preset created by autoscan to be an empty string; change
the preset menu callback to substitute the frequency when the preset name
is empty.
Add a voice callback for the preset menu.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15507 a1c6a512-1295-4272-9138-f99709370657
2007-11-07 02:14:28 +00:00
Steve Bavin
31a2f33eb8
Mop up some yellow.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15207 a1c6a512-1295-4272-9138-f99709370657
2007-10-19 15:43:43 +00:00
Steve Bavin
32a9575130
FS#7994 - Rename talk.c API, make talk_disable() affect all talking (not just menus), hopefully save some space.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15206 a1c6a512-1295-4272-9138-f99709370657
2007-10-19 15:31:42 +00:00
Jens Arnold
8b44601a7c
Disable highperf mode in the peakmeter for swcodec targets, as it makes no sense. Improves responsiveness a lot with a peakmeter-enabled wps on targets with slow lcd updates (e.g. G5). Added a comment why highperf mode is needed for MAS targets.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15140 a1c6a512-1295-4272-9138-f99709370657
2007-10-16 08:34:51 +00:00
Jens Arnold
9afdf99212
Add the vkeyboard line end beep to (swcodec) targets with non-modal keyboard. * Select modal keyboard and enable morse mode for iPod 1st/2nd gen.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15066 a1c6a512-1295-4272-9138-f99709370657
2007-10-10 06:19:54 +00:00
Jens Arnold
064de4ce4d
Slight code policing.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15065 a1c6a512-1295-4272-9138-f99709370657
2007-10-10 06:02:08 +00:00
Jens Arnold
100d343963
Fix red Ondio builds. Hwcodec targets can't beep that way, so disable that beep for them.* Port the other vkeyboard enhancements (fixed character spelling and edit mode announcement) to the charcell vkeyboard (Player).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15064 a1c6a512-1295-4272-9138-f99709370657
2007-10-10 05:56:53 +00:00
Stéphane Doyon
1b89d588e1
Accessible keyboard: guard the beep with talk_menus_enabled()
...
rather than the beep setting from the playback settings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15062 a1c6a512-1295-4272-9138-f99709370657
2007-10-10 03:57:42 +00:00
Stéphane Doyon
d529a3845b
Make the virtual keyboard easier to use for blind users.
...
From FS#6324
When moving up/down and landing on the edit line, say "edit". Otherwise
it gets quite confusing.
When moving left and right on the edit line, sound a beep when the left
or right end is reached.
Before, it would say nothing either when the cursor is over a blank or
a char it doesn't know how to spell. So if we're on a blank spot, say
"blank".
Pass the whole utf8 char to be spelled.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15060 a1c6a512-1295-4272-9138-f99709370657
2007-10-10 02:28:58 +00:00
Stéphane Doyon
0279c71a92
Voice the recording trigger settings screen.
...
From FS#6325, with a slight coding improvement.
Also take out a duplicated snprintf in there.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15059 a1c6a512-1295-4272-9138-f99709370657
2007-10-10 01:41:48 +00:00
Stéphane Doyon
5acf091046
Add a voice callback to dynamic menus, along side the text_callback.
...
From FS#7563.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15042 a1c6a512-1295-4272-9138-f99709370657
2007-10-09 03:48:56 +00:00
Michael Sevakis
6077e5b7c8
Unify PCM interface just above the hardware driver level for all targets including the sims. Perform lockout of audio callback when changing states. Weird new playback or recording trouble? Check before and after this revision first though things seem quite sound.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15006 a1c6a512-1295-4272-9138-f99709370657
2007-10-06 22:27:27 +00:00
Marianne Arnold
af97e9369a
Commit FS #7881 by Mark Arigo - enable radio on the Sansa c200. It seems that many (if not all) c200s have the radio hardware even if you can't use it with the original firmware...
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14963 a1c6a512-1295-4272-9138-f99709370657
2007-10-02 21:04:10 +00:00
Nicolas Pennequin
49a9e1ef35
Make the gradient look better when more than one line is selected (running time, ID3 info, cuesheet viewer...). I haven't found a solution for scrolling yet, so that won't look too good.
...
The recording screen code needs a bit of adapting too, but I don't have a target to test on, so leave it for now.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14884 a1c6a512-1295-4272-9138-f99709370657
2007-09-28 13:49:43 +00:00
Nicolas Pennequin
f3b015f73b
FS#7808 by Tom Ross, Ken Fazzone and me, with help from Antoine Cellerier.
...
Add two new line selector types: solid colour and gradient. Solid colour only uses the primary colour setting.
The secondary colour setting is used for the gradient. Text colour for the selected item is also changeable.
These new settings are a bit controversial so they may be removed later.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14868 a1c6a512-1295-4272-9138-f99709370657
2007-09-27 15:42:55 +00:00
Peter D'Hoye
376169ab95
small optimisation: make a locally used function static
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14815 a1c6a512-1295-4272-9138-f99709370657
2007-09-22 09:05:06 +00:00
Nils Wallménius
c70d9462be
Make a few private functins static and use fewer bytes for constants
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14783 a1c6a512-1295-4272-9138-f99709370657
2007-09-20 16:44:28 +00:00
Jonathan Gordon
cf1cef5f57
minor update to gui_synclist_do_button() which will hopefully simplify things later.
...
Now returns true if the action was handled in that function instead of returning the handled action.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14733 a1c6a512-1295-4272-9138-f99709370657
2007-09-17 10:08:50 +00:00
Jens Arnold
945462edef
Make peakmeters work for real in swcodec simulators instead of just showing random movement.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14650 a1c6a512-1295-4272-9138-f99709370657
2007-09-09 09:07:22 +00:00
Peter D'Hoye
a3fb2b4e3e
The clipcount string used in the rec screen should have been named sysfont. Fix also the already translated ones.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14524 a1c6a512-1295-4272-9138-f99709370657
2007-08-29 18:36:29 +00:00
Peter D'Hoye
6109d39469
only build the clipcounter for targets with recording
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14467 a1c6a512-1295-4272-9138-f99709370657
2007-08-26 21:34:36 +00:00
Peter D'Hoye
583f186ce4
Implement FS #2976 : Clip Counter for recording screen. If enabled in peak meter settings, it shows the number of times clipping occurred (clip indicator going on). Count is reset on recording start and only counts during actual recording. Stays on screen when stopping or pauzing. Also fix a drawing bug when peakmeters start at a non-zero x offset.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14455 a1c6a512-1295-4272-9138-f99709370657
2007-08-25 15:53:54 +00:00
Jens Arnold
99ff02d2cb
Make peak release work per tick as intended. But that's too fast, so it's not the final solution.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14397 a1c6a512-1295-4272-9138-f99709370657
2007-08-20 06:36:24 +00:00
Nils Wallménius
c023cb8783
Revert previous 'fix' and implement the correct one, thanks markun! :-)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14396 a1c6a512-1295-4272-9138-f99709370657
2007-08-19 21:33:57 +00:00
Nils Wallménius
f2a1803b28
Always reset glyph width for loadable keyboards fixes FS#6220
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14394 a1c6a512-1295-4272-9138-f99709370657
2007-08-19 17:10:57 +00:00
Peter D'Hoye
ebcf06d237
Make peakmeter release setting work in units per tick (was units per read), add the unit and make it voiced. Make old leftover in lang file deprecated
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14390 a1c6a512-1295-4272-9138-f99709370657
2007-08-18 23:03:03 +00:00
Nils Wallménius
5b76936a44
Accept FS#6159 'Add voice to roughly 100 splash screens and yes-no menus' by Stephane Doyon with some minor tweaks by me. Rerun 'configure' and do a 'make clean' before rebuilding your voice files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14213 a1c6a512-1295-4272-9138-f99709370657
2007-08-06 13:08:36 +00:00
Nils Wallménius
b311367481
*** Lang v2 cleanup (FS#6574) ***
...
1) Introduces apps/features.txt that controls which strings are included
for each target based on defines.
2) .lng and .voice files are now target specific and the format versions
of both these file types have been bumped, which means that new voice
files are needed.
3) Use the 'features' mechanism to exclude strings for targets that
didn't use them.
4) Delete unused and deprecated and duplicated strings, sort strings in
english.lang
Some string IDs were changed so translations will be slightly worse than
before.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14198 a1c6a512-1295-4272-9138-f99709370657
2007-08-05 19:19:39 +00:00
Peter D'Hoye
6c36a58e49
Final changes to the recording naming code, this should make jhMikeS happy ;)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14165 a1c6a512-1295-4272-9138-f99709370657
2007-08-03 18:55:00 +00:00
Peter D'Hoye
c21abddaae
Even more optimizing for the recording name change...
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14148 a1c6a512-1295-4272-9138-f99709370657
2007-08-02 18:45:38 +00:00
Jens Arnold
31ff52cee6
Simplify the source based recording file names a bit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14136 a1c6a512-1295-4272-9138-f99709370657
2007-08-02 10:40:47 +00:00
Peter D'Hoye
705ca703e3
Let recording create filenames based on the recording source, closes FS #921 (yes, he waited 4 years for his feature request to make it)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14125 a1c6a512-1295-4272-9138-f99709370657
2007-08-01 22:04:28 +00:00
Jonathan Gordon
f7675a244b
remove the need for action_signalscreenchange().
...
Fixes problems with targets where the ACTION_STD_CANCEL event is a combo
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13956 a1c6a512-1295-4272-9138-f99709370657
2007-07-22 06:05:53 +00:00
Michael Sevakis
680afafc23
Fix all the red this time?
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13884 a1c6a512-1295-4272-9138-f99709370657
2007-07-14 13:41:59 +00:00
Michael Sevakis
7d759f6b9c
Do some planned radio interface cleanup since adding in the LV24020LP.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13880 a1c6a512-1295-4272-9138-f99709370657
2007-07-14 11:20:31 +00:00
Jonathan Gordon
a5278fa3db
Rearrange and cleanup settings code
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13851 a1c6a512-1295-4272-9138-f99709370657
2007-07-11 05:41:23 +00:00
Jonathan Gordon
415e9d78cc
User configurable recording path (my patch in FS#7201). path defaults to / and can be changed in the folder context menu (cleared in the recording settings menu)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13838 a1c6a512-1295-4272-9138-f99709370657
2007-07-10 07:41:37 +00:00
Peter D'Hoye
9337efdb7a
Accept FS #7303 by Christoph Reiter: add context menu to FM radio entry in main menu. Also changes a small naming inconsistency.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13778 a1c6a512-1295-4272-9138-f99709370657
2007-07-03 18:31:13 +00:00
Peter D'Hoye
e50cba942f
Give recording related menu entries a recording icon (settings and radio menus). FS #7302 with small addition by me.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13718 a1c6a512-1295-4272-9138-f99709370657
2007-06-25 21:19:45 +00:00
Michael Sevakis
ea255fbc3a
Prevent initial spinup when starting first file when in a stopped state on non-RTC targets. Fix some states that are dangerous on SWCODEC and could result in data loss. Had to make plugin API incopatible since specified numbered filename creation is enabled now on all non-RTC targets with recording; increase version and sort the items that looked like they had a place to go.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13683 a1c6a512-1295-4272-9138-f99709370657
2007-06-22 09:34:57 +00:00
Steve Bavin
24d9f59c78
When recording, disable voice menus without actually modifying user settings. Patch FS#7272, fixes bug FS #6163
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13615 a1c6a512-1295-4272-9138-f99709370657
2007-06-11 08:28:38 +00:00
Michael Sevakis
2d48d0ffa6
Straighten out some audio path APIs and misc. audio stuff. Having recording is not a prerequisite to having input/output source selection which is probably most useful when adding a audio input features like FM to a new port without forcing recording to be implemented first.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13599 a1c6a512-1295-4272-9138-f99709370657
2007-06-08 23:42:04 +00:00
Michael Sevakis
21a4a87ca2
Accept FS#7178 - Sansa e200 FM tuner support by Ivan Zupan. Do the needed integration work into recording and the AS3514 audio driver. Do a little AS3514 fiq_record tweak to have it all work nicely from the start.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13573 a1c6a512-1295-4272-9138-f99709370657
2007-06-06 19:23:48 +00:00
Michael Sevakis
619d2226bd
e200: Fix errors from recording addition and a warning that comes up when fixing the errors.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13558 a1c6a512-1295-4272-9138-f99709370657
2007-06-05 07:22:26 +00:00