Commit graph

83 commits

Author SHA1 Message Date
Jonathan Gordon
5ca1539969 the menu and list now accepts a parent viewport to draw in (and the menu can be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
2008-03-26 03:35:24 +00:00
Antoine Cellerier
a6d4e531a3 Patch "Remain in PLViewer when move_track is canceled", by Lee Kang Hyuk. Closes FS#8322.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15937 a1c6a512-1295-4272-9138-f99709370657
2007-12-15 17:14:04 +00:00
Nils Wallménius
4acae4da03 Use the strrsplt function in one more place
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15662 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 14:12:01 +00:00
Antoine Cellerier
2490700867 Playlist viewer move live preview. Closes FS #7968.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15124 a1c6a512-1295-4272-9138-f99709370657
2007-10-15 20:34:02 +00:00
Jonathan Gordon
cf1cef5f57 minor update to gui_synclist_do_button() which will hopefully simplify things later.
Now returns true if the action was handled in that function instead of returning the handled action.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14733 a1c6a512-1295-4272-9138-f99709370657
2007-09-17 10:08:50 +00:00
Peter D'Hoye
b8ded7d674 Accept FS #7627: allow viewing of dynamic playlist when it has ended
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14456 a1c6a512-1295-4272-9138-f99709370657
2007-08-25 16:05:58 +00:00
Peter D'Hoye
df3281347d Accept FS #7626: allow viewing playlist files if no playlist is loaded
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14420 a1c6a512-1295-4272-9138-f99709370657
2007-08-21 23:50:26 +00:00
Nils Wallménius
b311367481 *** Lang v2 cleanup (FS#6574) ***
1) Introduces apps/features.txt that controls which strings are included 
for each target based on defines.
2) .lng and .voice files are now target specific and the format versions 
of both these file types have been bumped, which means that new voice 
files are needed. 
3) Use the 'features' mechanism to exclude strings for targets that 
didn't use them.
4) Delete unused and deprecated and duplicated strings, sort strings in 
english.lang

Some string IDs were changed so translations will be slightly worse than 
before.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14198 a1c6a512-1295-4272-9138-f99709370657
2007-08-05 19:19:39 +00:00
Jonathan Gordon
88882a83d6 sync and commit FS#4954 - return any results found when aborting a playlist search
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14179 a1c6a512-1295-4272-9138-f99709370657
2007-08-04 09:36:47 +00:00
Jonathan Gordon
f7675a244b remove the need for action_signalscreenchange().
Fixes problems with targets where the ACTION_STD_CANCEL event is a combo


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13956 a1c6a512-1295-4272-9138-f99709370657
2007-07-22 06:05:53 +00:00
Jonathan Gordon
52ba1c614d Fix some naughty variable name reuse (hopefully correctly)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13269 a1c6a512-1295-4272-9138-f99709370657
2007-04-26 10:28:32 +00:00
Jonathan Gordon
3d44a20db7 Accept FS7078, try to show the last playlist if no audio is being played
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13268 a1c6a512-1295-4272-9138-f99709370657
2007-04-26 08:21:29 +00:00
Jonathan Gordon
70e2846241 oops, wrong return value
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13260 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 12:17:16 +00:00
Jonathan Gordon
a2740d9edc convert the playlist viewer menus to the newer API
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13259 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 11:20:19 +00:00
Michael Sevakis
eb85f14f95 No more type punning where it's not funny.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13235 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 19:20:20 +00:00
Michael Sevakis
8676dc25f5 Missed a couple. Hopefully fix all warnings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13234 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 19:07:15 +00:00
Michael Sevakis
26d242ae65 General housekeeping: Make plugin buffer functions take size_t * instead of int * to match the parameter type of the buffer functions called in the core. Get rid of unsafe int * <==> size_t * casting. Use ssize_t where int was used and size_t where unsigned int was used in the buffer calls to not alter signedness in the plugins. No API version change since it should only be an issue for 64-bit sim builds.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13233 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 18:38:25 +00:00
Jonathan Gordon
36a2e30872 Move the inbuilt filetype info into filetypes.c and rename the defines.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13201 a1c6a512-1295-4272-9138-f99709370657
2007-04-18 13:03:01 +00:00
Jonathan Gordon
6a5cc0bd25 Customizable icons for all bitmap targets. (FS#7013)
http://www.rockbox.org/twiki/bin/view/Main/CustomIcons for info on format and how to load them


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13177 a1c6a512-1295-4272-9138-f99709370657
2007-04-16 09:14:36 +00:00
Peter D'Hoye
734278b7d1 Consistency fix: pressing play (on) button also takes you to the WPS just like elsewhere. Fixes FS #6743
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13135 a1c6a512-1295-4272-9138-f99709370657
2007-04-12 21:28:58 +00:00
Peter D'Hoye
b16137e10b Make sure selected track of playlist viewer doesn't become bigger than number of tracks when deleting the last track. Fixes FS #6899
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13113 a1c6a512-1295-4272-9138-f99709370657
2007-04-11 22:39:12 +00:00
Jonathan Gordon
21b415df56 Give all menus using the old API a nice title and icons (except plugins)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13068 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 05:52:47 +00:00
Jonathan Gordon
6cbf30d5c7 Give the playlist viewer a title (FS#6898)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13028 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 04:13:02 +00:00
Jens Arnold
4d6374c923 Get rid of the 'center' parameter for splashes. There were only 2 of almost 500 splashes which were not centered.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12807 a1c6a512-1295-4272-9138-f99709370657
2007-03-16 21:56:08 +00:00
Jonathan Gordon
a1a4034b82 fix FS#6784
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12713 a1c6a512-1295-4272-9138-f99709370657
2007-03-11 01:09:25 +00:00
Nils Wallménius
87c20b7762 Remove useless define
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12463 a1c6a512-1295-4272-9138-f99709370657
2007-02-23 22:18:09 +00:00
Jonathan Gordon
ce584280ab Remove the File Options menu from the playlist viewer, but put the
playlist catalog options in. Fixes FS#6577


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12283 a1c6a512-1295-4272-9138-f99709370657
2007-02-12 05:02:42 +00:00
Jens Arnold
2597a13497 Next round of static'ing and related fixes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11836 a1c6a512-1295-4272-9138-f99709370657
2006-12-25 14:01:47 +00:00
Michael Sevakis
acc29d95be SWCODEC/IRAM: Save voice IRAM when a plugin initializes its IRAM. Defines two macros for declaring and initializing IRAM. Plugins should use these instead. See mp3_encoder, doom, etc. for details. Further tweaks in buffer restoration after other use. Hiding of some interfaces that should only be used by buffer management.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11544 a1c6a512-1295-4272-9138-f99709370657
2006-11-18 02:18:29 +00:00
Jonathan Gordon
6a1161b634 dont allow the volume setting to wrap
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11445 a1c6a512-1295-4272-9138-f99709370657
2006-11-06 10:11:51 +00:00
Linus Nielsen Feltzing
224c0a13eb Finally, the new button action system is here, thanks to Jonathan Gordon. Some button mappings have changed and other things may break. Comments should go to the forum, http://forums.rockbox.org/index.php?topic=5829.0 or the mailing list.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10582 a1c6a512-1295-4272-9138-f99709370657
2006-08-15 12:27:07 +00:00
Shachar Liberman
f53779d2f4 Committing FS#5182 - One button hold for Horizontal screen scrolling.
=>hold RIGHT or LEFT button on a GUI based list to scroll horizontally.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10545 a1c6a512-1295-4272-9138-f99709370657
2006-08-12 13:40:49 +00:00
Antoine Cellerier
59dc18dda0 FS#5784 - Strip extension from all filetypes in playlist viewer
Patch by Nils Wallménius


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10517 a1c6a512-1295-4272-9138-f99709370657
2006-08-10 21:08:44 +00:00
Kevin Ferrare
f77ac7a6a7 added support remote support for the id3 infos screen (had to slightly change the list engine to use it here as well), corrected a mistake in the french translation
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10175 a1c6a512-1295-4272-9138-f99709370657
2006-07-02 12:28:27 +00:00
Hardeep Sidhu
9a681dd700 Redraw list whenever playlist changes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10116 a1c6a512-1295-4272-9138-f99709370657
2006-06-12 23:25:12 +00:00
Hardeep Sidhu
06605a92c0 Buffer margin was off by 1 causing corruption when page scrolling
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9953 a1c6a512-1295-4272-9138-f99709370657
2006-05-17 07:57:54 +00:00
Hardeep Sidhu
c7f304e1b9 Stop playback and exit viewer if last track in current playlist is removed
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9739 a1c6a512-1295-4272-9138-f99709370657
2006-04-20 07:30:28 +00:00
Zakk Roberts
34ad56ddfd Fix unexitable playlist viewer menu for iPods and possibly other models.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9447 a1c6a512-1295-4272-9138-f99709370657
2006-04-03 04:13:26 +00:00
Tomas Salfischberger
4ec9dbdd18 For backlight_on() to work, you need backlight.h :)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8907 a1c6a512-1295-4272-9138-f99709370657
2006-03-05 00:16:34 +00:00
Tomas Salfischberger
c2e86cd0d9 Patch FS#4759 by Jonathan Gordon - searching in playlists.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8906 a1c6a512-1295-4272-9138-f99709370657
2006-03-04 23:53:09 +00:00
Hardeep Sidhu
0cca6caa8a Currently playing playlist can now be overwritten. Save playlist screen defaults to this.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8641 a1c6a512-1295-4272-9138-f99709370657
2006-02-09 09:09:32 +00:00
Linus Nielsen Feltzing
2f56ee9d0f Proper fix for the playlist viewer crash
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8359 a1c6a512-1295-4272-9138-f99709370657
2006-01-17 14:15:47 +00:00
Linus Nielsen Feltzing
0b8149fefb Fixed a crash when wrapping the playlist viewer backwards, and made it always select the currently playing track when viewing the current playlist
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8358 a1c6a512-1295-4272-9138-f99709370657
2006-01-17 12:30:03 +00:00
Daniel Stenberg
f981ea93fb kill gcc4 warnings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8162 a1c6a512-1295-4272-9138-f99709370657
2005-12-05 22:44:42 +00:00
Hardeep Sidhu
3074394d24 If follow playlist is enabled, the playlist viewer should start at the current playing track. Minor code cleanup.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7997 a1c6a512-1295-4272-9138-f99709370657
2005-11-19 18:19:46 +00:00
Kevin Ferrare
15046f99b3 show/hide icons now works properly in playlist viewer
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7911 a1c6a512-1295-4272-9138-f99709370657
2005-11-16 17:23:49 +00:00
Kevin Ferrare
e991beed6d replaced all the splash calls by gui_sync_splash, added some missing remote key in the playlist viewer
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7909 a1c6a512-1295-4272-9138-f99709370657
2005-11-16 15:12:15 +00:00
Kevin Ferrare
6a53c33a8b fixed the warning and changed playlist max entries in buffer to 200 as it was before
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7902 a1c6a512-1295-4272-9138-f99709370657
2005-11-16 02:55:26 +00:00
Kevin Ferrare
8517ed8939 Multi screen support for playlist viewer, some fixes in other gui files
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7901 a1c6a512-1295-4272-9138-f99709370657
2005-11-16 02:12:25 +00:00
Miika Pekkarinen
c52f7f1b5e iRiver: Fixed broken items skipping on playlist: Now skipping and
marking them as bad instead of deleting the entries from playlist.
Faster buffered track skipping and preventing glitches from previous
tracks (still something might occur though, please report them).


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7647 a1c6a512-1295-4272-9138-f99709370657
2005-10-21 06:40:45 +00:00