Jonathan Gordon
94b9804427
Make MENUITEM_STRINGLIST() menus talk (if ID2P() is used for the string)
...
Makes the plugin browser talk (FS#7612), as well as the paylist viewer menu and the bookmark menu.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14399 a1c6a512-1295-4272-9138-f99709370657
2007-08-20 09:11:05 +00:00
Magnus Holmgren
1d9f693658
Redraw the menu when stopping playback, in case the bookmarking code left something on screen.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14196 a1c6a512-1295-4272-9138-f99709370657
2007-08-05 15:21:47 +00:00
Jonathan Gordon
75e2f19de3
dont redraw the menu if we are about to quit anyway (noticable when backing out of the playlist menu from the wps context menu)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14180 a1c6a512-1295-4272-9138-f99709370657
2007-08-04 09:47:17 +00:00
Jonathan Gordon
73336e9729
Finally use the rec button to get to the rec screen on sansa and iriver hxxx. hold rec to get there... short press still is unused
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14141 a1c6a512-1295-4272-9138-f99709370657
2007-08-02 12:13:20 +00:00
Jonathan Gordon
fe2b376060
Fix the text for settings which have a different title than what is shown in the menu (i.e scroll options)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13962 a1c6a512-1295-4272-9138-f99709370657
2007-07-23 05:40:45 +00:00
Jonathan Gordon
f7675a244b
remove the need for action_signalscreenchange().
...
Fixes problems with targets where the ACTION_STD_CANCEL event is a combo
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13956 a1c6a512-1295-4272-9138-f99709370657
2007-07-22 06:05:53 +00:00
Jonathan Gordon
a5278fa3db
Rearrange and cleanup settings code
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13851 a1c6a512-1295-4272-9138-f99709370657
2007-07-11 05:41:23 +00:00
Jonathan Gordon
50dc0cabe3
same as previous commit, but more forgotten cases
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13850 a1c6a512-1295-4272-9138-f99709370657
2007-07-11 04:17:43 +00:00
Jonathan Gordon
953e7cf183
woops, menus stopped getting redrawn when the setting screen exited
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13849 a1c6a512-1295-4272-9138-f99709370657
2007-07-11 04:13:30 +00:00
Jonathan Gordon
411f3e2b2b
If the action handler for the menu returns ACTION_REDRAW the list will be redrawn. Fixes the Now Playing/Resume Playback text not updating
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13848 a1c6a512-1295-4272-9138-f99709370657
2007-07-11 02:22:03 +00:00
Jonathan Gordon
b9f22af85a
Redraw the menus once every action, not 3 times
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13847 a1c6a512-1295-4272-9138-f99709370657
2007-07-11 01:23:57 +00:00
Jonathan Gordon
0baad43a93
Accept FS#7313 - make the menus talk more often
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13679 a1c6a512-1295-4272-9138-f99709370657
2007-06-21 12:32:10 +00:00
Steve Bavin
24d9f59c78
When recording, disable voice menus without actually modifying user settings. Patch FS#7272, fixes bug FS #6163
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13615 a1c6a512-1295-4272-9138-f99709370657
2007-06-11 08:28:38 +00:00
Jonathan Gordon
fd9d140119
Fix FS#7176 - wps context menu doesnt set the correct selection.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13445 a1c6a512-1295-4272-9138-f99709370657
2007-05-20 14:24:02 +00:00
Nils Wallménius
f31e123133
Remove unused function and unused header
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13424 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 19:54:11 +00:00
Jonathan Gordon
77a458a464
Move the old api out of the core and into the plugin lib.
...
ew plugins shuold use the new api and not this one.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13358 a1c6a512-1295-4272-9138-f99709370657
2007-05-08 11:55:43 +00:00
Jonathan Gordon
cf478758dd
fix the menus again, this time it stopped redrawing after coming out of setting screens
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13353 a1c6a512-1295-4272-9138-f99709370657
2007-05-08 01:32:29 +00:00
Jonathan Gordon
baf9cf6990
Fix my previous commit... menus will redraw correctly again
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13338 a1c6a512-1295-4272-9138-f99709370657
2007-05-07 08:50:47 +00:00
Jonathan Gordon
1228820ca9
Fix the menus so lines scroll again
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13337 a1c6a512-1295-4272-9138-f99709370657
2007-05-07 07:51:35 +00:00
Jonathan Gordon
3a7760c3e2
Convert onplay.c to the new manu API. only plugins are still using the old API now
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13294 a1c6a512-1295-4272-9138-f99709370657
2007-04-30 13:41:33 +00:00
Jonathan Gordon
cd8870ccfb
fix a bug which made menus using the old API and a callback function to not work correctly
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13246 a1c6a512-1295-4272-9138-f99709370657
2007-04-22 14:24:32 +00:00
Jonathan Gordon
6a5cc0bd25
Customizable icons for all bitmap targets. (FS#7013)
...
http://www.rockbox.org/twiki/bin/view/Main/CustomIcons for info on format and how to load them
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13177 a1c6a512-1295-4272-9138-f99709370657
2007-04-16 09:14:36 +00:00
Jens Arnold
17c93f9be0
Fix an off-by-one bug (hitting when menu titles are enabled) in the oldmenu wrapper.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13149 a1c6a512-1295-4272-9138-f99709370657
2007-04-14 00:03:09 +00:00
Jonathan Gordon
f9fb49284e
Give most of the items in the main menu a context menu
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13126 a1c6a512-1295-4272-9138-f99709370657
2007-04-12 15:28:51 +00:00
Jens Arnold
8636e6949e
Moved SH1 system code to target tree. * First shot at hwcompat cleanup.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13114 a1c6a512-1295-4272-9138-f99709370657
2007-04-11 23:51:00 +00:00
Jens Arnold
178c565beb
Stop/shutdown logic rework in browsers and menus. Recorder V1: Double-Off shutdown is now possible from menus and sub-browsers as well. Player, other targets which are always powered during charging: Attempted shutdown from menu with charger plugged now displays the charging splash.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13079 a1c6a512-1295-4272-9138-f99709370657
2007-04-09 13:39:37 +00:00
Jonathan Gordon
9e95e306cd
fix yellow
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13069 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 06:15:34 +00:00
Jonathan Gordon
21b415df56
Give all menus using the old API a nice title and icons (except plugins)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13068 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 05:52:47 +00:00
Jonathan Gordon
a053e58894
minor actions cleanup:
...
- CONTEXT_MAINMENU is not actually needed, use CONTEXT_TREE which does the same actions
- (gigabeat) use vol+/- in the lists to control volume (every list!) (FS#6982 in a better way)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13062 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 01:33:01 +00:00
Peter D'Hoye
d2b305571e
Check if a new version got installed after usb disconnect and ask if user wants to reboot. Causes disk spinup before showing the usb logo. Also fixes do_menu() not returning to root_menu after usb disconnect.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12972 a1c6a512-1295-4272-9138-f99709370657
2007-03-30 21:54:48 +00:00
Jonathan Gordon
91e726a1c1
Move all valid menu return codes to a single file (root_menu.h) so we don't need to rely on GO_TO_ROOT == MENU_ATTACHED_USB.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12937 a1c6a512-1295-4272-9138-f99709370657
2007-03-27 06:38:11 +00:00
Jonathan Gordon
1f5ee2a366
convert the xobox menu to the new API so it can be used as an example for plugin devs
...
Includes some fixes in the api to handle this.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12907 a1c6a512-1295-4272-9138-f99709370657
2007-03-25 14:31:56 +00:00
Jonathan Gordon
5b61ebe84e
Remove buffer overflow in solatiare menu
...
Make the old api -> new api wrapper in the menu safer.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12831 a1c6a512-1295-4272-9138-f99709370657
2007-03-18 11:01:23 +00:00
Jonathan Gordon
e54d8e1388
Remove the exit_value variable.. set the MENU_FUNC_CHECK_RETVAL fla and
...
return 1 if you want your funciton to quit the menus.
save settings after clearing the background so it persists
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12827 a1c6a512-1295-4272-9138-f99709370657
2007-03-18 07:03:43 +00:00
Jonathan Gordon
b5e587c081
Fix improper shift and mask order causing FS#6842
...
Set start_selected if exiting do_menu() early from more places
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12826 a1c6a512-1295-4272-9138-f99709370657
2007-03-18 06:31:33 +00:00
Jonathan Gordon
3d39c4de28
Fix it dropping back to the file browser.
...
Fix yellow
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12823 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 14:16:11 +00:00
Jonathan Gordon
208136d1ea
Reload the menu if do_menu() is called while another menu is running
...
(fixes crashing coming out of rec settings from fm menu)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12822 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 14:10:51 +00:00
Jonathan Gordon
daf66940b1
Unify the way functions are called from menus.
...
Optionally, the functions return value can be checked for a value to
tell the menu to quit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12821 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 12:33:34 +00:00
Jonathan Gordon
b1a626949e
put action_signalscreenchange(); in before exiting do_menu(), fixes
...
FS#6829
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12774 a1c6a512-1295-4272-9138-f99709370657
2007-03-15 05:40:18 +00:00
Jonathan Gordon
5dffaf74f5
This one should not have been "fixed"
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12773 a1c6a512-1295-4272-9138-f99709370657
2007-03-15 05:09:18 +00:00
Jonathan Gordon
b35c1d8d35
Change anywhere where do_menu()'s return value was checked and expected
...
a bool to appear the same as the old API. Possibly fixes some bugs, but
doubtful.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12772 a1c6a512-1295-4272-9138-f99709370657
2007-03-15 04:42:10 +00:00
Jens Arnold
b1646abc18
Fix 64 bit warnings for real.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12683 a1c6a512-1295-4272-9138-f99709370657
2007-03-08 06:30:15 +00:00
Jonathan Gordon
7cb46f2f3e
Really fix the yellow this time
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12682 a1c6a512-1295-4272-9138-f99709370657
2007-03-08 04:20:28 +00:00
Jonathan Gordon
fe3fa144c6
fix yellow
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12681 a1c6a512-1295-4272-9138-f99709370657
2007-03-08 00:51:20 +00:00
Jonathan Gordon
1005195cb6
dont crash if play is pressed in menus using the old api
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12671 a1c6a512-1295-4272-9138-f99709370657
2007-03-07 13:24:29 +00:00
Jonathan Gordon
3452146217
Make the old menu aPI use the new API. Both are avialable to core and
...
rocks, but use the new API unless you absolutly have to use the old one
(and file a FS bug if you do)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12670 a1c6a512-1295-4272-9138-f99709370657
2007-03-07 13:00:46 +00:00
Jonathan Gordon
43b2d091ba
Fix the various bugs associated with pressing MENU to move in and out of
...
the Rockbox Menu
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12666 a1c6a512-1295-4272-9138-f99709370657
2007-03-07 10:13:07 +00:00
Jonathan Gordon
a74eefe1b2
Pressing Menu in the Rockbox Menu puts you back in the previous screen.
...
Hopefully simplify the code a bit
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12643 a1c6a512-1295-4272-9138-f99709370657
2007-03-06 13:35:15 +00:00
Linus Nielsen Feltzing
298c2bbd83
Allow dynamic menu items to be spoken, especially the resume/now playing item
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12614 a1c6a512-1295-4272-9138-f99709370657
2007-03-05 00:32:33 +00:00
Jonathan Gordon
97090863a6
Allow settings to have a different title in the setting screen than they
...
have in the menu.
Fixes the scroll speed/step settings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12572 a1c6a512-1295-4272-9138-f99709370657
2007-03-03 14:23:03 +00:00