Commit graph

21 commits

Author SHA1 Message Date
Dave Chapman
f02cba8096 Code cleaning - remove some unnecessary defined(SIMULATOR) checks
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13369 a1c6a512-1295-4272-9138-f99709370657
2007-05-10 13:16:08 +00:00
Thom Johansen
8e6e290a95 Factor first order shelving filter code out for easier reuse and replace the crossfeed filter with it. Crossfeed _should_ still sound the same, so please do tell if it doesn't.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12674 a1c6a512-1295-4272-9138-f99709370657
2007-03-07 15:06:33 +00:00
Thom Johansen
deb69d280d Wrap filter_bishelf_coefs with HAVE_SW_TONE_CONTROLS to not waste bytes on targets that don't use it.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12490 a1c6a512-1295-4272-9138-f99709370657
2007-02-26 00:58:07 +00:00
Thom Johansen
a7fabf0741 Add software based bass/treble controls for targets which have no such functionality in hardware (currently only X5). They can also be used on any other SWCODEC target by adding #define HAVE_SW_TONE_CONTROLS in the relevant config-*.h file. Also remove some now unneeded zero checks when using get_replaygain_int(). Comments on sound quality are welcome as some parameters can still be fine-tuned.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12489 a1c6a512-1295-4272-9138-f99709370657
2007-02-26 00:41:26 +00:00
Thom Johansen
5f48e1590f Optimise EQ coef calculation routines for both speed and size. Move now unneeded fsqrt function to plugin fixed point library in case it'll be needed. Move all fixed point helper macros to dsp.h. Added FRACMUL_SHL macro to facilitate high-precision shifting of 64 bit multiplies and remove rounding from macsr in main thread to make this work as intended.
Tested quite thorougly, but as always, be careful with your ears.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12203 a1c6a512-1295-4272-9138-f99709370657
2007-02-05 01:01:15 +00:00
Jens Arnold
314f3b58f1 More static'ing, and a few fixes resulting from that.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11737 a1c6a512-1295-4272-9138-f99709370657
2006-12-12 22:22:21 +00:00
Thom Johansen
48b4ac3745 Two more bits of precision for shelving EQ filters and some comment updates. Tested quite thoroughly, but as always with audio related commits: mind your ears.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11265 a1c6a512-1295-4272-9138-f99709370657
2006-10-18 22:45:39 +00:00
Thom Johansen
8238b49c74 New crossfeed complete with no volume reducing bugs. Feedback on all the
new options is appreciated. Thanks to Dan Everton for the settings/GUI
code.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9609 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 13:49:05 +00:00
Thom Johansen
5f9bd4fb98 Make EQ work on 64 bit sims again.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9214 a1c6a512-1295-4272-9138-f99709370657
2006-03-23 19:26:21 +00:00
Thom Johansen
e70a50cd9a Fix the inaccurate frequency setting problems of the EQ due to
inaccuracies in the sin/cos functioncs. A million thanks to safetydan
for fixing my crappy trig functions!


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9209 a1c6a512-1295-4272-9138-f99709370657
2006-03-23 15:40:59 +00:00
Thom Johansen
c00ec11598 Further 64 bit related fixes. EQ should now work in AMD64 sim.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9142 a1c6a512-1295-4272-9138-f99709370657
2006-03-21 01:09:53 +00:00
Thom Johansen
ea4ccb5aba Samples should always be 32 bit on all platforms, so change most
occurences of long to int32_t to enable working sounds also on 64 bit
sims. Note that some codecs (MP3 and Wavpack) still have other 64
bit related problems.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9120 a1c6a512-1295-4272-9138-f99709370657
2006-03-19 16:31:45 +00:00
Dan Everton
62441704e7 C implementation of eq filter. Allows equalizer to be used in the simulator. Code from preglow.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8973 a1c6a512-1295-4272-9138-f99709370657
2006-03-09 09:40:03 +00:00
Thom Johansen
fa9c5c0656 Erronous comment.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8803 a1c6a512-1295-4272-9138-f99709370657
2006-02-23 11:29:10 +00:00
Dan Everton
88abdd97b2 Add Equalizer configuration to Sound Settings menu.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8606 a1c6a512-1295-4272-9138-f99709370657
2006-02-07 14:07:46 +00:00
Linus Nielsen Feltzing
dd8cb8a2c1 Committed a little too much
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8569 a1c6a512-1295-4272-9138-f99709370657
2006-02-04 23:16:31 +00:00
Linus Nielsen Feltzing
621bcc2294 The simulator should use the keypad period key, not the regular one
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8568 a1c6a512-1295-4272-9138-f99709370657
2006-02-04 23:15:15 +00:00
Thom Johansen
9b4b4d0bf2 More sane fixed point format for Q parameter.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8535 a1c6a512-1295-4272-9138-f99709370657
2006-02-02 20:04:02 +00:00
Thom Johansen
98c37c7f89 Enable ARM EQ support.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8518 a1c6a512-1295-4272-9138-f99709370657
2006-02-01 08:36:56 +00:00
Thom Johansen
65721f0b35 Slight change of coef format. Removed erronous hard code of channel
number in EQ filtering routine and added some minor changes.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8486 a1c6a512-1295-4272-9138-f99709370657
2006-01-29 17:52:13 +00:00
Thom Johansen
a8cc6a7454 Initial multi-band EQ support for software codec platforms. Now go start
making that user interface!


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8478 a1c6a512-1295-4272-9138-f99709370657
2006-01-29 02:10:28 +00:00