Magnus Holmgren
2235081dbc
Prevent possible buffer overflow when locating album art.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16231 a1c6a512-1295-4272-9138-f99709370657
2008-02-06 19:51:19 +00:00
Nicolas Pennequin
536b5a0482
Accept FS#8469 by Bryan Childs with a few adjustments: Remove duplicate strip_extension() function from albumart.c. The other one is moved from tree.c to misc.c.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16103 a1c6a512-1295-4272-9138-f99709370657
2008-01-18 10:02:03 +00:00
Robert Kukla
d87b037efe
consolidate the 3 file_exists() functions into one; use the version that explicitly uses dircache; give dir_exists() the same treatment for consistency
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15742 a1c6a512-1295-4272-9138-f99709370657
2007-11-21 21:28:27 +00:00
Nils Wallménius
4acae4da03
Use the strrsplt function in one more place
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15662 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 14:12:01 +00:00
Jens Arnold
ffb3dfd241
Fix some places for USB_NONE. Still some more complex cases left though.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14122 a1c6a512-1295-4272-9138-f99709370657
2007-08-01 20:21:34 +00:00
Michael Sevakis
ea255fbc3a
Prevent initial spinup when starting first file when in a stopped state on non-RTC targets. Fix some states that are dangerous on SWCODEC and could result in data loss. Had to make plugin API incopatible since specified numbered filename creation is enabled now on all non-RTC targets with recording; increase version and sort the items that looked like they had a place to go.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13683 a1c6a512-1295-4272-9138-f99709370657
2007-06-22 09:34:57 +00:00
Brandon Low
74cbb0a1b2
Give color targets the ability to display each LCD line a different color and use this newfangled ability to provide themable colored file types. See the comments on read_color_theme_file and the sample.colors file provided for how to use this. .colors files go in themes directory for now. This separate line color function should be trivial to add to menus and wpss.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13656 a1c6a512-1295-4272-9138-f99709370657
2007-06-17 21:16:34 +00:00
Nils Wallménius
f46657ec5a
Move the setvol wrapper function to misc.c and use it in more places instead of doing the same checks everywhere
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13524 a1c6a512-1295-4272-9138-f99709370657
2007-05-30 17:57:32 +00:00
Jens Arnold
178c565beb
Stop/shutdown logic rework in browsers and menus. Recorder V1: Double-Off shutdown is now possible from menus and sub-browsers as well. Player, other targets which are always powered during charging: Attempted shutdown from menu with charger plugged now displays the charging splash.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13079 a1c6a512-1295-4272-9138-f99709370657
2007-04-09 13:39:37 +00:00
Peter D'Hoye
dc33e1e8a7
Don't check for bootfile changes on devices that use OF for USB (and thus reboot)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12974 a1c6a512-1295-4272-9138-f99709370657
2007-03-30 23:36:10 +00:00
Peter D'Hoye
d2b305571e
Check if a new version got installed after usb disconnect and ask if user wants to reboot. Causes disk spinup before showing the usb logo. Also fixes do_menu() not returning to root_menu after usb disconnect.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12972 a1c6a512-1295-4272-9138-f99709370657
2007-03-30 21:54:48 +00:00
Jens Arnold
2c7b127dd7
Set CONFIG_RTC to 0 for non-RTC targets, and check with #if to profit from -Wundef. No code change.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12811 a1c6a512-1295-4272-9138-f99709370657
2007-03-16 23:47:03 +00:00
Magnus Holmgren
14ba91eaa9
A few more bookmark code tweaks. Also improves how the bookmark selection screen is displayed on Archos players.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12350 a1c6a512-1295-4272-9138-f99709370657
2007-02-17 13:36:44 +00:00
Magnus Holmgren
ea7992455a
Make the updated %rg tag match playback behaviour (fall back to track gain if album gain requested but not available). Share the mode decision logic with playback code and simplify the %rg tag handling.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11532 a1c6a512-1295-4272-9138-f99709370657
2006-11-15 20:26:33 +00:00
Michael Sevakis
0f5cb94aa4
Big Patch adds primarily: Samplerate and format selection to recording for SWCODEC. Supprort for samplerates changing in playback (just goes with the recording part inseparably). Samplerates to all encoders. Encoders can be configured individually on a menu specific to the encoder in the recording menu. File creation is delayed until flush time to reduce spinups when splitting. Misc: statusbar icons for numbers are individual digits to display any number. Audio buffer was rearranged to maximize memory available to recording and properly reinitialized when trashed. ColdFire PCM stuff moved to target tree to avoid a complicated mess when adding samplerate switching. Some needed API changes and to neaten up growing gap between hardware and software codecs.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11452 a1c6a512-1295-4272-9138-f99709370657
2006-11-06 18:07:30 +00:00
Miika Pekkarinen
a1ac743453
Implement fast_readline as a function and use it for tagtree also.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11301 a1c6a512-1295-4272-9138-f99709370657
2006-10-21 20:37:33 +00:00
Dave Chapman
8c800cf59a
Replace references to HAVE_RTC with CONFIG_RTC and remove the HAVE_RTC defines from config-*.h
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8147 a1c6a512-1295-4272-9138-f99709370657
2005-12-04 15:23:47 +00:00
Jens Arnold
05042affc7
Core: A graphics framework can now register a hook function to extend the core screendump routine. * Grayscale library: (1) Changed the screendump routine into a hook, and implemented it for H1x0. (2) The planar pixel setting routines now use one register less. Fixes build problem with developer builds (frame pointers enabled) on coldfire.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7574 a1c6a512-1295-4272-9138-f99709370657
2005-10-01 10:20:55 +00:00
Linus Nielsen Feltzing
60895bc107
Patch #1272052 by Henrik Backe - Move credits to a plugin
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7450 a1c6a512-1295-4272-9138-f99709370657
2005-09-02 05:39:09 +00:00
Jens Arnold
58e9412bff
Added universal functions for creation of numbered filenames and date+time filenames (units with RTC only). Some size optimisations within code using these new functions. Everything should behave as before, except config saving will always find the highest file number + 1 even if the sequence is non-contiguous.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7449 a1c6a512-1295-4272-9138-f99709370657
2005-09-02 01:15:35 +00:00
Linus Nielsen Feltzing
670abf99ae
The shutdown message is now displayed before saving the database, giving better user feedback when whutting off the player
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7351 a1c6a512-1295-4272-9138-f99709370657
2005-08-18 14:23:18 +00:00
Linus Nielsen Feltzing
3d2178148b
Moved the car adapter mode handling to apps/, now every thread gets SYS_CHARGER_CONNECTED and SYS_CHARGER_DISCONNECTED events
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6255 a1c6a512-1295-4272-9138-f99709370657
2005-04-06 11:12:22 +00:00
Jean-Philippe Bernardy
f64939eeda
oops again, incomplete long policy
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5843 a1c6a512-1295-4272-9138-f99709370657
2005-02-07 22:56:37 +00:00
Jens Arnold
2116bba296
New function for formatting large-range values for output, both printed and voiced. This replaces num2max5(). It is currently used for the total/free space display in the info menu, for the recorded number of bytes (recorders) and the MMC debug info (Ondios).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5721 a1c6a512-1295-4272-9138-f99709370657
2005-01-31 00:39:20 +00:00
Jens Arnold
0dc52d5c36
Extended default_event_handler() that calls a callback function prior to actually handling the event.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5263 a1c6a512-1295-4272-9138-f99709370657
2004-10-12 22:45:01 +00:00
Linus Nielsen Feltzing
f749093c26
Cosmetic changes
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4954 a1c6a512-1295-4272-9138-f99709370657
2004-07-26 23:31:40 +00:00
Linus Nielsen Feltzing
ade5d7b848
First step in revamping the USB event handling, paving the way for the upcoming SYS_POWER_OFF event
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4951 a1c6a512-1295-4272-9138-f99709370657
2004-07-26 16:06:59 +00:00
Linus Nielsen Feltzing
5b5003dcb1
New feature: clean shutdown if you press OFF twice in the file browser, or select "Shut
...
off" in the main menu. Players only have the menu option, due to lack of keys.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4940 a1c6a512-1295-4272-9138-f99709370657
2004-07-24 21:26:41 +00:00
Linus Nielsen Feltzing
26440c9fd6
Moved settings_parseline() to misc.c
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4824 a1c6a512-1295-4272-9138-f99709370657
2004-07-05 11:15:50 +00:00
Linus Nielsen Feltzing
a8dab4c08a
New screen dump feature for recorders
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4817 a1c6a512-1295-4272-9138-f99709370657
2004-06-30 13:31:14 +00:00
Linus Nielsen Feltzing
75b41a88f6
Moved read_line() to misc.c
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3647 a1c6a512-1295-4272-9138-f99709370657
2003-05-04 02:04:31 +00:00
Daniel Stenberg
9963c4570b
renamed string.c to misc.c and added a misc.h for the num2max5() function,
...
and included that header file in recording.c
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3403 a1c6a512-1295-4272-9138-f99709370657
2003-03-10 12:19:49 +00:00