Commit graph

558 commits

Author SHA1 Message Date
Bertrik Sikken
0023943439 Fix duplicate #includes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20977 a1c6a512-1295-4272-9138-f99709370657
2009-05-17 14:50:19 +00:00
Bertrik Sikken
09085a30f6 Remove unneeded #include "backdrop.h"
Remove unneeded #include "statusbar.h"


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20891 a1c6a512-1295-4272-9138-f99709370657
2009-05-09 18:09:14 +00:00
Bertrik Sikken
d4d121538d Remove unnecessary #include "backlight.h"
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20790 a1c6a512-1295-4272-9138-f99709370657
2009-04-25 21:32:55 +00:00
Bertrik Sikken
66cf3a3329 Clean up some #includes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20238 a1c6a512-1295-4272-9138-f99709370657
2009-03-08 16:10:40 +00:00
Jonathan Gordon
7f77dd8c26 fix FS#9796 - playlist resume from plugins didnt work
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20101 a1c6a512-1295-4272-9138-f99709370657
2009-02-25 05:41:31 +00:00
Jonathan Gordon
4544531585 redraw the lists once before going into the button loop to make things look more responsive
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19773 a1c6a512-1295-4272-9138-f99709370657
2009-01-15 06:24:58 +00:00
Jonathan Gordon
a68e5d835f remove some useless/unused stuff from gwps.c
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19705 a1c6a512-1295-4272-9138-f99709370657
2009-01-07 10:57:51 +00:00
Jonathan Gordon
36531c7471 bah, the filetree does the same spindown handling as the WPS so fix it there also
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19632 a1c6a512-1295-4272-9138-f99709370657
2009-01-01 13:12:37 +00:00
Jonathan Gordon
e385ee18ce Decouple the statusbar drawing from the rest of the screen drawing. it is not drawn roughly 4x per second automatically.
viewport_Set_defaults() will setup the given viewport with the correct "full screen" dimensions (so start at 0,0 if statusbars are disabled or 0,8 if they are enabled.)
All screens should keep the statusbar enabled, but if you really want to ignore the user setting you can disbaled it with viewportmanager_set_statusbar(false).

This commit also includes some menu/list viewport cleanups from kugel in FS#9603


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19622 a1c6a512-1295-4272-9138-f99709370657
2008-12-31 05:59:26 +00:00
Jonathan Gordon
ee1c231779 move the scrobbler and playlist shutdown/restart calls out of tree.c and move them into the regular usb/shutdown handlers.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19124 a1c6a512-1295-4272-9138-f99709370657
2008-11-17 07:34:00 +00:00
Frank Gevaerts
2f8a0081c6 Apply FS#9500. This adds a storage_*() abstraction to replace ata_*(). To do that, it also introduces sd_*, nand_*, and mmc_*.
This should be a good first step to allow multi-driver targets, like the Elio (ATA/SD), or the D2 (NAND/SD).


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18960 a1c6a512-1295-4272-9138-f99709370657
2008-11-01 16:14:28 +00:00
Nils Wallménius
48b52aec46 Fix FS#8949 - Alphabetical directory listing reversed after "Error Accessing Directory", patch by pondlife, some long line police by me, also kill a few error splashes in functions that could be called by threads other than UI
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18742 a1c6a512-1295-4272-9138-f99709370657
2008-10-08 16:32:01 +00:00
Steve Bavin
8a813fdd9d Fix FS#9352 - allow .talk clips for single-character filenames.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18383 a1c6a512-1295-4272-9138-f99709370657
2008-09-02 08:15:44 +00:00
Nils Wallménius
01729e7a18 FS#9281 Rename of splash functions.
* Remove gui_splash()
* Rename gui_syncsplash() to splashf() and remove its voice 
capabilities.
* Rename the internal splash() to splash_internal() and introduce an 
externally visible splash() that handles simple splashing  without 
printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ, 
"foo"); if a LANG_* id is passed it will be voiced.
* Adjust all places that called gui_syncsplash() to use the correct 
variant from above.
* Export both new functions to plugins and adjust places calling 
rb->splash() to use the correct variant so that we now have naming 
consistency between the core and plugins.
* Fix one latent bug that would cause my sim to crash with the above 
changes and correct P2STR and P2ID macros, thanks to pondlife.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18282 a1c6a512-1295-4272-9138-f99709370657
2008-08-15 08:27:39 +00:00
Bertrik Sikken
9569de0fe1 Remove unnecessary #include
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18088 a1c6a512-1295-4272-9138-f99709370657
2008-07-18 21:37:08 +00:00
Stéphane Doyon
3eb76d053d talk.c helper functions to voice a filename, in a more generic way
than from tree.c
Voice a file or dir's thumbnail from path components,
or spell last path component. Ability to prefix the thumbnail or
spelling with some talk ids.

This is the talk_file patch from FS#6323, just refactored a bit.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18048 a1c6a512-1295-4272-9138-f99709370657
2008-07-15 14:55:31 +00:00
Bertrik Sikken
54635b74a5 Removed unneeded #include "plugin.h"
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17852 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 18:36:51 +00:00
Daniel Stenberg
2acc0ac542 Updated our source code header to explicitly mention that we are GPL v2 or
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 18:10:04 +00:00
Peter D'Hoye
f76122f0e7 Accept FS #9052 by Alexander Levin with a fix by me. Changes HAS_BUTTONBAR into HAVE_BUTTONBAR to bring it in line with the other defines
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17655 a1c6a512-1295-4272-9138-f99709370657
2008-05-29 20:32:39 +00:00
Jonathan Gordon
10df05438e more textarea to viewport conversion... yes/no screen...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17454 a1c6a512-1295-4272-9138-f99709370657
2008-05-11 13:39:22 +00:00
Jonathan Gordon
517aca8532 use the playlist catalog code to generate the playlists under Playlist > Create playlist
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17352 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 13:01:16 +00:00
Jonathan Gordon
daa8341a13 a bit of code cleanup.. use a single function to get the statusbar height (or lack of if its enabled), and remove some gui_textarea stuff which could be done using the splash. (gui_textarea is on the way out)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17350 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 10:58:05 +00:00
Jonathan Gordon
ea664e0647 Viewported quickscreen (take 2 :D) (FS#8553)
- no customization support
- no top item
- much better use of the screen
- deprecates 20 odd lang strings (the QS can now use the regular lang strings and user font)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17315 a1c6a512-1295-4272-9138-f99709370657
2008-05-03 12:30:40 +00:00
Nils Wallménius
33c44461e1 Const police raid, making a lot of pointers to lang strings const and removing some ugly casting
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17251 a1c6a512-1295-4272-9138-f99709370657
2008-04-26 09:30:24 +00:00
Nils Wallménius
a01996436d Use file_exists and dir_exists functions where appropriate, fix one wrong file descriptor check and one possible dir descriptor leak
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17147 a1c6a512-1295-4272-9138-f99709370657
2008-04-16 19:51:43 +00:00
Nils Wallménius
6848961aa5 Pass the buffer length to the list_get_name callback functions instead of using hardcoded MAX_PATH
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17049 a1c6a512-1295-4272-9138-f99709370657
2008-04-09 15:25:17 +00:00
Linus Nielsen Feltzing
0ab1a3b801 Small fix to be able to use F3 to quit the F3 quick menu on the Archos Recorder
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16946 a1c6a512-1295-4272-9138-f99709370657
2008-04-03 13:38:24 +00:00
Dave Chapman
d746b79317 Remove unnecessary (and incorrect) #ifdefs surrounding #include "backdrop.h", and correct remaining references to HAVE_LCD_REMOTE to HAVE_REMOTE_LCD
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16873 a1c6a512-1295-4272-9138-f99709370657
2008-03-29 01:14:10 +00:00
Jonathan Gordon
5ca1539969 the menu and list now accepts a parent viewport to draw in (and the menu can be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
2008-03-26 03:35:24 +00:00
Jonathan Gordon
0e5cec2d18 FS#8457 - convert the list drawing code to use viewports. This does not include any of the customizability which was in the patch, so unless any bugs show up users should not notice any difference.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16527 a1c6a512-1295-4272-9138-f99709370657
2008-03-05 09:58:30 +00:00
Magnus Holmgren
04dc828c9f Better bookmark resume handling, in particular when resuming a directory. If Load Last Bookmark is set to Yes and the last bookmarked file could not be found, play the selected file instead. When selecting a bookmark for a missing file in the bookmark list, show a message that resume isn't possible (and don't play any selected file if Load Last Bookmark is set to Ask).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16267 a1c6a512-1295-4272-9138-f99709370657
2008-02-10 12:16:27 +00:00
Magnus Holmgren
2235081dbc Prevent possible buffer overflow when locating album art.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16231 a1c6a512-1295-4272-9138-f99709370657
2008-02-06 19:51:19 +00:00
Paul Louden
f7c938a7b7 (Hopefully) Revert the quickscreen changes. Many fixes need to be made,
and the exact implementation needs discussion. We apologize for the 
inconvenience and hope to bring an improved quickscreen to you soon.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16224 a1c6a512-1295-4272-9138-f99709370657
2008-02-05 09:09:38 +00:00
Jonathan Gordon
2c82494e66 updated the quickscreen's:
- use viewports
- dont change to system font, fiddle with item positions to make them fit small screens
- user customizable options (use the .cfg settings "quickscreen_left, quickscreen_right, quickscreen_top, quickscreen_bottom" for the name and the .cfg name for the setting you want to use. it can be any except the string settings... (e.g. quickscreen_left:talk menu)
- a top item! if there is none set the up button will exit the screen



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16220 a1c6a512-1295-4272-9138-f99709370657
2008-02-05 05:50:20 +00:00
Magnus Holmgren
9d6f6aa5fd When automatically loading the last bookmark and the file couldn't be found, nothing much seemed to happen. Show 'Nothing to resume' in this case, so the user has a clue that something went wrong. Should perhaps use a different message in this case.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16145 a1c6a512-1295-4272-9138-f99709370657
2008-01-22 22:38:32 +00:00
Nicolas Pennequin
536b5a0482 Accept FS#8469 by Bryan Childs with a few adjustments: Remove duplicate strip_extension() function from albumart.c. The other one is moved from tree.c to misc.c.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16103 a1c6a512-1295-4272-9138-f99709370657
2008-01-18 10:02:03 +00:00
Jonathan Gordon
189f9e2be9 charcell doesnt show titles in lists, so remove the "show path" setting and free up some bin space
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16069 a1c6a512-1295-4272-9138-f99709370657
2008-01-13 09:29:45 +00:00
Jonathan Gordon
f5ec3e49e0 remove the duplicated gui_list struct and only duplicate the members which are actually different on each screen. should translate to a smaller bin and easier code (users shouldnt notice any difference)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15947 a1c6a512-1295-4272-9138-f99709370657
2007-12-17 02:37:21 +00:00
Nils Wallménius
ade8ae9acb Whitespace/indent/codestyle tweaks, should make no functional difference
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15722 a1c6a512-1295-4272-9138-f99709370657
2007-11-20 13:53:29 +00:00
Michael Sevakis
fadbf0a6f7 Make threads responsible for explicit cancellation of their own boosted status. Sleeping and timeouts will no longer cancel it.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15709 a1c6a512-1295-4272-9138-f99709370657
2007-11-20 03:44:25 +00:00
Stéphane Doyon
a4f491cac1 Add a setting to control whether or not to speak the file type (r15506).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15508 a1c6a512-1295-4272-9138-f99709370657
2007-11-07 03:25:33 +00:00
Stéphane Doyon
8024aad1f1 Accept FS#7653: Say file type.
In the file browser, when spelling of directory or file names is enabled,
say the file type (or "folder").


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15506 a1c6a512-1295-4272-9138-f99709370657
2007-11-07 01:45:43 +00:00
Stéphane Doyon
8e82a90578 Accept FS#7775: Use list voice callback in file browser
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15232 a1c6a512-1295-4272-9138-f99709370657
2007-10-21 00:20:51 +00:00
Jonathan Gordon
1e199cd25e dirbrowse should return a GO_TO_* value, not false on error (fixes the problem where browsing plugins/fons/etc dirs from the menu would put you back n the filebrowser if the folder was empty instead of back in the menu)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15198 a1c6a512-1295-4272-9138-f99709370657
2007-10-19 06:11:13 +00:00
Magnus Holmgren
7d34565c62 Don't get the dircache size while dircache is still initializing. If done during shutdown, it will force a foreground scan on next boot.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15013 a1c6a512-1295-4272-9138-f99709370657
2007-10-07 12:05:48 +00:00
Jonathan Gordon
cf1cef5f57 minor update to gui_synclist_do_button() which will hopefully simplify things later.
Now returns true if the action was handled in that function instead of returning the handled action.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14733 a1c6a512-1295-4272-9138-f99709370657
2007-09-17 10:08:50 +00:00
Jonathan Gordon
da727b5ace Show the plugin category name in the list title in the plugin browsers.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14370 a1c6a512-1295-4272-9138-f99709370657
2007-08-16 13:55:37 +00:00
Peter D'Hoye
360d951271 Small optimisation
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14344 a1c6a512-1295-4272-9138-f99709370657
2007-08-14 21:02:44 +00:00
Peter D'Hoye
043c966ebf Add another file extension viewing option that mimics the old behaviour and make this default. Also update Dutch lang file and manual for this.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14324 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 23:11:30 +00:00
Peter D'Hoye
37fd439fc0 Accept FS #7346 and take it a whole step further. Gives a separate setting to control the displaying of file extensions: off, on, or only how unknown extensions.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14315 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 19:29:49 +00:00