Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
15583 commits 17 branches 142 tags 291 MiB
Commit graph

471 commits

Author SHA1 Message Date
Nicolas Pennequin
720cfe3954 Improve clearing of pictures in conditional constructs. This fixes improper clearing of pictures used in several conditionals or in nested conditionals (FS#7856). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15663 a1c6a512-1295-4272-9138-f99709370657
 2007-11-18 15:32:45 +00:00
Nicolas Pennequin
572ecef486 Smarter conditional handling by storing the previous value. Updates are done only if the value has changed. This avoids unnecessary line or picture clearing, and should help fix some problems WPS creators were having. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15657 a1c6a512-1295-4272-9138-f99709370657
 2007-11-18 13:24:39 +00:00
Nicolas Pennequin
83e190bcef Hopefully fix the compile errors. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15625 a1c6a512-1295-4272-9138-f99709370657
 2007-11-14 22:18:51 +00:00
Nicolas Pennequin
31f76116f1 Make the WPS parser stricter with invalid parameter lists. It will now reject them instead of ignoring them (this includes the second parameter to %m|x|, which is invalid and now causes a failure). Also change the debugging code in order to allow more precise error messages, including the faulty token's index and description. Finally, add a few missing token description and fine-tune the #ifdefs. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15624 a1c6a512-1295-4272-9138-f99709370657
 2007-11-14 22:02:41 +00:00
Nicolas Pennequin
f554e00b61 Allow setting a margin on a non-scrolling line by using %m|margin| instead of %s|margin|. This allows to easily place dynamic info next to album art. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15610 a1c6a512-1295-4272-9138-f99709370657
 2007-11-14 00:45:04 +00:00
Nicolas Pennequin
bb999f9eb3 Check that the WPS uses album art before clearing its position on conditional. Without that check, having a conditional as very first token would cause undesired clearing. Thanks to PaulJam for spotting. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15609 a1c6a512-1295-4272-9138-f99709370657
 2007-11-13 22:56:42 +00:00
Dave Chapman
f6ef46b73f FS#8135 - add an optional "left margin" parameter to the %s WPS tag - e.g. %s|100|. This patch uses parts of the scroll-margins patch (FS#2954), but is much smaller, only offers a left-margin, and only affects the WPS code. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15604 a1c6a512-1295-4272-9138-f99709370657
 2007-11-12 21:34:01 +00:00
Nicolas Pennequin
8537cbf091 Add detection for a previously ignored error case: a conditional token is present but no conditional start token (e.g. "%?C%al|>"). This would cause an inifnite loop in the displaying code. Thanks to markun for making the mistake and reporting it ;) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15598 a1c6a512-1295-4272-9138-f99709370657
 2007-11-12 18:43:38 +00:00
Nicolas Pennequin
81dedee7d0 Various album art improvements: 
* Make the album art display tag static instead of dynamic, making it be drawn less often, which is good.
* Add the possibility of clearing the album art bitmap instead of drawing it, and use this abaility when the display tag is inside a conditional construct.
* Add the album art display tag to wps_debug.c.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15592 a1c6a512-1295-4272-9138-f99709370657
 2007-11-12 01:31:42 +00:00
Nicolas Pennequin
9d4bed7ff0 Album art support. Based on FS#3045, but heavily modified to adapt to MoB and for cleanness. 
The cover pictures are loaded from external bitmaps. JPEG and embedded art are not supported. The pictures will only be drawn on the main display. There is no resizing but it is possible to specify the WPS bitmap size in the bitmap names (e.g. cover.100x100.bmp).
The bitmaps are stored in the main buffer and read directly from there. Currently, duplicate bitmaps will simply be present several times in the buffer, but this will be improved.
To enable for a target, #define HAVE_ALBUMART in its config file.
For more information, see the wiki page: http://www.rockbox.org/wiki/AlbumArt.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15572 a1c6a512-1295-4272-9138-f99709370657
 2007-11-11 12:29:37 +00:00
Stéphane Doyon
6f4c6ed990 Straighten out voicing of yesno dialogs. 
Make it so gui_syncyesno_run() does not modify the text_messages passed
as argument, simplify the code and even reduce size a bit.
The key is to support voicing at the level of the text_message itself.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15505 a1c6a512-1295-4272-9138-f99709370657
 2007-11-07 01:37:00 +00:00
Jonathan Gordon
04d0e3bc41 fix talking simplelists which I broke yesterday. dont talk if the list is being redrawn because get_action() timed out. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15459 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 12:52:32 +00:00
Jonathan Gordon
a6f2b82803 revert my previous commit and do it in a much less hacky way (both of these were for FS#8084) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15458 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 12:40:18 +00:00
Jonathan Gordon
4ada9ed2d9 last minor fix for the colour screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15456 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 10:57:06 +00:00
Jonathan Gordon
eb20149804 minor touchpad tweaking... 
lists - dont do ACTION_STD_OK if pressing an area under the last item
colour chooser - change the seelcted colour straight away without having to swicth sliders first


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15455 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 10:51:11 +00:00
Jonathan Gordon
fd9bad6597 touchpad interface for the colour selection screens. 
voice the unacceptable colour splash (nice and pointless :p )


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15454 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 10:42:22 +00:00
Jonathan Gordon
e247230e0d redraw the siplelist more often 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15446 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 01:04:10 +00:00
Karl Kurbjun
38548c7118 Build some more plugins for M:Robe most work, doom builds and runs if you use a hack - need to fix the user timer so that it works properly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15403 a1c6a512-1295-4272-9138-f99709370657
 2007-11-02 05:21:34 +00:00
Michael Sevakis
d6af287397 Implement as genuine a set_irq_level function for the sim as possible. The yield added earlier is still nescessary since other threads won't run anyway while viewing the database screen on either sim or target. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15321 a1c6a512-1295-4272-9138-f99709370657
 2007-10-26 23:11:18 +00:00
Steve Bavin
ab784649cd Don't lock up simulators when lists are used with TIMEOUT_NOBLOCK. Fixes FS#8030. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15318 a1c6a512-1295-4272-9138-f99709370657
 2007-10-26 18:04:42 +00:00
Steve Bavin
fda41b892e Try and save some bytes, seeing as we already assumed LANG_ constants for month and weekday names are contiguous. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15289 a1c6a512-1295-4272-9138-f99709370657
 2007-10-24 15:34:36 +00:00
Steve Bavin
072a3c5017 Complete info screen voicing; now consistent with displayed screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15284 a1c6a512-1295-4272-9138-f99709370657
 2007-10-24 12:32:12 +00:00
Jonathan Gordon
eed41ff985 mrobe changes: 
stop it thinking the battery is always flat and shutting down
add keymap for time/date screen
pressing a list item will highlight it before accepting it (looks better than it just entering the item without the selection changing first)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15280 a1c6a512-1295-4272-9138-f99709370657
 2007-10-23 14:33:16 +00:00
Stéphane Doyon
a82a860c7e Small voice-related tweaks and fixes to simplelists. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15276 a1c6a512-1295-4272-9138-f99709370657
 2007-10-23 05:19:03 +00:00
Jonathan Gordon
fa13cbee80 First go at getting the touchpad working in the ui. lists only for now. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15264 a1c6a512-1295-4272-9138-f99709370657
 2007-10-22 12:26:53 +00:00
Jonathan Gordon
0465101f92 allow simplelists to set the timeout and the start selection. 
set a slightly saner default timeout
talk the selected item when the list is first displayed


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15247 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 13:47:43 +00:00
Miika Pekkarinen
caff835d78 Fixed debug menu crashing. Show last file processed by tagcache engine in debug menu. Enabled autoupdating of deleted files for flash storage devices. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15244 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 11:06:30 +00:00
Jonathan Gordon
616971c71e remove the seelection_size param from the info init call to hopefully decrease the bin size a bit 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15237 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 06:42:52 +00:00
Jonathan Gordon
5eac0108f9 simplify the simpelist api slightly so not every struct member needs to be init manually. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15236 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 01:27:17 +00:00
Stéphane Doyon
7736947b74 Voice the "Cancelled" splash in option_screen(). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15235 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 00:53:28 +00:00
Stéphane Doyon
27615a4b6d From FS#7774: use list voice callback in option selection (option_screen(()). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15233 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 00:22:49 +00:00
Stéphane Doyon
8486c0413e Accept FS#7774: Voice callback for gui_synclist. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15231 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 00:20:10 +00:00
Jonathan Gordon
5f893be2a3 add a list API for simple lists which dont need lots of code to run. 
Example uses in debug_menu.c
This API works best if most of the text is static, or not many actions 
need to acted on. (of course, any list could use this)



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15221 a1c6a512-1295-4272-9138-f99709370657
 2007-10-20 12:32:55 +00:00
Steve Bavin
32a9575130 FS#7994 - Rename talk.c API, make talk_disable() affect all talking (not just menus), hopefully save some space. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15206 a1c6a512-1295-4272-9138-f99709370657
 2007-10-19 15:31:42 +00:00
Antoine Cellerier
d66b3c0f61 Remove the "invert scroll" code since it's not used anywhere anymore (and it was broken on color targets with gradients anyway). Closes FS #7875. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15125 a1c6a512-1295-4272-9138-f99709370657
 2007-10-15 20:42:51 +00:00
Jonathan Gordon
52040a05a2 fix the wrong value being selected initially 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15121 a1c6a512-1295-4272-9138-f99709370657
 2007-10-15 12:34:43 +00:00
Jonathan Gordon
0f7f3467bf Integer setting changes to make all those settings consistant on the target. 
wheel targets, clockwise is increase value
archos player, + is increase
button targets, up is increase


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15120 a1c6a512-1295-4272-9138-f99709370657
 2007-10-15 10:33:01 +00:00
Jonathan Gordon
887ff33f2e Fix int settings being backwards on the player 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15116 a1c6a512-1295-4272-9138-f99709370657
 2007-10-15 07:57:11 +00:00
Jonathan Gordon
58777c350a Fix FS#7952 - flip list settings didnt work properly 
Accept FS#7956 - flip some sound settings on wheel targets so clockwise increases


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15113 a1c6a512-1295-4272-9138-f99709370657
 2007-10-15 05:35:20 +00:00
Nicolas Pennequin
7eedcb49d9 Fix buggy gradient display when a coloured file is selected in the browser. Thanks to smably for the report. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14891 a1c6a512-1295-4272-9138-f99709370657
 2007-09-28 19:47:28 +00:00
Nicolas Pennequin
49a9e1ef35 Make the gradient look better when more than one line is selected (running time, ID3 info, cuesheet viewer...). I haven't found a solution for scrolling yet, so that won't look too good. 
The recording screen code needs a bit of adapting too, but I don't have a target to test on, so leave it for now.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14884 a1c6a512-1295-4272-9138-f99709370657
 2007-09-28 13:49:43 +00:00
Nicolas Pennequin
f3b015f73b FS#7808 by Tom Ross, Ken Fazzone and me, with help from Antoine Cellerier. 
Add two new line selector types: solid colour and gradient. Solid colour only uses the primary colour setting.
The secondary colour setting is used for the gradient. Text colour for the selected item is also changeable.
These new settings are a bit controversial so they may be removed later.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14868 a1c6a512-1295-4272-9138-f99709370657
 2007-09-27 15:42:55 +00:00
Nils Wallménius
7b71787bd8 Get rid of macros and do these calculations only once instead 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14770 a1c6a512-1295-4272-9138-f99709370657
 2007-09-20 10:06:33 +00:00
Steve Bavin
39ff1878bc Fix FS#7766 - crash at track transition if A-B repeat is enabled but no B marker is set 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14769 a1c6a512-1295-4272-9138-f99709370657
 2007-09-20 09:15:35 +00:00
Jonathan Gordon
cf1cef5f57 minor update to gui_synclist_do_button() which will hopefully simplify things later. 
Now returns true if the action was handled in that function instead of returning the handled action.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14733 a1c6a512-1295-4272-9138-f99709370657
 2007-09-17 10:08:50 +00:00
Nils Wallménius
12a957b0e8 Disable wrapping of the bass and treble settings and do the same for volume in a cleaner way, closes FS#7783 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14712 a1c6a512-1295-4272-9138-f99709370657
 2007-09-15 17:29:15 +00:00
Nils Wallménius
22df2fd0bf Slight code simplification 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14683 a1c6a512-1295-4272-9138-f99709370657
 2007-09-13 20:53:23 +00:00
Jonathan Gordon
24006ffeac stop non-live settings from beign accepted even if cancel was chosen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14616 a1c6a512-1295-4272-9138-f99709370657
 2007-09-05 03:06:49 +00:00
Jonathan Gordon
51edc1102c Change the way set_option() works so these settings are voiced again (recording settings mostly..) Fixes FS#7552 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14487 a1c6a512-1295-4272-9138-f99709370657
 2007-08-28 11:00:54 +00:00
Magnus Holmgren
a50c2b1494 Apply fix from FS#6341, with some changes by me. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14430 a1c6a512-1295-4272-9138-f99709370657
 2007-08-22 16:33:34 +00:00