Commit graph

172 commits

Author SHA1 Message Date
Magnus Holmgren
fdac6417c9 Improve handling of RVA2 (replaygain) frames.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16262 a1c6a512-1295-4272-9138-f99709370657
2008-02-10 10:09:42 +00:00
Magnus Holmgren
d4cb075af7 Fix reading of ID3V2 tags with frame data length fields, hopefully without breaking anything else.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16006 a1c6a512-1295-4272-9138-f99709370657
2008-01-06 19:49:25 +00:00
Nicolas Pennequin
b583ff6e4b Turn the DEBUGF messages into logf in the ID3 parser, so that by default they don't get shown.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15364 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 18:02:41 +00:00
Nicolas Pennequin
9f6719ec56 Oops. The function should be static.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15347 a1c6a512-1295-4272-9138-f99709370657
2007-10-28 15:54:08 +00:00
Nicolas Pennequin
895eb984ac Some genre strings must not be adjusted by adjust_mp3_entry. Thanks to PaulJam for the report.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15346 a1c6a512-1295-4272-9138-f99709370657
2007-10-28 14:46:45 +00:00
Thom Johansen
294ec1d110 Remove the ID3 tag version priority setting on the grounds of it being pretty pointless. ID3v2 tags are superior to ID3v1 tags, and needs less seeking around to find.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14750 a1c6a512-1295-4272-9138-f99709370657
2007-09-19 10:40:55 +00:00
Jens Arnold
af533820ee More efficient version of the fix.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14619 a1c6a512-1295-4272-9138-f99709370657
2007-09-05 06:48:33 +00:00
Jens Arnold
fcab061250 Hopefully stop the crashes on database init on ARM (and SH1) targets when comment tags using UTF-16 are present.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14618 a1c6a512-1295-4272-9138-f99709370657
2007-09-05 06:27:59 +00:00
Robert Kukla
3fbd2414af fix sub-string comparison
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14602 a1c6a512-1295-4272-9138-f99709370657
2007-09-04 08:23:12 +00:00
Magnus Holmgren
72fafe48b9 Fix FS#7698, UTF-16 comments not read correctly. Also ignore more iTunes comments.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14594 a1c6a512-1295-4272-9138-f99709370657
2007-09-03 16:15:08 +00:00
Magnus Holmgren
cdfb22f9df Remove some debug code. Remove some unnecessary checks.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14454 a1c6a512-1295-4272-9138-f99709370657
2007-08-25 10:56:22 +00:00
Magnus Holmgren
4e68732769 Small ReplayGain cleanup. Move RVA2 specific code to id3.c and don't do the parsing via strings. Generalize parts of the code for later use by MPC. Make some local functions static. Add and update some comments for clarity.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14453 a1c6a512-1295-4272-9138-f99709370657
2007-08-25 10:25:13 +00:00
Nicolas Pennequin
db15e5d3ba Add an error check in get_mp3_metadata()
Check whether getonglength() succeeded or not, to prevent get_mp3_metadata()
from returning a success value when in fact it failed.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14327 a1c6a512-1295-4272-9138-f99709370657
2007-08-14 11:56:14 +00:00
Robert Kukla
0bd027aa1a ignore comments containing iTunes 7 gapless data; should solve issues reported in http://forums.rockbox.org/index.php?topic=12048.0 and http://forums.rockbox.org/index.php?topic=12053.0
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14294 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 14:13:33 +00:00
Dan Everton
eecfe9f1cb Add support for grouping tags. From FS#7362.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14242 a1c6a512-1295-4272-9138-f99709370657
2007-08-08 10:19:56 +00:00
Dan Everton
f4a61f0c4a Add support for parsing the disc number tag from metadata and use of it in the database. Patch originally from FS#4961 with some minor tweaks by me.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14154 a1c6a512-1295-4272-9138-f99709370657
2007-08-03 10:00:42 +00:00
Adam Gashlin
de4904a189 added missing extra null terminator to indicate end of WMA extension
list


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13854 a1c6a512-1295-4272-9138-f99709370657
2007-07-11 14:17:42 +00:00
Dave Chapman
c72824786a Initial, work-in-progress, version of a WMA codec using Michael Giacomelli's fixed-point and malloc-less WMA decoder (based on the ffmpeg WMA decoder from early 2006, and also building on the work started by Paul Jones). The codec itself and the ASF parsing code were written by me, inspired by the ASF parser in libasf. Current performance is around 400% realtime on gigabeat, 100% realtime on PP and 20% realtime on Coldfire.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13769 a1c6a512-1295-4272-9138-f99709370657
2007-07-03 09:25:36 +00:00
Dave Chapman
520274219a Initial commit of Monkey's Audio (.ape/.mac) support. Note that Monkey's is an extremely CPU-intensive codec, and that the decoding speed is directly related to the compression level (-c1000, -c2000, -c3000, -c4000 or -c5000) used when encoding the file. Current performance is: -c1000 to -c3000 are realtime on a Gigabeat, -c1000 is realtime on Coldfire targets (H100, H300 and Cowon), and nothing is realtime on PortalPlayer targets (iPods, H10, Sansa). Hopefully this can be improved. More information at FS #7256.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13562 a1c6a512-1295-4272-9138-f99709370657
2007-06-05 16:58:29 +00:00
Linus Nielsen Feltzing
a452f73e44 Correct parsing of the ID3V2 extended header
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12970 a1c6a512-1295-4272-9138-f99709370657
2007-03-30 12:55:46 +00:00
Linus Nielsen Feltzing
f46857f085 Patch by Denis Stanishevskiy, prevent endless loop in the ID3 parser
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12968 a1c6a512-1295-4272-9138-f99709370657
2007-03-30 07:11:55 +00:00
Jens Arnold
f68362ad6f Fix simulator builds, and some debugf() format strings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12817 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 09:54:28 +00:00
Robert Kukla
79a2a936a2 remove numerical genre and use genre_string consistently:
- fix spurious display of "blues" genre for missing genre tag 
- simplify code/use less code
- numerical->string conversion only once instead of at every use

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12552 a1c6a512-1295-4272-9138-f99709370657
2007-03-02 21:49:42 +00:00
Linus Nielsen Feltzing
ab0752c9c0 Correct spelling of CONFIG_CODEC, fixes FS#6668
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12356 a1c6a512-1295-4272-9138-f99709370657
2007-02-17 20:49:54 +00:00
Miika Pekkarinen
6dbe772eb7 FS#6651 - Improved id3 comment extraction.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12344 a1c6a512-1295-4272-9138-f99709370657
2007-02-17 08:46:32 +00:00
Linus Nielsen Feltzing
aa8761fccc Shave a few bytes off the binary size, especially on hwcodec targets
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12323 a1c6a512-1295-4272-9138-f99709370657
2007-02-15 22:55:22 +00:00
Adam Gashlin
b73960d3b9 Adding SPC codec (FS #6542)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12298 a1c6a512-1295-4272-9138-f99709370657
2007-02-14 03:34:55 +00:00
Miika Pekkarinen
4e9766477b FS#6638 - Album artist and comment patch for WPS and tagcache. Export
your database before updating because initialization is needed.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12255 a1c6a512-1295-4272-9138-f99709370657
2007-02-10 12:09:28 +00:00
Dan Everton
5158751263 Minor whitespace and formatting fixes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12253 a1c6a512-1295-4272-9138-f99709370657
2007-02-10 09:55:06 +00:00
Dan Everton
ebc58c9f06 Add Speex playback support. Patch from FS #5607 thanks to Frederik Vestre.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12241 a1c6a512-1295-4272-9138-f99709370657
2007-02-09 10:06:53 +00:00
Adam Gashlin
5d20c9d121 adding NSF (NES music) codec
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12112 a1c6a512-1295-4272-9138-f99709370657
2007-01-25 18:06:17 +00:00
Dominik Riebeling
8cce37f161 "Trash Metal" should be "Thrash Metal". Reported as FS#6503, checked against Winamp.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11942 a1c6a512-1295-4272-9138-f99709370657
2007-01-07 23:10:21 +00:00
Magnus Holmgren
d00f1d599a Add "m4b" to the list of supported filename extensions.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11689 a1c6a512-1295-4272-9138-f99709370657
2006-12-08 13:55:14 +00:00
Michael Sevakis
0729b928ce Recording: Add AIFF recording to SWCODEC. Note: AIFF playback chokes on sample rates other than 44.1kHz whether recorded or created and saved with an external program. Recorded files will still open in an external editor however.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11583 a1c6a512-1295-4272-9138-f99709370657
2006-11-24 19:49:04 +00:00
Miika Pekkarinen
0dd7ea2d71 Support building tagcache db natively on PC using the core of the
Rockbox tagcache database engine. Only host endian support at the
moment and no command line parameters. Mainly for developers for
debugging at the moment.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11497 a1c6a512-1295-4272-9138-f99709370657
2006-11-10 08:03:33 +00:00
Jens Arnold
128c3ee686 AIFF is not (yet) a supported format on HWCODEC targets.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11455 a1c6a512-1295-4272-9138-f99709370657
2006-11-06 19:49:05 +00:00
Michael Sevakis
0f5cb94aa4 Big Patch adds primarily: Samplerate and format selection to recording for SWCODEC. Supprort for samplerates changing in playback (just goes with the recording part inseparably). Samplerates to all encoders. Encoders can be configured individually on a menu specific to the encoder in the recording menu. File creation is delayed until flush time to reduce spinups when splitting. Misc: statusbar icons for numbers are individual digits to display any number. Audio buffer was rearranged to maximize memory available to recording and properly reinitialized when trashed. ColdFire PCM stuff moved to target tree to avoid a complicated mess when adding samplerate switching. Some needed API changes and to neaten up growing gap between hardware and software codecs.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11452 a1c6a512-1295-4272-9138-f99709370657
2006-11-06 18:07:30 +00:00
Miika Pekkarinen
58ebf47a2b FS#6216 Update so MP3 files are only opened once. With corrections and
patch cleanup.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11343 a1c6a512-1295-4272-9138-f99709370657
2006-10-25 16:57:53 +00:00
Rani Hod
a875ed5d57 Accepted FS#6023 - ADX codec (some kind of ADPCM).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11046 a1c6a512-1295-4272-9138-f99709370657
2006-09-25 16:13:05 +00:00
Miika Pekkarinen
7f1346d641 Fixed a division by zero in mp3 metadata parser.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11003 a1c6a512-1295-4272-9138-f99709370657
2006-09-19 18:27:43 +00:00
Michael Sevakis
4fc717a4c1 Added FS#2939 Encoder Codec Interface + Codecs by Antonius Hellmann with additional FM Recording support and my modifications
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10789 a1c6a512-1295-4272-9138-f99709370657
2006-08-28 22:38:41 +00:00
Mark Arigo
b50e8935e1 Re-enable parsing replaygain from ID3v2.4 TXXX fields since that's the default for foobar2000 0.9, however, give the RVA2 field priority
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10277 a1c6a512-1295-4272-9138-f99709370657
2006-07-21 20:15:01 +00:00
Dan Everton
7b5af8c045 Add support for parsing binary data ID3 tags. Add support for parsing RVA2 ID3 tags for replaygain values instead of TXXX tags when playing files tagged with ID3v2.4. Patch by psyche78 (task #2937)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10259 a1c6a512-1295-4272-9138-f99709370657
2006-07-20 10:35:20 +00:00
Dave Chapman
752faa4351 Patch #5157 by Rainer Sinsch - SID codec
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10237 a1c6a512-1295-4272-9138-f99709370657
2006-07-18 18:33:12 +00:00
Brandon Low
7f5fb7bbd9 Fix red builds
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9710 a1c6a512-1295-4272-9138-f99709370657
2006-04-17 20:55:53 +00:00
Brandon Low
5286c7ddb8 Add copy and adjust helper for mp3entry struct as it is 1) not copy safe and 2) nonobvious that its not copy safe
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9709 a1c6a512-1295-4272-9138-f99709370657
2006-04-17 20:32:25 +00:00
Dan Everton
358055ece9 Add TDRC tag from id3 v2.4 to fix year not showing in files tagged with id3 v2.4
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9258 a1c6a512-1295-4272-9138-f99709370657
2006-03-26 14:23:32 +00:00
Dave Chapman
fbd8e5d29c Patch #1421483 - AIFF codec by Jvo Studer
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8524 a1c6a512-1295-4272-9138-f99709370657
2006-02-01 16:42:02 +00:00
Magnus Holmgren
e8b1787296 Discard some LAME header fields if the file length has changed since the header was written. Fixes some NPR podcasts.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8307 a1c6a512-1295-4272-9138-f99709370657
2006-01-08 08:58:58 +00:00
Magnus Holmgren
ec32c08a35 Restore full support for id3v2 frames with multiple strings (like TXXX). Makes MP3 ReplayGain work again.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8196 a1c6a512-1295-4272-9138-f99709370657
2005-12-07 22:59:09 +00:00