Steve Bavin
5f70ad4cb0
Minor simplification; replace unneeded variable cur_ti with a macro
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11200 a1c6a512-1295-4272-9138-f99709370657
2006-10-12 15:54:36 +00:00
Steve Bavin
d49c810ec9
Add CPU boost tracker to see where boosts are coming from
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11125 a1c6a512-1295-4272-9138-f99709370657
2006-10-05 10:07:03 +00:00
Steve Bavin
8b08935a3b
Flush queued voice clips when not playing audio
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11087 a1c6a512-1295-4272-9138-f99709370657
2006-09-28 16:45:23 +00:00
Steve Bavin
c9a78621af
Another fix for crashing when changing crossfade settings
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11086 a1c6a512-1295-4272-9138-f99709370657
2006-09-28 15:17:59 +00:00
Steve Bavin
b2269cce94
Fix hangs when changing crossfade settings
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11084 a1c6a512-1295-4272-9138-f99709370657
2006-09-28 09:20:56 +00:00
Steve Bavin
081281f6a1
Fix a crash and CPU being left boosted when using voice - FS#6024
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11053 a1c6a512-1295-4272-9138-f99709370657
2006-09-26 07:19:43 +00:00
Michael Sevakis
9d56f2d2cf
SWCODEC recording hang fixed. Fixed other trouble spots for codec swapping when playing. Removed call to audio_set_recording_options from fm_recording_settings on SWCODEC (Not proper to do ! My bad.).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10978 a1c6a512-1295-4272-9138-f99709370657
2006-09-17 18:52:31 +00:00
Miika Pekkarinen
815684aced
FS#5992 Reworked playback.c to fix voice bugs by Steve Bavin. Fixed to
...
work with the new scheduler and handled properly and fast the track
skipping.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10966 a1c6a512-1295-4272-9138-f99709370657
2006-09-17 08:34:42 +00:00
Miika Pekkarinen
a85044bf9e
New scheduler, with priorities for swcodec platforms. Frequent task
...
switching should be more efficient and tasks are stored in linked
lists to eliminate unnecessary task switching to improve performance.
Audio should no longer skip on swcodec targets caused by too CPU
hungry UI thread or background threads.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10958 a1c6a512-1295-4272-9138-f99709370657
2006-09-16 16:18:11 +00:00
Steve Bavin
3cc46e7620
Rearrangement of playback.c to group routines by thread
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10838 a1c6a512-1295-4272-9138-f99709370657
2006-09-01 07:59:31 +00:00
Steve Bavin
a3087e4fb0
Add logging for all playback queueing, for the simulator at least
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10823 a1c6a512-1295-4272-9138-f99709370657
2006-08-31 10:01:07 +00:00
Magnus Holmgren
92f07a65ad
Fix warning.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10808 a1c6a512-1295-4272-9138-f99709370657
2006-08-30 16:27:00 +00:00
Magnus Holmgren
719d220925
Applied patch #5879 by Andrew Cupper: Fix backward seeking bug.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10807 a1c6a512-1295-4272-9138-f99709370657
2006-08-30 15:47:18 +00:00
Michael Sevakis
4fc717a4c1
Added FS#2939 Encoder Codec Interface + Codecs by Antonius Hellmann with additional FM Recording support and my modifications
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10789 a1c6a512-1295-4272-9138-f99709370657
2006-08-28 22:38:41 +00:00
Miika Pekkarinen
987bbdfab7
Force WPS reload after all tracks have been buffered (runtime stats
...
are updated).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10768 a1c6a512-1295-4272-9138-f99709370657
2006-08-27 14:23:50 +00:00
Linus Nielsen Feltzing
dd98c219e0
Quick and dirty fix for a serious issue that could make X5 crash when using voice
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10721 a1c6a512-1295-4272-9138-f99709370657
2006-08-23 14:02:35 +00:00
Magnus Holmgren
9f09a39436
Add resume support to AAC files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10720 a1c6a512-1295-4272-9138-f99709370657
2006-08-23 13:10:48 +00:00
Linus Nielsen Feltzing
97b56a665c
Patch #5844 by Steve Bavin - Fix confused voice file memory allocation
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10711 a1c6a512-1295-4272-9138-f99709370657
2006-08-23 08:21:15 +00:00
Linus Nielsen Feltzing
42f0ad3c8f
Patch #5766 by Steve Bavin - Fix for various voice related crashes
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10590 a1c6a512-1295-4272-9138-f99709370657
2006-08-15 18:01:42 +00:00
Dave Chapman
0a7ded3e29
Memory size checks in .c/.h files should use MEM, not MEMORYSIZE
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10557 a1c6a512-1295-4272-9138-f99709370657
2006-08-13 09:19:24 +00:00
Tomasz Malesinski
28910e7e17
Various lower limits and sizes for targets with 1MB of RAM (Iriver iFP7xx).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10556 a1c6a512-1295-4272-9138-f99709370657
2006-08-12 23:01:52 +00:00
Miika Pekkarinen
b591bb3f46
FS#5691 Fix for crash if stop pressed during voice output.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10457 a1c6a512-1295-4272-9138-f99709370657
2006-08-05 07:29:53 +00:00
Miika Pekkarinen
8e0b02a60f
Prevent buffer filling trying to start over and over causing playback
...
to skip when runtimedb has been enabled.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10456 a1c6a512-1295-4272-9138-f99709370657
2006-08-04 10:29:04 +00:00
Miika Pekkarinen
bb5330cb88
Don't yield_codecs() within codec thread.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10428 a1c6a512-1295-4272-9138-f99709370657
2006-08-03 07:45:53 +00:00
Miika Pekkarinen
ab279dd6bf
Stop playback before updating runtime stats. And yield codecs while
...
storing the stats to db to prevent skipping.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10427 a1c6a512-1295-4272-9138-f99709370657
2006-08-03 07:29:19 +00:00
Miika Pekkarinen
513cafec7e
Checked the rebuffering code. Might fix buffers desyncing and a system
...
crash.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10373 a1c6a512-1295-4272-9138-f99709370657
2006-07-31 06:12:53 +00:00
Miika Pekkarinen
4ccacd4004
Completely remove all track entries at audio_rebuffer().
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10364 a1c6a512-1295-4272-9138-f99709370657
2006-07-29 19:34:12 +00:00
Miika Pekkarinen
3b2f049ec6
Another oops.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10363 a1c6a512-1295-4272-9138-f99709370657
2006-07-29 17:50:44 +00:00
Miika Pekkarinen
2fa682535b
Oops, committed some extra stuff not necessary.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10362 a1c6a512-1295-4272-9138-f99709370657
2006-07-29 17:39:55 +00:00
Miika Pekkarinen
d43bff987a
Define MAX_TRACK_MAX and use it to keep the ring track structure
...
inside boundaries. Cleaned identation also.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10361 a1c6a512-1295-4272-9138-f99709370657
2006-07-29 17:25:31 +00:00
Miika Pekkarinen
6128ff3453
Fixed one of the many pending bugs in the playback engine and restored
...
the instant wps skip feature.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10348 a1c6a512-1295-4272-9138-f99709370657
2006-07-28 09:32:52 +00:00
Magnus Holmgren
0d8c50d7af
Add resume support for AC3 files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10332 a1c6a512-1295-4272-9138-f99709370657
2006-07-26 19:08:16 +00:00
Mark Arigo
50f7e4e083
Additional fix for seeking beyond the current buffered data
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10243 a1c6a512-1295-4272-9138-f99709370657
2006-07-18 21:10:13 +00:00
Dave Chapman
752faa4351
Patch #5157 by Rainer Sinsch - SID codec
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10237 a1c6a512-1295-4272-9138-f99709370657
2006-07-18 18:33:12 +00:00
Miika Pekkarinen
45dfe2a36f
Initial runtimedb support for tagcache. Only for developers,
...
statistical data will be lost in future until changelogs has been
implemented.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10217 a1c6a512-1295-4272-9138-f99709370657
2006-07-15 17:36:25 +00:00
Dave Chapman
b1a272eee2
Patch by Mark Arigo to close bug report #5305 - fixes crashes when attempting to seek beyond the currently buffered data.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10181 a1c6a512-1295-4272-9138-f99709370657
2006-07-03 21:23:14 +00:00
Hardeep Sidhu
75117cc993
Wait for voice to complete before stopping playback. Fixes hang when stopping from filetree while voice is playing.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10141 a1c6a512-1295-4272-9138-f99709370657
2006-06-21 04:16:18 +00:00
Hardeep Sidhu
a02fd1ad7d
Only swap_codec() in voice thread when something is playing. Fixes B#5486.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10132 a1c6a512-1295-4272-9138-f99709370657
2006-06-17 11:21:22 +00:00
Jens Arnold
630e9586b6
Fix resume for MP1. Thanks go to Dave Chapman for the hint.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10096 a1c6a512-1295-4272-9138-f99709370657
2006-06-10 11:22:21 +00:00
Hardeep Sidhu
1e0b1d58d6
Stop playback if playlist_next() returns -1 (e.g. if auto directory change fails)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10091 a1c6a512-1295-4272-9138-f99709370657
2006-06-07 20:43:34 +00:00
Magnus Holmgren
f95dd56a2c
Fix bug 5341: Resume in Wav and Flac doesn't start from the position where it was left off. Mark Arigo helped with the Flac fix.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10051 a1c6a512-1295-4272-9138-f99709370657
2006-06-04 15:04:03 +00:00
Hardeep Sidhu
5483da667b
Previous automatic skip fix had a problem if audio_fill_file_buffer() was called after setting playlist_end but before audio_check_new_track(). To fix this, playlist_end is now reset in audio_check_new_track().
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10039 a1c6a512-1295-4272-9138-f99709370657
2006-06-03 17:23:20 +00:00
Dave Chapman
db1cda87a6
Replace "#if (ROCKBOX_HAS_LOGF == 1)" with "#ifdef ROCKBOX_HAS_LOGF" - this is consistent with the rest of Rockbox and Mark Arigo reported that it caused an error in his gcc when trying to compile a logf-enabled sim
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9991 a1c6a512-1295-4272-9138-f99709370657
2006-05-25 21:08:38 +00:00
Hardeep Sidhu
a8928804e1
Reset playlist_end when automatically skipping. Fixes B#5319.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9929 a1c6a512-1295-4272-9138-f99709370657
2006-05-15 02:37:06 +00:00
Hardeep Sidhu
c9a11cd3c8
Reset id3 info in all cases where we need to rebuffer tracks
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9928 a1c6a512-1295-4272-9138-f99709370657
2006-05-15 01:45:35 +00:00
Hardeep Sidhu
c8e280c1ed
Reset id3 info when skipping directories. Fixes B#5323.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9892 a1c6a512-1295-4272-9138-f99709370657
2006-05-09 00:14:51 +00:00
Hardeep Sidhu
6a267a8be7
Don't initiate track change if at end of playlist
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9868 a1c6a512-1295-4272-9138-f99709370657
2006-05-03 16:33:23 +00:00
Hardeep Sidhu
7033baea5e
Only reset resume settings when we're really at the end of the playlist
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9867 a1c6a512-1295-4272-9138-f99709370657
2006-05-03 15:54:08 +00:00
Hardeep Sidhu
982d995ae9
Stop playing current track before starting a new playlist with an offset (eg. bookmarks).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9861 a1c6a512-1295-4272-9138-f99709370657
2006-05-02 16:18:21 +00:00
Hardeep Sidhu
b8d1a55fbd
Properly set audio_is_initialized flag for swcodec devices ad use it when initializing crossfade. This should fix the problems with resuming playback at startup.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9853 a1c6a512-1295-4272-9138-f99709370657
2006-05-01 18:18:54 +00:00
Magnus Holmgren
e187e01e36
Fix one seeking bug: when seeking back to before a resume point, audio from another track could be played.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9837 a1c6a512-1295-4272-9138-f99709370657
2006-04-30 08:39:24 +00:00
Brandon Low
4564f5c56a
Don't magically skip tracks without user interraction
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9813 a1c6a512-1295-4272-9138-f99709370657
2006-04-26 12:19:16 +00:00
Brandon Low
69cf4f57ac
This seems to fix a few bugs in that
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9811 a1c6a512-1295-4272-9138-f99709370657
2006-04-26 04:31:06 +00:00
Brandon Low
da1cddfcbb
This seems to make selecting a new track from the file browser work very close to right.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9810 a1c6a512-1295-4272-9138-f99709370657
2006-04-26 04:01:35 +00:00
Brandon Low
522ec278ef
Switch inserts back from do while to while loops, because mpc likes to insert zero byte chunks at the end of files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9802 a1c6a512-1295-4272-9138-f99709370657
2006-04-25 18:21:05 +00:00
Brandon Low
3ac7bd7204
Fix the most likely cause of ipod nano startup race, and also seems to fix crossfade buffer reinitialization during playback for me
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9790 a1c6a512-1295-4272-9138-f99709370657
2006-04-24 12:57:41 +00:00
Brandon Low
e0f7ecbfd8
Make track info update in a smarter way
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9782 a1c6a512-1295-4272-9138-f99709370657
2006-04-24 00:48:00 +00:00
Brandon Low
d461a3ef65
Fix some todos, and prevent the position from jumping around badly on seek
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9781 a1c6a512-1295-4272-9138-f99709370657
2006-04-23 23:27:11 +00:00
Brandon Low
6a6c322a19
Improve stop behavior
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9779 a1c6a512-1295-4272-9138-f99709370657
2006-04-23 22:54:01 +00:00
Brandon Low
5cdee94b40
Fix a warning, and prepare for handling end-of-track seeking
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9778 a1c6a512-1295-4272-9138-f99709370657
2006-04-23 22:30:52 +00:00
Brandon Low
2e8b933c0d
Should fix some track ending early problems
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9777 a1c6a512-1295-4272-9138-f99709370657
2006-04-23 22:21:12 +00:00
Brandon Low
8ecb8582a1
Make some adjustments to when the WPS will be updated, giving faster next track and cleaner track change updates
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9776 a1c6a512-1295-4272-9138-f99709370657
2006-04-23 20:37:43 +00:00
Brandon Low
83ce56846a
Remove an unneeded define, add a todo
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9765 a1c6a512-1295-4272-9138-f99709370657
2006-04-22 21:31:07 +00:00
Brandon Low
c71ad7ea7f
Fix warning
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9760 a1c6a512-1295-4272-9138-f99709370657
2006-04-22 14:53:00 +00:00
Brandon Low
f3bc1efc49
First commit of reworking voice to be mroe stable on swcodec
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9758 a1c6a512-1295-4272-9138-f99709370657
2006-04-22 14:40:13 +00:00
Hardeep Sidhu
f635f4a824
Set playing to true immediately when audio_play() is called. Fixes a bug when selecting tracks from playlist viewer.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9737 a1c6a512-1295-4272-9138-f99709370657
2006-04-20 05:33:53 +00:00
Brandon Low
4b36096b93
Have the codec thread stop the pcm if we need to spin up the disk
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9727 a1c6a512-1295-4272-9138-f99709370657
2006-04-19 00:23:08 +00:00
Brandon Low
56d6f3ecfc
Fix playback if the user does a very fast seek->skip press
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9726 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 23:43:54 +00:00
Brandon Low
2c9b1717e6
Fix end of playlist handling. I think.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9725 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 19:52:10 +00:00
Brandon Low
1344ccd3c1
Revert previous, it is broken
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9724 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 19:51:37 +00:00
Brandon Low
426dc212c6
Make seeking synchronous. It's better this way
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9722 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 19:08:15 +00:00
Brandon Low
2b18727a8a
Fix dir skipping with new playback arch. Enable dir skipping on ipod with a couple of difficult combos (select|right/left) or short-long left / short-long right. The latter causes stuck in pause sometimes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9720 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 18:33:09 +00:00
Brandon Low
ed44e19c3f
Should fix a bug with track skipping backwards following track skip forward, play, seek backward
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9718 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 16:53:24 +00:00
Brandon Low
7df187f20e
Save empty resume information if the playlist has ended
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9717 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 16:45:44 +00:00
Brandon Low
095ae809eb
Reduce code size when logf is off. Add a todo. Undo a previous fix that broke crossfade on manual track changes
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9708 a1c6a512-1295-4272-9138-f99709370657
2006-04-17 19:59:16 +00:00
Brandon Low
98097d23ec
Misc. minor fixes: Guarantee aligned buffer. Enable load-codec-from-disk if a new track requires a different codec than the playing track, but does not already have it on the buffer. Stop playback immediately on a manual track skip. Handle seeking a distance greater than the size of the audio buffer. Enforce the 'no malloc for voice codec'.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9704 a1c6a512-1295-4272-9138-f99709370657
2006-04-17 17:05:05 +00:00
Brandon Low
bf397b5635
Remove an unneeded WPS update signal. Make the codec thread more polite about requesting buffering. Prevent more Codec failure pops when the codec was _asked_ to stop.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9674 a1c6a512-1295-4272-9138-f99709370657
2006-04-15 09:19:49 +00:00
Brandon Low
ebadcc633a
Put new_track on the codec_api, and use it instead of the reload_codec variable in most places. Should help with problems people have had with GUI vs. playback sync.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9670 a1c6a512-1295-4272-9138-f99709370657
2006-04-15 02:03:11 +00:00
Brandon Low
363dbc4b58
This might fix the buffering problem. Didn't happen to me the way I usually reproduce it just now
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9668 a1c6a512-1295-4272-9138-f99709370657
2006-04-14 22:15:38 +00:00
Brandon Low
530cad32e8
Still not bright
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9666 a1c6a512-1295-4272-9138-f99709370657
2006-04-14 17:48:01 +00:00
Brandon Low
de25006ad9
I am dumb
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9665 a1c6a512-1295-4272-9138-f99709370657
2006-04-14 17:39:18 +00:00
Brandon Low
7c986a91a6
Work around the bug with buffer wrapping. Serious performance penalty, and a lot of buffering is discarded to achieve this, but it doesn't crash while I find the real cause
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9664 a1c6a512-1295-4272-9138-f99709370657
2006-04-14 17:31:19 +00:00
Brandon Low
348d9ece4b
Fix some unlikely buffer problems. Doesn't fix any reported bugs, but fixes some possible ones.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9663 a1c6a512-1295-4272-9138-f99709370657
2006-04-14 17:00:22 +00:00
Brandon Low
86c7e1a947
Fix some stop/pause/boost stuff
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9662 a1c6a512-1295-4272-9138-f99709370657
2006-04-14 16:42:14 +00:00
Brandon Low
fb966b3cf8
Fix a lack of return on error for check_new_track (rare condition)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9661 a1c6a512-1295-4272-9138-f99709370657
2006-04-14 14:19:56 +00:00
Brandon Low
0291a6e200
Fix the queue implementation
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9660 a1c6a512-1295-4272-9138-f99709370657
2006-04-14 14:03:43 +00:00
Brandon Low
fd08424694
Change to using a queue to synchronize between threads instead of abusing a mutex
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9659 a1c6a512-1295-4272-9138-f99709370657
2006-04-14 13:05:08 +00:00
Brandon Low
fbe74d1df6
Fix one cause of buffer-offness, but I'm pretty sure this is not the cause of problems that people are having as the debug code I put in detects and corrects it. Make taginfo instead of stupid filename appear on manual track skip, off buffer (stupid bug).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9658 a1c6a512-1295-4272-9138-f99709370657
2006-04-14 12:53:29 +00:00
Brandon Low
2f4edabfce
Tweak id3v1 tag stripping, better code, same functionality. Ensure correct buf_idx on track when rebuffer&seek.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9653 a1c6a512-1295-4272-9138-f99709370657
2006-04-14 04:42:11 +00:00
Brandon Low
2f11d60dcd
Change when the new_track variable is reset to fix the track display during skipping
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9652 a1c6a512-1295-4272-9138-f99709370657
2006-04-14 03:47:32 +00:00
Brandon Low
1d41f77b37
Boost during the track transition, trust me, it makes sense. Better logging of buffer-not-synched issues. Revert a previous change to make a function take a parameter intead of using cur_ti. Add some todos.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9651 a1c6a512-1295-4272-9138-f99709370657
2006-04-13 21:47:00 +00:00
Brandon Low
017914a087
Adjust filesize if id3v1 is stripped
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9648 a1c6a512-1295-4272-9138-f99709370657
2006-04-13 20:42:11 +00:00
Brandon Low
0744e760cb
Ensure that the buffer doesn't get out of sync on rebuffer track changes. Remove the concept of pcmuf_boost_mode as it doesn't seem necessary, and adds an unnecessary way for the CPU to stay boosted.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9646 a1c6a512-1295-4272-9138-f99709370657
2006-04-13 17:30:54 +00:00
Brandon Low
483c947c3d
Add a logf, remove an unused parameter, and an unused member of the track_info struct, ensure that we unboos on stop even if buffering, make a function take a parameter instead of using a global
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9644 a1c6a512-1295-4272-9138-f99709370657
2006-04-13 15:48:00 +00:00
Brandon Low
c95044a9c1
Track skipping rework more. This seems to handle rapid skipping very gracefully without compromising buffer safety. There may still be a potentially broken code path if the user does a very rapid skip, stop sequence, and I will be sure to investigate this. Due to Slasheri's concern, reimplement rapid GUI update for track skipping in a safe way.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9643 a1c6a512-1295-4272-9138-f99709370657
2006-04-13 14:17:12 +00:00
Brandon Low
b1fa534f14
Simplify audio startup, and remove some unnecessary code
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9640 a1c6a512-1295-4272-9138-f99709370657
2006-04-13 02:46:34 +00:00
Brandon Low
44d9576ff5
Track changes should zero the seek_time to prevent undesired seeking in the new track
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9636 a1c6a512-1295-4272-9138-f99709370657
2006-04-12 03:25:54 +00:00
Brandon Low
54af304a5b
use the cur_ti pointer, as it's always synched up with track_ridx any way
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9635 a1c6a512-1295-4272-9138-f99709370657
2006-04-12 02:01:26 +00:00
Brandon Low
376950155c
Get the GUI and audio in sync for track changes
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9634 a1c6a512-1295-4272-9138-f99709370657
2006-04-12 01:45:53 +00:00
Brandon Low
10c3a34c85
Fix major rebuffer stupidity, remove a redundant call, and a wrong comment.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9633 a1c6a512-1295-4272-9138-f99709370657
2006-04-12 00:21:29 +00:00