Jonathan Gordon
036fb05dfd
Accept a quick patch from Alexander Levin to neaten up the #defines and comments from my earlier commit
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19897 a1c6a512-1295-4272-9138-f99709370657
2009-02-01 13:43:08 +00:00
Jonathan Gordon
80cb3551eb
Statusbar handling fixes.
...
Fixes FS#9845 - %we/%wd wasnt working
WPS no longer resets the viewportmanger more than needed (was doing it twice/draw before)
screens can now enable/disable the statusbar easily ignoring the setting instead of needing special handling (fix for the radio screen coming soon)
minor glitch introduced in this commit... the statusbar in the WPS might disappear for a fraction of a second when it is entered, I need to track this down...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19894 a1c6a512-1295-4272-9138-f99709370657
2009-02-01 11:34:16 +00:00
Jonathan Gordon
b84fe020a5
use the playback PLAYBACK_EVENT_TRACK_CHANGE instead of the WPS to keep track of the current track (for follow playlist)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19747 a1c6a512-1295-4272-9138-f99709370657
2009-01-11 04:03:17 +00:00
Jonathan Gordon
04dcf117a1
revert part of r19705 which caused fS#9773
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19732 a1c6a512-1295-4272-9138-f99709370657
2009-01-09 04:46:28 +00:00
Jonathan Gordon
a68e5d835f
remove some useless/unused stuff from gwps.c
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19705 a1c6a512-1295-4272-9138-f99709370657
2009-01-07 10:57:51 +00:00
Jonathan Gordon
e385ee18ce
Decouple the statusbar drawing from the rest of the screen drawing. it is not drawn roughly 4x per second automatically.
...
viewport_Set_defaults() will setup the given viewport with the correct "full screen" dimensions (so start at 0,0 if statusbars are disabled or 0,8 if they are enabled.)
All screens should keep the statusbar enabled, but if you really want to ignore the user setting you can disbaled it with viewportmanager_set_statusbar(false).
This commit also includes some menu/list viewport cleanups from kugel in FS#9603
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19622 a1c6a512-1295-4272-9138-f99709370657
2008-12-31 05:59:26 +00:00
Jonathan Gordon
c7fec13fd8
FS#9173 - move all time/clock related settings in the menus into system > "time & date" (this includes sleep timer, alarm settings)
...
The time/date dispaly has been moved out of the "rockbox info" screen and into this screen also (only displayed if there is at least 3 lines of text on the screen though)
The time/date is talked in this screen by pressing the usual context-menu button (usually long-select)
Targets without a RTC are not changed (i.e sleep timer isnt moved)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19282 a1c6a512-1295-4272-9138-f99709370657
2008-12-01 09:28:14 +00:00
Jonathan Gordon
825eda1ff9
revert my commit from a few days ago.. It doesnt actually do anything
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18712 a1c6a512-1295-4272-9138-f99709370657
2008-10-05 09:23:16 +00:00
Jonathan Gordon
dfec613bac
fix yellow... should also actyually fix the issue...
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18688 a1c6a512-1295-4272-9138-f99709370657
2008-10-03 01:25:44 +00:00
Jonathan Gordon
28f1f50ab7
Hopefully fix crashes if the start screen is set to previous and nvram.bin becomes invalid
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18686 a1c6a512-1295-4272-9138-f99709370657
2008-10-03 00:43:09 +00:00
Nils Wallménius
93a87685c3
Clean up use of snprintf where strncpy if suited, avoid useless copying of constant strings for wps token evaluator, minor const police too.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18625 a1c6a512-1295-4272-9138-f99709370657
2008-09-24 20:03:53 +00:00
Nils Wallménius
01729e7a18
FS#9281 Rename of splash functions.
...
* Remove gui_splash()
* Rename gui_syncsplash() to splashf() and remove its voice
capabilities.
* Rename the internal splash() to splash_internal() and introduce an
externally visible splash() that handles simple splashing without
printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ,
"foo"); if a LANG_* id is passed it will be voiced.
* Adjust all places that called gui_syncsplash() to use the correct
variant from above.
* Export both new functions to plugins and adjust places calling
rb->splash() to use the correct variant so that we now have naming
consistency between the core and plugins.
* Fix one latent bug that would cause my sim to crash with the above
changes and correct P2STR and P2ID macros, thanks to pondlife.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18282 a1c6a512-1295-4272-9138-f99709370657
2008-08-15 08:27:39 +00:00
Bertrik Sikken
dff382cb9c
Make a couple of locally used callbacks static
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18067 a1c6a512-1295-4272-9138-f99709370657
2008-07-16 12:10:49 +00:00
Daniel Stenberg
2acc0ac542
Updated our source code header to explicitly mention that we are GPL v2 or
...
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 18:10:04 +00:00
Steve Bavin
5f8bd63cba
FS#9019 - Tidied up WPS context menu. Moved playlist to the top, added Playback Settings optiona and removed duplicate options.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17603 a1c6a512-1295-4272-9138-f99709370657
2008-05-22 08:02:48 +00:00
Jonathan Gordon
10df05438e
more textarea to viewport conversion... yes/no screen...
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17454 a1c6a512-1295-4272-9138-f99709370657
2008-05-11 13:39:22 +00:00
Bertrik Sikken
e15f8a21a9
Made source files #include the header file that they implement to make sure they are in sync. Made some local functions static.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17312 a1c6a512-1295-4272-9138-f99709370657
2008-05-03 08:35:14 +00:00
Nils Wallménius
33c44461e1
Const police raid, making a lot of pointers to lang strings const and removing some ugly casting
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17251 a1c6a512-1295-4272-9138-f99709370657
2008-04-26 09:30:24 +00:00
Dave Chapman
d746b79317
Remove unnecessary (and incorrect) #ifdefs surrounding #include "backdrop.h", and correct remaining references to HAVE_LCD_REMOTE to HAVE_REMOTE_LCD
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16873 a1c6a512-1295-4272-9138-f99709370657
2008-03-29 01:14:10 +00:00
Dave Chapman
78d29f535f
Major cleanup of checkwps - fix all warnings and add a script to build versions for all supported targets (plus some unsupported ones). You now need to run the version of checkwps that matches the device your WPS is for.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16831 a1c6a512-1295-4272-9138-f99709370657
2008-03-26 23:35:34 +00:00
Jonathan Gordon
5ca1539969
the menu and list now accepts a parent viewport to draw in (and the menu can be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
2008-03-26 03:35:24 +00:00
Steve Bavin
6cc3895e5a
Fix FS#7334, make Follow Playlist work when STOP is pressed.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16253 a1c6a512-1295-4272-9138-f99709370657
2008-02-09 15:20:15 +00:00
Steve Bavin
32a9575130
FS#7994 - Rename talk.c API, make talk_disable() affect all talking (not just menus), hopefully save some space.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15206 a1c6a512-1295-4272-9138-f99709370657
2007-10-19 15:31:42 +00:00
Stéphane Doyon
6d08116691
Fix a bug whereby ACTION_TREE_WPS (GO_TO_PREVIOUS_MUSIC) brings us to the
...
radio, despite playback having been started since we last visited the radio.
To reproduce:
-go to the radio,
-stop and exit it,
-go to the browser, and do a playlist insert,
or start a playlist from the playlist catalog,
anything that starts playback without going to the WPS.
-Press ACTION_TREE_WPS.
Find yourself back into the radio.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15085 a1c6a512-1295-4272-9138-f99709370657
2007-10-12 04:20:20 +00:00
Stéphane Doyon
84ed3fd50f
Go to the WPS on a successful bookmark_mrb_load() from the MRB,
...
rather than popping back to the root menu.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15084 a1c6a512-1295-4272-9138-f99709370657
2007-10-12 04:10:08 +00:00
Stéphane Doyon
2ee85c5056
Voice already gets shutup when starting playback. It's also appropriate
...
to shut it up when returning to the WPS (GO_TO_WPS).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15083 a1c6a512-1295-4272-9138-f99709370657
2007-10-12 02:23:52 +00:00
Stéphane Doyon
5acf091046
Add a voice callback to dynamic menus, along side the text_callback.
...
From FS#7563.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15042 a1c6a512-1295-4272-9138-f99709370657
2007-10-09 03:48:56 +00:00
Jonathan Gordon
fda7d720c0
Accept FS#5464 - organise the rocks directory.
...
If any plugins or "open with" optoins dont work please let me know...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14214 a1c6a512-1295-4272-9138-f99709370657
2007-08-06 13:42:52 +00:00
Nils Wallménius
5b76936a44
Accept FS#6159 'Add voice to roughly 100 splash screens and yes-no menus' by Stephane Doyon with some minor tweaks by me. Rerun 'configure' and do a 'make clean' before rebuilding your voice files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14213 a1c6a512-1295-4272-9138-f99709370657
2007-08-06 13:08:36 +00:00
Nils Wallménius
b311367481
*** Lang v2 cleanup (FS#6574) ***
...
1) Introduces apps/features.txt that controls which strings are included
for each target based on defines.
2) .lng and .voice files are now target specific and the format versions
of both these file types have been bumped, which means that new voice
files are needed.
3) Use the 'features' mechanism to exclude strings for targets that
didn't use them.
4) Delete unused and deprecated and duplicated strings, sort strings in
english.lang
Some string IDs were changed so translations will be slightly worse than
before.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14198 a1c6a512-1295-4272-9138-f99709370657
2007-08-05 19:19:39 +00:00
Jonathan Gordon
f7675a244b
remove the need for action_signalscreenchange().
...
Fixes problems with targets where the ACTION_STD_CANCEL event is a combo
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13956 a1c6a512-1295-4272-9138-f99709370657
2007-07-22 06:05:53 +00:00
Peter D'Hoye
5737254429
Give the plugin menu its own title (when configured). Fixes FS #7371
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13856 a1c6a512-1295-4272-9138-f99709370657
2007-07-11 22:05:38 +00:00
Jonathan Gordon
411f3e2b2b
If the action handler for the menu returns ACTION_REDRAW the list will be redrawn. Fixes the Now Playing/Resume Playback text not updating
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13848 a1c6a512-1295-4272-9138-f99709370657
2007-07-11 02:22:03 +00:00
Peter D'Hoye
9337efdb7a
Accept FS #7303 by Christoph Reiter: add context menu to FM radio entry in main menu. Also changes a small naming inconsistency.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13778 a1c6a512-1295-4272-9138-f99709370657
2007-07-03 18:31:13 +00:00
Jonathan Gordon
2ca895bae7
Fix FS#7387 - trying to go into the file browser when the last folder was on the MMC/mSD card (which was removed) would go into an infinite loop.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13768 a1c6a512-1295-4272-9138-f99709370657
2007-07-03 08:43:38 +00:00
Nils Wallménius
f31e123133
Remove unused function and unused header
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13424 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 19:54:11 +00:00
Nicolas Pennequin
1cf2ec38b1
Change some ifdefs for the recent backdrop changes (fixes the yellow builds) and move the backdrop files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13265 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 22:08:00 +00:00
Nicolas Pennequin
7fdfa56454
Add backdrop support for LCD remotes with depth > 1-bit. Only WPS backdrops, but the groundwork is laid for main backdrops too (all that's really needed are menus to set/clear them).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13263 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 21:44:56 +00:00
Jonathan Gordon
680acbf71b
fix a stupid bug which didnt check the flag correctly (caused the player to crash trying to access the shutdown options context menu)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13258 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 10:41:17 +00:00
Brandon Low
b44b660ac4
Fix build for those who don't want to build tagcache
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13203 a1c6a512-1295-4272-9138-f99709370657
2007-04-18 19:46:34 +00:00
Jonathan Gordon
f9fb49284e
Give most of the items in the main menu a context menu
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13126 a1c6a512-1295-4272-9138-f99709370657
2007-04-12 15:28:51 +00:00
Jens Arnold
5764ff571a
Fix yellow player build. Sims have no charging...
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13080 a1c6a512-1295-4272-9138-f99709370657
2007-04-09 13:54:38 +00:00
Jens Arnold
178c565beb
Stop/shutdown logic rework in browsers and menus. Recorder V1: Double-Off shutdown is now possible from menus and sub-browsers as well. Player, other targets which are always powered during charging: Attempted shutdown from menu with charger plugged now displays the charging splash.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13079 a1c6a512-1295-4272-9138-f99709370657
2007-04-09 13:39:37 +00:00
Jonathan Gordon
ec7ca33a0c
Fix the root menu for any targets without a radio (we are using #if not #ifdef for CONFIG_TUNER). Fixes the bookmark issue in FS#6965)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13027 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 02:50:43 +00:00
Robert Kukla
1f33735097
FS#6948 - Fix the broken 'follow playlist' feature
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12985 a1c6a512-1295-4272-9138-f99709370657
2007-03-31 21:59:57 +00:00
Peter D'Hoye
d2b305571e
Check if a new version got installed after usb disconnect and ask if user wants to reboot. Causes disk spinup before showing the usb logo. Also fixes do_menu() not returning to root_menu after usb disconnect.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12972 a1c6a512-1295-4272-9138-f99709370657
2007-03-30 21:54:48 +00:00
Peter D'Hoye
4d28b2f043
set correct eol-style and keywords properties
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12966 a1c6a512-1295-4272-9138-f99709370657
2007-03-29 22:51:03 +00:00
Jonathan Gordon
678705c732
Hopefully fix FS#6863 for good. (possible to get into infinite loop in the menu with screens returning GO_TO_PREVIOUS)
...
Also clean up root_menu.c a bit
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12960 a1c6a512-1295-4272-9138-f99709370657
2007-03-29 14:19:28 +00:00
Jonathan Gordon
91e726a1c1
Move all valid menu return codes to a single file (root_menu.h) so we don't need to rely on GO_TO_ROOT == MENU_ATTACHED_USB.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12937 a1c6a512-1295-4272-9138-f99709370657
2007-03-27 06:38:11 +00:00
Dominik Riebeling
c3bef27cbd
Temporary workaround hard lockup with "nothing to resume" splash at end of the playlist if the last active screen was the main menu. A proper fix should come soon.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12896 a1c6a512-1295-4272-9138-f99709370657
2007-03-23 08:09:28 +00:00