Avoid constructing the bootloader file path in the caller. Pass filename
list and mountpoint separately so it can directly fall back to the
mountpoint.
Change some functions to use references instead of creating temporary
objects.
Change-Id: I09c9d755553a32de3d02a42a8ce1fcb94f831b2a
Reworking handling of player specific data (static player configuration,
as well as information retrieved from the server) changed the behaviour
on a non-present configuration entry. This eventually caused the
mountpoint not being set for players that don't have a bootloader file
on disk. Fixing this accidentially removed the default-if-not-found
handling for the bootloader file.
Restore the old default value behaviour for both cases.
Change-Id: I627782ccdef198619fb507f8b09a64811b3bd18f
- When uninstalling update the log file only at the end of removing all
files. This gives a major speed improveness since othewise the log
file is written after each file. This slows down things notably,
especially on slow disks.
- Explicitly update the UI during install zip extraction. Avoids
progress seemingly hanging due to the UI not getting updated often
enough.
Change-Id: Ib353a92e02a7038d6e55f5f88dcfb5085602c0f2
When uninstalling parts with lots of small files the process can take
quite some time. Update the progress accordingly.
Change-Id: Iecc4553b36abbc1cf9652a325ccb29b62a7fc4cc
We only use it for playing the TTS sample so it's not too important.
Since this is a separate Qt module it might not be installed, so make it
optional.
Change-Id: I2c91dd5d587c8a984525b2297bbe7d597b816b4f
During bootloader installation sansapatcher disk access is accidentially
set up twice. This is not a problem except on Windows, which will abort
with a "permission denied" error.
This is basically the same problem as for ipodpatcher bootloader install.
Change-Id: I03220e17d0e00a15fff23c02aba7da93d4781964
During bootloader installation ipodpatcher disk access is accidentially
set up twice. This is not a problem except on Windows, which will abort
with a "permission denied" error.
Change-Id: I9a835ef0d49f24df741b7b2909c4bd87cb1c8341
It seems Qt6 doesn't require explicit linking to QSvgIconPlugin anymore,
and cmake has trouble finding it. On native Windows builds it isn't
required, so remove it.
Change-Id: I87651f51ab212511947ab9fca3297b0dff276577
Qt6 has QMultimedia, but QSound has been removed. It's only use for
playing a TTS test sample. Disable that for now.
Change-Id: Id3b5c834f9579a43e390c0c00a4c1a35b59182bd
- Fix regexp case insensitive option being inverted.
- Pass more objects by reference.
- Some const-ness.
Change-Id: I1c77ad22ab1e505c8dce8c083d9c52e76a6860be
QProgressDialog shows / hides itself automatically based on the progress
value set, so calling hide() directly doesn't prevent the dialog from
showing itself.
Change the logic to set a value instead. Fixes the progress dialog
sometimes appearing in situations where it wasn't used at all.
Change-Id: Ifef063f31b7f888bb74f180dea0679e81cc5c8fe
When communicating with Festival via socket don't assume readAll() would
read all data we expect. We can only read the data that has been sent by
the server so far, and this is not necessarily complete.
This notably improves the configuration dialog response and reliably.
Change-Id: I9a812f03df785fb3ad32783a8573a2c86dc317ed
Qt uses the systems certificate store. On old(er) systems the root
certificate might not be present, so checking the certificate from the
rockbox.org server might fail.
On startup we try to download the build-info file. If this fails with a
certificate error allow the user to temporarily accept the rockbox.org
certificate for all successive requests.
Change-Id: I459e12d53286aaedea4db659d90a5e057c56801f
For Qt versions less than 5.14 MinGW windeployqt requires passing
--release or --debug to pick the correct libs to deploy. For newer
version this must not be passed, or otherwise windeployqt errors out.
Use a conditional expression to only add the parameter for older Qt
versions.
Change-Id: I7afe2b77e9829e989adaeeb7c7499d5955926da2
For development builds we provide a download URL, but use the daily
build files. Those require the version of the daily build to be set when
expanding the URL string.
Change-Id: Ie6dcf38f7e86527217edc01ee11a20758a178622
We now initialize sectorbuf explicitly, and there are situation where it
wasn't initialized explicitly.
Change-Id: I35516a1fa7326c0861885ffa058737de19285c2c
Use named arguments for function and allow passing additional executable
targets to be copied to the deploy tree.
Update current uses and add ipodpatcher and sansapatcher to Rockbox
Utility deployment.
This is in preparation for moving ipodpatcher / sansapatcher
functionality out of Rockbox Utility so we eventually can avoid
elevation / sudo of the whole installer. Currently this only results in
Rockbox Utility releases shipping ipodpatcher / sansapatcher
executables.
Change-Id: Ibb6601b7e437648135059c580e2ce2532574835a
On Ipods we use the bootloader "filename" to pass the mountpoint, which
is then used to determine the correct device to use.
Change-Id: I1dd2060ae9176bfdece9337160db08caf326e1f5
Don't try to get a bootloader filename from an empty list. This happens
if the device doesn't have a bootloader file on disk.
Change-Id: Idd4c265e7ae298913c5feefb3963120867a0e858
Replace QLabel with QSvgWidget so the widget draws the svg directly
instead of first creating a pixmap from it.
This also avoids an issue when building with mxe which causes the image
to not show due to a missing svg plugin (which doesn't happen for svg
icons.)
Change-Id: Ic4e265f0567984d1ffe7a3e1cc641df27755e90b
The old deployment script doesn't work anymore due to the change to
cmake, and since we build the distribution packages (zip / dmg /
AppImage) with cmake directly there's not much need left for the old
deployment.
Change-Id: Ide20887c5bc2e22aabbfb47374d70529609fbc3c
Instead of checking for certain hardcoded strings, fetch
the actual capability bitmask by instantiating an installer
and querying it.
Change-Id: I7883d9c1e90da37ee7c0189732ac626685adbfa1
- Fix binary name in Info.plist.
- Run dmgbuild as Python module, in some cases it isn't available directly.
- Add missing dmgbuild configuration for themeeditor.
Change-Id: I2db50959b88283f43e2203cf71b130cdb33103dd
