Teruaki Kawashima
cc9e336fa1
text editor: Return pointer to buffer but position in buffer for ACTION_GET to simpify code.
...
Use strlcpy instead of strcpy to prevent buffer overflow.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23845 a1c6a512-1295-4272-9138-f99709370657
2009-12-04 12:53:14 +00:00
Teruaki Kawashima
f6999b8f2a
text editor: optimize a bit and try to reduce size.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22449 a1c6a512-1295-4272-9138-f99709370657
2009-08-21 14:56:23 +00:00
Nils Wallménius
3200d04d75
Make the formatter functions used by the settings return a pointer to avoid usless copying of lang strings, this brought with it a long chain of const correctness and a few random cleanups
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22440 a1c6a512-1295-4272-9138-f99709370657
2009-08-20 16:47:44 +00:00
Thomas Martitz
18e40e0f4c
Make kbd_input() show a cancel splash to indicate user abort better and for better consistency all over the place. Change checking for its return value (style-wise) at some places too.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22269 a1c6a512-1295-4272-9138-f99709370657
2009-08-12 14:38:25 +00:00
Frank Gevaerts
308522b60e
Decrease the text buffer a tiny bit to make it fit again on archos. This really should use plugin_get_buffer() (and possibly plugin_get_audio_buffer() for big files) though.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21996 a1c6a512-1295-4272-9138-f99709370657
2009-07-21 21:19:42 +00:00
Teruaki Kawashima
3f7dfeed3a
text_editor: don't set filename "/" before input new filename so that user can easily create copy in same directory.
...
select new last line if last line is cut/deleted or concatenated to above line.
fix bugs when changes are not saved (FS#9692, patch by Johannes Linke).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21994 a1c6a512-1295-4272-9138-f99709370657
2009-07-21 14:35:29 +00:00
Nils Wallménius
3d4701a6e4
FS#10080
...
* Move strncpy() from core to the pluginlib
* Introduce strlcpy() and use that instead in most places (use memcpy in a few) in core and some plugins
* Drop strncpy() from the codec api as no codec used it
* Bump codec and plugin api versions
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21863 a1c6a512-1295-4272-9138-f99709370657
2009-07-14 13:57:45 +00:00
Alexander Levin
119cfdaa0a
Do not unnecessarily change and restore the status bar setting (part of FS#10138 by Teruaki Kawashima)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21493 a1c6a512-1295-4272-9138-f99709370657
2009-06-24 20:17:17 +00:00
Alexander Levin
763a7d7457
Ensure that the file handle is always closed in text editor plugin (part of FS#10138 by Teruaki Kawashima, minor modifications by me)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21491 a1c6a512-1295-4272-9138-f99709370657
2009-06-24 15:18:32 +00:00
Alexander Levin
249800c1ae
Fix a typo in the comment
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20422 a1c6a512-1295-4272-9138-f99709370657
2009-03-21 09:24:40 +00:00
Alexander Levin
56086db778
Fix yellow
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20408 a1c6a512-1295-4272-9138-f99709370657
2009-03-20 19:37:11 +00:00
Alexander Levin
2d77fde363
Accept some improvements to the text editor plugin (FS#9988 with minor modifications by me)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20405 a1c6a512-1295-4272-9138-f99709370657
2009-03-20 18:59:03 +00:00
Alex Parker
788ace2ec6
Change spelling to British English in the filetype colours section
...
of text_editor
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20327 a1c6a512-1295-4272-9138-f99709370657
2009-03-16 21:24:29 +00:00
Andrew Mahone
23d9812273
loader-initialized global plugin API:
...
struct plugin_api *rb is declared in PLUGIN_HEADER, and pointed to by
__header.api
the loader uses this pointer to initialize rb before calling entry_point
entry_point is no longer passed a pointer to the plugin API
all plugins, and pluginlib functions, are modified to refer to the
global rb
pluginlib functions which only served to copy the API pointer are
removed
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19776 a1c6a512-1295-4272-9138-f99709370657
2009-01-16 10:34:40 +00:00
Björn Stenberg
a36cdf5b37
Removed the sim_ prefix from the plugin api.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19704 a1c6a512-1295-4272-9138-f99709370657
2009-01-07 09:53:46 +00:00
Björn Stenberg
c6b3d38a15
New makefile solution: A single invocation of 'make' to build the entire tree. Fully controlled dependencies give faster and more correct recompiles.
...
Many #include lines adjusted to conform to the new standards.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19146 a1c6a512-1295-4272-9138-f99709370657
2008-11-20 11:27:31 +00:00
Nils Wallménius
01729e7a18
FS#9281 Rename of splash functions.
...
* Remove gui_splash()
* Rename gui_syncsplash() to splashf() and remove its voice
capabilities.
* Rename the internal splash() to splash_internal() and introduce an
externally visible splash() that handles simple splashing without
printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ,
"foo"); if a LANG_* id is passed it will be voiced.
* Adjust all places that called gui_syncsplash() to use the correct
variant from above.
* Export both new functions to plugins and adjust places calling
rb->splash() to use the correct variant so that we now have naming
consistency between the core and plugins.
* Fix one latent bug that would cause my sim to crash with the above
changes and correct P2STR and P2ID macros, thanks to pondlife.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18282 a1c6a512-1295-4272-9138-f99709370657
2008-08-15 08:27:39 +00:00
Daniel Stenberg
2acc0ac542
Updated our source code header to explicitly mention that we are GPL v2 or
...
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 18:10:04 +00:00
Steve Bavin
6526577818
Plugin parameters should be const.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17492 a1c6a512-1295-4272-9138-f99709370657
2008-05-13 09:57:56 +00:00
Jonathan Gordon
33b785e40b
allow the plugin playback control menu to be put in a viewport.
...
fix text editor so it is actually possible to get to the control menu if the file hasnt been changed (its in the regular menu now)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17221 a1c6a512-1295-4272-9138-f99709370657
2008-04-23 10:28:34 +00:00
Nils Wallménius
6848961aa5
Pass the buffer length to the list_get_name callback functions instead of using hardcoded MAX_PATH
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17049 a1c6a512-1295-4272-9138-f99709370657
2008-04-09 15:25:17 +00:00
Jonathan Gordon
5ca1539969
the menu and list now accepts a parent viewport to draw in (and the menu can be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
2008-03-26 03:35:24 +00:00
Dave Chapman
e92d2c51ed
Add a general-purpose parse_list function to parse a string containing a delimited list of items and adapt the parse_image_load() function in the WPS parser to use it. This function will also be used to parse the upcoming WPS %V viewport tag, but I'm committing it separately as these changes are unrelated to the viewport implementation itself.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16728 a1c6a512-1295-4272-9138-f99709370657
2008-03-21 13:41:35 +00:00
Paul Louden
31bf5cc8e5
Oops. Was thinking _TREE_ not _STD_, so no changes to the text editor
...
after all.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15708 a1c6a512-1295-4272-9138-f99709370657
2007-11-20 02:11:13 +00:00
Paul Louden
92b6ee91fa
Fix keymapping inconsistencies generated by my previous keymap change,
...
this touches the FM Radio, Recording, and Text Editors.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15706 a1c6a512-1295-4272-9138-f99709370657
2007-11-20 01:59:06 +00:00
Dave Chapman
a076da6efc
Remove an unneeded #include - action.h is already included by plugin.h
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15388 a1c6a512-1295-4272-9138-f99709370657
2007-10-31 22:33:28 +00:00
Nils Wallménius
d969a420b6
Do not display the backdrop in text viewer and editor plugins
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14835 a1c6a512-1295-4272-9138-f99709370657
2007-09-23 19:15:56 +00:00
Jonathan Gordon
cf1cef5f57
minor update to gui_synclist_do_button() which will hopefully simplify things later.
...
Now returns true if the action was handled in that function instead of returning the handled action.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14733 a1c6a512-1295-4272-9138-f99709370657
2007-09-17 10:08:50 +00:00
Jonathan Gordon
744f07f554
fix FS#6754 - the standard context menu action will now delete the selected line
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14137 a1c6a512-1295-4272-9138-f99709370657
2007-08-02 11:07:06 +00:00
Jonathan Gordon
cafffb5b65
FS#5809:
...
add playback menu to text editor,
make the filename saving in rockpaint a bit better, automatically adds .bmp if its not there
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13993 a1c6a512-1295-4272-9138-f99709370657
2007-07-26 08:04:28 +00:00
Jonathan Gordon
f22dd51956
unused variable
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13902 a1c6a512-1295-4272-9138-f99709370657
2007-07-15 06:53:17 +00:00
Jonathan Gordon
9dca6aafb3
convert the last of the menus in text_editor to the new api
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13901 a1c6a512-1295-4272-9138-f99709370657
2007-07-15 06:45:12 +00:00
Paul Louden
f8b5913ae7
Make user-visible spelling "colours" rather than "colors".
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13671 a1c6a512-1295-4272-9138-f99709370657
2007-06-19 04:21:06 +00:00
Jonathan Gordon
1b947de1ad
s/icons/colors
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13666 a1c6a512-1295-4272-9138-f99709370657
2007-06-18 13:57:05 +00:00
Jonathan Gordon
46e186fa61
extend the text editor plugin to be able to modify the .colors file
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13665 a1c6a512-1295-4272-9138-f99709370657
2007-06-18 13:37:57 +00:00
Jonathan Gordon
77a458a464
Move the old api out of the core and into the plugin lib.
...
ew plugins shuold use the new api and not this one.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13358 a1c6a512-1295-4272-9138-f99709370657
2007-05-08 11:55:43 +00:00
Jonathan Gordon
f34495deca
Dont boost so often, fixes FS#6845
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12832 a1c6a512-1295-4272-9138-f99709370657
2007-03-18 13:25:18 +00:00
Jens Arnold
79c8a8cbbe
Let GCC check arguments of some more printf-style functions, also for plugins and codecs.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12815 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 09:02:53 +00:00
Jens Arnold
4d6374c923
Get rid of the 'center' parameter for splashes. There were only 2 of almost 500 splashes which were not centered.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12807 a1c6a512-1295-4272-9138-f99709370657
2007-03-16 21:56:08 +00:00
Dave Chapman
6820ed1f7f
Add the O_TRUNC flag when writing the modified file back to disk - fixes FS #6559
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12122 a1c6a512-1295-4272-9138-f99709370657
2007-01-27 10:45:34 +00:00
Jonathan Gordon
6a1161b634
dont allow the volume setting to wrap
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11445 a1c6a512-1295-4272-9138-f99709370657
2006-11-06 10:11:51 +00:00
Jonathan Gordon
ddba5fa37d
fixes fs5913
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11441 a1c6a512-1295-4272-9138-f99709370657
2006-11-06 06:21:45 +00:00
Jonathan Gordon
de93c63834
fix text editor for actions system, stopgap approach untill actions is modified properly for plugins
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10836 a1c6a512-1295-4272-9138-f99709370657
2006-09-01 02:58:44 +00:00
Daniel Stenberg
1e88be518a
Barry Wardell's keymappings for H10
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10446 a1c6a512-1295-4272-9138-f99709370657
2006-08-03 20:17:25 +00:00
Kevin Ferrare
f77ac7a6a7
added support remote support for the id3 infos screen (had to slightly change the list engine to use it here as well), corrected a mistake in the french translation
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10175 a1c6a512-1295-4272-9138-f99709370657
2006-07-02 12:28:27 +00:00
Kevin Ferrare
0e027bd90c
To avoid having to use the main unit when accidentally launching a plugin from the remote, plugins now support remote quit
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10157 a1c6a512-1295-4272-9138-f99709370657
2006-06-30 16:43:47 +00:00
Hardeep Sidhu
ab3e71cad9
Added reload_directory() to plugin api and modified text editor and sudoku plugins to call it when saving a new file. Fixes B#5360.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10053 a1c6a512-1295-4272-9138-f99709370657
2006-06-04 16:36:49 +00:00
Marcoen Hirschberg
9ad02de623
fix simulator build for the gigabeat
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9973 a1c6a512-1295-4272-9138-f99709370657
2006-05-22 16:28:19 +00:00
Dave Chapman
4c3ada4428
Patch #5374 - Updated text editor plugin from Jonathan Gordon.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9963 a1c6a512-1295-4272-9138-f99709370657
2006-05-20 10:16:03 +00:00
Zakk Roberts
0f842a16e5
Fix: don't ask for what file to save to if you 'Save Changes' with a file already opened.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9481 a1c6a512-1295-4272-9138-f99709370657
2006-04-04 02:28:04 +00:00