Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
21273 commits 17 branches 142 tags 291 MiB
Commit graph

778 commits

Author SHA1 Message Date
Thomas Martitz
5c9fe52629 Commit part of FS#9873 - Utilise buttons for playlisting 
It adds a shortcut (combo or button) to directly go from the wps to the playlist viewer. The combos could possibly be improved on some targets, but I tried to keep a tad bit of consistency (was hardly possible).
I also added a corresponding touchscreen region and adapted cabbiev2.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22003 a1c6a512-1295-4272-9138-f99709370657
 2009-07-22 22:10:25 +00:00
Thomas Martitz
23e46b3d98 touchscreen regions: 
a) check for trailing '|' so that it doesn't match wrong strings (a not-yet-existing "playlist" would match the existing "play")
b) don't recalculate the array length in each iteration

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21998 a1c6a512-1295-4272-9138-f99709370657
 2009-07-22 21:14:47 +00:00
Jonathan Gordon
24b136f62d rework cuesheet support: 
swcodec: search for a .cue during buffering (with the possibility of adding embedded cuesheets later)
hwcodec: search for a .cue when the id3 info for the current track is requested for the first time (disk should be spining so non issue)

major beenfit from this is simplofy cuesheet handling code a bit... if mp3entry.cuesheet != NULL then there is a valid cuesheet.. no need to worry about if its enabled and preloaded.
There is the possibility of putting the next/prev subtrack handling inside the playback code (as well as the id3 updating stuff (see FS#9789 for more info), but thats probably not a good idea.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21978 a1c6a512-1295-4272-9138-f99709370657
 2009-07-20 05:18:18 +00:00
Nils Wallménius
3d4701a6e4 FS#10080 
* Move strncpy() from core to the pluginlib
* Introduce strlcpy() and use that instead in most places (use memcpy in a few) in core and some plugins
* Drop strncpy() from the codec api as no codec used it
* Bump codec and plugin api versions


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21863 a1c6a512-1295-4272-9138-f99709370657
 2009-07-14 13:57:45 +00:00
Alexander Levin
23ea8a53a1 Slightly reduce the bin size by using ushort instead of int in arrays 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21840 a1c6a512-1295-4272-9138-f99709370657
 2009-07-13 14:48:02 +00:00
Alexander Levin
f448fa4655 Correctly compute the array size regardless of the element type 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21839 a1c6a512-1295-4272-9138-f99709370657
 2009-07-13 14:20:39 +00:00
Alexander Levin
76e6291780 Unify semitone and cent macros and make the formula a bit more obvious 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21814 a1c6a512-1295-4272-9138-f99709370657
 2009-07-12 17:14:01 +00:00
Alexander Levin
7765158513 Fix red in bootloaders 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21782 a1c6a512-1295-4272-9138-f99709370657
 2009-07-11 17:16:23 +00:00
Alexander Levin
cc7c665d9b Improvements to the pitch screen UI (FS#10359 by David Johnston) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21781 a1c6a512-1295-4272-9138-f99709370657
 2009-07-11 16:46:19 +00:00
Andrew Mahone
1bc67c81b6 Fix type mismatch warnings and errors exposed when building with EABI toolchain. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21769 a1c6a512-1295-4272-9138-f99709370657
 2009-07-11 00:22:26 +00:00
Thomas Martitz
2ad5e244c7 Correct another small typo in a comment. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21746 a1c6a512-1295-4272-9138-f99709370657
 2009-07-10 16:27:24 +00:00
Alexander Levin
37c7a67b47 Fix a typo 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21741 a1c6a512-1295-4272-9138-f99709370657
 2009-07-10 12:22:30 +00:00
Thomas Martitz
989ed2be01 Fix a few comments in gwps.c. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21740 a1c6a512-1295-4272-9138-f99709370657
 2009-07-10 11:53:15 +00:00
Jonathan Gordon
a06f6eedae cleanup the remote+main statusbar handling a bit, and fix the bug where the remote wps might reserve the space for the statusbar even if its disabled 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21709 a1c6a512-1295-4272-9138-f99709370657
 2009-07-08 00:51:03 +00:00
Jonathan Gordon
5931c2a82a fix yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21668 a1c6a512-1295-4272-9138-f99709370657
 2009-07-05 18:30:00 +00:00
Jonathan Gordon
f1034e00f6 FS#10406 - split the statusbar setting into one for each display, and allow the bar to be at the top or bottom of the display 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21665 a1c6a512-1295-4272-9138-f99709370657
 2009-07-05 18:07:58 +00:00
Jonathan Gordon
0e445fcef6 Fix the bug where the short-long fwd/back action would ffwd/rewind the next folder (consult the manual if that makes no sense) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21619 a1c6a512-1295-4272-9138-f99709370657
 2009-07-03 05:08:33 +00:00
Steve Bavin
f96f623090 Oops. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21470 a1c6a512-1295-4272-9138-f99709370657
 2009-06-22 19:51:02 +00:00
Steve Bavin
40d9b218e5 Allow use of timestretch with semitones in the pitchscreen. Rename variables to clarify the meaning of 'speed'. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21468 a1c6a512-1295-4272-9138-f99709370657
 2009-06-22 18:52:14 +00:00
Alexander Levin
8589fcb3e3 Merge the "Replaygain Off" option into the replaygain type; eliminate the "On/Off" setting (FS#10356). All WPS tags should work as before. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21414 a1c6a512-1295-4272-9138-f99709370657
 2009-06-20 21:13:24 +00:00
Steve Bavin
cbbf032c1b Display speed as relative to real-time, not timestretch amount. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21375 a1c6a512-1295-4272-9138-f99709370657
 2009-06-20 10:36:07 +00:00
Alexander Levin
02a3740596 Slightly rearrange statements. No functional change but RAM and binary are reduced. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21350 a1c6a512-1295-4272-9138-f99709370657
 2009-06-19 11:23:02 +00:00
Marianne Arnold
49c9ab8120 Restore the ACTION_REDRAW case as it was before r20661 (with a slight change as suggested by Thomas Martitz). Without it you could get trapped in the WPS on targets with software hold as disabling hold again did not work correctly. Also fix(ed) typos... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21325 a1c6a512-1295-4272-9138-f99709370657
 2009-06-18 13:50:11 +00:00
Steve Bavin
d6ad019af3 Renamed routines and changed comments for clarity. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21309 a1c6a512-1295-4272-9138-f99709370657
 2009-06-16 07:10:05 +00:00
Jens Arnold
b22e604a06 Fix the charcell viewport defaults. The statusbar is offscreen on charcell. This fixes e.g. the yesno screen when deleting files. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21267 a1c6a512-1295-4272-9138-f99709370657
 2009-06-12 22:22:19 +00:00
Steve Bavin
fb2380790e FS#8894 - Add time stretching feature to all SWCODEC targets - the current algorithm is best for spoken word. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21258 a1c6a512-1295-4272-9138-f99709370657
 2009-06-12 07:20:50 +00:00
Thomas Martitz
be214c9445 Fix a problem that the statusbar was redrawn to late and not really in sync with the lists when changing loading a (theme) .cfg or changing the colors witht the color picker. Now both, the statusbar and the tree lists are redrawn instantly after settings_apply() (even before the "Theme loaded" splash). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21222 a1c6a512-1295-4272-9138-f99709370657
 2009-06-08 18:19:43 +00:00
Jens Arnold
1d6df54df2 Convert a number of places in core and plugins to use the BIT_N() macro instead of 1<<n. Speeds up things on SH1, and also reduces core binsize. Most notable speedups: 1 bit lcd driver: drawpixel +20%, drawline + 27%, hline +5%; jpeg viewer: +8% for 1/8 scaling. Other targets are unaffected. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21205 a1c6a512-1295-4272-9138-f99709370657
 2009-06-07 21:27:05 +00:00
Thomas Martitz
6de2f14b23 Fix FS#10231. The gwps_leave_wps() call at powering down is completely unnecessary anyway as it's meant to prepare the displaying of the next screen, which isn't needed when there's no next screen. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21067 a1c6a512-1295-4272-9138-f99709370657
 2009-05-24 16:09:00 +00:00
Bertrik Sikken
ab222c1705 Simplify some redundant boolean expressions 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21013 a1c6a512-1295-4272-9138-f99709370657
 2009-05-21 14:15:24 +00:00
Bertrik Sikken
2dc2054319 Remove some unused declarations 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21010 a1c6a512-1295-4272-9138-f99709370657
 2009-05-21 12:32:26 +00:00
Bertrik Sikken
0023943439 Fix duplicate #includes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20977 a1c6a512-1295-4272-9138-f99709370657
 2009-05-17 14:50:19 +00:00
Bertrik Sikken
8d5dbf4c14 Clean up some unused #includes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20975 a1c6a512-1295-4272-9138-f99709370657
 2009-05-17 11:56:06 +00:00
Jonathan Gordon
2172c91473 get repeat/hold actions working on the touchscreen WPS. prepending an action with & means that this will only get triggered if you hold down the area. cabbie WPS updated so the fwd/rwd icons will do that when held or skip fwd/back if just pressed. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20974 a1c6a512-1295-4272-9138-f99709370657
 2009-05-17 06:25:18 +00:00
Marianne Arnold
e435e4d976 New 'clock present' WPS tag: The tag checks for the presence of the clock hardware and can be used unconditionally (returning a 'c') or in a conditional. You can specify what to display if a target has the clock (the true case) and an alternative for targets without. This can be useful for e.g. the greyscale 160x128 WPSs or the Archos ones which work on players with and without the hardware. - Add the new tag to the WPS tag description in the manual. Change the headline to the less technical 'Time and Date' as per the discussion in IRC. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20961 a1c6a512-1295-4272-9138-f99709370657
 2009-05-16 11:22:41 +00:00
Thomas Martitz
dad292c3ef Fix splash on greyscale (was showing only a black or grey box, no text) by reverting to lcd_set_foreground(). That does a bit more on greyscale than just setting the current's viewports fg_pattern :/ 
It will still only apply to the viewport used for splash, so no need to restore the old foreground.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20944 a1c6a512-1295-4272-9138-f99709370657
 2009-05-15 15:27:32 +00:00
Thomas Martitz
f4aa7428ea Fix FS#10197 by setting the viewport before calculating the string size. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20943 a1c6a512-1295-4272-9138-f99709370657
 2009-05-15 14:53:06 +00:00
Jonathan Gordon
13cc654cea More touchscreen additions, quickscreen, browser, context menu, skip fwd/back buttons in the mr500 wps (a "button bar" will pop up for 2.5s when the screen is touched.) 
icons by Johannes Voggenthaler
pitch screen icon is there but not used because that screen isnt fixed for the touhscreen yet


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20939 a1c6a512-1295-4272-9138-f99709370657
 2009-05-15 06:02:50 +00:00
Jonathan Gordon
c1267dc700 allow the user to change the shuffle and repeat modes from the touchscreen, update the mr500 default wps to show how to do it (hint, press the shuffle/rep icon) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20937 a1c6a512-1295-4272-9138-f99709370657
 2009-05-15 05:36:16 +00:00
Jonathan Gordon
d48f1a0a45 get the quickscreen working on the mr500. hold "mode" on the remote to get to it, then you can use the 4 directions on the remote, or the touchscreen to change the values. "mode" will exit, as will pressing in the top or middle of the main screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20935 a1c6a512-1295-4272-9138-f99709370657
 2009-05-15 05:08:28 +00:00
Bertrik Sikken
09085a30f6 Remove unneeded #include "backdrop.h" 
Remove unneeded #include "statusbar.h"


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20891 a1c6a512-1295-4272-9138-f99709370657
 2009-05-09 18:09:14 +00:00
Thomas Martitz
c91e73e922 Convert splashes to viewports for bitmap targets and only draw/update the viewport that is needed instead of the whole screen. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20870 a1c6a512-1295-4272-9138-f99709370657
 2009-05-08 00:28:33 +00:00
Karl Kurbjun
2677886bc3 Keep the quickscreen from crashing the player with a divide by 0 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20854 a1c6a512-1295-4272-9138-f99709370657
 2009-05-06 02:17:04 +00:00
Thomas Martitz
9adc03949f Revert r20786 as it caused problems with alternating sublines (they need to be reset if gui_wps_refresh() wasn't called for some time, since the subline timeout gets confused). Also, it needs to be set to get the update, since do_full_update will be set to false after track change no matter if an update happened. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20812 a1c6a512-1295-4272-9138-f99709370657
 2009-04-27 18:57:51 +00:00
Thomas Martitz
29cf2e148b Setting do_full_update isn't actually needed, since the track changed event will set it if needed. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20786 a1c6a512-1295-4272-9138-f99709370657
 2009-04-25 19:23:40 +00:00
Jonathan Gordon
0eb5dc649f beginings of a working touchscreen interface for the WPS. 2 new tags: 
%T|x|y|width|height|action| <- setup a region (relative to the current viewport) where if pressed the "action" will be done (currently play/stop/prev/next/menu/browse work, suggestions for others to add and better names welcome)
%Tl<timeout> <- used as a conditional to say if the touchscreen was touched in the last <timeout>, use this to enable/disable button viewports or something... same syntax as other timeout tags

cabbiev2 for the mr500 has been modified to demonstrate the new tags. press the pause/play button to pause playback. press the rockbox logo to get back to the menu. pretty icons needed to make this more usable :)



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20753 a1c6a512-1295-4272-9138-f99709370657
 2009-04-20 01:41:56 +00:00
Thomas Martitz
ec7a0c5676 Fix caption backlight. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20708 a1c6a512-1295-4272-9138-f99709370657
 2009-04-14 22:13:29 +00:00
Thomas Martitz
725733ca92 Fix remote wps updating (again, FS#10121). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20693 a1c6a512-1295-4272-9138-f99709370657
 2009-04-12 00:30:28 +00:00
Jens Arnold
fbe39975cf Slightly more compact boundary check. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20691 a1c6a512-1295-4272-9138-f99709370657
 2009-04-11 23:07:02 +00:00
Karl Kurbjun
76328bbfda Fix the scrollbar boundary checking to prevent the player from freezing on screens that are too small to show the list with the font selected. Correct the M:Robe remote screen height. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20690 a1c6a512-1295-4272-9138-f99709370657
 2009-04-11 22:22:44 +00:00