Peter D'Hoye
4af5dd84a2
fix red
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17859 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 21:02:43 +00:00
Peter D'Hoye
205f3df781
Remove a viewport ambiguity by changing the screens width/heigth members into lcdwidth/lcdheight. Normal usercode should always use getwidth()/getheigth() as that returns the viewport width/height. Fixes issues that would have appeared in many places when introducing viewports with sizes != lcd sizes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17857 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 20:45:21 +00:00
Daniel Stenberg
2acc0ac542
Updated our source code header to explicitly mention that we are GPL v2 or
...
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 18:10:04 +00:00
Peter D'Hoye
90b616913b
Peakmeters: use screens[].getwidth() and not screens[].width as the latter one returns the LCD width (which really shouldn't be there) - the former returns the width of the viewport. Do some code police as well.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17841 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 16:59:56 +00:00
Peter D'Hoye
db00c568c9
Fix broken peakmeters: peakmeter was using viewport drawing code but absolute screen coordinates for display updating. To Do: peakmeter must completely use viewport info for its updates.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17838 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 16:31:06 +00:00
Jens Arnold
3867cf9181
Use the flash disk icon on all flash sttorage targets instead just on the Ondio. Pointed out by Llorean.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17812 a1c6a512-1295-4272-9138-f99709370657
2008-06-27 21:40:06 +00:00
Jonathan Gordon
bdbdb97f19
FS#9051 - remove LCD margins... use viewports if you need them...
...
NOTE to WPS people....
%m has been removed, but (i think) because of the other %m tags it wont fail if you try loading a wps with %m|..|, it will just be ignored.
Also note that if the statusbar is enabled the default viewport is 8 pixels shorter than when its not, i.e (0,0) is really (0,8) if the statusbar is shown... I dont think this will be a major issue because almost no WPS show the bar and use bitmaps... text only WPS shouldnt be affected.
Please report problem screens in http://forums.rockbox.org/index.php?topic=17358.0
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17763 a1c6a512-1295-4272-9138-f99709370657
2008-06-23 13:20:35 +00:00
Peter D'Hoye
f76122f0e7
Accept FS #9052 by Alexander Levin with a fix by me. Changes HAS_BUTTONBAR into HAVE_BUTTONBAR to bring it in line with the other defines
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17655 a1c6a512-1295-4272-9138-f99709370657
2008-05-29 20:32:39 +00:00
Jonathan Gordon
0501fb016c
total removal of gui_textarea. The only thing using the text_message struct is the yesno screen so move its definition to yesno.h
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17653 a1c6a512-1295-4272-9138-f99709370657
2008-05-29 11:13:46 +00:00
Jonathan Gordon
43f0770943
move the HAS_BUTTONBAR define to the config-<target>.h files
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17652 a1c6a512-1295-4272-9138-f99709370657
2008-05-29 09:14:32 +00:00
Jonathan Gordon
ff469ab573
Updated recording trigger screen (seems to be a feature almost noone uses?)
...
problems/complaints in http://forums.rockbox.org/index.php?topic=16837.0
there is a known issue that on this screen the stop icon wont update, I dont know why and noone else wants to look at it, so hopefully this will force another set of eyes on it.. this is only a graphical issue... recordings still work fine
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17643 a1c6a512-1295-4272-9138-f99709370657
2008-05-28 10:55:39 +00:00
Peter D'Hoye
9098112869
Fix red
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17532 a1c6a512-1295-4272-9138-f99709370657
2008-05-15 23:00:33 +00:00
Peter D'Hoye
a3524029bf
Accept FS #8994 : add another recording filesplit option: stop recording and shutdown
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17531 a1c6a512-1295-4272-9138-f99709370657
2008-05-15 22:47:07 +00:00
Bertrik Sikken
19425909c3
Another round of making local functions static and making sure that source files are in sync with their header files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17337 a1c6a512-1295-4272-9138-f99709370657
2008-05-03 21:33:00 +00:00
Bertrik Sikken
e15f8a21a9
Made source files #include the header file that they implement to make sure they are in sync. Made some local functions static.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17312 a1c6a512-1295-4272-9138-f99709370657
2008-05-03 08:35:14 +00:00
Bertrik Sikken
2843469876
Moved atoi declaration to stdlib.h. Deleted atoi.h
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17280 a1c6a512-1295-4272-9138-f99709370657
2008-04-28 16:18:04 +00:00
Nils Wallménius
33c44461e1
Const police raid, making a lot of pointers to lang strings const and removing some ugly casting
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17251 a1c6a512-1295-4272-9138-f99709370657
2008-04-26 09:30:24 +00:00
Bertrik Sikken
db2d61f4ea
Killed unnecessary global variables by making them static.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17184 a1c6a512-1295-4272-9138-f99709370657
2008-04-20 10:24:15 +00:00
Magnus Holmgren
79fb077933
When looking for album art in /.rockbox/albumart/, use album artist rather than artist, if available.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17171 a1c6a512-1295-4272-9138-f99709370657
2008-04-19 15:21:09 +00:00
Nils Wallménius
a01996436d
Use file_exists and dir_exists functions where appropriate, fix one wrong file descriptor check and one possible dir descriptor leak
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17147 a1c6a512-1295-4272-9138-f99709370657
2008-04-16 19:51:43 +00:00
Nils Wallménius
6848961aa5
Pass the buffer length to the list_get_name callback functions instead of using hardcoded MAX_PATH
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17049 a1c6a512-1295-4272-9138-f99709370657
2008-04-09 15:25:17 +00:00
Steve Bavin
799e9489ca
Remove some more simulator debugging output.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17019 a1c6a512-1295-4272-9138-f99709370657
2008-04-07 17:19:53 +00:00
Dave Chapman
78d29f535f
Major cleanup of checkwps - fix all warnings and add a script to build versions for all supported targets (plus some unsupported ones). You now need to run the version of checkwps that matches the device your WPS is for.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16831 a1c6a512-1295-4272-9138-f99709370657
2008-03-26 23:35:34 +00:00
Dave Chapman
b9bb723f12
1) Make Rockbox reject any WPSs if there are errors loading any of the required bmps; 2) Make checkwps actually load the images using the Rockbox bmp loader, and reject the WPS in the same was as Rockbox on bmp errors.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16822 a1c6a512-1295-4272-9138-f99709370657
2008-03-26 18:18:22 +00:00
Jonathan Gordon
5ca1539969
the menu and list now accepts a parent viewport to draw in (and the menu can be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
2008-03-26 03:35:24 +00:00
Dave Chapman
d02c79c03f
Commit viewports-in-WPS patch (FS#8385). This adds the %V tag - see the CustomWPS page for details (shortly...). There is still some work to do - decide how to handle font references, decide how to handle conditionals. Plus checkwps is broken - I'll fix that in a separate commit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16733 a1c6a512-1295-4272-9138-f99709370657
2008-03-21 19:38:00 +00:00
Jens Arnold
8113717da9
Fix BMP loader for the iAudio M3 display.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16722 a1c6a512-1295-4272-9138-f99709370657
2008-03-20 17:40:58 +00:00
Jens Arnold
76614b3687
Make vkeyboard usable on M3.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16709 a1c6a512-1295-4272-9138-f99709370657
2008-03-18 22:59:39 +00:00
Peter D'Hoye
9c3f6c4079
Simplify that clip indicator reset code a bit
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16559 a1c6a512-1295-4272-9138-f99709370657
2008-03-08 20:32:37 +00:00
Peter D'Hoye
30ab1a3c0e
Reset recording clipping indicators when changing gain. Solves FS #6147
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16557 a1c6a512-1295-4272-9138-f99709370657
2008-03-08 17:43:04 +00:00
Peter D'Hoye
0ecdb37e99
Fix FS #8514 (remote peakmeter issue) by separating the peak release times for the screens. Thanks to amiconn for pointing in the right direction.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16234 a1c6a512-1295-4272-9138-f99709370657
2008-02-06 21:53:07 +00:00
Magnus Holmgren
2235081dbc
Prevent possible buffer overflow when locating album art.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16231 a1c6a512-1295-4272-9138-f99709370657
2008-02-06 19:51:19 +00:00
Nicolas Pennequin
cfe51b0cd1
Add a couple safety checks in search_albumart_files(). Should fix the sliding_puzzle crashes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16225 a1c6a512-1295-4272-9138-f99709370657
2008-02-05 11:56:21 +00:00
Jonas Häggqvist
2cffb1bf3d
Look for albumart in .rockbox/albumart/<artist>-<album><size>.bmp in addition to the current locations.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16110 a1c6a512-1295-4272-9138-f99709370657
2008-01-19 18:05:06 +00:00
Nicolas Pennequin
536b5a0482
Accept FS#8469 by Bryan Childs with a few adjustments: Remove duplicate strip_extension() function from albumart.c. The other one is moved from tree.c to misc.c.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16103 a1c6a512-1295-4272-9138-f99709370657
2008-01-18 10:02:03 +00:00
Jonathan Gordon
4d238c14d7
bandaid fix for FS#8168 - statusbar would be enabled if poweroff happened while in fm screen. a proper fix is to not force the statusbar on in the fm screen, but untill that happens this is fine.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16044 a1c6a512-1295-4272-9138-f99709370657
2008-01-10 06:46:04 +00:00
Peter D'Hoye
db1e12bac0
Quick fix to prevent freezing of H10 (possibly others too) when left at the disk full message. Needs more investigation to find the cause of the freeze.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15938 a1c6a512-1295-4272-9138-f99709370657
2007-12-15 23:51:13 +00:00
Nicolas Pennequin
90ce826903
Initial commit of the PictureFlow plugin, a nice visualization for album covers.
...
Original code by Ariya Hidayat. Rockbox port by Jonas Hurrelmann and a few tweaks by me.
On the first startup the database is scanned and album art is searched for each album. This process will take some time (dircache enabled and/or database in RAM speed it up, and it is possible to abort by pressing MENU), but the results are cached and the next startups will be very quick.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15900 a1c6a512-1295-4272-9138-f99709370657
2007-12-09 18:48:02 +00:00
Peter D'Hoye
05007e1a79
More code police
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15890 a1c6a512-1295-4272-9138-f99709370657
2007-12-07 00:31:31 +00:00
Peter D'Hoye
327d78eb6e
Code police
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15889 a1c6a512-1295-4272-9138-f99709370657
2007-12-07 00:28:16 +00:00
Peter D'Hoye
a007b558b3
Fix gradient selection bar in recording screen
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15888 a1c6a512-1295-4272-9138-f99709370657
2007-12-07 00:07:30 +00:00
Jens Arnold
89bfb66939
BMP loader: Handle top-down BMP files (height is negative). Note that the e200 example pictures still don't work, as they are larger than the screen (not a loader problem).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15855 a1c6a512-1295-4272-9138-f99709370657
2007-11-30 08:51:18 +00:00
Michael Sevakis
b0dd9eb5bc
Repair the no-spinup on start/split feature of recording. Recording directory selection broke it. Please only look at the disk during encoder loading opportunities in future additions.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15853 a1c6a512-1295-4272-9138-f99709370657
2007-11-30 05:14:57 +00:00
Linus Nielsen Feltzing
236cdaee03
Make the recording screen handle button repeats correctly when changing gain. Fixes FS#8038.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15811 a1c6a512-1295-4272-9138-f99709370657
2007-11-26 11:51:39 +00:00
Nils Wallménius
e711de2974
Make the variable for numbers of screens to update const on non-remote-lcd targets.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15806 a1c6a512-1295-4272-9138-f99709370657
2007-11-25 21:47:16 +00:00
Robert Kukla
ed64a663a0
make check_dir use dir_exists and slightly optimise the latter
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15744 a1c6a512-1295-4272-9138-f99709370657
2007-11-21 22:42:52 +00:00
Robert Kukla
d87b037efe
consolidate the 3 file_exists() functions into one; use the version that explicitly uses dircache; give dir_exists() the same treatment for consistency
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15742 a1c6a512-1295-4272-9138-f99709370657
2007-11-21 21:28:27 +00:00
Michael Sevakis
fadbf0a6f7
Make threads responsible for explicit cancellation of their own boosted status. Sleeping and timeouts will no longer cancel it.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15709 a1c6a512-1295-4272-9138-f99709370657
2007-11-20 03:44:25 +00:00
Magnus Holmgren
7aa4ae6e45
Improved use of album name when locating the album art file: replace chars that are invalid in file names; double quotes to single quotes, other invalid chars to underscore (now only very long album names could cause a problem). Also removed some unecessary code and reduced stack usage a bit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15630 a1c6a512-1295-4272-9138-f99709370657
2007-11-15 20:22:03 +00:00
Nicolas Pennequin
1480d078e7
Add an error check, just to be safe.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15596 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 14:26:47 +00:00