Commit graph

30 commits

Author SHA1 Message Date
William Wilgus
3745c813f9 misc.c open_pathfmt caller supplied buffer
Amachronic raised concern about open() blocking causing a static buf
to get overwritten in multiple calls its prudent to just have the caller
supply the buffer to minimize stack issues later

Change-Id: Iae27c7d063adb1a65688f920f6aa5c395fa5694a
2022-11-23 22:09:46 -05:00
William Wilgus
e7e20fab1b create function open_pathfmt() to allow printf formatting on open()
save some space by allowing printf formatting directly rather than
having a buffer and using sprintf

Change-Id: I049c8f898fb4a68a26ad0f0646250c242647ba12
2022-11-19 23:13:42 -05:00
Solomon Peachy
658026e626 [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice.
Note:  I left behind lcd_bitmap in features.txt, because removing it
would require considerable work in the manual and the translations.

Change-Id: Ia8ca7761f610d9332a0d22a7d189775fb15ec88a
2020-07-24 21:20:13 +00:00
Solomon Peachy
0c4f89370d [2/4] get rid of HAVE_LCD_CHARCELLS
HAVE_LCD_BITMAP is now redundant.

lcd_bitmap is always-on in features.txt so manual and lang strings
don't have to change

Change-Id: I08eeb20de48099ffc2dc23782711af368c2ec794
2020-07-24 21:20:13 +00:00
Solomon Peachy
8fc5e33ae1 FS#9788: Include timestamp in logf filename (Yoshihisa Uchida)
For example, logf_202007071157.txt

Change-Id: Ia50c0ca67772e3d26b49dd8e1a3519816e5211c6
2020-07-07 15:58:51 +00:00
Mihail Zenkov
e599810ffa Don't add new message to logf when we dump it to file
Fix log file corruption if we have new messages at dumping log to file. Comment
removed as it incorrect. We store all messages in direct order (last message at
end of file).

Change-Id: I4acfa8a0935cc41a889e08f6bc42974fefd1ade2
2016-04-04 11:07:44 +02:00
Jeffrey Goode
13b8e3d66d Remove last traces of sprintf.h
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25864 a1c6a512-1295-4272-9138-f99709370657
2010-05-07 02:13:47 +00:00
Thomas Martitz
0a1d7c28b7 Make open() posix compliant api-wise. A few calls (those with O_CREAT) need the additional optional mode parameter so add it. Impact for the core is almost zero, as open() is a wrapper macro for the real open function which doesn't take the variable parameter.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25844 a1c6a512-1295-4272-9138-f99709370657
2010-05-06 17:35:13 +00:00
Jeffrey Goode
e5c2d94171 Prettify debug menu for logf
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23717 a1c6a512-1295-4272-9138-f99709370657
2009-11-23 00:19:22 +00:00
Maurus Cuelenaere
20b0dd2788 A new implementation of logf, logfdisplay and logfdump.
Flyspray: FS#10528
Author: Amaury Pouly


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22462 a1c6a512-1295-4272-9138-f99709370657
2009-08-21 22:54:23 +00:00
Rafaël Carré
9a5174c8a3 Fix logf() multilines handling
Each line (of MAX_LOGF_ENTRY characters) would be marked with
LOGF_TERMINATE_CONTINUE_LINE, but still be padded with a '\0'

This also reverts r22250 which worked around the problem in logfdump()

Flyspray: FS#10513
Author: Amaury Pouly

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22253 a1c6a512-1295-4272-9138-f99709370657
2009-08-11 16:12:03 +00:00
Rafaël Carré
0773ece459 Fix logfdump multilines handling
Flyspray: FS#10509
Author: amaury pouly

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22250 a1c6a512-1295-4272-9138-f99709370657
2009-08-11 12:22:03 +00:00
Maurus Cuelenaere
19fde6c0c0 Logf display: add ability to scroll through messages
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20743 a1c6a512-1295-4272-9138-f99709370657
2009-04-19 15:48:26 +00:00
Maurus Cuelenaere
4c793febc8 Commit FS#9733 (multiline logf) by Yoshihisa Uchida
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19625 a1c6a512-1295-4272-9138-f99709370657
2008-12-31 17:01:00 +00:00
Daniel Stenberg
2acc0ac542 Updated our source code header to explicitly mention that we are GPL v2 or
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 18:10:04 +00:00
Jonathan Gordon
bdbdb97f19 FS#9051 - remove LCD margins... use viewports if you need them...
NOTE to WPS people....
%m has been removed, but (i think) because of the other %m tags it wont fail if you try loading a wps with %m|..|, it will just be ignored.
Also note that if the statusbar is enabled the default viewport is 8 pixels shorter than when its not, i.e (0,0) is really (0,8) if the statusbar is shown... I dont think this will be a major issue because almost no WPS show the bar and use bitmaps... text only WPS shouldnt be affected.

Please report problem screens in http://forums.rockbox.org/index.php?topic=17358.0


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17763 a1c6a512-1295-4272-9138-f99709370657
2008-06-23 13:20:35 +00:00
Bertrik Sikken
a5d3029c82 Update source files to include the header file for the functions they implement, to make sure the header and the implementation is consistent (and fix it for a case where it wasn't).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17275 a1c6a512-1295-4272-9138-f99709370657
2008-04-28 10:22:05 +00:00
Barry Wardell
d727f5d936 Make logf builds compile again since the clean up of hard-coded paths
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14665 a1c6a512-1295-4272-9138-f99709370657
2007-09-10 19:29:53 +00:00
Nils Wallménius
04b3435afd Clean up hard-coded paths
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14662 a1c6a512-1295-4272-9138-f99709370657
2007-09-10 09:46:36 +00:00
Linus Nielsen Feltzing
224c0a13eb Finally, the new button action system is here, thanks to Jonathan Gordon. Some button mappings have changed and other things may break. Comments should go to the forum, http://forums.rockbox.org/index.php?topic=5829.0 or the mailing list.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10582 a1c6a512-1295-4272-9138-f99709370657
2006-08-15 12:27:07 +00:00
Dave Chapman
19f8ae7609 Patch #5678 from Daniel Ankers - add ipod 3G button definitions to the logf viewer
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10234 a1c6a512-1295-4272-9138-f99709370657
2006-07-18 16:03:36 +00:00
Brandon Low
16ee4160d6 Make logf not be a dumb wrapper
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9626 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 22:19:47 +00:00
Christian Gmeiner
7446714e11 x5: we dont have a BUTTON_OFF -> we use BUTTON_POWER now
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9204 a1c6a512-1295-4272-9138-f99709370657
2006-03-23 13:47:48 +00:00
Dave Chapman
1a4ef4fc0a Add iPod key binding for the logf viewer
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8494 a1c6a512-1295-4272-9138-f99709370657
2006-01-30 21:12:27 +00:00
Michiel Van Der Kolk
65ff219e8e better logf stuff..
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6948 a1c6a512-1295-4272-9138-f99709370657
2005-06-30 15:14:08 +00:00
Jens Arnold
f40175c8dc Truncate logfile on open.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6556 a1c6a512-1295-4272-9138-f99709370657
2005-06-04 08:16:57 +00:00
Daniel Stenberg
6ebdbe8df3 Modified logf to use a define for the log width, and changed it to default to
21 as that is what fits in an iriver LCD by default since the font is 6 pixels
wide.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6547 a1c6a512-1295-4272-9138-f99709370657
2005-06-01 13:21:20 +00:00
Daniel Stenberg
c95319f6fd Added logfdump - that writes the internal logf log to .rockbox/logf.txt
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6545 a1c6a512-1295-4272-9138-f99709370657
2005-06-01 13:07:37 +00:00
Daniel Stenberg
edc07922eb (Optional) logf support
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6538 a1c6a512-1295-4272-9138-f99709370657
2005-05-30 13:00:43 +00:00
Daniel Stenberg
e2c4a6c642 initial take at logf log browser
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6519 a1c6a512-1295-4272-9138-f99709370657
2005-05-24 14:26:23 +00:00