Thomas Martitz
144df92bfb
Android: Rewrite lcd subsystem to use the SurfaceView API.
...
That enables drawing from outside the apps UI thread, i.e. from within the Rockbox native thread, without needing synchronization means, and adds determinism as to when the draw happens.
It simplifies the drawing routines and adds a convinient way of detecting whether drawing should happen or not (surfaceCreated/Destroyed).
It also restores max. fps on my phone which went down drastically with the gingerbread(CM7) update.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29333 a1c6a512-1295-4272-9138-f99709370657
2011-02-19 01:13:38 +00:00
Thomas Martitz
8bc2801e7c
Fix red caused by incorrect includes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29329 a1c6a512-1295-4272-9138-f99709370657
2011-02-18 23:29:11 +00:00
Thomas Martitz
1e391fbdbc
Fix yellows and checkwps.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29328 a1c6a512-1295-4272-9138-f99709370657
2011-02-18 23:17:07 +00:00
Thomas Jarosch
3926c30705
Make sure we don't read past the end of a C-string in format_track_path. Second part of FS #11947
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29326 a1c6a512-1295-4272-9138-f99709370657
2011-02-18 21:56:48 +00:00
Thomas Jarosch
15a5f9ca95
Don't underflow the buffer in format_track_path() if it consists of whitespaces
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29325 a1c6a512-1295-4272-9138-f99709370657
2011-02-18 21:39:59 +00:00
Thomas Jarosch
84fccff170
Fix off-by-one buffer read access in format_track_path(). Part of #11947
...
We need to check for "i < max" first.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29324 a1c6a512-1295-4272-9138-f99709370657
2011-02-18 21:21:50 +00:00
Andree Buschmann
ae32e1ef06
Ensure proper initialization of some variables and arrays in metadata parsing. Fixes FS#11948.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29323 a1c6a512-1295-4272-9138-f99709370657
2011-02-17 18:35:24 +00:00
Alessio Lenzi
b5cf163f5a
Updated italian translation
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29322 a1c6a512-1295-4272-9138-f99709370657
2011-02-16 22:33:33 +00:00
Thomas Jarosch
a0a411aef6
Use 35-Adobe-Helvetica as default font on maemo. 27-Adobe-Helvetica is too small
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29321 a1c6a512-1295-4272-9138-f99709370657
2011-02-16 19:06:39 +00:00
Thomas Jarosch
29e4a2d90d
Fix buffer size used for realpath() call
...
Thanks to kugel for pointing this out.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29320 a1c6a512-1295-4272-9138-f99709370657
2011-02-16 18:40:44 +00:00
Magnus Holmgren
efba46f980
FS#11933: Check for external album art if embedded album art fails to load.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29319 a1c6a512-1295-4272-9138-f99709370657
2011-02-16 18:06:50 +00:00
Thomas Jarosch
1dbea9d959
No need to cast away const. Thanks to sideral
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29318 a1c6a512-1295-4272-9138-f99709370657
2011-02-16 17:58:57 +00:00
Thomas Jarosch
0060fed451
RaaA: Fix tagcache filename lookups for paths containing symbolic links
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29317 a1c6a512-1295-4272-9138-f99709370657
2011-02-16 01:01:49 +00:00
Thomas Jarosch
3ced180f5d
Treat unknown RaaA platforms like SDL for last.FM scrobbler log file. Fix yellow
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29315 a1c6a512-1295-4272-9138-f99709370657
2011-02-15 21:32:53 +00:00
Thomas Jarosch
81614c428c
RaaA: Fix last.FM scrobbler log file location
...
The .scrobbler.log or .scrobbler-timeless.log file
resides in the USB mass storage area. The exact location
differs for every RaaA platform.
The SDL platform sticks it in ROCKBOX_DIR for now.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29314 a1c6a512-1295-4272-9138-f99709370657
2011-02-15 21:13:03 +00:00
Andree Buschmann
2f3ab5fa22
Correct the metadata's VBR flag for MP4 files. ALAC is native VBR, AAC very unlikely is CBR. The VBR flag is used by several WPS.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29313 a1c6a512-1295-4272-9138-f99709370657
2011-02-15 20:59:22 +00:00
Andree Buschmann
526bee6266
2nd try: All AAC-HE files will double the frame sample count, not only AAC-HE files with SBR upsampling. This change fixes issues with some m4a files reported in the forums.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29312 a1c6a512-1295-4272-9138-f99709370657
2011-02-15 20:26:04 +00:00
Andree Buschmann
e3abdb1a52
Undo unwanted commit r29310.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29311 a1c6a512-1295-4272-9138-f99709370657
2011-02-15 20:10:50 +00:00
Andree Buschmann
237ca504e1
All AAC-HE files will double the frame sample count, not only AAC-HE files with SBR upsampling. This change fixes issues with some m4a files reported in the forums.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29310 a1c6a512-1295-4272-9138-f99709370657
2011-02-15 20:00:28 +00:00
Thomas Jarosch
258626f455
Fix the shutdown sequence for maemo, SDL and simulator builds
...
Do proper shutdown in RaaA builds like writeout of
last.FM scrobbler file and other neat things.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29309 a1c6a512-1295-4272-9138-f99709370657
2011-02-15 19:43:04 +00:00
Magnus Holmgren
1f85259ef1
Update Swedish translation.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29308 a1c6a512-1295-4272-9138-f99709370657
2011-02-14 20:41:50 +00:00
Mustapha Senhaji
6fee581b09
Czech language: Some minor terminology changes by Marek Salaba FS#11935
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29307 a1c6a512-1295-4272-9138-f99709370657
2011-02-14 17:20:52 +00:00
Mustapha Senhaji
b63422d62e
Some languages updates for the upcoming release:
...
-Spanish by Francisco Vila FS#11936
-French by Jean-Marie Moraux FS#11940
-Serbian by Ivan Pesic FS#11941
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29306 a1c6a512-1295-4272-9138-f99709370657
2011-02-14 17:15:57 +00:00
Michael Sevakis
b15aa47c56
All kernel objects in code shared amongs targets (core, plugins, codecs) should be declared SHAREDBSS_ATTR as any core could potentially touch them even though they seem only to involve threads on one core. The exception is target code for particular CPUs where proper allocation is fixed. playlist.c was a little odd too-- use one mutex for the current playlist and a separate one for created playlists (still pondering the necessity of more than one).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29305 a1c6a512-1295-4272-9138-f99709370657
2011-02-14 11:27:45 +00:00
Michael Sevakis
8f14357064
Code police buffering.c a little - use already predominant style - shorted lines over 80 cols.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29304 a1c6a512-1295-4272-9138-f99709370657
2011-02-14 09:18:58 +00:00
Michael Sevakis
6938255b6b
Buffering: tin cup. Update threading structure and handle rebuffer more reliably on buffer thread using a single message send.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29303 a1c6a512-1295-4272-9138-f99709370657
2011-02-14 08:36:29 +00:00
Michael Sevakis
0fde635fb0
Leave a gap between all handles because ringbuf_add_cross interprets equal pointers as empty, corruption guard check could fail to detect overlap if buffering ran right up to the next handle and it gets asked to buffer again before freeing the following handles (adds a byte on average). Storage alignment on handle reset must at times avoid alignment increments if after a stopped rebuffer, the handle was shrunk too close to the next one or the reading position in a prior rebuffer.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29302 a1c6a512-1295-4272-9138-f99709370657
2011-02-14 02:14:26 +00:00
Alex Parker
f8a4fbc843
FS#11937 by Marcin Bukat - update Polish translation.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29301 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 21:42:32 +00:00
Andree Buschmann
c0b0cd5905
Do not fiddle with audiobuf in talk_init() when no voice file is present. Avoids stopping of audio playback when changing languages without using voice files. Closes FS#10479.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29300 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 21:30:13 +00:00
Andree Buschmann
46dbe3036c
Explicitly say 'minutes' when speaking the runtime, fixes FS#11934.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29299 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 19:14:43 +00:00
Andree Buschmann
f7c6034728
Update german translation.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29298 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 17:49:24 +00:00
Nils Wallménius
4ca36ca90c
Explicitely say 'minutes' when speaking the battery time, fixes FS#11932.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29297 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 16:02:17 +00:00
Michael Sevakis
efdf49668e
Needed to do a few more things to have r29291 correct.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29294 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 11:02:37 +00:00
Alex Parker
78a71d4701
FS#11928 by Marek Salaba - Update of Czech language
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29293 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 10:46:48 +00:00
Alex Parker
0c9e0dfeea
FS#11929 by Gabriel Maia - Portuguese translation update.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29292 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 10:46:43 +00:00
Michael Sevakis
b474d0d98f
Change add_handle to never have side effects on the buffer if it fails. It actually seems ok and I'm not sure if's responsible for anything, but it's more sane and keeps buffer_handle from regressing buf_widx later if buffering cur_handle.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29291 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 10:44:13 +00:00
Michael Sevakis
50c727ce7a
Oops. Put back some changes to go only with others.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29289 a1c6a512-1295-4272-9138-f99709370657
2011-02-12 12:33:43 +00:00
Michael Sevakis
3c81bf0c13
Fix move_handle in buffering. Calculating wraps by buffer_len - 1 is incorrect. Switch handle movement to memmove calls exclusively.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29288 a1c6a512-1295-4272-9138-f99709370657
2011-02-12 12:18:09 +00:00
Andree Buschmann
3f377e568e
Use menu layout for sleep timer that is consistent to other timers. Closes FS#11923.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29283 a1c6a512-1295-4272-9138-f99709370657
2011-02-11 16:15:11 +00:00
Frank Gevaerts
4421cfedf0
Make sure there is a logo for LCD_WIDTH>480 && LCDWIDTH<600 (useful for 600x1024 LCDs)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29281 a1c6a512-1295-4272-9138-f99709370657
2011-02-11 11:28:21 +00:00
Michael Hohmuth
a5303765ec
autoresume: Match full directory path names only in autoresumable()
...
Removed genre-tag matching (considered too fragile for real-world use).
Removed substring matching for file names. To avoid unintended
matches, the search pattern now must match the file's full dir name
(or a parent directory thereof), anchored in the root directory.
Search strings now must be delimited with ":" rather than ",". The
default list of directories is "/podcast:/podcasts" (case-insensitive).
Made implementation somewhat more efficient (don't use strtok -> no
need to copy the string to private storage (stack) before tokenizing
it).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29280 a1c6a512-1295-4272-9138-f99709370657
2011-02-11 00:20:03 +00:00
Michael Sevakis
bdec638b9b
Always do proper mp3entry copying instead of using bufread directly. Add bufreadid3() helper.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29279 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 22:03:39 +00:00
Alexander Levin
82a8ad643a
Fix a couple of typos in the comment in english.lang. Whether the comment is correct is another question which is not the subject of this commit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29278 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 20:55:39 +00:00
Andree Buschmann
57ca48458f
Fix test plugin build.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29277 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 20:20:12 +00:00
Michael Sevakis
edfff8a5ef
audio_peek_track should copy the struct mp3entry instead of pointing directly into the buffer. Despite the dire warning, caller does in fact yield/sleep and its usage is too nonlocalized to control that reliably.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29275 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 10:26:07 +00:00
Michael Hohmuth
e93713ba3c
autoresume: Simplify configuration option for resume on automatic
...
track change
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29271 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 09:37:58 +00:00
Michael Sevakis
88d91faba5
buffering: Don't execute move-handle-ony case if handle is of metadata type (atomic) and must be kept fully buffered. Manage handle corruption guard and handle buffering with one set of logic which allows reading of the maximum amount of data without overflow. 'FIXME' regarding handle corruption guard is really part of expected operation when thread that does the handle closing hasn't yet performed the delegated task before rebuffering starts.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29270 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 05:56:21 +00:00
Thomas Martitz
bf1ca7041e
Hopefully all green now
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29263 a1c6a512-1295-4272-9138-f99709370657
2011-02-09 20:51:11 +00:00
Thomas Martitz
c64e5e675a
Fix remaining reds.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29262 a1c6a512-1295-4272-9138-f99709370657
2011-02-09 20:38:36 +00:00
Thomas Martitz
86cab2e27a
Disable buffering codecs (and code generally) on RaaA.
...
It's not useful to do it since you need to write back the code to disk to be able to load it from memory, it also requires writing to an executable directory.
Keep it for the simulator for the sake of simulating.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29261 a1c6a512-1295-4272-9138-f99709370657
2011-02-09 20:27:23 +00:00