Commit graph

205 commits

Author SHA1 Message Date
Torne Wuff
f018fbbe18 id3 parser: add id3v2.2 TPA tag for "part of set" as iTunes appears to use it
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28181 a1c6a512-1295-4272-9138-f99709370657
2010-09-28 19:39:35 +00:00
Rafaël Carré
7c339c937a parse_sap_header(): remove write-only variable
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28132 a1c6a512-1295-4272-9138-f99709370657
2010-09-21 08:25:46 +00:00
Rafaël Carré
37c1192753 ASAP parse_sap_header() : remove write only variables
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28111 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:16:56 +00:00
Rafaël Carré
f03141477a setid3v2title(): unused variable
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28110 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:16:52 +00:00
Michael Giacomelli
f63570ace5 Add uppercase M4A file type to the mp4 parser. Technically Apple says to use lowercase, but various programs tolerate this, so we can too. Fixes FS#11536.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27805 a1c6a512-1295-4272-9138-f99709370657
2010-08-14 01:09:46 +00:00
Mohamed Tarek
4ff2cf4f0c WMA Voice now plays and seeks in the sim. The code is still in floating point, and is not added to the main build. There's still a bug with the decoder in the current state that it outputs a fewer number of samples than ffmpeg's.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27744 a1c6a512-1295-4272-9138-f99709370657
2010-08-07 17:55:02 +00:00
Rafaël Carré
53b5abd93c aiff metadata: fix format string (%zd for size_t)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27572 a1c6a512-1295-4272-9138-f99709370657
2010-07-26 09:04:38 +00:00
Rafaël Carré
cb86bc7e92 aiff metadata: skip chunks larger than buffer
Also use a stack temporary buffer bigger than id3->path

Fix FS#11494 which uses a (unparsed) 410 bytes comment chunk

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27570 a1c6a512-1295-4272-9138-f99709370657
2010-07-26 08:59:17 +00:00
Michael Giacomelli
33df565584 Commit FS#7831. Corrects our flac decoder to not reject files that have samplecount set to 0.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27244 a1c6a512-1295-4272-9138-f99709370657
2010-07-02 18:39:11 +00:00
Mohamed Tarek
816fca820c Wrote apps/codecs/wmapro.c and modified libwmapro to make the codec work in the sim. Neither libwmapro nor wmapro.c have been added to the main build yet, codecs.make should be edited to compile both with rockbox.
current status of the decoder :
- Plays and seeks in the sim
- Still in floating point

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27006 a1c6a512-1295-4272-9138-f99709370657
2010-06-21 10:48:34 +00:00
Frank Gevaerts
3763ace3ec Revert r26048. APE tags in mp3 is explicitely on http://www.rockbox.org/wiki/NoDo
This sort of change should never go in without prior discussion or consensus


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26071 a1c6a512-1295-4272-9138-f99709370657
2010-05-15 21:57:17 +00:00
Yoshihisa Uchida
fecf90fda9 mp3: when ID3 tags are not found, search APE tags
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26048 a1c6a512-1295-4272-9138-f99709370657
2010-05-15 10:20:06 +00:00
Yoshihisa Uchida
3c74d20462 fix yellow
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26046 a1c6a512-1295-4272-9138-f99709370657
2010-05-15 09:24:38 +00:00
Yoshihisa Uchida
7a6a8c64fe ID3 tags parser separates from metadata/mp3.c
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26044 a1c6a512-1295-4272-9138-f99709370657
2010-05-15 09:15:24 +00:00
Yoshihisa Uchida
0f5c6d47d4 add True Audio (TTA) codec
decoding speed iPod video ~153%
But in some players, the decoding speed is not enough.
(e.g., H180 52.4% (thanks amiconn), H300 55.09% (thanks n1s))

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25994 a1c6a512-1295-4272-9138-f99709370657
2010-05-13 12:40:09 +00:00
Yoshihisa Uchida
90de864d89 chunksize decreases 4 bytes regardless wave/wave64.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25926 a1c6a512-1295-4272-9138-f99709370657
2010-05-10 11:13:17 +00:00
Mohamed Tarek
cd4d80aeba nomsg
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25922 a1c6a512-1295-4272-9138-f99709370657
2010-05-09 21:42:09 +00:00
Jeffrey Goode
a26a68d23c Fix wav metadata bug, also fix typos and some const police
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25919 a1c6a512-1295-4272-9138-f99709370657
2010-05-09 19:58:20 +00:00
Yoshihisa Uchida
20eb5f48e5 wave/wave64 LIST chunk parser
- logic simplify
 - tag data always ends by the '\0' terminate.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25911 a1c6a512-1295-4272-9138-f99709370657
2010-05-09 07:10:07 +00:00
Magnus Holmgren
fe29ad2edd Save some binsize.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25899 a1c6a512-1295-4272-9138-f99709370657
2010-05-08 13:21:27 +00:00
Yoshihisa Uchida
35808b70d5 wave/wave64: parse LIST chunk.
Then, title, artist, etc. (in LIST chunk data) are displayed.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25898 a1c6a512-1295-4272-9138-f99709370657
2010-05-08 12:15:15 +00:00
Thomas Martitz
50a6ca39ad Move c/h files implementing/defining standard library stuff into a new libc directory, also standard'ify some parts of the code base (almost entirely #include fixes).
This is to a) to cleanup firmware/common and firmware/include a bit, but also b) for Rockbox as an application which should use the host system's c library and headers, separating makes it easy to exclude our files from the build.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25850 a1c6a512-1295-4272-9138-f99709370657
2010-05-06 21:04:40 +00:00
Mohamed Tarek
7aaae54afc - Modify metadata/asf.c to use libasf.
- Modify the files in libwma to use libasf.
- Remove apps/codecs/libwma/asf.h since it's not used now.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25783 a1c6a512-1295-4272-9138-f99709370657
2010-05-02 18:27:01 +00:00
Yoshihisa Uchida
7a3822c8b0 fix bug: WAV file playback does not resume (FS#11077)
Not only WAV but also Sun audio, SMAF, vox and WAV64 can resume.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25289 a1c6a512-1295-4272-9138-f99709370657
2010-03-22 10:02:05 +00:00
Andree Buschmann
63f0b2b8e9 Correction of musepack SV8 replaygain. The album/title peak is saved in a logarithmic representation and needs to be converted to linear fixed point for further processing.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25187 a1c6a512-1295-4272-9138-f99709370657
2010-03-14 22:34:09 +00:00
Yoshihisa Uchida
2d1937a158 wave metadata parser reduces binsize.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25161 a1c6a512-1295-4272-9138-f99709370657
2010-03-14 05:41:02 +00:00
Yoshihisa Uchida
0996bbd278 corrects the smaf parser the following.
- It is normally retrieved even if the position of wave data is not in given position from the head.
- The problem that artist/title/composer cannot be given normally when the character code != iso8859-1, utf-8.
- The problem that the position of chunk does not given correctly some mmf files.
- artist/title/composer stored in not id3v1buf but id3v2buf.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25141 a1c6a512-1295-4272-9138-f99709370657
2010-03-13 05:53:54 +00:00
Yoshihisa Uchida
4446d1bc85 reduce firmware and sun audio codec.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25140 a1c6a512-1295-4272-9138-f99709370657
2010-03-13 05:19:40 +00:00
Andree Buschmann
2ac401f486 Make atrac3 streams in wav containers work again (error was introduced with r24782). Add additional info to atrac3 debug information.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25134 a1c6a512-1295-4272-9138-f99709370657
2010-03-12 18:47:13 +00:00
Yoshihisa Uchida
20f5a533ae Oops. forget static.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25107 a1c6a512-1295-4272-9138-f99709370657
2010-03-10 11:19:17 +00:00
Yoshihisa Uchida
207a84a381 unify the wave/wave64 parser.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25106 a1c6a512-1295-4272-9138-f99709370657
2010-03-10 10:55:01 +00:00
Andree Buschmann
56023837ae Fix musepack sv8 metadata parser. Thanks to Magnus Holmgren for spotting.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25076 a1c6a512-1295-4272-9138-f99709370657
2010-03-08 22:39:15 +00:00
Andree Buschmann
40c266532b Reduce binsize again.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25060 a1c6a512-1295-4272-9138-f99709370657
2010-03-07 20:55:37 +00:00
Andree Buschmann
b3d9578c27 Major change to musepack decoder: Import v1.3.0 (r458 from svn.musepack.net) to rockbox. Several adaptions in the musepack decoder were made to get the library work and perform fast under rockbox on several targets. With this change mpc sv8 is supported, including seek, replay gain and metadata support. The decoding speed is a 1-4% lower than the last implementation. Reason for this is main restructuring in the bitstream demuxer.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25056 a1c6a512-1295-4272-9138-f99709370657
2010-03-07 19:34:44 +00:00
Yoshihisa Uchida
66ebc35c55 Wave/Wave64/vox metadata parser: optimize just a little.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24992 a1c6a512-1295-4272-9138-f99709370657
2010-03-02 10:59:46 +00:00
Yoshihisa Uchida
f7533cceaa au metadata parser: optimize just a little.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24982 a1c6a512-1295-4272-9138-f99709370657
2010-03-01 10:37:52 +00:00
Nils Wallménius
d586fa1e7c Mark array as const
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24981 a1c6a512-1295-4272-9138-f99709370657
2010-03-01 08:41:57 +00:00
Maurus Cuelenaere
4dad0dd762 Reduce binsize by using unsigned char array instead of int in AU metadata parser.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24967 a1c6a512-1295-4272-9138-f99709370657
2010-02-28 12:45:32 +00:00
Yoshihisa Uchida
561cb2c401 Add wave64(.w64) codec (FS#11022)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24959 a1c6a512-1295-4272-9138-f99709370657
2010-02-28 08:48:07 +00:00
Yoshihisa Uchida
8c5eaa35ec Add vox (Dialogic telephony formats) codec add. (FS#11021)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24956 a1c6a512-1295-4272-9138-f99709370657
2010-02-28 08:13:30 +00:00
Yoshihisa Uchida
4e3c807466 Add Sun Audio codec. (FS#10433)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24955 a1c6a512-1295-4272-9138-f99709370657
2010-02-28 07:22:20 +00:00
Bertrik Sikken
9502021590 Add missing #include in libpcm codecs
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24887 a1c6a512-1295-4272-9138-f99709370657
2010-02-24 19:02:14 +00:00
Steve Bavin
c6e69cd886 Put the SMAF metadata buffer on the stack to save some memory. Only tested with one SMAF file, so please check if you have more.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24886 a1c6a512-1295-4272-9138-f99709370657
2010-02-24 17:20:39 +00:00
Yoshihisa Uchida
45e009a364 add SMAF codec (.mmf extension)(FS#10432)
This codec supports only wave data (ADPCM and PCM).
It does not support MIDI, picture, and movie.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24878 a1c6a512-1295-4272-9138-f99709370657
2010-02-24 11:46:29 +00:00
Yoshihisa Uchida
3716abba92 commit FS#10424 and FS#10425
- wav(RIFF) supports Microsoft ADPCM, Dialogic OKI ADPCM, YAMAHA ADPCM, Adobe SWF ADPCM.
- AIFF supports QuickTime IMA ADPCM.
- DVI ADPCM(IMA ADPCM) reworks.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24782 a1c6a512-1295-4272-9138-f99709370657
2010-02-20 02:04:56 +00:00
Mohamed Tarek
82f05895af Initial support for ATRAC3 streams in wav containers.
Current state :
- Playback and seeking are possible.
- We now support ATRAC3 in any of its possible containers (wav/at3, oma/aa3, and rm/ra).

TODO :
- Fix joint-stereo decoding for ATRAC3 - the decoder currently produces lots of glitches.
- Rename atrac3_oma.c since it works for both oma and wav containers.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24689 a1c6a512-1295-4272-9138-f99709370657
2010-02-16 03:34:39 +00:00
Mohamed Tarek
faec50d67b Fix a comment in OMA metadata parser. No functional changes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24683 a1c6a512-1295-4272-9138-f99709370657
2010-02-16 01:55:48 +00:00
Mohamed Tarek
2e314093c8 "Detach" ATRAC3 from RM. Since ATRAC3 isn't really specific to RM, it must not be obligatory to initialize the decoder through RMContext.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24682 a1c6a512-1295-4272-9138-f99709370657
2010-02-16 01:47:22 +00:00
Mohamed Tarek
23ac6ffaa1 Add support for Sony OMA file format. Currently only supports ATRAC3 (without DRM), and seeks. Tested on sansa
e200.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24615 a1c6a512-1295-4272-9138-f99709370657
2010-02-12 03:21:37 +00:00
Andree Buschmann
db4d7a313e 1st part of fix for FS#10637. Correction of mpc header parsing.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24408 a1c6a512-1295-4272-9138-f99709370657
2010-01-31 11:43:42 +00:00
Michael Giacomelli
c9183bf15e Commit FS#10422 by Yoshihisa Uchida. Seperates WAV and AIFF parsing from PCM decoding by introducing libpcm, a library for decoding linear and non-uniform PCM independently of the container format.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24346 a1c6a512-1295-4272-9138-f99709370657
2010-01-27 17:25:10 +00:00
Andree Buschmann
05778b501d Fix further tabs
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24156 a1c6a512-1295-4272-9138-f99709370657
2010-01-03 10:50:34 +00:00
Michael Giacomelli
ce8640d7b8 Second part of FS#10832 by Juliusz Chroboczek. Ignore empty mdat chunks in mp4 files.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24148 a1c6a512-1295-4272-9138-f99709370657
2010-01-02 21:02:13 +00:00
Michael Giacomelli
008c368c87 Commit first part of FS#10832 by Juliusz Chroboczek. Allows playback of unstreamable AAC/ALAC files by stepping through the file to find the index, potientially rebuffering. This is likely to impose a battery life hit on files which are unstreamable and not much smaller then the buffer, but should not impact streamable files at all.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24147 a1c6a512-1295-4272-9138-f99709370657
2010-01-02 20:54:55 +00:00
Magnus Holmgren
6b6463c8b7 Add support for the MP4 file type 'isom'. Based on FS#10790 with an additional fix, making the sample file play. Also updated some debug prints.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23708 a1c6a512-1295-4272-9138-f99709370657
2009-11-22 16:37:36 +00:00
Nils Wallménius
2e28c1853b Unify fourcc macro and some style changes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23664 a1c6a512-1295-4272-9138-f99709370657
2009-11-18 17:30:42 +00:00
Nils Wallménius
556daaf34a Make svn properties consistent and set some missing ones
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23663 a1c6a512-1295-4272-9138-f99709370657
2009-11-18 16:59:34 +00:00
Mohamed Tarek
e0d8202599 Revert r23339 and use setid3v1title() from metadata/mp3.c instead.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23349 a1c6a512-1295-4272-9138-f99709370657
2009-10-25 18:11:55 +00:00
Mohamed Tarek
027e7634bf Add support for ID3v1 metadta tags in Real Media container.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23339 a1c6a512-1295-4272-9138-f99709370657
2009-10-24 23:53:01 +00:00
Marcoen Hirschberg
c48af23c7e add gapless playback for Nero encoded AAC files
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22984 a1c6a512-1295-4272-9138-f99709370657
2009-10-06 13:47:12 +00:00
Marcoen Hirschberg
f3e5ced844 add gapless support for MP3 files encoded with iTunes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22872 a1c6a512-1295-4272-9138-f99709370657
2009-10-02 09:14:17 +00:00
Marcoen Hirschberg
500bdda4f2 add support for comments in ID3v2.2
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22868 a1c6a512-1295-4272-9138-f99709370657
2009-10-01 11:50:06 +00:00
Michael Giacomelli
ad9835c689 Logic was backwards on the check for NSF file format. Fix that and save one memcmp.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22559 a1c6a512-1295-4272-9138-f99709370657
2009-08-30 03:52:11 +00:00
Michael Giacomelli
f701fc5166 Patch doesn't SVN add . . .
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22558 a1c6a512-1295-4272-9138-f99709370657
2009-08-30 03:15:43 +00:00
Michael Giacomelli
e4c30bdf0e Accept FS#10570 by Jason Yu. Adds metadata parsing for NSF files.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22557 a1c6a512-1295-4272-9138-f99709370657
2009-08-30 02:53:15 +00:00
Mohamed Tarek
685628cf18 Support for playback of atrac3 audio in rm, in sim.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22311 a1c6a512-1295-4272-9138-f99709370657
2009-08-14 17:36:57 +00:00
Mohamed Tarek
466b2ae248 Factor out bytestream reading functions needed in rm parsers/codecs.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22308 a1c6a512-1295-4272-9138-f99709370657
2009-08-14 15:13:14 +00:00
Mohamed Tarek
e63f1ecb97 Fix yellow.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22239 a1c6a512-1295-4272-9138-f99709370657
2009-08-10 19:53:10 +00:00
Boris Gjenero
7f971e0176 Fix FS#10476. Prevent FLAC bitrate calculation overflow with large files. The watermark depends on the bitrate, and so this also fixes playback pauses on large FLAC files.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22211 a1c6a512-1295-4272-9138-f99709370657
2009-08-08 20:27:03 +00:00
Mohamed Tarek
cc68b632cb Add a couple of functions for the rm metadata parser for debugging, and add a comment to codecs/a52_rm.c to indicate the source of the decode
function.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22182 a1c6a512-1295-4272-9138-f99709370657
2009-08-06 05:45:54 +00:00
Mohamed Tarek
26cee86a0c Add support for AC3 audio in RM container.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22155 a1c6a512-1295-4272-9138-f99709370657
2009-08-04 13:54:06 +00:00
Maurus Cuelenaere
1ace06a67d Metadata parser: make adjust_mp3entry() not depend on id3_is_genre_string(), so there's no need to compare the string to the whole genre array (thanks to Mikael Magnusson)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22105 a1c6a512-1295-4272-9138-f99709370657
2009-08-01 19:52:54 +00:00
Maurus Cuelenaere
faf37f9d21 MP3 metadata parser:
* Use ARRAYLEN()
 * id3_is_genre_string(): loop over the whole array instead of comparing a pointer to the first and last item of an array of pointers (fixes crash on Onda VX747)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22104 a1c6a512-1295-4272-9138-f99709370657
2009-08-01 19:37:09 +00:00
Mohamed Tarek
c08a2c7c53 Change enum codecs in apps/codecs/librm/rm.h to follow the coding guidelines.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22067 a1c6a512-1295-4272-9138-f99709370657
2009-07-27 12:29:06 +00:00
Mohamed Tarek
5f5d105755 Change the naming scheme for codecs found in different containers.
Like changing AFMT_AAC to AFMT_MP4_AAC and AFMT_RAAC to AFMT_RM_AAC.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22066 a1c6a512-1295-4272-9138-f99709370657
2009-07-27 12:13:22 +00:00
Mohamed Tarek
fe1568a11c Fix yellow - (Value in an enumeration not handled in a switch).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22032 a1c6a512-1295-4272-9138-f99709370657
2009-07-25 15:54:05 +00:00
Mohamed Tarek
b8cccb5ae1 Adding support for playback of aac audio in rm container, with seeking.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22031 a1c6a512-1295-4272-9138-f99709370657
2009-07-25 15:47:13 +00:00
Mohamed Tarek
6f4294219e Generic codec-extradata parsing, in preparation for addition of AAC/RM.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21941 a1c6a512-1295-4272-9138-f99709370657
2009-07-18 00:29:19 +00:00
Nils Wallménius
3d4701a6e4 FS#10080
* Move strncpy() from core to the pluginlib
* Introduce strlcpy() and use that instead in most places (use memcpy in a few) in core and some plugins
* Drop strncpy() from the codec api as no codec used it
* Bump codec and plugin api versions


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21863 a1c6a512-1295-4272-9138-f99709370657
2009-07-14 13:57:45 +00:00
Mohamed Tarek
ff7c0cd7c5 Silence warnings to fix yellows for now.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21810 a1c6a512-1295-4272-9138-f99709370657
2009-07-12 15:11:22 +00:00
Mohamed Tarek
6258e24e0e Some fixes for the standalone test program.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21807 a1c6a512-1295-4272-9138-f99709370657
2009-07-12 14:43:24 +00:00
Maurus Cuelenaere
851b0e3234 Try at fixing 'cast to/from pointer to/from integer of different size' warnings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21719 a1c6a512-1295-4272-9138-f99709370657
2009-07-08 17:18:59 +00:00
Maurus Cuelenaere
3c338766d1 RM metadata parser: fix unaligned access
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21716 a1c6a512-1295-4272-9138-f99709370657
2009-07-08 15:00:00 +00:00
Mohamed Tarek
e184ef1027 Adding support for rm playback. Only cook codec is supported for now and no seeking.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21695 a1c6a512-1295-4272-9138-f99709370657
2009-07-06 22:40:45 +00:00
Thomas Martitz
659425f23e Redo r21460 and r21462 so that it doesn't introduce a new #define. Patch by Jeffrey Goode, taken from FS#10366.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21467 a1c6a512-1295-4272-9138-f99709370657
2009-06-22 18:40:49 +00:00
Thomas Martitz
78914f3833 FS#10364 - Optional debug output for vorbis.c by Jeffrey Goode.
Gets rid of the (recently added) annyoing vorbis debug statements. Comment out "#define LOGF_ENABLE" in vorbis.c to restore them.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21460 a1c6a512-1295-4272-9138-f99709370657
2009-06-21 21:59:16 +00:00
Magnus Holmgren
0b495f0a18 Improved Vorbis comment reader. The tags no longer need to fit in the first Ogg page to be fully read (album art can make the tags not fit).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21134 a1c6a512-1295-4272-9138-f99709370657
2009-05-30 14:24:16 +00:00
Mohamed Tarek
b68707d465 Add read_uint8() and read_uint16be() to metadata_common.c/h
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20968 a1c6a512-1295-4272-9138-f99709370657
2009-05-16 19:05:50 +00:00
Andrew Mahone
fd7002ae6c Attempt to fix yellow on sims (can't reproduce on my system).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20954 a1c6a512-1295-4272-9138-f99709370657
2009-05-16 02:06:22 +00:00
Dave Chapman
da3dc455f6 Change the type of read_uint32be to uint32_t and ensure all variables passed to that function are also of that type. No functional changes, but makes read_uint32be consistent with the other read_* functions and prevents warning in the upcoming RealAudio metadata parser.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20950 a1c6a512-1295-4272-9138-f99709370657
2009-05-15 22:45:03 +00:00
Robert Keevil
4f47b38938 Fix reading of Musicbrainz track IDs from ID3 tags - incorrect return values resulted in these tags being partially overwritten
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20719 a1c6a512-1295-4272-9138-f99709370657
2009-04-16 23:10:45 +00:00
Nils Wallménius
5a55772201 Small code reuse improvement
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19943 a1c6a512-1295-4272-9138-f99709370657
2009-02-08 11:09:55 +00:00
Magnus Holmgren
c54ddbd78c MP4/AAC: Add support for album artist tags written by Foobar2000. Closes FS#9723.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19669 a1c6a512-1295-4272-9138-f99709370657
2009-01-04 17:41:17 +00:00
Magnus Holmgren
5a00367a08 Fix FS#9522: stop reading an ID3v2 tag if a frame length is bad.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19005 a1c6a512-1295-4272-9138-f99709370657
2008-11-04 19:47:52 +00:00
Magnus Holmgren
ee378abe63 Add support for the album artist field used by Foobar2000 in ID3v2 tags.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18935 a1c6a512-1295-4272-9138-f99709370657
2008-10-30 19:00:24 +00:00
Bertrik Sikken
92683778f6 Add missing #include to mp3 metadata parser.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18885 a1c6a512-1295-4272-9138-f99709370657
2008-10-26 13:07:29 +00:00
Björn Stenberg
51b45d5602 Split id3.c/h into metadata.c/h and metadata/mp3.c. Updated all references. Moved mp3data.c/h from firmware to apps.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18814 a1c6a512-1295-4272-9138-f99709370657
2008-10-15 06:38:51 +00:00
Robert Keevil
2c170356f3 FS#9139 - support for ver 1.1 scrobbler log files. Upload any old files first - uploading software may need updating, see the LastFMLog wiki page
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18732 a1c6a512-1295-4272-9138-f99709370657
2008-10-07 18:39:44 +00:00
Nils Wallménius
1121af7b5e Print a helpful error in the sim for usupported formats in Ogg containers (f.e. Ogg/FLAC)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18623 a1c6a512-1295-4272-9138-f99709370657
2008-09-24 17:43:10 +00:00
Dominik Wenger
9b7566e3ec asap: fix stereo mode and hopefully fix metadata handling.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18140 a1c6a512-1295-4272-9138-f99709370657
2008-07-28 19:20:40 +00:00