Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
35584 commits 17 branches 142 tags 291 MiB
Commit graph

35584 commits

This branch
This branch
All branches
Author SHA1 Message Date
James Buren
60933d98c6 inflate: import initial module for deflate decompression 
This will eventually be used by the ZIP module and other things
that support DEFLATE based streams.

Change-Id: I4acc9561eb56c9c368d1defab9c14e0454d105e1
 2021-08-07 03:03:27 +00:00
William Wilgus
603e749c1d metadata/smaf.c handle read errors 
Change-Id: I450f1fc8e1b69ce09f9888f5384c3e23a93822a1
 2021-08-07 02:53:28 +00:00
William Wilgus
8a8fd3d4a3 metadata/mp3data.c set data to 0 in case of read error 
Change-Id: I15d4e3d3be4bf4531c892f4351355b0b2e8e0ca9
 2021-08-06 20:55:11 -04:00
Aidan MacDonald
2008b7d1b0 Fix yellow from d541a72a 
Change-Id: I9c539035544d285da1941d2c1954cf2aa4d00087
 2021-08-06 19:59:33 +01:00
Aidan MacDonald
257ba1d2e0 Fix possible negative fd in playlist.c 
Change-Id: I59d88609ec3f20ec9f482a777396cd72be23a35b
 2021-08-06 19:38:06 +01:00
Aidan MacDonald
02b940396b Be sure to wipe id3 tag after failed parse in playback.c 
Change-Id: I000c78e913ab80afa9b82cae937afb5255831b79
 2021-08-06 18:34:04 +00:00
Aidan MacDonald
d541a72a0e Bugfixes in eq_menu.c 
Change-Id: Ibf754554f685d13ac00a49694fcecee459ff838f
 2021-08-06 18:23:57 +00:00
Aidan MacDonald
1a9a5fc279 Fix wrong printf format in system-hosted.c 
Change-Id: I73722f0711a295152a98ab784cd6cf76379ef52e
 2021-08-06 18:23:17 +00:00
Aidan MacDonald
b8b195a296 Fix hosted glibc backtrace 
According to backtrace(3) man page, the string returned from
backtrace_symbols() contains the return address so we shouldn't
need to print it ourselves.

Change-Id: Ia779207285c9ea0052b9aee3d84ee8380bf46d82
 2021-08-06 18:54:34 +01:00
Aidan MacDonald
6b1b7b6016 Fix use of uninitialized variable in mp4 metadata parser 
Change-Id: Idca69e7429af13609785755d4e152d87f471c462
 2021-08-06 16:10:41 +00:00
Aidan MacDonald
34fcea0b20 Fix path buffer overflow in screendump 
Overflow is due to a hidden assumption in create_datetime_filename()
and create_numbered_filename() where buffer must be >= MAX_PATH bytes.

Change-Id: I9d36517d861b6925352380d551afc5439edbb340
 2021-08-06 15:46:53 +00:00
Solomon Peachy
835d0c737a logf: Fix two issues with logf_panic_dump() 
* It had a (read) buffer overflow when dumping the stuff on the back half of the buffer
 * a highly questionable code construct was nuked

Change-Id: I7f6f119524fc2095f788fc9b3d356459955d3ace
 2021-08-06 10:08:00 -04:00
James Buren
da45b37fac tools/iriver: fix resource management in encode/decode functions 
Change-Id: Ib0b38378c66d5902694d9af9fd0271d616101660
 2021-08-06 03:08:10 +00:00
Solomon Peachy
a20755e9ef test_disk: Minor fix in an error path 
...Log the variable containing the actual error

Change-Id: If22e6b684f2e213bc45c8ca95295936ba8e09895
 2021-08-05 14:22:53 +00:00
Solomon Peachy
9f0f2c6658 metadata: Fix sign extension in get_uint64_le() routine 
Change-Id: Ibd85cf72ac1babd1fa636c341b90b76bdfc0491b
 2021-08-05 13:44:39 +00:00
Solomon Peachy
566d836ac6 mikmod: Uninitialized variable used in a control flow decision 
Change-Id: I6df903399361f1df7ca0f766fff4062a984e2ba8
 2021-08-05 13:44:33 +00:00
Solomon Peachy
f3010c6a8e hosted: Fix rtc_write_datetime() error handling 
(if mktime() fails, don't attempt to write its result to the RTC)

Change-Id: Ib09b8dccafdef032119db76f10af74dfc220cc21
 2021-08-05 13:44:11 +00:00
William Wilgus
cb6b0d2c0e disk.c ensure a valid volume is returned from get_free_volume() 
volume is used for element math and indexing into buffers
-1  volume is bad

Change-Id: I1ec75ef3a848c154ea80905224ea9a3a14bf8151
 2021-08-05 11:01:29 +00:00
William Wilgus
d57900ae12 misc.c format_sound_value guard division by zero 
Change-Id: I7085cb34d2258aa5fc7e04fc0e73d6f733810038
 2021-08-05 11:00:47 +00:00
William Wilgus
848633f921 lib/skin_parser check that malloc succeeded 
Change-Id: I32db233a53b0f693f815cf96bcbe6711c366e5b3
 2021-08-05 10:38:18 +00:00
Aidan MacDonald
03a6eb63f1 Simplify clamp_component 
Surprise surprise: the compiler generates shorter, branch-free code
if we don't try to be clever with signed/unsigned casting tricks.

Change-Id: I93d2020b6127e7d43feee394b06a52aaeddf3b79
 2021-08-05 10:26:50 +00:00
Aidan MacDonald
429a7e2c0a Avoid buffer overflow when generating bookmark file name 
Change-Id: I14f3d83a8089d33f4e900a1d5f965e67082a07ea
 2021-08-04 19:04:48 +00:00
Aidan MacDonald
bdd9c8dfc8 plugins: Fix issues in 2048 
One of these was an unintentional fallthrough -- if you said no to
'quit without saving' it would save and quit.

Change-Id: I33828b58962a05adab65ac5f71dd0e2b1e07001b
 2021-08-04 19:04:37 +00:00
Aidan MacDonald
005c414e5f Document intentional fallthroughs + fix harmless unintended ones 
Change-Id: I1ca5b1027ec30cbf61093bab35b980196ed14e6b
 2021-08-04 18:59:46 +00:00
Dominik Riebeling
ef41cc6623 Revert "rbutil: Remove done() signal from Themes Install window." 
The done() signal is acutally needed to indicate the installation being
finished. Fixes installation being stuck after themes install.

This reverts commit fb6840e572.

Change-Id: I9c1791e3ecfec992da40ff72b6969d80bbb0cd7f
 2021-08-04 19:10:34 +02:00
Solomon Peachy
c522917644 plugins/resistor: Fix incorrect check for a valid 4th band value 
Change-Id: I499bcd6d2d6fd5dd92c184cc1ec014e62f0441fa
 2021-08-04 14:56:20 +00:00
Solomon Peachy
37bfcab23f powermgmt: Clean up some convoluted #ifdefs 
Makes it more explicit what code is used under which circumstances.

Change-Id: I0a482dd48e1eb4b119ca6d8dca2b8aa450445fd1
 2021-08-04 09:39:37 -04:00
William Wilgus
0d0640e57a menu.c guard against NULL menu, list, setting pointers 
Change-Id: Id45d9ac3b88571cb3927ca29314f997d5cbfd598
 2021-08-03 11:43:53 +00:00
William Wilgus
074daea51f lua fix potential null warning 
I'm not sure this would happen but I suspect its possible to get malformed
data back from lineinfo as this is how the error system tracks code flow
and this is a hacked add-on to allow RLE (run length encoding) of
said code flow data

Change-Id: I4b914c632935f8b1a9fa960212c58e810b2db738
 2021-08-03 11:02:15 +00:00
William Wilgus
1fd190d02d mask_select guard against null pointers 
Change-Id: I83d246c13d22c1e76a55cbfdd20dcc955eb556ec
 2021-08-03 11:00:59 +00:00
William Wilgus
36e48a8bb2 icon.c guard against negative error values bytesread is copied to an unsigned int for core_shrink 
Change-Id: Iff93397e7d6fae8936ef0fdbb1e71df63bcf6531
 2021-08-02 23:06:40 -04:00
William Wilgus
93c9d675af folder_select prevent directory handle leak on error 
Change-Id: If1617dc92683d7de3d7709b363a593e40fbc5bc8
 2021-08-03 03:01:14 +00:00
William Wilgus
429eedf49e list-skinned.c check label pointer for validity 
Change-Id: I993ff4a2d5d1c46bad46aae7f46fa4996e67481a
 2021-08-03 02:49:17 +00:00
William Wilgus
382b52b120 filetypes.c filesize() guard against negative error values 
buffer size is copied to an unsigned int for core_alloc

Change-Id: I7b9ccab79554e55b22d39501ccb779036913258a
 2021-08-02 22:32:15 -04:00
William Wilgus
1fc4a17e1c language.c fix possible buffer overrun 
ensure zero termination regardless of data read from lang file

Change-Id: I0da0e787ffb10c9268557812b061cc3c452fbd0a
 2021-08-03 00:57:35 +00:00
William Wilgus
3b6c3d769f open_plugins bugfix failure to save 
if you added a plugin through the core settings and then used the shortcut
immediately the entry would never get flushed to disk

Change-Id: I62e876bbf0a8fa96acba1cc2582e2563401547f1
 2021-08-03 00:31:10 +00:00
William Wilgus
0501af8b06 metadata/flac.c fix potential buffer overrun 
Change-Id: Iee12f251455c4fda9d91d10e466d17e5e02046b9
 2021-08-02 03:00:01 +00:00
William Wilgus
247731fe8c id3tags.c check for buffer overrun 
Change-Id: I74fde8e234fe85abfabefddcea7f10038167c715
 2021-08-01 22:29:14 -04:00
William Wilgus
2346a7aa6d playlist_catalog fix strcpy overlap, potential buffer overrun 
Change-Id: I7cd1302d2c905992078351a531a5d67fdb465809
 2021-08-02 02:27:43 +00:00
William Wilgus
83653023d4 tagcache.c clean up 
Change-Id: I658ee345461eeda77cbe856cec46c21dcce7715b
 2021-08-02 00:43:52 +00:00
Dana Conrad
a2fd00cf38 Software Volume: Remove sample rounding 
Change-Id: I630139333d64b4c8cae86939ecfc52c44a34ffea
 2021-08-01 02:20:00 +00:00
William Wilgus
ecf0d631e7 tagcache.c Fix potential buffer overruns WIP 
Needs tested

Change-Id: I373b72c72f98777dc7a2d8085e975aeac164c297
 2021-07-31 10:44:02 -04:00
William Wilgus
7413442411 tagcache.c WS changes 
Change-Id: Ied0fa6010e8bfa82e1c46cafcfb0dec51478d346
 2021-07-31 10:26:59 -04:00
James Buren
fad4c75163 crc32/adler32: add full copyright notice to source files 
Change-Id: Ifa04be9a6e419772c18b21e81fe1f246f4248af7
 2021-07-31 01:30:39 +00:00
James Buren
f32fc84ef6 adler32: import adapted implementation from tinf/zlib 
This adds an adapted version of the adler32 algorithm from tinf/zlib
which will be necessary to support ZLIB deflate streams in the future.

Change-Id: Ie60e15acb288acf56a2d44e3d3e912e1b3eb2216
 2021-07-30 23:11:49 +00:00
William Wilgus
ee05b8574a playlist.c fix multitude of sins Invalid Control file on USB unplug? 
failure to close file handles
reading memory prior to buffer on error
loop variable integer overflow on error

Change-Id: I2893c34cd041d085fd7f56a88cb4cb14131cea11
 2021-07-30 00:40:43 -04:00
William Wilgus
f9c5d1fccf open_plugin.c (CORE) File input Bugfixes 
Explicitly Null terminate char fields
0 is a valid file descriptor

Change-Id: I0faa9f5ec919ca913bceabf919fbaefcb38c39b9
 2021-07-29 23:15:33 -04:00
William Wilgus
ea438ee132 cuesheet.c Fix potential NULL in INDEX parsing 
untested

Change-Id: I6160348eeece364e3242f047437877ea34136f9c
 2021-07-30 02:30:49 +00:00
Solomon Peachy
7318d393ea libc: atoi() is supposed to return 0 if handed a NULL pointer 
Change-Id: I2d77532536ca83e5c9c2d7622a0e672082969f75
 2021-07-30 01:41:13 +00:00
Aidan MacDonald
2e9443104f rbcodec: Fix typo in makefile 
Hopefully this will fix all those random build failures.

Change-Id: I02ff625c538a21f20b33874b4ab54ed8c893a433
 2021-07-25 15:55:36 +01:00