Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
17146 commits 17 branches 142 tags 291 MiB
Commit graph

196 commits

Author SHA1 Message Date
Jonathan Gordon
6d207956d3 found (and fixed) by Stephane Doyon... 
"A glitch was recently introduced when backing out of context menu functions. When exiting for example the playlist viewer, or the id3 viewer, it will speak the name of the menu entry used to access that function. That's pretty confusing because it sounds like you dropped back into the menu system while we have in fact exited the context menu completely."



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17293 a1c6a512-1295-4272-9138-f99709370657
 2008-04-30 10:22:39 +00:00
Jonathan Gordon
fe9dca3d5b option_screen() now accepts a viewport 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17223 a1c6a512-1295-4272-9138-f99709370657
 2008-04-23 11:07:40 +00:00
Jonathan Gordon
286d48f4ec enable the quickscreen in menus and neaten up the else if-ing 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17222 a1c6a512-1295-4272-9138-f99709370657
 2008-04-23 10:33:46 +00:00
Nils Wallménius
6848961aa5 Pass the buffer length to the list_get_name callback functions instead of using hardcoded MAX_PATH 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17049 a1c6a512-1295-4272-9138-f99709370657
 2008-04-09 15:25:17 +00:00
Jonathan Gordon
a53b85a52a fix themes not being fully applied to the menu on load (Hopefully fixes FS#8808) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16819 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 13:34:47 +00:00
Jonathan Gordon
be185a1eaf fix the buttonbar in the browser and menus. 
fix a problem where the menus wouldnt redraw when they should have when settings change


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16816 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 09:05:42 +00:00
Jonathan Gordon
5ca1539969 the menu and list now accepts a parent viewport to draw in (and the menu can be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 03:35:24 +00:00
Steve Bavin
cd88e2ad93 Code police raid on the settings code, consting and putting headers alongside their implementation. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16798 a1c6a512-1295-4272-9138-f99709370657
 2008-03-25 15:24:03 +00:00
Linus Nielsen Feltzing
34d08b235e Fix buffer overflow in the title padding code (FS#8163) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15633 a1c6a512-1295-4272-9138-f99709370657
 2007-11-16 08:18:08 +00:00
Jonathan Gordon
c586739763 git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15546 a1c6a512-1295-4272-9138-f99709370657 2007-11-09 00:48:18 +00:00
Jonathan Gordon
5cab5dab0e fix red 
fix Björn's name in the (c)
fix FS#8105 - backing out of the submenus in the context menus shuoldnt leave the context menu completly (expect playlist which possibly makes sense?)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15513 a1c6a512-1295-4272-9138-f99709370657
 2007-11-07 10:06:21 +00:00
Jonathan Gordon
91ccc01bcf fix FS#7288 - pad the title of the scrolling settings so they actually scroll 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15469 a1c6a512-1295-4272-9138-f99709370657
 2007-11-05 13:15:35 +00:00
Jonathan Gordon
a6f2b82803 revert my previous commit and do it in a much less hacky way (both of these were for FS#8084) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15458 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 12:40:18 +00:00
Jonathan Gordon
62decc42e7 return to the main menu if stop is pressed in the wps context menu, (blame pondlife for the hack :D ) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15457 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 12:10:41 +00:00
Stéphane Doyon
4e09b78f8c From FS#7774: use list voice callback in menus. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15234 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 00:23:23 +00:00
Steve Bavin
32a9575130 FS#7994 - Rename talk.c API, make talk_disable() affect all talking (not just menus), hopefully save some space. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15206 a1c6a512-1295-4272-9138-f99709370657
 2007-10-19 15:31:42 +00:00
Stéphane Doyon
5acf091046 Add a voice callback to dynamic menus, along side the text_callback. 
From FS#7563.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15042 a1c6a512-1295-4272-9138-f99709370657
 2007-10-09 03:48:56 +00:00
Jonathan Gordon
cf1cef5f57 minor update to gui_synclist_do_button() which will hopefully simplify things later. 
Now returns true if the action was handled in that function instead of returning the handled action.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14733 a1c6a512-1295-4272-9138-f99709370657
 2007-09-17 10:08:50 +00:00
Jonathan Gordon
94b9804427 Make MENUITEM_STRINGLIST() menus talk (if ID2P() is used for the string) 
Makes the plugin browser talk (FS#7612), as well as the paylist viewer menu and the bookmark menu.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14399 a1c6a512-1295-4272-9138-f99709370657
 2007-08-20 09:11:05 +00:00
Magnus Holmgren
1d9f693658 Redraw the menu when stopping playback, in case the bookmarking code left something on screen. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14196 a1c6a512-1295-4272-9138-f99709370657
 2007-08-05 15:21:47 +00:00
Jonathan Gordon
75e2f19de3 dont redraw the menu if we are about to quit anyway (noticable when backing out of the playlist menu from the wps context menu) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14180 a1c6a512-1295-4272-9138-f99709370657
 2007-08-04 09:47:17 +00:00
Jonathan Gordon
73336e9729 Finally use the rec button to get to the rec screen on sansa and iriver hxxx. hold rec to get there... short press still is unused 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14141 a1c6a512-1295-4272-9138-f99709370657
 2007-08-02 12:13:20 +00:00
Jonathan Gordon
fe2b376060 Fix the text for settings which have a different title than what is shown in the menu (i.e scroll options) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13962 a1c6a512-1295-4272-9138-f99709370657
 2007-07-23 05:40:45 +00:00
Jonathan Gordon
f7675a244b remove the need for action_signalscreenchange(). 
Fixes problems with targets where the ACTION_STD_CANCEL event is a combo


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13956 a1c6a512-1295-4272-9138-f99709370657
 2007-07-22 06:05:53 +00:00
Jonathan Gordon
a5278fa3db Rearrange and cleanup settings code 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13851 a1c6a512-1295-4272-9138-f99709370657
 2007-07-11 05:41:23 +00:00
Jonathan Gordon
50dc0cabe3 same as previous commit, but more forgotten cases 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13850 a1c6a512-1295-4272-9138-f99709370657
 2007-07-11 04:17:43 +00:00
Jonathan Gordon
953e7cf183 woops, menus stopped getting redrawn when the setting screen exited 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13849 a1c6a512-1295-4272-9138-f99709370657
 2007-07-11 04:13:30 +00:00
Jonathan Gordon
411f3e2b2b If the action handler for the menu returns ACTION_REDRAW the list will be redrawn. Fixes the Now Playing/Resume Playback text not updating 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13848 a1c6a512-1295-4272-9138-f99709370657
 2007-07-11 02:22:03 +00:00
Jonathan Gordon
b9f22af85a Redraw the menus once every action, not 3 times 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13847 a1c6a512-1295-4272-9138-f99709370657
 2007-07-11 01:23:57 +00:00
Jonathan Gordon
0baad43a93 Accept FS#7313 - make the menus talk more often 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13679 a1c6a512-1295-4272-9138-f99709370657
 2007-06-21 12:32:10 +00:00
Steve Bavin
24d9f59c78 When recording, disable voice menus without actually modifying user settings. Patch FS#7272, fixes bug FS #6163 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13615 a1c6a512-1295-4272-9138-f99709370657
 2007-06-11 08:28:38 +00:00
Jonathan Gordon
fd9d140119 Fix FS#7176 - wps context menu doesnt set the correct selection. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13445 a1c6a512-1295-4272-9138-f99709370657
 2007-05-20 14:24:02 +00:00
Nils Wallménius
f31e123133 Remove unused function and unused header 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13424 a1c6a512-1295-4272-9138-f99709370657
 2007-05-19 19:54:11 +00:00
Jonathan Gordon
77a458a464 Move the old api out of the core and into the plugin lib. 
ew plugins shuold use the new api and not this one.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13358 a1c6a512-1295-4272-9138-f99709370657
 2007-05-08 11:55:43 +00:00
Jonathan Gordon
cf478758dd fix the menus again, this time it stopped redrawing after coming out of setting screens 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13353 a1c6a512-1295-4272-9138-f99709370657
 2007-05-08 01:32:29 +00:00
Jonathan Gordon
baf9cf6990 Fix my previous commit... menus will redraw correctly again 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13338 a1c6a512-1295-4272-9138-f99709370657
 2007-05-07 08:50:47 +00:00
Jonathan Gordon
1228820ca9 Fix the menus so lines scroll again 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13337 a1c6a512-1295-4272-9138-f99709370657
 2007-05-07 07:51:35 +00:00
Jonathan Gordon
3a7760c3e2 Convert onplay.c to the new manu API. only plugins are still using the old API now 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13294 a1c6a512-1295-4272-9138-f99709370657
 2007-04-30 13:41:33 +00:00
Jonathan Gordon
cd8870ccfb fix a bug which made menus using the old API and a callback function to not work correctly 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13246 a1c6a512-1295-4272-9138-f99709370657
 2007-04-22 14:24:32 +00:00
Jonathan Gordon
6a5cc0bd25 Customizable icons for all bitmap targets. (FS#7013) 
http://www.rockbox.org/twiki/bin/view/Main/CustomIcons for info on format and how to load them


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13177 a1c6a512-1295-4272-9138-f99709370657
 2007-04-16 09:14:36 +00:00
Jens Arnold
17c93f9be0 Fix an off-by-one bug (hitting when menu titles are enabled) in the oldmenu wrapper. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13149 a1c6a512-1295-4272-9138-f99709370657
 2007-04-14 00:03:09 +00:00
Jonathan Gordon
f9fb49284e Give most of the items in the main menu a context menu 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13126 a1c6a512-1295-4272-9138-f99709370657
 2007-04-12 15:28:51 +00:00
Jens Arnold
8636e6949e Moved SH1 system code to target tree. * First shot at hwcompat cleanup. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13114 a1c6a512-1295-4272-9138-f99709370657
 2007-04-11 23:51:00 +00:00
Jens Arnold
178c565beb Stop/shutdown logic rework in browsers and menus. Recorder V1: Double-Off shutdown is now possible from menus and sub-browsers as well. Player, other targets which are always powered during charging: Attempted shutdown from menu with charger plugged now displays the charging splash. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13079 a1c6a512-1295-4272-9138-f99709370657
 2007-04-09 13:39:37 +00:00
Jonathan Gordon
9e95e306cd fix yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13069 a1c6a512-1295-4272-9138-f99709370657
 2007-04-08 06:15:34 +00:00
Jonathan Gordon
21b415df56 Give all menus using the old API a nice title and icons (except plugins) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13068 a1c6a512-1295-4272-9138-f99709370657
 2007-04-08 05:52:47 +00:00
Jonathan Gordon
a053e58894 minor actions cleanup: 
- CONTEXT_MAINMENU is not actually needed, use CONTEXT_TREE which does the same actions
- (gigabeat) use vol+/- in the lists to control volume (every list!) (FS#6982 in a better way)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13062 a1c6a512-1295-4272-9138-f99709370657
 2007-04-08 01:33:01 +00:00
Peter D'Hoye
d2b305571e Check if a new version got installed after usb disconnect and ask if user wants to reboot. Causes disk spinup before showing the usb logo. Also fixes do_menu() not returning to root_menu after usb disconnect. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12972 a1c6a512-1295-4272-9138-f99709370657
 2007-03-30 21:54:48 +00:00
Jonathan Gordon
91e726a1c1 Move all valid menu return codes to a single file (root_menu.h) so we don't need to rely on GO_TO_ROOT == MENU_ATTACHED_USB. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12937 a1c6a512-1295-4272-9138-f99709370657
 2007-03-27 06:38:11 +00:00
Jonathan Gordon
1f5ee2a366 convert the xobox menu to the new API so it can be used as an example for plugin devs 
Includes some fixes in the api to handle this.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12907 a1c6a512-1295-4272-9138-f99709370657
 2007-03-25 14:31:56 +00:00