Michael Sevakis
e61e9c61d0
Do some cleanup, adjustment and a couple fixes to recent sound changes.
...
* SOUND_x enum can be generated by audiohw_settings.h along with settings
entries and sound_val2phys.
* VOLUME_MIN and VOLUME_MAX are no longer necessary within sound.c. If
you need them, they are for target-defined purposes.
* Fix up SDL volume implementation in sdl.c. Move sim volume calculation
code to pcm-sdl.c.
* Min trigger tresholds were based upon VOLUME_MIN for some reason.
These setting have nothing to do with playback volume. Since it is no
longer present, set these at -89dB which is the minimum peak meter
sensitivity setting.
* Fix an oversight in wm8758.c. I forgot to add the dB->register
conversion to audiohw_set_volume.
Change-Id: Ie1df33f1793eee75e6793f16bc7bddd16edb7f75
2013-04-22 20:38:17 -04:00
Michael Sevakis
0c7b787398
Straighten out the mad twisted state of sound.c and related areas.
...
This is going right in since it's long overdue. If anything is goofed,
drop me a line or just tweak it yourself if you know what's wrong. :-)
Make HW/SW codec interface more uniform when emulating HW functionality
on SWCODEC for functions such as "audiohw_set_pitch". The firmware-to-
DSP plumbing is in firmware/drivers/audiohw-swcodec.c. "sound_XXX"
APIs are all in sound.c with none in DSP code any longer.
Reduce number of settings definitions needed by each codec by providing
defaults for common ones like balance, channels and SW tone controls.
Remove need for separate SIM code and tables and add virtual codec header
for hosted targets.
Change-Id: I3f23702bca054fc9bda40f49824ce681bb7f777b
2013-04-15 12:02:05 -04:00
Boris Gjenero
6c97145e7d
Add missing includes found using -Wmissing-declarations.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31396 a1c6a512-1295-4272-9138-f99709370657
2011-12-21 18:02:50 +00:00
Michael Sevakis
feddfdb2d9
Gigabeat S/i.MX31/wm8978: Clean up clocking information in the general wmcodec/pcm drivers and move it to the target's wmcodec/i2s files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30771 a1c6a512-1295-4272-9138-f99709370657
2011-10-17 15:37:14 +00:00
Michael Sevakis
8bfaac7672
WM8978: Turn off AMUTE since it can cause annoying clicking with audio that produces runs of zeros (esp. emulators and synths) and makes it worse when starting/stopping pcm.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29213 a1c6a512-1295-4272-9138-f99709370657
2011-02-06 02:01:13 +00:00
Michael Sevakis
485aecd923
WM8978: sound.c weirdness strikes again. Prescaler values have to be in centibels.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29100 a1c6a512-1295-4272-9138-f99709370657
2011-01-21 08:31:40 +00:00
Michael Sevakis
72ccb14ab1
Gigabeat S: Turn off hardware effects (tone and 3d) when doing digital loopback for FM recording otherwise the signal and levels are poorly represented in monitoring (can't just do ADC->DAC for general FM and get voice too). Some tweaking to input setup to improve gain a tiny bit. A little bit quieter startup too.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26300 a1c6a512-1295-4272-9138-f99709370657
2010-05-26 05:13:45 +00:00
Michael Sevakis
80d0d15ca9
Gigabeat S: Fully enable access to hardware tone controls and 3-D effect feature. Under the hood, it's designated a hardware equalizer since it is one. Implement code framework for hardware EQ in general. Menu aspect is well abstracted and so the UI and strings can be changed around if taste doesn't quite suit. So far the emphasis is distinction of the UI labelling from the software EQ so that it's clear the settings are for a different thing.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26051 a1c6a512-1295-4272-9138-f99709370657
2010-05-15 13:09:45 +00:00
Michael Sevakis
6bb9384b70
wm8978: Clean out silly macros. Use 'POS' convention instead for shifted bitfields. Additionally, use volume update latching for all volume settings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26043 a1c6a512-1295-4272-9138-f99709370657
2010-05-15 04:59:25 +00:00
Rafaël Carré
f2f34881ec
Remove pcm_mute() which has been unused since r19308
...
Remove audiohw_mute from header as well, and make this function static
to each driver (commented out when it was unused)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25733 a1c6a512-1295-4272-9138-f99709370657
2010-04-27 00:05:02 +00:00
Jeffrey Goode
9d842683eb
Comment out LOGF_ENABLE defines everywhere, replace evil comments
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23497 a1c6a512-1295-4272-9138-f99709370657
2009-11-03 16:25:03 +00:00
Michael Sevakis
2e99b3d931
Gigabeat S: Allow recording from FM. Give FM the same volume range as playback. NOTE: This bumps the si4700 output volume to -0dB so other players with that may need a minor adjustment.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19619 a1c6a512-1295-4272-9138-f99709370657
2008-12-31 01:38:44 +00:00
Nils Wallménius
9711b1e2e3
Gigabeat S, use saner input volume on the line in used for fm to have fm volume at similar volume as playback. Add a few comments.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19602 a1c6a512-1295-4272-9138-f99709370657
2008-12-27 22:56:29 +00:00
Michael Sevakis
e69d567d9e
Bring consistency to pcm implementation and samplerate handling. Less low-level duplication. A small test_sampr fix so it works on coldfire again.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19400 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 11:01:07 +00:00
Nils Wallménius
65f61d6cce
FS#9609 FM radio support for the Gigabeat S, seeking/scanning is not yet
...
implemented but manual tuning works nicely. Thanks to Rafaël Carré,
Bertrik Sikken and Robert Menes for suggestions and debugging help.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19372 a1c6a512-1295-4272-9138-f99709370657
2008-12-09 20:48:04 +00:00
Michael Sevakis
5dfde5c80b
Gigabeat S samplerate control: Fix really dumb mistake made when doing cleanup. Add some more correctness.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19180 a1c6a512-1295-4272-9138-f99709370657
2008-11-22 14:39:42 +00:00
Michael Sevakis
5dec3b34aa
Oops. Used wrong constant.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19179 a1c6a512-1295-4272-9138-f99709370657
2008-11-22 12:23:31 +00:00
Michael Sevakis
7c007f5d87
Audio samplerate control for Gigabeat S: 8, 11.025, 12, 16, 22.050, 24, 32, 44.1 and 48 kHz.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19178 a1c6a512-1295-4272-9138-f99709370657
2008-11-22 12:17:26 +00:00
Michael Sevakis
20477d024e
Gigabeat S: Fix PCM being cut off at the beginning. The DAC L-R swapping isn't needed now either. Fixes voice clips on the Gigabeat S.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19141 a1c6a512-1295-4272-9138-f99709370657
2008-11-19 03:12:34 +00:00
Michael Sevakis
db5965ff9e
Gigabeat S/WM8978: Fix problem of volume getting silenced after settings are applied. There still seems to be a problem of cutting of voice samples from the beggining of clips when music isn't playing-- next to be investigated.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19109 a1c6a512-1295-4272-9138-f99709370657
2008-11-15 23:48:19 +00:00
Daniel Stenberg
2acc0ac542
Updated our source code header to explicitly mention that we are GPL v2 or
...
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 18:10:04 +00:00
Christian Gmeiner
56fceacfeb
fix some problems with missing HAVE_RECORDING checks
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17544 a1c6a512-1295-4272-9138-f99709370657
2008-05-16 20:40:59 +00:00
Michael Sevakis
8f0a1b3e6c
It's better not to use fixed constants since the lower volume limit may not be constant.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17329 a1c6a512-1295-4272-9138-f99709370657
2008-05-03 16:10:46 +00:00
Michael Sevakis
5df4405317
Gigabeat S: Man it's so loud in here. We have SOUND! Someone please make keymaps consistent; it's rather messy atm.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17327 a1c6a512-1295-4272-9138-f99709370657
2008-05-03 15:14:52 +00:00
Michael Sevakis
27fac88548
Gigabeat S: Implement i2c driver - transmit works but no testing of receiving which will get a chance later. Add some seeds for codec driver. Correct a few #defines.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17254 a1c6a512-1295-4272-9138-f99709370657
2008-04-27 10:30:54 +00:00