Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
34378 commits 17 branches 142 tags 291 MiB
Commit graph

58 commits

Author SHA1 Message Date
William Wilgus
5afdcdd460 Bug fix icon.c crashes with negative icon index 
The index for Icon_NOICON is -1 which is caught properly
as is icon > Icon_Last_Themeable

But if you pass an index lower than Icon_NOICON screen_put_iconxy()
tries to read memory prior to the iconset resulting in a crash

Change-Id: I415e650932d65214d883a1595e22261f22e776b6
 2019-09-24 23:51:12 -05:00
Thomas Martitz
0246f0ceb4 Fix remaining reds/yellows. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26024 a1c6a512-1295-4272-9138-f99709370657
 2010-05-14 13:21:40 +00:00
Jeffrey Goode
32ad1f84ee Revert hotkey bitmaps 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25875 a1c6a512-1295-4272-9138-f99709370657
 2010-05-07 14:46:42 +00:00
Jeffrey Goode
16e0c5730d Hotkey menu items have their own icon 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25866 a1c6a512-1295-4272-9138-f99709370657
 2010-05-07 03:21:12 +00:00
Thomas Martitz
50a6ca39ad Move c/h files implementing/defining standard library stuff into a new libc directory, also standard'ify some parts of the code base (almost entirely #include fixes). 
This is to a) to cleanup firmware/common and firmware/include a bit, but also b) for Rockbox as an application which should use the host system's c library and headers, separating makes it easy to exclude our files from the build.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25850 a1c6a512-1295-4272-9138-f99709370657
 2010-05-06 21:04:40 +00:00
Thomas Martitz
50d09bd84c Fix yellows. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22271 a1c6a512-1295-4272-9138-f99709370657
 2009-08-12 14:51:16 +00:00
Thomas Martitz
18e40e0f4c Make kbd_input() show a cancel splash to indicate user abort better and for better consistency all over the place. Change checking for its return value (style-wise) at some places too. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22269 a1c6a512-1295-4272-9138-f99709370657
 2009-08-12 14:38:25 +00:00
Nicolas Pennequin
396aeafa6c Correct Björn's name in various file headers. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20491 a1c6a512-1295-4272-9138-f99709370657
 2009-03-23 17:08:46 +00:00
Bertrik Sikken
56e2764116 Make local function static and add missing #includes for Archos player 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18505 a1c6a512-1295-4272-9138-f99709370657
 2008-09-12 21:11:06 +00:00
Daniel Stenberg
2acc0ac542 Updated our source code header to explicitly mention that we are GPL v2 or 
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
 2008-06-28 18:10:04 +00:00
Jens Arnold
63e9c05217 Revert accidental tree commit. Sorry for that. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16576 a1c6a512-1295-4272-9138-f99709370657
 2008-03-08 23:53:03 +00:00
Jens Arnold
8c6920e343 Revert accidental tree commit. Sorry for that. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16574 a1c6a512-1295-4272-9138-f99709370657
 2008-03-08 23:50:55 +00:00
Jens Arnold
9b939a615d Revert accidental tree commit. Sorry for that. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16572 a1c6a512-1295-4272-9138-f99709370657
 2008-03-08 23:41:30 +00:00
Jens Arnold
d1ed7c37b1 No need to have \n here. panicf() won't output it anyway. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16570 a1c6a512-1295-4272-9138-f99709370657
 2008-03-08 23:34:43 +00:00
Jens Arnold
bc357da2ae Small fixes for icon behaviour on the Player: Read viewer icon numbers from viewers.config, and correct the icon selection in icons.c. Now viewer supported filetypes get the mirrored question mark icon instead of no icon at all. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16389 a1c6a512-1295-4272-9138-f99709370657
 2008-02-23 13:12:08 +00:00
Jens Arnold
b1764679f5 Stop the player vkeyboard from freezing when voice is enabled and it tries to spell a non-ASCII character. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15999 a1c6a512-1295-4272-9138-f99709370657
 2008-01-05 10:26:02 +00:00
Steve Bavin
32a9575130 FS#7994 - Rename talk.c API, make talk_disable() affect all talking (not just menus), hopefully save some space. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15206 a1c6a512-1295-4272-9138-f99709370657
 2007-10-19 15:31:42 +00:00
Jens Arnold
064de4ce4d Slight code policing. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15065 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 06:02:08 +00:00
Jens Arnold
100d343963 Fix red Ondio builds. Hwcodec targets can't beep that way, so disable that beep for them.* Port the other vkeyboard enhancements (fixed character spelling and edit mode announcement) to the charcell vkeyboard (Player). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15064 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 05:56:53 +00:00
Steve Bavin
53b1aaf7b0 ...forgot one. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13616 a1c6a512-1295-4272-9138-f99709370657
 2007-06-11 08:30:13 +00:00
Nils Wallménius
f7a81a9d6a More header and dead code cleanup. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13430 a1c6a512-1295-4272-9138-f99709370657
 2007-05-19 20:55:49 +00:00
Jonathan Gordon
6a5cc0bd25 Customizable icons for all bitmap targets. (FS#7013) 
http://www.rockbox.org/twiki/bin/view/Main/CustomIcons for info on format and how to load them


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13177 a1c6a512-1295-4272-9138-f99709370657
 2007-04-16 09:14:36 +00:00
Jens Arnold
290a812e71 Make the charset more maintainable by using an enum for font indexing, fix wrong U circumflex, and add 2 missing characters to the vkeyboard. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12940 a1c6a512-1295-4272-9138-f99709370657
 2007-03-27 18:32:58 +00:00
Jens Arnold
51f4d3f212 Ooops. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12917 a1c6a512-1295-4272-9138-f99709370657
 2007-03-26 08:04:30 +00:00
Jens Arnold
ad4e3d6657 First step of charcell LCD code rework: * Make it fully unicode aware so that adding non-ISO8859-1 scripts becomes possible (limited by the LCD capabilities of course). * Make the API more similar to the bitmap LCD code's API. * Moved hardware dependent parts to target tree. * Simplified code. * Jumpscroll temporarily non-functional. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12916 a1c6a512-1295-4272-9138-f99709370657
 2007-03-26 07:52:13 +00:00
Jonathan Gordon
02a871780f Remove the need to double up the MENU macros in manu.h. 
Icons are now used by their id which must be part of the icons_6x8 enum, 
or Icon_NOICON for none


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12571 a1c6a512-1295-4272-9138-f99709370657
 2007-03-03 13:52:14 +00:00
Jens Arnold
28108ef6d1 Code cleanup. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8182 a1c6a512-1295-4272-9138-f99709370657
 2005-12-07 07:15:16 +00:00
Jens Arnold
4a90fb6d85 Fixed player vkeyboard to properly work with unicode on target. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8181 a1c6a512-1295-4272-9138-f99709370657
 2005-12-07 00:02:30 +00:00
Marcoen Hirschberg
b0fee17d6e waiting is over: initial unicode commit 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8169 a1c6a512-1295-4272-9138-f99709370657
 2005-12-06 13:27:15 +00:00
Kevin Ferrare
1a1abf25f4 removed old statusbar and buttonbar code 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8004 a1c6a512-1295-4272-9138-f99709370657
 2005-11-20 01:02:14 +00:00
Kevin Ferrare
8517ed8939 Multi screen support for playlist viewer, some fixes in other gui files 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7901 a1c6a512-1295-4272-9138-f99709370657
 2005-11-16 02:12:25 +00:00
Jens Arnold
c7e4f5f259 Keyboard code cleanup & optimisation. Corrected potential overflow problem. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7397 a1c6a512-1295-4272-9138-f99709370657
 2005-08-24 06:48:39 +00:00
Jens Arnold
6c00e38665 Icon code cleanup, optimisation & policeing. Removed unused icons. Applied uniform icon naming scheme. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7396 a1c6a512-1295-4272-9138-f99709370657
 2005-08-24 00:09:42 +00:00
Jens Arnold
3842dc3a72 A bit more elegant cursor position handling. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5851 a1c6a512-1295-4272-9138-f99709370657
 2005-02-08 08:24:36 +00:00
Jens Arnold
5c55e7f8ad New virtual keyboard for player: (1) Much more user friendly (button directions, no submenu). (2) Now voiced like the recorder keypad. (3) More compact and straightforward code. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5819 a1c6a512-1295-4272-9138-f99709370657
 2005-02-06 23:23:49 +00:00
Björn Stenberg
6c33c51a4c Redesigned the button handling. The code now uses symbolic function defines instead of checking for specific buttons. This makes it easier to add support for new devices with different button layouts. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5091 a1c6a512-1295-4272-9138-f99709370657
 2004-09-19 21:58:37 +00:00
Linus Nielsen Feltzing
4d49a6b26e Added bookmark icon for the Player/Studio 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4880 a1c6a512-1295-4272-9138-f99709370657
 2004-07-14 12:21:59 +00:00
Linus Nielsen Feltzing
6ed333e3d7 Fixed the Player keyboard cursor positioning, bug #983404 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4861 a1c6a512-1295-4272-9138-f99709370657
 2004-07-09 13:11:16 +00:00
Björn Stenberg
fb00c2190b Plugin/file type association system. Patch #879411 by Henrik Backe 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4677 a1c6a512-1295-4272-9138-f99709370657
 2004-05-21 20:08:24 +00:00
Daniel Stenberg
8e43ccbec6 Initial suppport for building Rockbox for Neo. The Neo has a different 
key layout so we need to check for this.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4138 a1c6a512-1295-4272-9138-f99709370657
 2003-12-12 13:34:27 +00:00
Björn Stenberg
ba371fb595 Added plugin loader. Moved games, demos and the text viewer to loadable plugins. Copy your *.rock files to /.rockbox/rocks/ 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3769 a1c6a512-1295-4272-9138-f99709370657
 2003-06-29 16:33:04 +00:00
Kjell Ericson
72d674368c We missed the null byte at the end of the string. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3718 a1c6a512-1295-4272-9138-f99709370657
 2003-06-02 12:07:11 +00:00
Mats Lidell
cad6f24a50 Synched with recorder: Starts editing at the end of the string. 
Bug with long strings fixed (Strings longer than newchars was
truncated.)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3431 a1c6a512-1295-4272-9138-f99709370657
 2003-03-11 15:05:04 +00:00
Mats Lidell
23826f0a34 Language support for player keyboard. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3196 a1c6a512-1295-4272-9138-f99709370657
 2003-01-31 07:26:56 +00:00
Kjell Ericson
ff4da18d1a Removed cursor before adding it. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3183 a1c6a512-1295-4272-9138-f99709370657
 2003-01-29 11:49:13 +00:00
Kjell Ericson
565505abd4 Added a "cursor"-function for the keyvoard. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3171 a1c6a512-1295-4272-9138-f99709370657
 2003-01-27 14:37:03 +00:00
Mats Lidell
50a1dcb9dd Cursor movement in the middle of the screen only moves the cursor. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3162 a1c6a512-1295-4272-9138-f99709370657
 2003-01-26 00:33:06 +00:00
Mats Lidell
95c542f8df Adds cursor blink and forward and backwards delete to keyboard input. (No lang support 
yet. Still experimental.)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3161 a1c6a512-1295-4272-9138-f99709370657
 2003-01-24 14:51:22 +00:00
Kjell Ericson
d853887a57 First version of a "better" keyboard handling for the Player. 
More to come from Mats and me.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3141 a1c6a512-1295-4272-9138-f99709370657
 2003-01-21 14:26:56 +00:00
Mats Lidell
f3313da2da First attempt in rocklatin1 input for player. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3134 a1c6a512-1295-4272-9138-f99709370657
 2003-01-20 12:25:28 +00:00