Nils Wallménius
46943ad40c
Avoid more useless string copys and make some random cleanups
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23092 a1c6a512-1295-4272-9138-f99709370657
2009-10-11 08:45:47 +00:00
Peter D'Hoye
dcdc2b93ae
Correct a recording screen usability issue created in r21034. Pause used to start too, then was set to only start and now only pauses. Rec used to start and split, then only split and now again starts and splits.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23055 a1c6a512-1295-4272-9138-f99709370657
2009-10-09 19:16:32 +00:00
Nils Wallménius
3200d04d75
Make the formatter functions used by the settings return a pointer to avoid usless copying of lang strings, this brought with it a long chain of const correctness and a few random cleanups
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22440 a1c6a512-1295-4272-9138-f99709370657
2009-08-20 16:47:44 +00:00
Thomas Martitz
4c48b59be8
User definable UI viewport, to be able to restrict the UI into a viewport for all bitmap displays.
...
Flyspray: FS#8799
This will allow for pretty themes, for example those with nice glass effects on their backdrops (some might argue they're wasting screen space but it's upto them),
as well as allowing for future background WPS updates in the main UI.
Plugins are not converted yet, they simply use the full screen. Ideally, any plugin that does *not* want the UI viewport, should take care of that itself (i.e. plugins should normally use the UI viewport).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22365 a1c6a512-1295-4272-9138-f99709370657
2009-08-16 22:20:11 +00:00
Antonius Hellmann
974a48004a
correct bottom viewport height calculation in the recording screen
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21961 a1c6a512-1295-4272-9138-f99709370657
2009-07-18 16:43:43 +00:00
Nils Wallménius
3d4701a6e4
FS#10080
...
* Move strncpy() from core to the pluginlib
* Introduce strlcpy() and use that instead in most places (use memcpy in a few) in core and some plugins
* Drop strncpy() from the codec api as no codec used it
* Bump codec and plugin api versions
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21863 a1c6a512-1295-4272-9138-f99709370657
2009-07-14 13:57:45 +00:00
Jonathan Gordon
f1034e00f6
FS#10406 - split the statusbar setting into one for each display, and allow the bar to be at the top or bottom of the display
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21665 a1c6a512-1295-4272-9138-f99709370657
2009-07-05 18:07:58 +00:00
Rafaël Carré
1910d026b1
fix a typo in comments (audio CD duration is not 74 or 80 hours)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21479 a1c6a512-1295-4272-9138-f99709370657
2009-06-23 21:22:06 +00:00
Marc Guay
814b3dbfbc
FS#10230 - Remove 'start new file if not recording' functionality from ACTION_REC_NEWFILE
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21034 a1c6a512-1295-4272-9138-f99709370657
2009-05-22 13:51:56 +00:00
Bertrik Sikken
0023943439
Fix duplicate #includes
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20977 a1c6a512-1295-4272-9138-f99709370657
2009-05-17 14:50:19 +00:00
Bertrik Sikken
09085a30f6
Remove unneeded #include "backdrop.h"
...
Remove unneeded #include "statusbar.h"
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20891 a1c6a512-1295-4272-9138-f99709370657
2009-05-09 18:09:14 +00:00
Jens Arnold
11ad7b4bc8
Move screendump from apps to firmware, solving two nasty firmware-to-apps calls. This required to move the filename creation functions as well. * Fix bug in the BMP header of Clip screendumps. * Add remote screendump for targets with an LCD remote. * Simplify some ifdefs and rename a macro in the sim.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19967 a1c6a512-1295-4272-9138-f99709370657
2009-02-10 23:43:37 +00:00
Jonathan Gordon
701a593c5d
continuation of last nights statusbar cleanup.
...
accept FS#9858 and FS#9859
make the rec and fm screens force the statusbar the correct way now which doesnt need extra status variables
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19904 a1c6a512-1295-4272-9138-f99709370657
2009-02-02 03:14:51 +00:00
Jonathan Gordon
e385ee18ce
Decouple the statusbar drawing from the rest of the screen drawing. it is not drawn roughly 4x per second automatically.
...
viewport_Set_defaults() will setup the given viewport with the correct "full screen" dimensions (so start at 0,0 if statusbars are disabled or 0,8 if they are enabled.)
All screens should keep the statusbar enabled, but if you really want to ignore the user setting you can disbaled it with viewportmanager_set_statusbar(false).
This commit also includes some menu/list viewport cleanups from kugel in FS#9603
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19622 a1c6a512-1295-4272-9138-f99709370657
2008-12-31 05:59:26 +00:00
Michael Sevakis
2e99b3d931
Gigabeat S: Allow recording from FM. Give FM the same volume range as playback. NOTE: This bumps the si4700 output volume to -0dB so other players with that may need a minor adjustment.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19619 a1c6a512-1295-4272-9138-f99709370657
2008-12-31 01:38:44 +00:00
Frank Gevaerts
059fff29ec
Since *set_led_enabled() is actually an ata-specific feature, move it back to ata_* only
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19006 a1c6a512-1295-4272-9138-f99709370657
2008-11-04 19:57:36 +00:00
Frank Gevaerts
2f8a0081c6
Apply FS#9500. This adds a storage_*() abstraction to replace ata_*(). To do that, it also introduces sd_*, nand_*, and mmc_*.
...
This should be a good first step to allow multi-driver targets, like the Elio (ATA/SD), or the D2 (NAND/SD).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18960 a1c6a512-1295-4272-9138-f99709370657
2008-11-01 16:14:28 +00:00
Björn Stenberg
9558c4956d
Moved pcm_record from firmware to apps. Cleaned up some. Now all code using struct mp3entry is in apps.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18807 a1c6a512-1295-4272-9138-f99709370657
2008-10-14 11:12:20 +00:00
Peter D'Hoye
528fe442fc
New recording setting to configure how mono recordings are made. Previously, this was always L+R, which was kinda silly if your signal was on L only. This setting allows for L, R or L+R. SWCODEC only for now, to be added for HWCODEC (although that will only be L and L+R probably)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18745 a1c6a512-1295-4272-9138-f99709370657
2008-10-08 22:18:16 +00:00
Peter D'Hoye
216b7d4247
Fix broken h1x0 sim build by providing a stub for pcm_sample_rate()
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18326 a1c6a512-1295-4272-9138-f99709370657
2008-08-20 22:57:02 +00:00
Peter D'Hoye
b4483f05af
Recording screen: show spdif samplerate on SWCODEC targets (with spdif of course). To be adapted so this also works for HWCODEC. And to be tested as I have no cable around and a broken disk in my h120....
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18325 a1c6a512-1295-4272-9138-f99709370657
2008-08-20 22:33:38 +00:00
Peter D'Hoye
44d4fcd7d2
Recording screen: do not show L/R gain settings when recording mono; do not show gain (and AGC) at all when recording via spdif.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18324 a1c6a512-1295-4272-9138-f99709370657
2008-08-20 21:38:47 +00:00
Peter D'Hoye
74b01ffbfd
Adapt comment to the fact that the splash is removed
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18283 a1c6a512-1295-4272-9138-f99709370657
2008-08-15 08:40:34 +00:00
Nils Wallménius
01729e7a18
FS#9281 Rename of splash functions.
...
* Remove gui_splash()
* Rename gui_syncsplash() to splashf() and remove its voice
capabilities.
* Rename the internal splash() to splash_internal() and introduce an
externally visible splash() that handles simple splashing without
printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ,
"foo"); if a LANG_* id is passed it will be voiced.
* Adjust all places that called gui_syncsplash() to use the correct
variant from above.
* Export both new functions to plugins and adjust places calling
rb->splash() to use the correct variant so that we now have naming
consistency between the core and plugins.
* Fix one latent bug that would cause my sim to crash with the above
changes and correct P2STR and P2ID macros, thanks to pondlife.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18282 a1c6a512-1295-4272-9138-f99709370657
2008-08-15 08:27:39 +00:00
Peter D'Hoye
2966c7cc5a
Fix a small delay in updating the recording screen. This caused the screen not to update when changing settings fast (key repeat)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18273 a1c6a512-1295-4272-9138-f99709370657
2008-08-13 21:09:10 +00:00
Peter D'Hoye
76b6262df8
Adapt clip counter to compact view of recording screen
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18246 a1c6a512-1295-4272-9138-f99709370657
2008-08-11 18:32:10 +00:00
Peter D'Hoye
4396b5b101
Recording screen: show a more compact view if 6 lines do not fit but 4 do. Should help things on small screens or with big fonts.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18239 a1c6a512-1295-4272-9138-f99709370657
2008-08-10 21:03:07 +00:00
Nils Wallménius
c49438419d
Style police, trigStat -> trig_stat
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18209 a1c6a512-1295-4272-9138-f99709370657
2008-08-07 11:48:56 +00:00
Peter D'Hoye
496e1f7e85
First step of the recording screen redesign. The screen is split into a fixed top part containing essential data and the peakmeters/triggerbar, and a bottom part that is in fact a list. The list contains the items that can be changed, and also some stuff that isn't important enough to be on the top part, like the filename. That filename is now shown completely. If the font is too big to have 6 lines on the display, sysfont is used.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18202 a1c6a512-1295-4272-9138-f99709370657
2008-08-06 20:12:44 +00:00
Jonathan Gordon
92bd97b121
fix FS#9146
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17945 a1c6a512-1295-4272-9138-f99709370657
2008-07-05 12:47:34 +00:00
Bertrik Sikken
f4d4a6ab60
Implement FS#8947 - Add a stub in the simulator for ata_disk_is_active. This make it possible to clean up some #ifdef SIMULATOR macros.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17927 a1c6a512-1295-4272-9138-f99709370657
2008-07-03 13:37:57 +00:00
Peter D'Hoye
205f3df781
Remove a viewport ambiguity by changing the screens width/heigth members into lcdwidth/lcdheight. Normal usercode should always use getwidth()/getheigth() as that returns the viewport width/height. Fixes issues that would have appeared in many places when introducing viewports with sizes != lcd sizes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17857 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 20:45:21 +00:00
Daniel Stenberg
2acc0ac542
Updated our source code header to explicitly mention that we are GPL v2 or
...
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 18:10:04 +00:00
Jonathan Gordon
bdbdb97f19
FS#9051 - remove LCD margins... use viewports if you need them...
...
NOTE to WPS people....
%m has been removed, but (i think) because of the other %m tags it wont fail if you try loading a wps with %m|..|, it will just be ignored.
Also note that if the statusbar is enabled the default viewport is 8 pixels shorter than when its not, i.e (0,0) is really (0,8) if the statusbar is shown... I dont think this will be a major issue because almost no WPS show the bar and use bitmaps... text only WPS shouldnt be affected.
Please report problem screens in http://forums.rockbox.org/index.php?topic=17358.0
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17763 a1c6a512-1295-4272-9138-f99709370657
2008-06-23 13:20:35 +00:00
Jonathan Gordon
ff469ab573
Updated recording trigger screen (seems to be a feature almost noone uses?)
...
problems/complaints in http://forums.rockbox.org/index.php?topic=16837.0
there is a known issue that on this screen the stop icon wont update, I dont know why and noone else wants to look at it, so hopefully this will force another set of eyes on it.. this is only a graphical issue... recordings still work fine
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17643 a1c6a512-1295-4272-9138-f99709370657
2008-05-28 10:55:39 +00:00
Peter D'Hoye
9098112869
Fix red
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17532 a1c6a512-1295-4272-9138-f99709370657
2008-05-15 23:00:33 +00:00
Peter D'Hoye
a3524029bf
Accept FS #8994 : add another recording filesplit option: stop recording and shutdown
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17531 a1c6a512-1295-4272-9138-f99709370657
2008-05-15 22:47:07 +00:00
Bertrik Sikken
e15f8a21a9
Made source files #include the header file that they implement to make sure they are in sync. Made some local functions static.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17312 a1c6a512-1295-4272-9138-f99709370657
2008-05-03 08:35:14 +00:00
Bertrik Sikken
2843469876
Moved atoi declaration to stdlib.h. Deleted atoi.h
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17280 a1c6a512-1295-4272-9138-f99709370657
2008-04-28 16:18:04 +00:00
Peter D'Hoye
9c3f6c4079
Simplify that clip indicator reset code a bit
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16559 a1c6a512-1295-4272-9138-f99709370657
2008-03-08 20:32:37 +00:00
Peter D'Hoye
30ab1a3c0e
Reset recording clipping indicators when changing gain. Solves FS #6147
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16557 a1c6a512-1295-4272-9138-f99709370657
2008-03-08 17:43:04 +00:00
Peter D'Hoye
db1e12bac0
Quick fix to prevent freezing of H10 (possibly others too) when left at the disk full message. Needs more investigation to find the cause of the freeze.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15938 a1c6a512-1295-4272-9138-f99709370657
2007-12-15 23:51:13 +00:00
Peter D'Hoye
05007e1a79
More code police
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15890 a1c6a512-1295-4272-9138-f99709370657
2007-12-07 00:31:31 +00:00
Peter D'Hoye
327d78eb6e
Code police
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15889 a1c6a512-1295-4272-9138-f99709370657
2007-12-07 00:28:16 +00:00
Peter D'Hoye
a007b558b3
Fix gradient selection bar in recording screen
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15888 a1c6a512-1295-4272-9138-f99709370657
2007-12-07 00:07:30 +00:00
Michael Sevakis
b0dd9eb5bc
Repair the no-spinup on start/split feature of recording. Recording directory selection broke it. Please only look at the disk during encoder loading opportunities in future additions.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15853 a1c6a512-1295-4272-9138-f99709370657
2007-11-30 05:14:57 +00:00
Linus Nielsen Feltzing
236cdaee03
Make the recording screen handle button repeats correctly when changing gain. Fixes FS#8038.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15811 a1c6a512-1295-4272-9138-f99709370657
2007-11-26 11:51:39 +00:00
Nils Wallménius
e711de2974
Make the variable for numbers of screens to update const on non-remote-lcd targets.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15806 a1c6a512-1295-4272-9138-f99709370657
2007-11-25 21:47:16 +00:00
Robert Kukla
ed64a663a0
make check_dir use dir_exists and slightly optimise the latter
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15744 a1c6a512-1295-4272-9138-f99709370657
2007-11-21 22:42:52 +00:00
Steve Bavin
31a2f33eb8
Mop up some yellow.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15207 a1c6a512-1295-4272-9138-f99709370657
2007-10-19 15:43:43 +00:00