Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Update CONTRIBUTING to reflect our switch to git on gerrit.

Browse source 
Fixes FS#12536

Change-Id: Iee4700ef01eb23c92a026df5074ffcf0257fe0ec
This commit is contained in:
Marcin Bukat 2012-01-24 13:05:25 +01:00
parent dc85718bfd
commit fee6f80fb8
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
docs/CONTRIBUTING
View file

@ -1,5 +1,3 @@
$Id$
__________ __ ___. __________ __ ___.
Open \______ \ ____ ____ | | _\_ |__ _______ ___ Open \______ \ ____ ____ | | _\_ |__ _______ ___
Source | _// _ \_/ ___\| |/ /| __ \ / _ \ \/ / Source | _// _ \_/ ___\| |/ /| __ \ / _ \ \/ /
@ -55,7 +53,7 @@ Braces for function declarations are put in a new line under the name, as in:
} }
Always indent your code with four spaces. Don't use TAB characters, as that Always indent your code with four spaces. Don't use TAB characters, as that
will mess up code display in CVS, printing, and a zillion other places. will mess up code display, printing, and a zillion other places.
Keep lines below 80 columns length. Use whitespace and newlines to make the Keep lines below 80 columns length. Use whitespace and newlines to make the
code easy to browse/read. code easy to browse/read.
@ -67,16 +65,18 @@ Use "unix style" line feeds: "LF" only. Do not use "CR+LF".
Use UTF-8 character set, but try to refrain from using any non-ascii Use UTF-8 character set, but try to refrain from using any non-ascii
letters as they will only appear weird in some camps no matter what. letters as they will only appear weird in some camps no matter what.
Patches Contributing code
------- -------
Create a patch using 'svn diff > mychanges.patch We have a public code review system based on git, which is also how you can
Trim your patches so they only contain relevant changes. check out the latest version of the Rockbox sources.
See http://www.rockbox.org/wiki/UsingGit for details on how to setup your
environment and how to upload a change you have made for review.
Submit your patch to the project via our patch tracker: We'd prefer that you don't submit patches to the bug tracker any more,
http://www.rockbox.org/tracker/index.php?type=4 as it's much harder to read and discuss them there.
Credits Credits
------- -------
We believe in crediting all contributors by name. Before committing a patch to We believe in crediting all contributors by name. Before committing a patch to
SVN, we ask that you give us your full real name (no pseudonyms or nicknames) Git, we ask that you give us your full real name (no pseudonyms or nicknames)
for adding to the credits list. for adding to the credits list.