Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

bookmark: Disable -Wformat-truncation around create_bookmark()

Browse source 
GCC 7 and up complain about this false positive when -Wformat-truncation
or -D_FORTIFY_SOURCE is turned on.

Primarily affects simulator builds on hosts with strict defaults.

Change-Id: I385b3c247775e1268b6bbd326b1afc3eb5453db7
This commit is contained in:
Solomon Peachy 2020-05-17 21:25:27 -04:00
parent 0cee5ba91b
commit d9454f11d5
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
apps/bookmark.c
View file

@ -372,7 +372,13 @@ static bool add_bookmark(const char* bookmark_file_name, const char* bookmark,
return true;
}
/* GCC 7 and up complain about the snprintf in create_bookmark() when
compiled with -D_FORTIFY_SOURCE or -Wformat-truncation
This is a false positive, so disable it here only */
#pragma GCC diagnostic push
#if __GNUC__ >= 7
#pragma GCC diagnostic ignored "-Wformat-truncation"
#endif
/* ----------------------------------------------------------------------- */
/* This function takes the system resume data and formats it into a valid */
/* bookmark. */
@ -441,6 +447,7 @@ static char* create_bookmark()
else
return NULL;
}
#pragma GCC diagnostic pop /* -Wformat-truncation */
/* ----------------------------------------------------------------------- */
/* This function will determine if an autoload is necessary. This is an */