Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Increase id3v2 max item size on high mem targets

Browse source 
As per multiple user requests:
https://forums.rockbox.org/index.php/topic,53319.msg

The acceptable size for id3v2 fields currently maxes out at
240 bytes on targets with more than 2MB of memory.

The comments field, especially for Podcasts, can sometimes
contain significantly more characters than Rockbox allows.

The limit for devices with more than 8MB of memory
is increased to 500 bytes for individual fields, and
to 1800 bytes for the buffer containing all fields.

Change-Id: I4593372229158756f102f67bcc4a43e64f632d58
This commit is contained in:
Christian Soffke 2021-03-20 19:13:08 +01:00 committed by William Wilgus
parent d5676fcd90
commit a8846e3003
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/rbcodec/metadata/metadata.h
View file

@ -176,7 +176,10 @@ struct afmt_entry
/* database of labels and codecs. add formats per above enum */ /* database of labels and codecs. add formats per above enum */
extern const struct afmt_entry audio_formats[AFMT_NUM_CODECS]; extern const struct afmt_entry audio_formats[AFMT_NUM_CODECS];
#if MEMORYSIZE > 2 #if MEMORYSIZE > 8
#define ID3V2_BUF_SIZE 1800
#define ID3V2_MAX_ITEM_SIZE 500
#elif MEMORYSIZE > 2
#define ID3V2_BUF_SIZE 900 #define ID3V2_BUF_SIZE 900
#define ID3V2_MAX_ITEM_SIZE 240 #define ID3V2_MAX_ITEM_SIZE 240
#else #else