Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

gcc 4.3.1 quite rightfully warnings when printf-style functions use "format

Browse source 
not a string literal and no format arguments". Those occurances can (will?)
lead to future nasty and surprising bugs. These are just a few of a very large
amount of necessary fixes.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18274 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Daniel Stenberg 2008-08-13 21:38:33 +00:00
parent 2966c7cc5a
commit a30f5e4b64
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
apps/menus/playback_menu.c
View file

@ -143,7 +143,7 @@ static int audioscrobbler_callback(int action,const struct menu_item_ex *this_it
{ {
case ACTION_EXIT_MENUITEM: /* on exit */ case ACTION_EXIT_MENUITEM: /* on exit */
if (!scrobbler_is_enabled() && global_settings.audioscrobbler) if (!scrobbler_is_enabled() && global_settings.audioscrobbler)
gui_syncsplash(HZ*2, ID2P(LANG_PLEASE_REBOOT)); gui_syncsplash(HZ*2, "%s", ID2P(LANG_PLEASE_REBOOT));
if(scrobbler_is_enabled() && !global_settings.audioscrobbler) if(scrobbler_is_enabled() && !global_settings.audioscrobbler)
scrobbler_shutdown(); scrobbler_shutdown();
@ -161,7 +161,7 @@ static int cuesheet_callback(int action,const struct menu_item_ex *this_item)
{ {
case ACTION_EXIT_MENUITEM: /* on exit */ case ACTION_EXIT_MENUITEM: /* on exit */
if (!cuesheet_is_enabled() && global_settings.cuesheet) if (!cuesheet_is_enabled() && global_settings.cuesheet)
gui_syncsplash(HZ*2, ID2P(LANG_PLEASE_REBOOT)); gui_syncsplash(HZ*2, "%s", ID2P(LANG_PLEASE_REBOOT));
break; break;
} }
return action; return action;

2
firmware/panic.c
View file

@ -80,7 +80,7 @@ void panicf( const char *fmt, ...)
/* no LCD */ /* no LCD */
#endif #endif
lcd_update(); lcd_update();
DEBUGF(panic_buf); DEBUGF("%s", panic_buf);
set_cpu_frequency(0); set_cpu_frequency(0);