Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

WPS plugin hotkey: Fix UB

Browse source 
HOTKEY_PLUGIN action resulted in return value
of void function being assigned and then returned
by execute_hotkey.

Change-Id: I8b141e878fc2c0b09070186fc3520314c18a83b0
This commit is contained in:
Christian Soffke 2022-11-19 22:19:15 +01:00
parent dcde5aa89d
commit 8fe42c43c6
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
apps/onplay.c
View file

@ -1828,17 +1828,18 @@ static int tree_hotkey_run_plugin(void *param)
return ONPLAY_RELOAD_DIR;
}
static void hotkey_run_plugin(void)
static int hotkey_run_plugin(void)
{
open_plugin_run(ID2P(LANG_HOTKEY_WPS));
return ONPLAY_OK;
}
struct hotkey_assignment {
int action; /* hotkey_action */
int lang_id; /* Language ID */
struct menu_func func; /* Function to run if this entry is selected */
int return_code; /* What to return after the function is run */
};
int return_code; /* What to return after the function is run. ONPLAY_OK here */
}; /* means to use function return code, see execute_hotkey */
#define HOTKEY_FUNC(func, param) {{(void *)func}, param}