Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

doom: Fix a potential buffer trashing in the doom plugin

Browse source 
(caught by GCC12's -Waddress)

Change-Id: I122b44324c60c668ed4a066aa6301d40cb7597ba
This commit is contained in:
Solomon Peachy 2022-07-11 19:35:10 -04:00
parent 632af4837e
commit 840fb4d47b
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
apps/plugins/doom/d_deh.c
View file

@ -2868,6 +2868,7 @@ boolean deh_GetData(char *s, char *k, uint_64_t *l, char **strval, int fpout)
if (*t == '=') break; if (*t == '=') break;
buffer[i] = *t; // copy it buffer[i] = *t; // copy it
} }
if (i == 0) i = 1; /* Just in case */
buffer[--i] = '\0'; // terminate the key before the '=' buffer[--i] = '\0'; // terminate the key before the '='
if (!*t) // end of string with no equal sign if (!*t) // end of string with no equal sign
{ {