Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

tagcache.c remove 16-bit compression for add_uniqbuf

Browse source 
apparently there are tags such as year or genre that are indexed 1 byte
apart, as much as I like the idea of this I cannot come up with a way
to reliably denote 2 16 bit entries from a single 32 bit entry without
losing data or adding bookkeeping which would likely make it pointless

Change-Id: I8a9908575700cab9506c36f5422222145557fa6b
This commit is contained in:
William Wilgus 2022-03-22 00:22:42 -04:00
parent cfeeb7889d
commit 61bc7b91bc
1 changed files with 5 additions and 44 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
apps/tagcache.c
View file

@ -1284,52 +1284,13 @@ static bool add_uniqbuf(struct tagcache_search *tcs, uint32_t id)
return true; return true;
} }
if (id <= UINT16_MAX) for (i = 0; i < tcs->unique_list_count; i++)
{ {
/* place two 16-bit entries in a single 32-bit slot */ /* Return false if entry is found. */
uint32_t idtmp; if (tcs->unique_list[i] == id)
union uentry{
uint16_t u16[2];
uint32_t u32;
} *entry;
id |= 1; /*odd - flag 16-bit entry */
for (i = 0; i < tcs->unique_list_count; i++)
{ {
entry = (union uentry *) &tcs->unique_list[i]; //logf("%d Exists @ %d", id, i);
if ((entry->u32 & 1) == 0) /* contains a 32-bit entry */ return false;
continue;
/* Return false if entry is found. */
if (entry->u16[0] == id || entry->u16[1] == id)
{
//logf("%d Exists (16) @ %d", id, i);
return false;
}
if (entry->u16[1] == 0 && (entry->u16[0] & 1) == 1)
{
entry->u16[1] = id & UINT16_MAX;
return true; /*no more 16bit entries add to empty 16bit slot */
}
}
/* Not Found and no empty slot add a new entry */
entry = (union uentry *) &idtmp;
entry->u16[1] = 0;
entry->u16[0] = id & UINT16_MAX;
id = idtmp;
}
else
{
id &= ~1; /* even - flag 32-bit entry */
for (i = 0; i < tcs->unique_list_count; i++)
{
/* Return false if entry is found. */
if (tcs->unique_list[i] == id)
{
//logf("%d Exists (32)@ %d", id, i);
return false;
}
} }
} }