Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

playlist.c fix old out of bounds read

Browse source 
In case next_index == -1, this would read before the start of
the playlist->indices buffer.

Change-Id: I0a32a31c7c97c755a1217b8bea90a650f9e36a93
This commit is contained in:
Aidan MacDonald 2023-01-04 19:54:07 +00:00
parent 5d0c382a59
commit 5bb062391f
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
apps/playlist.c
View file

@ -1828,7 +1828,8 @@ static int get_next_index(const struct playlist_info* playlist, int steps,
}
/* No luck if the whole playlist was bad. */
if (playlist->indices[next_index] & PLAYLIST_SKIPPED)
if (next_index < 0 || next_index >= playlist->amount ||
playlist->indices[next_index] & PLAYLIST_SKIPPED)
return -1;
return next_index;