Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

FS#13186: IAP: Send periodic updates in mode 4 (Stefan Ott)

Browse source 
Devices in IAP mode 4 do not explicitly request specific notifications, thus they don't get *any* periodic notifications at the moment (in particular, they miss the track position updates that are supposed to be sent out every 500 ms).

The attached patch fixes this by skipping an early return for devices in IST_EXTENDED state.

Change-Id: I23e35247dd0494e537429d4fd9d51dc7f4653d76
This commit is contained in:
Solomon Peachy 2020-03-29 12:42:16 -04:00
parent f86f7883f5
commit 51ad625404
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/iap/iap-core.c
View file

@ -855,7 +855,7 @@ void iap_periodic(void)
} }
if (!device.do_notify) return; if (!device.do_notify) return;
if (device.notifications == 0) return; if ((device.notifications == 0) && (interface_state != IST_EXTENDED)) return;
/* Volume change notifications are sent every 100ms */ /* Volume change notifications are sent every 100ms */
if (device.notifications & (BIT_N(4) | BIT_N(16))) { if (device.notifications & (BIT_N(4) | BIT_N(16))) {

1
docs/CREDITS
View file

@ -683,6 +683,7 @@ Andy Potter
Stefan Waigand Stefan Waigand
Guo Zhong Kai Guo Zhong Kai
Martin Buck Martin Buck
Stefan Ott
The libmad team The libmad team
The wavpack team The wavpack team