Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fuze+: make sure lcd is ready before chaning a register

Browse source 
The lcd driver does not wait for the refresh to be done to return
from lcd_update(). This means that changing a register is unsafe
if done in the middle of the redraw. This could happen when
disabling the lcd for example. Make sure it doesn't happen by
waiting for the lcdif to be ready.

Change-Id: I43ec62a637dd61c3b2a3a6e131c1a9e8035524b1
This commit is contained in:
Amaury Pouly 2012-12-26 02:39:39 +01:00
parent 7fddc2327b
commit 38878020d2
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
firmware/target/arm/imx233/sansa-fuzeplus/lcd-fuzeplus.c
View file

@ -208,6 +208,7 @@ static uint32_t i80_read_register(uint32_t data_out)
static void lcd_write_reg(uint32_t reg, uint32_t data) static void lcd_write_reg(uint32_t reg, uint32_t data)
{ {
uint32_t old_reg = reg; uint32_t old_reg = reg;
imx233_lcdif_wait_ready();
/* get back to 18-bit word length */ /* get back to 18-bit word length */
imx233_lcdif_set_word_length(HW_LCDIF_CTRL__WORD_LENGTH_18_BIT); imx233_lcdif_set_word_length(HW_LCDIF_CTRL__WORD_LENGTH_18_BIT);
reg = encode_16_to_18(reg); reg = encode_16_to_18(reg);