Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

skin_engine: Fix %if() when comparing against a negative number.

Browse source 
If the tag being checked returns a negative number (e.g. %LI does that
when the current list item does not have an icon) the tag's value would
always end up being 1.

Change-Id: I69ab175b6c46dd7567386e649732dbb8327972fc
This commit is contained in:
Georg Gadinger 2021-01-23 16:39:23 +01:00
parent befae2909f
commit 278e7457ea
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/gui/skin_engine/skin_tokens.c
View file

@ -598,7 +598,7 @@ static const char* NOINLINE get_lif_token_value(struct gui_wps *gwps,
break; break;
} }
case INTEGER: case INTEGER:
if (!number_set && out_text && *out_text >= '0' && *out_text <= '9') if (!number_set && out_text && ((*out_text >= '0' && *out_text <= '9') || (*out_text == '-' && out_text[1] >= '0' && out_text[1] <= '9')))
a = atoi(out_text); a = atoi(out_text);
/* fall through */ /* fall through */
case PERCENT: case PERCENT:

1
docs/CREDITS
View file

@ -699,6 +699,7 @@ Michael Rey
Yuxuan Shui Yuxuan Shui
James Buren James Buren
Issa Beganović Issa Beganović
Georg Gadinger
The libmad team The libmad team
The wavpack team The wavpack team