Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

x1000-installer: remove redundant overflow check

Browse source 
This overflow is impossible to trigger due to the simple
relationship between binary and hexadecimal numbers.

Change-Id: Ie8243129967abb935a77152a808765318052c979
This commit is contained in:
Aidan MacDonald 2021-11-28 14:38:09 +00:00
parent c086a3386f
commit 1ad60c3344
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/x1000-installer/src/xf_flashmap.c
View file

@ -136,10 +136,8 @@ int xf_map_parseline(const char* line, struct xf_map* map)
if(int_val > UINT32_MAX/16) if(int_val > UINT32_MAX/16)
return XF_E_INT_OVERFLOW; return XF_E_INT_OVERFLOW;
int_val *= 16;
if(int_val > UINT32_MAX - digit_val) int_val *= 16;
return XF_E_INT_OVERFLOW;
int_val |= digit_val; int_val |= digit_val;
} }
} }