Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Threading: Use 'size_t' for stack size in core threading code

Browse source 
For some reason it was defined as 'unsigned short' but all arguments to
the threading functions and other structs used size_t.  The SDL plugin
tried to allocate a 2MB stack and this resulted in much badness.

This is a _very_ old bug, and might be responsible for countless subtle
bugs!

Change-Id: I8b7fd79a10c21e3ab524a89b4d40d9afa4fab638
This commit is contained in:
Solomon Peachy 2020-04-04 23:27:27 -04:00
parent 3ee2fdb7c0
commit 191ffe272b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
firmware/kernel/thread-internal.h
View file

@ -128,7 +128,7 @@ struct thread_entry
all threads blocked by this one) */
#endif
#ifndef HAVE_SDL_THREADS
unsigned short stack_size; /* Size of stack in bytes */
size_t stack_size; /* Size of stack in bytes */
#endif
unsigned char state; /* Thread slot state (STATE_*) */
#ifdef HAVE_SCHEDULER_BOOSTCTRL