Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

usb: Fix iPod video connection issues

Browse source 
Apparently a response is coming out of nowhere and tripping this
check. I can't be bothered to look into it; it would be better to
just update the ARC USB driver to the new control request API...

Change-Id: Ic5062443e060534f170d3afe17c00d3c25d1d3bd
This commit is contained in:
Aidan MacDonald 2023-01-23 16:01:43 +00:00
parent c0c1a6e5f0
commit 1025283042
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
firmware/usbstack/usb_core.c
View file

@ -1040,10 +1040,15 @@ void usb_drv_control_response(enum usb_control_response resp,
unsigned int num_active = num_active_requests--; unsigned int num_active = num_active_requests--;
/* /*
* There must have been a prior request submission, at least. * There should have been a prior request submission, at least.
* FIXME: It seems the iPod video can get here and ignoring it
* allows the connection to succeed??
*/ */
if (num_active == 0) if (num_active == 0)
panicf("null ctrl req"); {
//panicf("null ctrl req");
return;
}
/* /*
* This can happen because an active request was already pending when * This can happen because an active request was already pending when