Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove some old code which tries to clear/set the backdrop when starting plugins which is broken and potentially can cause backdrop corruption if the backdrop buffers move during the plugin lifetime

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30545 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Jonathan Gordon 2011-09-14 12:47:26 +00:00
parent da44fd6f99
commit 08d285b414
1 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
apps/plugin.c
View file

@ -812,10 +812,6 @@ int plugin_load(const char* plugin, const void* parameter)
struct plugin_header *p_hdr; struct plugin_header *p_hdr;
struct lc_header *hdr; struct lc_header *hdr;
#if LCD_DEPTH > 1
fb_data* old_backdrop;
#endif
if (current_plugin_handle && pfn_tsr_exit) if (current_plugin_handle && pfn_tsr_exit)
{ /* if we have a resident old plugin and a callback */ { /* if we have a resident old plugin and a callback */
if (pfn_tsr_exit(!strcmp(current_plugin, plugin)) == false ) if (pfn_tsr_exit(!strcmp(current_plugin, plugin)) == false )
@ -869,9 +865,6 @@ int plugin_load(const char* plugin, const void* parameter)
*(p_hdr->api) = &rockbox_api; *(p_hdr->api) = &rockbox_api;
#if defined HAVE_LCD_BITMAP && LCD_DEPTH > 1
old_backdrop = lcd_get_backdrop();
#endif
lcd_clear_display(); lcd_clear_display();
lcd_update(); lcd_update();
@ -914,7 +907,6 @@ int plugin_load(const char* plugin, const void* parameter)
#ifdef HAVE_LCD_BITMAP #ifdef HAVE_LCD_BITMAP
lcd_setfont(FONT_UI); lcd_setfont(FONT_UI);
#if LCD_DEPTH > 1 #if LCD_DEPTH > 1
lcd_set_backdrop(old_backdrop);
#ifdef HAVE_LCD_COLOR #ifdef HAVE_LCD_COLOR
lcd_set_drawinfo(DRMODE_SOLID, global_settings.fg_color, lcd_set_drawinfo(DRMODE_SOLID, global_settings.fg_color,
global_settings.bg_color); global_settings.bg_color);
@ -942,7 +934,7 @@ int plugin_load(const char* plugin, const void* parameter)
#endif #endif
FOR_NB_SCREENS(i) FOR_NB_SCREENS(i)
viewportmanager_theme_undo(i, false); viewportmanager_theme_undo(i, true);
#ifdef HAVE_PLUGIN_CHECK_OPEN_CLOSE #ifdef HAVE_PLUGIN_CHECK_OPEN_CLOSE
if(open_files != 0 && !current_plugin_handle) if(open_files != 0 && !current_plugin_handle)