rockbox/tools/checkwps/checkwps.c
Michael Sevakis 7d1a47cf13 Rewrite filesystem code (WIP)
This patch redoes the filesystem code from the FAT driver up to the
clipboard code in onplay.c.

Not every aspect of this is finished therefore it is still "WIP". I
don't wish to do too much at once (haha!). What is left to do is get
dircache back in the sim and find an implementation for the dircache
indicies in the tagcache and playlist code or do something else that
has the same benefit. Leaving these out for now does not make anything
unusable. All the basics are done.

Phone app code should probably get vetted (and app path handling
just plain rewritten as environment expansions); the SDL app and
Android run well.

Main things addressed:
1) Thread safety: There is none right now in the trunk code. Most of
what currently works is luck when multiple threads are involved or
multiple descriptors to the same file are open.

2) POSIX compliance: Many of the functions behave nothing like their
counterparts on a host system. This leads to inconsistent code or very
different behavior from native to hosted. One huge offender was
rename(). Going point by point would fill a book.

3) Actual running RAM usage: Many targets will use less RAM and less
stack space (some more RAM because I upped the number of cache buffers
for large memory). There's very little memory lying fallow in rarely-used
areas (see 'Key core changes' below). Also, all targets may open the same
number of directory streams whereas before those with less than 8MB RAM
were limited to 8, not 12 implying those targets will save slightly
less.

4) Performance: The test_disk plugin shows markedly improved performance,
particularly in the area of (uncached) directory scanning, due partly to
more optimal directory reading and to a better sector cache algorithm.
Uncached times tend to be better while there is a bit of a slowdown in
dircache due to it being a bit heavier of an implementation. It's not
noticeable by a human as far as I can say.

Key core changes:
1) Files and directories share core code and data structures.

2) The filesystem code knows which descriptors refer to same file.
This ensures that changes from one stream are appropriately reflected
in every open descriptor for that file (fileobj_mgr.c).

3) File and directory cache buffers are borrowed from the main sector
cache. This means that when they are not in use by a file, they are not
wasted, but used for the cache. Most of the time, only a few of them
are needed. It also means that adding more file and directory handles
is less expensive. All one must do in ensure a large enough cache to
borrow from.

4) Relative path components are supported and the namespace is unified.
It does not support full relative paths to an implied current directory;
what is does support is use of "." and "..". Adding the former would
not be very difficult. The namespace is unified in the sense that
volumes may be specified several times along with relative parts, e.g.:
"/<0>/foo/../../<1>/bar" :<=> "/<1>/bar".

5) Stack usage is down due to sharing of data, static allocation and
less duplication of strings on the stack. This requires more
serialization than I would like but since the number of threads is
limited to a low number, the tradoff in favor of the stack seems
reasonable.

6) Separates and heirarchicalizes (sic) the SIM and APP filesystem
code. SIM path and volume handling is just like the target. Some
aspects of the APP file code get more straightforward (e.g. no path
hashing is needed).

Dircache:
Deserves its own section. Dircache is new but pays homage to the old.
The old one was not compatible and so it, since it got redone, does
all the stuff it always should have done such as:

1) It may be update and used at any time during the build process.
No longer has one to wait for it to finish building to do basic file
management (create, remove, rename, etc.).

2) It does not need to be either fully scanned or completely disabled;
it can be incomplete (i.e. overfilled, missing paths), still be
of benefit and be correct.

3) Handles mounting and dismounting of individual volumes which means
a full rebuild is not needed just because you pop a new SD card in the
slot. Now, because it reuses its freed entry data, may rebuild only
that volume.

4) Much more fundamental to the file code. When it is built, it is
the keeper of the master file list whether enabled or not ("disabled"
is just a state of the cache). Its must always to ready to be started
and bind all streams opened prior to being enabled.

5) Maintains any short filenames in OEM format which means that it does
not need to be rebuilt when changing the default codepage.

Miscellaneous Compatibility:
1) Update any other code that would otherwise not work such as the
hotswap mounting code in various card drivers.

2) File management: Clipboard needed updating because of the behavioral
changes. Still needs a little more work on some finer points.

3) Remove now-obsolete functionality such as the mutex's "no preempt"
flag (which was only for the prior FAT driver).

4) struct dirinfo uses time_t rather than raw FAT directory entry
time fields. I plan to follow up on genericizing everything there
(i.e. no FAT attributes).

5) unicode.c needed some redoing so that the file code does not try
try to load codepages during a scan, which is actually a problem with
the current code. The default codepage, if any is required, is now
kept in RAM separarately (bufalloced) from codepages specified to
iso_decode() (which must not be bufalloced because the conversion
may be done by playback threads).

Brings with it some additional reusable core code:
1) Revised file functions: Reusable code that does things such as
safe path concatenation and parsing without buffer limitations or
data duplication. Variants that copy or alter the input path may be
based off these.

To do:
1) Put dircache functionality back in the sim. Treating it internally
as a different kind of file system seems the best approach at this
time.

2) Restore use of dircache indexes in the playlist and database or
something effectively the same. Since the cache doesn't have to be
complete in order to be used, not getting a hit on the cache doesn't
unambiguously say if the path exists or not.

Change-Id: Ia30f3082a136253e3a0eae0784e3091d138915c8
Reviewed-on: http://gerrit.rockbox.org/566
Reviewed-by: Michael Sevakis <jethead71@rockbox.org>
Tested: Michael Sevakis <jethead71@rockbox.org>
2014-08-30 03:48:23 +02:00

341 lines
8.3 KiB
C

/***************************************************************************
* __________ __ ___.
* Open \______ \ ____ ____ | | _\_ |__ _______ ___
* Source | _// _ \_/ ___\| |/ /| __ \ / _ \ \/ /
* Jukebox | | ( <_> ) \___| < | \_\ ( <_> > < <
* Firmware |____|_ /\____/ \___ >__|_ \|___ /\____/__/\_ \
* \/ \/ \/ \/ \/
* $Id$
*
* Copyright (C) 2008 by Dave Chapman
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
* KIND, either express or implied.
*
****************************************************************************/
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include "config.h"
#include "checkwps.h"
#include "resize.h"
#include "wps.h"
#include "skin_buffer.h"
#include "skin_debug.h"
#include "skin_engine.h"
#include "wps_internals.h"
#include "settings.h"
#include "viewport.h"
#include "file.h"
#include "font.h"
bool debug_wps = true;
int wps_verbose_level = 0;
char *skin_buffer;
const char *sim_root_dir = ".";
const struct settings_list *settings;
const int nb_settings = 0;
#ifdef SIMULATOR
#error beep beep
#endif
/* static endianness conversion */
#define SWAP_16(x) ((typeof(x))(unsigned short)(((unsigned short)(x) >> 8) | \
((unsigned short)(x) << 8)))
#define SWAP_32(x) ((typeof(x))(unsigned long)( ((unsigned long)(x) >> 24) | \
(((unsigned long)(x) & 0xff0000ul) >> 8) | \
(((unsigned long)(x) & 0xff00ul) << 8) | \
((unsigned long)(x) << 24)))
#ifndef letoh16
unsigned short letoh16(unsigned short x)
{
unsigned short n = 0x1234;
unsigned char* ch = (unsigned char*)&n;
if (*ch == 0x34)
{
/* Little-endian */
return x;
} else {
return SWAP_16(x);
}
}
#endif
#ifndef letoh32
unsigned short letoh32(unsigned short x)
{
unsigned short n = 0x1234;
unsigned char* ch = (unsigned char*)&n;
if (*ch == 0x34)
{
/* Little-endian */
return x;
} else {
return SWAP_32(x);
}
}
#endif
#ifndef htole32
unsigned int htole32(unsigned int x)
{
unsigned short n = 0x1234;
unsigned char* ch = (unsigned char*)&n;
if (*ch == 0x34)
{
/* Little-endian */
return x;
} else {
return SWAP_32(x);
}
}
#endif
int recalc_dimension(struct dim *dst, struct dim *src)
{
return 0;
}
#ifdef HAVE_ALBUMART
int playback_claim_aa_slot(struct dim *dim)
{
return 0;
}
void playback_release_aa_slot(int slot)
{
return;
}
#endif
int resize_on_load(struct bitmap *bm, bool dither,
struct dim *src, struct rowset *tmp_row,
unsigned char *buf, unsigned int len,
const struct custom_format *cformat,
IF_PIX_FMT(int format_index,)
struct img_part* (*store_part)(void *args),
void *args)
{
return 0;
}
static char pluginbuf[PLUGIN_BUFFER_SIZE];
static unsigned dummy_func2(void)
{
return 0;
}
void* plugin_get_buffer(size_t *buffer_size)
{
*buffer_size = PLUGIN_BUFFER_SIZE;
return pluginbuf;
}
struct user_settings global_settings = {
.statusbar = STATUSBAR_TOP,
#ifdef HAVE_LCD_COLOR
.bg_color = LCD_DEFAULT_BG,
.fg_color = LCD_DEFAULT_FG,
#endif
};
struct system_status global_status;
int getwidth(void) { return LCD_WIDTH; }
int getheight(void) { return LCD_HEIGHT; }
int getuifont(void) { return 0; }
#ifdef HAVE_REMOTE_LCD
int remote_getwidth(void) { return LCD_REMOTE_WIDTH; }
int remote_getheight(void) { return LCD_REMOTE_HEIGHT; }
#endif
static inline bool backdrop_load(const char *filename, char* backdrop_buffer)
{
(void)filename; (void)backdrop_buffer; return true;
}
struct screen screens[NB_SCREENS] =
{
{
.screen_type=SCREEN_MAIN,
.lcdwidth=LCD_WIDTH,
.lcdheight=LCD_HEIGHT,
.depth=LCD_DEPTH,
#ifdef HAVE_LCD_COLOR
.is_color=true,
#else
.is_color=false,
#endif
.getwidth = getwidth,
.getheight = getheight,
#ifdef HAVE_LCD_BITMAP
.getuifont = getuifont,
#endif
#if LCD_DEPTH > 1
.get_foreground=dummy_func2,
.get_background=dummy_func2,
.backdrop_load=backdrop_load,
#endif
},
#ifdef HAVE_REMOTE_LCD
{
.screen_type=SCREEN_REMOTE,
.lcdwidth=LCD_REMOTE_WIDTH,
.lcdheight=LCD_REMOTE_HEIGHT,
.depth=LCD_REMOTE_DEPTH,
.getuifont = getuifont,
.is_color=false,/* No color remotes yet */
.getwidth=remote_getwidth,
.getheight=remote_getheight,
#if LCD_REMOTE_DEPTH > 1
.get_foreground=dummy_func2,
.get_background=dummy_func2,
.backdrop_load=backdrop_load,
#endif
}
#endif
};
#ifdef HAVE_LCD_BITMAP
void screen_clear_area(struct screen * display, int xstart, int ystart,
int width, int height)
{
display->set_drawmode(DRMODE_SOLID|DRMODE_INVERSEVID);
display->fillrect(xstart, ystart, width, height);
display->set_drawmode(DRMODE_SOLID);
}
#endif
#if CONFIG_TUNER
bool radio_hardware_present(void)
{
return true;
}
#endif
#ifdef HAVE_LCD_BITMAP
static int loaded_fonts = 0;
static struct font _font;
int font_load(const char *path)
{
int id = 2 + loaded_fonts;
loaded_fonts++;
return id;
}
void font_unload(int font_id)
{
(void)font_id;
}
struct font* font_get(int font)
{
return &_font;
}
#endif
/* This is no longer defined in ROCKBOX builds so just use a huge value */
#define SKIN_BUFFER_SIZE (200*1024)
int main(int argc, char **argv)
{
int res;
int filearg = 1;
struct wps_data wps={0};
enum screen_type screen = SCREEN_MAIN;
struct screen* wps_screen;
/* No arguments -> print the help text
* Also print the help text upon -h or --help */
if( (argc < 2) ||
strcmp(argv[1],"-h") == 0 ||
strcmp(argv[1],"--help") == 0 )
{
printf("Usage: checkwps [OPTIONS] filename.wps [filename2.wps]...\n");
printf("\nOPTIONS:\n");
printf("\t-v\t\tverbose\n");
printf("\t-vv\t\tmore verbose\n");
printf("\t-vvv\t\tvery verbose\n");
printf("\t-h,\t--help\tshow this message\n");
return 1;
}
if (argv[1][0] == '-') {
filearg++;
int i = 1;
while (argv[1][i] && argv[1][i] == 'v') {
i++;
wps_verbose_level++;
}
}
skin_buffer = malloc(SKIN_BUFFER_SIZE);
if (!skin_buffer)
{
printf("mallloc fail!\n");
return 1;
}
skin_buffer_init(skin_buffer, SKIN_BUFFER_SIZE);
/* Go through every skin that was thrown at us, error out at the first
* flawed wps */
while (argv[filearg]) {
const char* name = argv[filearg++];
char *ext = strrchr(name, '.');
struct skin_stats stats;
printf("Checking %s...\n", name);
if (!ext)
{
printf("Invalid extension\n");
return 2;
}
ext++;
if (!strcmp(ext, "rwps") || !strcmp(ext, "rsbs") || !strcmp(ext, "rfms"))
{
#ifdef HAVE_REMOTE_LCD
screen = SCREEN_REMOTE;
#else
/* skip rwps etc. if not supported on this target (not an error) */
continue;
#endif
}
else if (!strcmp(ext, "wps") || !strcmp(ext, "sbs") || !strcmp(ext, "fms"))
{
screen = SCREEN_MAIN;
}
else
{
printf("Invalid extension\n");
return 2;
}
wps_screen = &screens[screen];
res = skin_data_load(screen, &wps, name, true, &stats);
if (!res) {
printf("WPS parsing failure\n");
skin_error_format_message();
return 3;
}
printf("WPS parsed OK\n\n");
if (wps_verbose_level>2)
skin_debug_tree(SKINOFFSETTOPTR(skin_buffer, wps.tree));
}
return 0;
}