Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
19902 commits 17 branches 142 tags 291 MiB
Commit graph

168 commits

Author SHA1 Message Date
Thomas Martitz
87d1744e91 Fix playlist "Insert" a bit. 
If insert was used to create a new playlist (e.g. inserting without audio playing), the insert position wasn't updated. Thus, the playlist created was in reversed order (except for the first song).
This was the reason "Insert last" was actually used as Insert in this case. BUT, this one doesn't update the insert position eiterh, but the order of the songs is fine, at least (due to appending).
Now, insert always updates the insert position properly, so that the aforementioned bugs are fixed. Insert is always used now.
Other impact: If you create a playlist using insert, every subsequent insert will append songs at the end of the playlist,if you start playback pressing select on songs, every subsequent insert will insert after the current track.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20241 a1c6a512-1295-4272-9138-f99709370657
 2009-03-08 17:18:18 +00:00
Jonas Häggqvist
73639e8e2e Fix FS#9945 - Paste operation doesn't detect disk full (and possibly other errors). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20121 a1c6a512-1295-4272-9138-f99709370657
 2009-02-26 22:55:04 +00:00
Jonathan Gordon
e385ee18ce Decouple the statusbar drawing from the rest of the screen drawing. it is not drawn roughly 4x per second automatically. 
viewport_Set_defaults() will setup the given viewport with the correct "full screen" dimensions (so start at 0,0 if statusbars are disabled or 0,8 if they are enabled.)
All screens should keep the statusbar enabled, but if you really want to ignore the user setting you can disbaled it with viewportmanager_set_statusbar(false).

This commit also includes some menu/list viewport cleanups from kugel in FS#9603


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19622 a1c6a512-1295-4272-9138-f99709370657
 2008-12-31 05:59:26 +00:00
Jonathan Gordon
ff2e9bdf72 fix FS#9687 - 'set song rating' should not be shown if the DB isnt useable 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19523 a1c6a512-1295-4272-9138-f99709370657
 2008-12-21 09:58:11 +00:00
Nils Wallménius
d7fb430935 Fix FS#9357 'Cut/Paste does not remove old folder when replacing', fix suggested by Dan Everton 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19285 a1c6a512-1295-4272-9138-f99709370657
 2008-12-01 11:31:22 +00:00
Bertrik Sikken
ae929e4dcd Make struct text_message const in apps/onplay.c 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19270 a1c6a512-1295-4272-9138-f99709370657
 2008-11-30 12:33:58 +00:00
Björn Stenberg
51b45d5602 Split id3.c/h into metadata.c/h and metadata/mp3.c. Updated all references. Moved mp3data.c/h from firmware to apps. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18814 a1c6a512-1295-4272-9138-f99709370657
 2008-10-15 06:38:51 +00:00
Jonathan Gordon
1da2f0112e Accept FS#9231 - viewportify the pitch screen by Thomas Martitz. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18714 a1c6a512-1295-4272-9138-f99709370657
 2008-10-05 13:01:54 +00:00
Alessio Lenzi
8aa0491fb7 Used correct voice messages for some splash screens. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18498 a1c6a512-1295-4272-9138-f99709370657
 2008-09-11 20:13:02 +00:00
Peter D'Hoye
3c1e9ca558 Change screens memebers char_width, char_height and nb_lines to functions returning a calculated value. Fixes FS #9361 because the values were calculated based on sysfont, not the user selected font. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18441 a1c6a512-1295-4272-9138-f99709370657
 2008-09-07 20:09:11 +00:00
Nils Wallménius
01729e7a18 FS#9281 Rename of splash functions. 
* Remove gui_splash()
* Rename gui_syncsplash() to splashf() and remove its voice 
capabilities.
* Rename the internal splash() to splash_internal() and introduce an 
externally visible splash() that handles simple splashing  without 
printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ, 
"foo"); if a LANG_* id is passed it will be voiced.
* Adjust all places that called gui_syncsplash() to use the correct 
variant from above.
* Export both new functions to plugins and adjust places calling 
rb->splash() to use the correct variant so that we now have naming 
consistency between the core and plugins.
* Fix one latent bug that would cause my sim to crash with the above 
changes and correct P2STR and P2ID macros, thanks to pondlife.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18282 a1c6a512-1295-4272-9138-f99709370657
 2008-08-15 08:27:39 +00:00
Daniel Stenberg
2acc0ac542 Updated our source code header to explicitly mention that we are GPL v2 or 
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
 2008-06-28 18:10:04 +00:00
Jonathan Gordon
0792596e17 the splash should set the viewport to NULL untill we start passing it a vp. (not any time soon though) 
"fix" FS#9044 by changing the delete dir screen to use the splash instead so it doesnt have to worry about the statusbar 
height


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17654 a1c6a512-1295-4272-9138-f99709370657
 2008-05-29 14:40:12 +00:00
Bertrik Sikken
06b53321b4 Create WPS context (onplay) menus using MAKE_ONPLAYMENU macro. Partial fix for FS#9037 - Menu exit behaviour is inconsistent in WPS context menu. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17646 a1c6a512-1295-4272-9138-f99709370657
 2008-05-28 17:12:47 +00:00
Nils Wallménius
b2ee5bc6b6 Restore the 'Open With...' menu item to the wps context menu wich was lost somewhere also document the wps context menu delete option 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17608 a1c6a512-1295-4272-9138-f99709370657
 2008-05-22 16:28:20 +00:00
Steve Bavin
5f8bd63cba FS#9019 - Tidied up WPS context menu. Moved playlist to the top, added Playback Settings optiona and removed duplicate options. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17603 a1c6a512-1295-4272-9138-f99709370657
 2008-05-22 08:02:48 +00:00
Steve Bavin
bc186c1a6b Fix FS#8986, problem where current file changes during deletion. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17494 a1c6a512-1295-4272-9138-f99709370657
 2008-05-13 13:49:50 +00:00
Nicolas Pennequin
357ffb3c46 Convert the whole codebase to UTF-8, except docs/COMMITTERS and tools/creative.c, which need checking. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17369 a1c6a512-1295-4272-9138-f99709370657
 2008-05-05 10:32:46 +00:00
Stéphane Doyon
ab0f7e17ef Accept FS#6188: study mode. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17355 a1c6a512-1295-4272-9138-f99709370657
 2008-05-04 13:47:58 +00:00
Jonathan Gordon
517aca8532 use the playlist catalog code to generate the playlists under Playlist > Create playlist 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17352 a1c6a512-1295-4272-9138-f99709370657
 2008-05-04 13:01:16 +00:00
Nils Wallménius
33c44461e1 Const police raid, making a lot of pointers to lang strings const and removing some ugly casting 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17251 a1c6a512-1295-4272-9138-f99709370657
 2008-04-26 09:30:24 +00:00
Jonathan Gordon
e8dbe2ee27 fix FS#7780 - remove some possibly dangerous items from the file browser context menu if the <microSD> (or mmc) is selected 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17206 a1c6a512-1295-4272-9138-f99709370657
 2008-04-21 14:52:42 +00:00
Nils Wallménius
a01996436d Use file_exists and dir_exists functions where appropriate, fix one wrong file descriptor check and one possible dir descriptor leak 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17147 a1c6a512-1295-4272-9138-f99709370657
 2008-04-16 19:51:43 +00:00
Jonathan Gordon
dada3242d5 Dont show the playlist catalog item in the file context menu unless the file is audio or a m3u(8). 
Mentinoed in FS#8752


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17106 a1c6a512-1295-4272-9138-f99709370657
 2008-04-14 10:03:46 +00:00
Robert Kukla
183dbbdc9a FS#8738 - move the progress bar to the bottom of the screen (fixes FS#8736 - "fake" progress bar when deleting a folder overlaps the text since r16527) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17055 a1c6a512-1295-4272-9138-f99709370657
 2008-04-09 20:13:09 +00:00
Robert Kukla
f617ba4a43 fix FS#8860 - File browser context menu shows unnecessary items in an empty directory 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17047 a1c6a512-1295-4272-9138-f99709370657
 2008-04-09 13:50:33 +00:00
Dave Chapman
d746b79317 Remove unnecessary (and incorrect) #ifdefs surrounding #include "backdrop.h", and correct remaining references to HAVE_LCD_REMOTE to HAVE_REMOTE_LCD 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16873 a1c6a512-1295-4272-9138-f99709370657
 2008-03-29 01:14:10 +00:00
Jonathan Gordon
5ca1539969 the menu and list now accepts a parent viewport to draw in (and the menu can be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 03:35:24 +00:00
Robert Kukla
ad5610dccd fix FS#8599 - First Song in Tagcache can't be rated 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16291 a1c6a512-1295-4272-9138-f99709370657
 2008-02-12 18:51:10 +00:00
Peter D'Hoye
80ad459c33 Accept FS #8570 by Thomas Martitz: recording dir location was not saved when set via context menu. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16275 a1c6a512-1295-4272-9138-f99709370657
 2008-02-10 18:28:59 +00:00
Robert Kukla
987faeaecd only display set rating menu entry if "gather runtime data" is enabled (was removed with jdGordon's last commit). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15538 a1c6a512-1295-4272-9138-f99709370657
 2007-11-08 16:31:44 +00:00
Jonathan Gordon
49ca667394 rework the set song rating setting so it uses the standard list. also the menu item will not disappear if the rating cant actually be set like it used to (it will splash <No Info> instead... ) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15529 a1c6a512-1295-4272-9138-f99709370657
 2007-11-08 14:00:36 +00:00
Jonathan Gordon
a6f2b82803 revert my previous commit and do it in a much less hacky way (both of these were for FS#8084) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15458 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 12:40:18 +00:00
Jonathan Gordon
62decc42e7 return to the main menu if stop is pressed in the wps context menu, (blame pondlife for the hack :D ) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15457 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 12:10:41 +00:00
Stéphane Doyon
5acf091046 Add a voice callback to dynamic menus, along side the text_callback. 
From FS#7563.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15042 a1c6a512-1295-4272-9138-f99709370657
 2007-10-09 03:48:56 +00:00
Peter D'Hoye
946a815cd4 Accept FS #7667 by Alexander Levin with minor fixes by me. Splits the shortcuts plugin into two, one for adding and one for viewing. Removes hard-coded file extension and allows to link from one shortcut file to another. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14599 a1c6a512-1295-4272-9138-f99709370657
 2007-09-03 22:24:26 +00:00
Barry Wardell
0686513d70 Fix bug where cross volume cut/paste would report failure even though it succeeded. Reported in a comment in FS#7634. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14422 a1c6a512-1295-4272-9138-f99709370657
 2007-08-22 00:05:29 +00:00
Nils Wallménius
5b76936a44 Accept FS#6159 'Add voice to roughly 100 splash screens and yes-no menus' by Stephane Doyon with some minor tweaks by me. Rerun 'configure' and do a 'make clean' before rebuilding your voice files. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14213 a1c6a512-1295-4272-9138-f99709370657
 2007-08-06 13:08:36 +00:00
Nils Wallménius
b1fa2f44a2 Oops remove misleading left-behind comment 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14205 a1c6a512-1295-4272-9138-f99709370657
 2007-08-05 22:38:00 +00:00
Nils Wallménius
b311367481 *** Lang v2 cleanup (FS#6574) *** 
1) Introduces apps/features.txt that controls which strings are included 
for each target based on defines.
2) .lng and .voice files are now target specific and the format versions 
of both these file types have been bumped, which means that new voice 
files are needed. 
3) Use the 'features' mechanism to exclude strings for targets that 
didn't use them.
4) Delete unused and deprecated and duplicated strings, sort strings in 
english.lang

Some string IDs were changed so translations will be slightly worse than 
before.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14198 a1c6a512-1295-4272-9138-f99709370657
 2007-08-05 19:19:39 +00:00
Jonathan Gordon
ef815729b6 Accept FS#7486 - shortcuts plugin. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14191 a1c6a512-1295-4272-9138-f99709370657
 2007-08-05 12:14:07 +00:00
Jonathan Gordon
8d4d5f67ea Address FS#6310 - shows an "infinite" slider when deleting/copying/moving files. 
maybe add this to other parts of the code so it doesnt look like the ui has stalled


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14189 a1c6a512-1295-4272-9138-f99709370657
 2007-08-05 10:25:00 +00:00
Jonathan Gordon
e95d7a0e76 Accept FS#7437 - add the delete option to the wps context menu so the currently playing file can be deleted. tested with a 130mb file on my sansa and it didnt cause problems 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14099 a1c6a512-1295-4272-9138-f99709370657
 2007-07-31 12:26:01 +00:00
Miika Pekkarinen
9d756e2760 Queue song statistical data to the tagcache system and update entirely in background. Fixes ratings disappearing or not saving in the DB at all. Fixes also UI delay when stopping playback and new statistics are committed to DB. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13955 a1c6a512-1295-4272-9138-f99709370657
 2007-07-21 17:35:19 +00:00
Jonathan Gordon
415e9d78cc User configurable recording path (my patch in FS#7201). path defaults to / and can be changed in the folder context menu (cleared in the recording settings menu) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13838 a1c6a512-1295-4272-9138-f99709370657
 2007-07-10 07:41:37 +00:00
Dan Everton
4c486ce948 Add splash messages while copying, moving, and deleting files. Also boost the CPU during move/copy since it seems to make things faster. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13441 a1c6a512-1295-4272-9138-f99709370657
 2007-05-20 10:04:39 +00:00
Nils Wallménius
f31e123133 Remove unused function and unused header 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13424 a1c6a512-1295-4272-9138-f99709370657
 2007-05-19 19:54:11 +00:00
Hardeep Sidhu
8c2bcf1bff Use INSERT_LAST when inserting tracks before playback has started. Fixes FS#7153. Also code policed for 80 col limit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13396 a1c6a512-1295-4272-9138-f99709370657
 2007-05-15 23:30:30 +00:00
Nicolas Pennequin
6190a0d68d Add an item to the WPS context menu to browse a currently playing cuesheet. The menu that appears allows changing tracks within the cuesheet. It was already reachable by selecting the right cuesheet file in the file browser, but this makes it easier to use (and should help users noticing that possibility because many seemed to ignore this viewer existed). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13388 a1c6a512-1295-4272-9138-f99709370657
 2007-05-14 17:34:52 +00:00
Hardeep Sidhu
7a2bc5272b Enable playlist functions for m3u files 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13308 a1c6a512-1295-4272-9138-f99709370657
 2007-05-03 01:10:52 +00:00