Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
12200 commits 17 branches 142 tags 291 MiB
Commit graph

64 commits

Author SHA1 Message Date
Michael Sevakis
aba6ca0881 Fix resampling clicking as much as possible at the moment. 1) Upsampling clicked because of size inaccuracies returned by DSP. Fix by simplifying audio system to use per-channel sample count from codec to pcm buffer. 2) Downsampling affected by 1) and was often starting passed the end of the data when not enough was available to generate an output sample. Fix by clamping input range to last sample in buffer and using the last sample value in the buffer. A perfect fix will require a double buffering scheme on the resampler to sufficient data during small data transients on both ends at all times of the down ratio on input and the up ratio on output. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12218 a1c6a512-1295-4272-9138-f99709370657
 2007-02-07 00:51:50 +00:00
Thom Johansen
5f48e1590f Optimise EQ coef calculation routines for both speed and size. Move now unneeded fsqrt function to plugin fixed point library in case it'll be needed. Move all fixed point helper macros to dsp.h. Added FRACMUL_SHL macro to facilitate high-precision shifting of 64 bit multiplies and remove rounding from macsr in main thread to make this work as intended. 
Tested quite thorougly, but as always, be careful with your ears.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12203 a1c6a512-1295-4272-9138-f99709370657
 2007-02-05 01:01:15 +00:00
Jens Arnold
314f3b58f1 More static'ing, and a few fixes resulting from that. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11737 a1c6a512-1295-4272-9138-f99709370657
 2006-12-12 22:22:21 +00:00
Michael Sevakis
2b545c3104 Fixed FS#6389 - Sound disappears after pitch change and jump to the start of the song. Forgot to reinit the resampler delta when adding DSP_FLUSH on my last change. Bah. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11621 a1c6a512-1295-4272-9138-f99709370657
 2006-11-29 00:16:25 +00:00
Michael Sevakis
bbef13eddf SWCODEC: Stop clicks between tracks when resampler is active by only switching the DSP frequency and not resetting the resampler at track boundaries. Will make sure DSP is correctly flushed at dicontinuities but don't hear any problems currently. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11600 a1c6a512-1295-4272-9138-f99709370657
 2006-11-26 12:02:47 +00:00
Michael Sevakis
17507b979d Fixed bug in dither_init that was causing the AIFF playback at sample rates other than 44.1kHz to not procede. It created a dependency of setting sample depth before frequency and aiff.codec does it the other way. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11595 a1c6a512-1295-4272-9138-f99709370657
 2006-11-25 20:59:45 +00:00
Magnus Holmgren
ea7992455a Make the updated %rg tag match playback behaviour (fall back to track gain if album gain requested but not available). Share the mode decision logic with playback code and simplify the %rg tag handling. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11532 a1c6a512-1295-4272-9138-f99709370657
 2006-11-15 20:26:33 +00:00
Thom Johansen
354770088e Re-enable the currently unused and broken dithering and noise shaping code already in Rockbox, and make it a user option instead of a codec-controlled option. The majority of people probably will not even hear any difference with this enabled, but feedback is welcome. Save your settings! 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11368 a1c6a512-1295-4272-9138-f99709370657
 2006-10-27 20:41:33 +00:00
Magnus Holmgren
4b3a00703d Fix the use of equalizer pre-cut in combination with replaygain. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9711 a1c6a512-1295-4272-9138-f99709370657
 2006-04-17 21:04:57 +00:00
Thom Johansen
239564c80e Fix/add some comments and remove some old leftover crossfeed code. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9705 a1c6a512-1295-4272-9138-f99709370657
 2006-04-17 17:24:02 +00:00
Thom Johansen
8238b49c74 New crossfeed complete with no volume reducing bugs. Feedback on all the 
new options is appreciated. Thanks to Dan Everton for the settings/GUI
code.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9609 a1c6a512-1295-4272-9138-f99709370657
 2006-04-11 13:49:05 +00:00
Miika Pekkarinen
93b6a1d12c Prevent two division by zeros and one problem causing a crash in the 
mp3 metadata parser.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9438 a1c6a512-1295-4272-9138-f99709370657
 2006-04-02 20:19:00 +00:00
Dan Everton
daebff8b5d Update equalizer precut value as it's adjusted. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9332 a1c6a512-1295-4272-9138-f99709370657
 2006-03-28 21:19:30 +00:00
Dan Everton
91db368845 Add precut setting for the equalizer and add some more comments to the eq menu code. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9298 a1c6a512-1295-4272-9138-f99709370657
 2006-03-27 21:20:35 +00:00
Jens Arnold
8083e8c0de Fixed potential sample overflow in variable stereo width > 100% and karaoke mode, both hwcodec and swcodec. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9263 a1c6a512-1295-4272-9138-f99709370657
 2006-03-26 17:41:36 +00:00
Dan Everton
fac50d12bf Slightly clearer code in dsp_eq_update_data. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9231 a1c6a512-1295-4272-9138-f99709370657
 2006-03-24 14:06:30 +00:00
Thom Johansen
cc94ae45a7 Keep assembler versions of DSP routines in dsp_arch.S files. This also 
solves the annoying register allocator problem when not using
-fomit-frame-pointer for the Coldfire assembler optimised crossfeed
routine.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9215 a1c6a512-1295-4272-9138-f99709370657
 2006-03-23 19:59:52 +00:00
Thom Johansen
e2824c94fc Use size-correct casts. Fixes some AMD64 sim warnings. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9192 a1c6a512-1295-4272-9138-f99709370657
 2006-03-22 16:04:51 +00:00
Thom Johansen
b0960aed11 Enabled channel configuration and stereo width option on software codec 
platforms.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9173 a1c6a512-1295-4272-9138-f99709370657
 2006-03-21 23:20:17 +00:00
Thom Johansen
ea4ccb5aba Samples should always be 32 bit on all platforms, so change most 
occurences of long to int32_t to enable working sounds also on 64 bit
sims. Note that some codecs (MP3 and Wavpack) still have other 64
bit related problems.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9120 a1c6a512-1295-4272-9138-f99709370657
 2006-03-19 16:31:45 +00:00
Dave Bryant
6472ecfc2e Added a couple inline assembly functions for ARM targets. This just about 
doubles the speed of crossfeed and makes a more modest improvement to the
replaygain loop.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8904 a1c6a512-1295-4272-9138-f99709370657
 2006-03-04 21:26:47 +00:00
Brandon Low
d04dbca00b Speed dsp gain up slightly mostly with better code order 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8758 a1c6a512-1295-4272-9138-f99709370657
 2006-02-20 23:52:47 +00:00
Dan Everton
5a1d77de83 Reduce CPU usage while changing EQ by only updating the coefficients of the band being modified. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8718 a1c6a512-1295-4272-9138-f99709370657
 2006-02-17 19:56:22 +00:00
Thom Johansen
f16a9f3b31 Use EMAC rounding mode in EQ coef calc for better precision. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8655 a1c6a512-1295-4272-9138-f99709370657
 2006-02-10 23:16:27 +00:00
Dave Bryant
b44c18ea9d Quick fix for crossfeed on iPod. Still needs optimization, but at least no 
more unpleasant surprises!


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8618 a1c6a512-1295-4272-9138-f99709370657
 2006-02-08 08:01:31 +00:00
Brandon Low
413da2a3d9 Rework PCM buffer 
* Linked list instead of static array buffer pointers
* Variable sized chunks
* Improved mix handling
* Reduction in duplicated code
* Reduced IRAM usage w/o sacrificing performance
* Converted to almost entirely unsigned math
* Add pause function to reduce pcm_* exposure to playback.

This WILL break playback on the iPod until linuxstb makes a followup commit.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8612 a1c6a512-1295-4272-9138-f99709370657
 2006-02-07 20:38:55 +00:00
Dan Everton
88abdd97b2 Add Equalizer configuration to Sound Settings menu. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8606 a1c6a512-1295-4272-9138-f99709370657
 2006-02-07 14:07:46 +00:00
Linus Nielsen Feltzing
dd8cb8a2c1 Committed a little too much 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8569 a1c6a512-1295-4272-9138-f99709370657
 2006-02-04 23:16:31 +00:00
Linus Nielsen Feltzing
621bcc2294 The simulator should use the keypad period key, not the regular one 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8568 a1c6a512-1295-4272-9138-f99709370657
 2006-02-04 23:15:15 +00:00
Thom Johansen
440d75f938 No need for different name members in eq_data struct. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8534 a1c6a512-1295-4272-9138-f99709370657
 2006-02-02 20:03:43 +00:00
Thom Johansen
55ff456c46 Recommit reverted changes and add the missing file... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8484 a1c6a512-1295-4272-9138-f99709370657
 2006-01-29 15:37:03 +00:00
Brandon Low
236d52410f Backout part of the last change to fix builds for now 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8479 a1c6a512-1295-4272-9138-f99709370657
 2006-01-29 02:46:18 +00:00
Thom Johansen
a8cc6a7454 Initial multi-band EQ support for software codec platforms. Now go start 
making that user interface!


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8478 a1c6a512-1295-4272-9138-f99709370657
 2006-01-29 02:10:28 +00:00
Thom Johansen
80b30761a5 This wont work after all. Someone please introduce -fomit-frame-pointer for debug builds, we don't need the frame pointer anyway. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8243 a1c6a512-1295-4272-9138-f99709370657
 2005-12-15 12:47:34 +00:00
Thom Johansen
df7f61e0c1 Fix typo and disable crossfeed assembler version for DEBUG builds, which obviously tend to need the frame pointer which i use. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8242 a1c6a512-1295-4272-9138-f99709370657
 2005-12-15 12:40:39 +00:00
Thom Johansen
e8b874b039 Playback speed commit broke mono resampling, this fixes it again. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8111 a1c6a512-1295-4272-9138-f99709370657
 2005-11-30 01:21:24 +00:00
Thom Johansen
27c658c8a6 Enabled playback speed adjustment support for H1x0. Modified the resampler to do both channels in one pass. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8099 a1c6a512-1295-4272-9138-f99709370657
 2005-11-28 22:26:20 +00:00
Thom Johansen
978521fe22 Replaygain support uses the accumulator extension bytss, so disable rounding. Fix some typos. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8051 a1c6a512-1295-4272-9138-f99709370657
 2005-11-23 14:30:58 +00:00
Thom Johansen
df37db99ce Added Coldfire ASM optimised crossfeed function. Have not measured speed improvement, but it is faster. Also moved activation check for crossfeed out of function to avoid a function call if it's not activated. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7891 a1c6a512-1295-4272-9138-f99709370657
 2005-11-15 10:05:01 +00:00
Marcoen Hirschberg
94404500bb fix crossfeed on non-coldfire platforms and the simulator 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7888 a1c6a512-1295-4272-9138-f99709370657
 2005-11-15 00:16:24 +00:00
Marcoen Hirschberg
e13fad3b4b add crossfeed dsp effect. Makes some music more enjoyable with headphones. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7884 a1c6a512-1295-4272-9138-f99709370657
 2005-11-14 21:56:56 +00:00
Thom Johansen
c9249add41 Automatically set clipping limits based on sample precision. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7719 a1c6a512-1295-4272-9138-f99709370657
 2005-11-02 00:30:58 +00:00
Jens Arnold
abd9f83e92 Two new sections for IRAM usage: .irodata (selectable with the ICONST_ATTR attribute macro), allowing to put 'const' data into IRAM without causing a section type conflict, and .ibss (selectable with the IBSS_ATTR attribute macro) for uninitialised data. * Rockbox core: Adjusted the linker scripts and init code to not include the .ibss section in the binary, it is cleared instead. Saves ~500 bytes on archos and ~30KB on iriver. Codecs and plugins don't handle .ibss in a special way yet. * The init code properly handles empty sections now (except .stack, which should never be empty). * Unified the init code for SH1 and coldfire a bit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7644 a1c6a512-1295-4272-9138-f99709370657
 2005-10-19 19:35:24 +00:00
Magnus Holmgren
4b711c2f72 Iriver: Added new ReplayGain type: track gain if shuffle mode is active, album gain otherwise. Properly apply ReplayGain settings on config file load. Bumped config version, so save your settings. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7558 a1c6a512-1295-4272-9138-f99709370657
 2005-09-24 15:22:48 +00:00
Thom Johansen
735208a541 Adapted codecs and DSP system to having MACSR saved in thread context. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7485 a1c6a512-1295-4272-9138-f99709370657
 2005-09-07 00:24:27 +00:00
Miika Pekkarinen
159c52dd36 Initial voice ui support for software codec platforms. Added also a 
beep when changing tracks.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7360 a1c6a512-1295-4272-9138-f99709370657
 2005-08-20 11:13:19 +00:00
Magnus Holmgren
75ef3129c9 iriver: slightly faster replaygain processing and clipping. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7353 a1c6a512-1295-4272-9138-f99709370657
 2005-08-18 19:25:39 +00:00
Magnus Holmgren
39cb5b7912 iriver: Do correct ReplayGain calculation. Fixes distortion problems (and lowers playback volume). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7343 a1c6a512-1295-4272-9138-f99709370657
 2005-08-17 20:58:15 +00:00
Magnus Holmgren
5a8eac1a5a Added pre-amp setting for files with ReplayGain information. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7303 a1c6a512-1295-4272-9138-f99709370657
 2005-08-11 18:56:20 +00:00
Linus Nielsen Feltzing
591d2890f1 patch #1255805 by Frederic Devernay - fix to buffer overflow in dsp.c 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7301 a1c6a512-1295-4272-9138-f99709370657
 2005-08-10 23:17:55 +00:00