Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
15535 commits 17 branches 142 tags 291 MiB
Commit graph

467 commits

Author SHA1 Message Date
Nicolas Pennequin
32bd59d4f7 Better error checking for the image display tag (%xdn). Should prevent problems with the former crossfeed tag (%xd) when used in a conditional construct. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13158 a1c6a512-1295-4272-9138-f99709370657
 2007-04-14 16:20:33 +00:00
Jens Arnold
0b7bb31453 Simplification, queue pointers don't wrap (except at INT_MAX, but the calculation is still correct in this case). Implemented queue_count() for the simulator. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13154 a1c6a512-1295-4272-9138-f99709370657
 2007-04-14 09:47:47 +00:00
Marcoen Hirschberg
5d2b1e3cb3 rename ACTION_WPSAB_RESET to ACTION_WPS_ABRESET to be more consistent with the rest 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13142 a1c6a512-1295-4272-9138-f99709370657
 2007-04-13 15:42:25 +00:00
Nicolas Pennequin
2ea39db310 FS#7020. Make the behaviour of '#' more consistent. It now requires escaping by a '%' to be displayed. If it is not escaped, the following text will be interpreted as a comment (including the newline character). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13140 a1c6a512-1295-4272-9138-f99709370657
 2007-04-13 11:43:10 +00:00
Jens Arnold
c05ee02312 Removed unused struct member from gui_synclist, and reordered struct members of gui_list for optimal packing. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13139 a1c6a512-1295-4272-9138-f99709370657
 2007-04-12 23:53:17 +00:00
Jens Arnold
47bf6c5a5a Moved archos backlight code to target tree. Changed old mutlivalue CONFIG_BACKLIGHT to a simple HAVE_BACKLIGHT. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13136 a1c6a512-1295-4272-9138-f99709370657
 2007-04-12 22:12:13 +00:00
Nicolas Pennequin
27cbf6bcea * Add the crossfade (%xf) WPS tag 
* Avoid eating the whole line when unsuccessfully parsing a %x or %xl tag. This will prevent unknown tags starting with %x from making the line disappear.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13127 a1c6a512-1295-4272-9138-f99709370657
 2007-04-12 16:15:34 +00:00
Jonathan Gordon
08e633c25c Hide the list title if only one line would fit under it 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13107 a1c6a512-1295-4272-9138-f99709370657
 2007-04-11 10:34:44 +00:00
Nicolas Pennequin
5cac46164a Use valid_time() instead of using individual checks which amount to the same thing, and add RTC tokens beginning and end values that are used to check if a token is an RTC one. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13096 a1c6a512-1295-4272-9138-f99709370657
 2007-04-10 15:27:52 +00:00
Nicolas Pennequin
536c5d9e74 RTC tags for the WPS: Accept FS#6998 and FS#7001 by Alexander Levin with changes by me. CUSTOM WPS FILES NEED TO BE UPDATED ! 
The RTC tags are now atomic, i.e. instead of using one tag with the format (e.g. %cd m yc), we use several separate tags, one for each value (e.g. %cd %cm %cy).
Also, %cP produces an uppercase AM/PM indicator and %cp a lowercase one, which is the opposite from what they did before.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13093 a1c6a512-1295-4272-9138-f99709370657
 2007-04-10 13:37:08 +00:00
Nicolas Pennequin
ad07c23a83 Accept FS#7004 by Michal Jevjak: Fix new sublines not being displayed after scrolling lines. This bug was introduced in the previous WPS commit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13090 a1c6a512-1295-4272-9138-f99709370657
 2007-04-10 01:14:04 +00:00
Nicolas Pennequin
cda89411b0 Accept FS#7000 by Dave Hooper: Fix scrolling line behaviour for dynamic tags (e.g. when a line with info about the next track didn't scroll) and fix some incorrect refreshing flags. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13081 a1c6a512-1295-4272-9138-f99709370657
 2007-04-09 14:06:38 +00:00
Nicolas Pennequin
9ce77aa554 Skip leading UTF8 BOM if present. Fixes the first line of the WPS not being understood as a comment when it is one. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13074 a1c6a512-1295-4272-9138-f99709370657
 2007-04-08 15:02:26 +00:00
Nicolas Pennequin
fd19b8dba4 * Improve conditional evaluation to allow using enums with only two cases (problem reported by roolku). This happens to simplify the code. 
* Rename get_tag() to get_token_value() and make it get a token pointer instead of the index of a token. This also simplifies the code a bit.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13073 a1c6a512-1295-4272-9138-f99709370657
 2007-04-08 14:00:00 +00:00
Nicolas Pennequin
ef5cfb4e58 Oops, this shouldn't have been removed (fix red). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13066 a1c6a512-1295-4272-9138-f99709370657
 2007-04-08 04:12:55 +00:00
Nicolas Pennequin
07696c10b1 FS#6991. Patch by Alexander Levin, modified by me: 
* Reorganisation of the WPS data structure with line and subline structs. This allows us to use sublines more sparingly, so it should save some memory. Also it removes the need for the "End Of Line" token. Overall, the data structure and the code are simplified and gain in clarity.
* Some code improvements and added comments.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13065 a1c6a512-1295-4272-9138-f99709370657
 2007-04-08 04:01:06 +00:00
Jonathan Gordon
fad3ad6894 fix FS#6883 — Follow playlist override where the WPS leaves you when a playlist ends 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13064 a1c6a512-1295-4272-9138-f99709370657
 2007-04-08 02:11:33 +00:00
Jonathan Gordon
a053e58894 minor actions cleanup: 
- CONTEXT_MAINMENU is not actually needed, use CONTEXT_TREE which does the same actions
- (gigabeat) use vol+/- in the lists to control volume (every list!) (FS#6982 in a better way)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13062 a1c6a512-1295-4272-9138-f99709370657
 2007-04-08 01:33:01 +00:00
Nicolas Pennequin
3dc42ba8c7 Add the sleep timer tag that got forgotten in the initial code. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13056 a1c6a512-1295-4272-9138-f99709370657
 2007-04-07 11:57:59 +00:00
Nicolas Pennequin
f3a149acf6 Make conditionals trigger a line update. Fixes FS#6987. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13054 a1c6a512-1295-4272-9138-f99709370657
 2007-04-07 00:18:28 +00:00
Jens Arnold
f9b90e9103 Now charcell displays require lcd_update() for updating the main lcd content like bitmap displays. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13050 a1c6a512-1295-4272-9138-f99709370657
 2007-04-06 22:55:00 +00:00
Nicolas Pennequin
8527ce82b6 Use the default subline timeout value in case the value isn't explicitly set. Hopefully this will be the last commit in that area :) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13048 a1c6a512-1295-4272-9138-f99709370657
 2007-04-06 19:07:57 +00:00
Nicolas Pennequin
87e77ba466 This time I hope I got it right! Basically, remove what the previous commit about subline timeouts added and make the values be computed by a special function at display time. This should bring complete compatibility with the previous code. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13047 a1c6a512-1295-4272-9138-f99709370657
 2007-04-06 16:43:07 +00:00
Nicolas Pennequin
3954a51311 Better handling of subline timeout values : All values are set to the default before another value is found by the parser. No more 
resetting to the default value at displaying time (this caused problems especially noticeable on the DancePuffDuo WPS). Changing 
the values with conditionals is still possible but only strictly positive tiemout values are accepted now. 


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13045 a1c6a512-1295-4272-9138-f99709370657
 2007-04-06 14:18:07 +00:00
Nicolas Pennequin
31d8068b33 End the default remote-WPS with a newline. Fixes FS #6979. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13041 a1c6a512-1295-4272-9138-f99709370657
 2007-04-06 02:01:34 +00:00
Nicolas Pennequin
9cf8960c85 * Fix the bug where subline separators were read as part of a string. 
* Some cosmetic code changes, no other functional change (add a comment and rename some variables).


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13034 a1c6a512-1295-4272-9138-f99709370657
 2007-04-05 14:09:59 +00:00
Dan Everton
86c0e3a4ca Rearrange struct wps_tag to avoid padding. Hopefully save some bytes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13033 a1c6a512-1295-4272-9138-f99709370657
 2007-04-05 10:21:49 +00:00
Nicolas Pennequin
29e18caacf Allow subline timeout values to be changed dynamically in the WPS (e.g. by using conditionals). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13026 a1c6a512-1295-4272-9138-f99709370657
 2007-04-05 02:44:01 +00:00
Jens Arnold
7b8767c093 Player full-line progress bar: No more separate character cell(s) for the colon(s) in the time display. Looks better, and takes less software-definable characters, allowing for up to 99:59:59 with the last progress bar character still working properly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13023 a1c6a512-1295-4272-9138-f99709370657
 2007-04-04 23:18:35 +00:00
Jens Arnold
c6fce6cad3 Player progress drawing rewrite (both emptying cup and full-line bar): * Fixes FS #6820, related to the glitch that progress moved in the opposite direction when seeking. * Smaller, more efficient code. * Full-line bar only displays as many software defined characters as needed, freeing the remaining ones for other text. * Don't cut last digit from times >=1 hour (at the cost of inexact last progress bar character). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13021 a1c6a512-1295-4272-9138-f99709370657
 2007-04-04 22:05:04 +00:00
Nicolas Pennequin
830a3a4720 * Make some private variables 'static'. 
* Fix the pitch tag and allow it to be used on all targets except the Archos Player.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13020 a1c6a512-1295-4272-9138-f99709370657
 2007-04-04 15:47:51 +00:00
Nicolas Pennequin
ab90d58801 Introducing the WPS tokenizer ! 
When a WPS file is loaded, it is parsed to an array of tokens, which allows more efficient displaying. More info on the tracker entry : FS #6862.
The parsing code is completely independant and is all in wps_parser.c. The displaying part stays in gwps-common.c.
Debugging code is provided (with the right ifdefs) and is disabled by default.
Overall, the code should be easier to read and maintain. Adding new WPS tags is made quite trivial.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13019 a1c6a512-1295-4272-9138-f99709370657
 2007-04-04 14:41:40 +00:00
Jens Arnold
2684e36724 Repair player progressbars (single char and full line) broken in the full unicode support move, and enable text alignment for charcell. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12993 a1c6a512-1295-4272-9138-f99709370657
 2007-04-01 17:32:12 +00:00
Jonathan Gordon
21165a3f3d Recode filetypes.c to remove its need for a static string buffer. 
Functional changes:
- filetypes.c handles the open with menu now instead of onplay.c
- automatic plugin registration no longer works (did anyone know about you could do this?)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12959 a1c6a512-1295-4272-9138-f99709370657
 2007-03-29 06:16:00 +00:00
Jens Arnold
ad4e3d6657 First step of charcell LCD code rework: * Make it fully unicode aware so that adding non-ISO8859-1 scripts becomes possible (limited by the LCD capabilities of course). * Make the API more similar to the bitmap LCD code's API. * Moved hardware dependent parts to target tree. * Simplified code. * Jumpscroll temporarily non-functional. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12916 a1c6a512-1295-4272-9138-f99709370657
 2007-03-26 07:52:13 +00:00
Jens Arnold
79c8a8cbbe Let GCC check arguments of some more printf-style functions, also for plugins and codecs. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12815 a1c6a512-1295-4272-9138-f99709370657
 2007-03-17 09:02:53 +00:00
Magnus Holmgren
1329d7d3fd Fix occasional missing cursor when moving up in a list with a title when paged scrolling is on. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12814 a1c6a512-1295-4272-9138-f99709370657
 2007-03-17 07:30:33 +00:00
Jens Arnold
2c7b127dd7 Set CONFIG_RTC to 0 for non-RTC targets, and check with #if to profit from -Wundef. No code change. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12811 a1c6a512-1295-4272-9138-f99709370657
 2007-03-16 23:47:03 +00:00
Jens Arnold
4d6374c923 Get rid of the 'center' parameter for splashes. There were only 2 of almost 500 splashes which were not centered. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12807 a1c6a512-1295-4272-9138-f99709370657
 2007-03-16 21:56:08 +00:00
Nils Wallménius
e6a8d2186c Make a couple of private functions 'static' 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12770 a1c6a512-1295-4272-9138-f99709370657
 2007-03-15 00:29:59 +00:00
Nils Wallménius
6485db3b37 Make a couple of private functions 'static' 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12729 a1c6a512-1295-4272-9138-f99709370657
 2007-03-11 21:48:20 +00:00
Miika Pekkarinen
2eefb5acb8 Optimized the gui list code performance, including automatic frame dropping and cpu boosting when button events are getting queued. Improved scrollwheel acceleration code is needed to notice a real change. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12721 a1c6a512-1295-4272-9138-f99709370657
 2007-03-11 10:52:36 +00:00
Jonathan Gordon
f83d6eb145 revert FS#6747 — y-margin reset in gui_list_draw, it introduced a nasty 
scroll bug which isnt so simple to fix.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12719 a1c6a512-1295-4272-9138-f99709370657
 2007-03-11 08:05:05 +00:00
Jonathan Gordon
4949818c24 only call display->setmargins() once 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12706 a1c6a512-1295-4272-9138-f99709370657
 2007-03-10 13:05:47 +00:00
Jonathan Gordon
a990ff2920 Accept FS#6747 by Timo Horstschäfer 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12704 a1c6a512-1295-4272-9138-f99709370657
 2007-03-10 12:43:21 +00:00
Linus Nielsen Feltzing
298c2bbd83 Allow dynamic menu items to be spoken, especially the resume/now playing item 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12614 a1c6a512-1295-4272-9138-f99709370657
 2007-03-05 00:32:33 +00:00
Robert Kukla
23c136c892 don't restart the whole wps to essentially update the display of runtime info, but make the concerned tags dynamic. Now scrolling is not restarted at end of buffering. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12592 a1c6a512-1295-4272-9138-f99709370657
 2007-03-04 16:09:18 +00:00
Jonathan Gordon
4de9fbeda6 Use the user font in the quickscreen if it fits. Still uses 
LANG_SYSFONT_x...


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12587 a1c6a512-1295-4272-9138-f99709370657
 2007-03-04 13:04:15 +00:00
Jonathan Gordon
5ea43ce8a9 thats what happens when you commit between dinner courses :p 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12582 a1c6a512-1295-4272-9138-f99709370657
 2007-03-04 08:35:20 +00:00
Jonathan Gordon
e6ba70548d Fix red builds. 
(Previous commit was for FS#6713 btw)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12581 a1c6a512-1295-4272-9138-f99709370657
 2007-03-04 08:05:33 +00:00
Jonathan Gordon
ca701bf62e Add a function to get the actual button that was pressed (and some 
status codes) instead of the action. Use this to figure out which screen 
to do prev/next page on in the lists


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12580 a1c6a512-1295-4272-9138-f99709370657
 2007-03-04 07:45:12 +00:00
Jonathan Gordon
02a871780f Remove the need to double up the MENU macros in manu.h. 
Icons are now used by their id which must be part of the icons_6x8 enum, 
or Icon_NOICON for none


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12571 a1c6a512-1295-4272-9138-f99709370657
 2007-03-03 13:52:14 +00:00
Jonathan Gordon
7ae5f12449 The list should reset the x margin when it finishes drawing. Not leave 
it up to the next screen


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12570 a1c6a512-1295-4272-9138-f99709370657
 2007-03-03 13:42:12 +00:00
Robert Kukla
ae08eeb4ff remove runtime detection of h1x0 series RTC MOD, but leave driver code 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12554 a1c6a512-1295-4272-9138-f99709370657
 2007-03-03 00:11:20 +00:00
Robert Kukla
79a2a936a2 remove numerical genre and use genre_string consistently: 
- fix spurious display of "blues" genre for missing genre tag 
- simplify code/use less code
- numerical->string conversion only once instead of at every use

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12552 a1c6a512-1295-4272-9138-f99709370657
 2007-03-02 21:49:42 +00:00
Jonathan Gordon
a9a9999ff4 fix usb disconnecting in the WPS 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12542 a1c6a512-1295-4272-9138-f99709370657
 2007-03-01 23:46:01 +00:00
Steve Bavin
361a60c964 Centralise icon enabling to hopefully save a few bytes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12540 a1c6a512-1295-4272-9138-f99709370657
 2007-03-01 18:25:13 +00:00
Jonathan Gordon
91cb68a1fb Introducing the root menu! 
Blind users: get a new voice file as there are lots of lang changes and new strings.
FS#6630 or RootMenu on the wiki for more info. complaints to /dev/null :)



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12528 a1c6a512-1295-4272-9138-f99709370657
 2007-03-01 11:14:46 +00:00
Jens Arnold
b49602e7a9 Fix a potential race condition with cuesheets (that hit every time in an archos test), plus a slight optimisation. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12524 a1c6a512-1295-4272-9138-f99709370657
 2007-02-28 23:43:38 +00:00
Robert Kukla
50b5ee4781 FS#6419 - driver for H1x0 series RTC Mod with runtime detection 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12520 a1c6a512-1295-4272-9138-f99709370657
 2007-02-28 13:20:36 +00:00
Dave Chapman
6c6c352310 Character-encoding policing 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12516 a1c6a512-1295-4272-9138-f99709370657
 2007-02-28 01:36:32 +00:00
Nils Wallménius
dbf772bae9 Remove unnecessary function call. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12471 a1c6a512-1295-4272-9138-f99709370657
 2007-02-24 11:49:52 +00:00
Nils Wallménius
f67a95330c Make private functions 'static'. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12470 a1c6a512-1295-4272-9138-f99709370657
 2007-02-24 11:07:21 +00:00
Nils Wallménius
7fdee10a70 Make private functions static. Remove some functions from the plugin api as they weren't used in any plugins and could then be declared static. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12462 a1c6a512-1295-4272-9138-f99709370657
 2007-02-23 21:52:45 +00:00
Jens Arnold
3a37f46fc9 Fix CONFIG_BACKLIGHT warnings. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12393 a1c6a512-1295-4272-9138-f99709370657
 2007-02-18 10:07:27 +00:00
Jonathan Gordon
9a6f419775 CONFIG_CHARGING 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12384 a1c6a512-1295-4272-9138-f99709370657
 2007-02-18 05:32:06 +00:00
Jonathan Gordon
bd47d48c21 Do the CONFIG_LED define 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12383 a1c6a512-1295-4272-9138-f99709370657
 2007-02-18 05:07:19 +00:00
Jonathan Gordon
eff0dc3e13 Allow the list to display a title icon even if no other icons will be 
displayed


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12375 a1c6a512-1295-4272-9138-f99709370657
 2007-02-18 00:52:34 +00:00
Magnus Holmgren
2067fcc695 Fix most (all?) CONFIG_LED warnings. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12370 a1c6a512-1295-4272-9138-f99709370657
 2007-02-17 23:22:37 +00:00
Daniel Stenberg
d52ee4c0d6 #ifdef 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12369 a1c6a512-1295-4272-9138-f99709370657
 2007-02-17 23:12:55 +00:00
Daniel Stenberg
20a5926d2e build with -Wundef to make sure we have spelled the defines right in #if lines 
and have the proper includes included etc


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12360 a1c6a512-1295-4272-9138-f99709370657
 2007-02-17 21:54:17 +00:00
Magnus Holmgren
14ba91eaa9 A few more bookmark code tweaks. Also improves how the bookmark selection screen is displayed on Archos players. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12350 a1c6a512-1295-4272-9138-f99709370657
 2007-02-17 13:36:44 +00:00
Nicolas Pennequin
7ba8aec5af * Add support for an optional y coordinate to the progressbar (from FS #4783). 
* Modify the 'Rockboxed' WPS to make use of this new coordinate. It improves the display of 
cuesheet/A-B markers a lot and cleans the bitmaps up a bit.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12321 a1c6a512-1295-4272-9138-f99709370657
 2007-02-15 22:17:01 +00:00
Nicolas Pennequin
9f4bd8712f Cuesheet support by Jonathan Gordon and me (FS #6460). 
Everytime an audio file is loaded, a cue file with the same name is searched for. A setting 
allows to disable this (default is off). Cuesheet files can also be viewed in the file browser.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12304 a1c6a512-1295-4272-9138-f99709370657
 2007-02-14 14:40:24 +00:00
Miika Pekkarinen
4e9766477b FS#6638 - Album artist and comment patch for WPS and tagcache. Export 
your database before updating because initialization is needed.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12255 a1c6a512-1295-4272-9138-f99709370657
 2007-02-10 12:09:28 +00:00
Michael Sevakis
0f17532c9d Revert the changes using global status for the screen states. It should wait for a more comprehensive plan to maximize benefit if any can be had. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12231 a1c6a512-1295-4272-9138-f99709370657
 2007-02-08 10:36:49 +00:00
Michael Sevakis
eed62f1657 Change the radio screen and recording screen to use the global_status structure for state. I guess global_status had been added already and I missed it. :D 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12222 a1c6a512-1295-4272-9138-f99709370657
 2007-02-07 04:24:21 +00:00
Michael Sevakis
ff3bb3aa18 Don't save the in-out state of the recording screen as a setting. Fixes the statusbar icons if settings were saved while recording screen was on. Humbly may I suggest a global_state structure to do all this state checking more efficiently\? Ignore me if that's being worked on by someone. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12221 a1c6a512-1295-4272-9138-f99709370657
 2007-02-07 02:48:19 +00:00
Steve Bavin
338d94f466 FS#4770 - Add USB charging for the H300 series 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12169 a1c6a512-1295-4272-9138-f99709370657
 2007-02-01 10:47:22 +00:00
Jonathan Gordon
228d62dd18 Split the system status variables out of global_settings and put them into a new struct global_status. Use status_save() if these need 
saving.
Added car_adapter_mode to the nvram settings, so nvram settings will be reset.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12101 a1c6a512-1295-4272-9138-f99709370657
 2007-01-24 02:19:22 +00:00
Dominik Riebeling
08c813d45a Respect the progressbar length when drawing AB markers. Fixes FS#6463. Also fix a function name typo. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11857 a1c6a512-1295-4272-9138-f99709370657
 2006-12-29 19:17:03 +00:00
Jens Arnold
2597a13497 Next round of static'ing and related fixes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11836 a1c6a512-1295-4272-9138-f99709370657
 2006-12-25 14:01:47 +00:00
Jonathan Gordon
7258b5e51a Make AB mode uable on the ipods. In AB mode select is used to set/reset 
the markers in he WPS. AB mode must be disblaed ot get into the browser.
This can allow the Ondio's to have AB mode but it makes rombox too
large.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11832 a1c6a512-1295-4272-9138-f99709370657
 2006-12-22 05:19:56 +00:00
Nils Wallménius
20338ca60d Removed unused button defines and made private functions static 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11750 a1c6a512-1295-4272-9138-f99709370657
 2006-12-13 11:52:21 +00:00
Nils Wallménius
ed15e2994d 1) Delete unused files from old database and old gui files 2) Remove unneccesary includes of the old database header 3) Delete the deprecated databox plugin 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11715 a1c6a512-1295-4272-9138-f99709370657
 2006-12-11 20:21:36 +00:00
Peter D'Hoye
3e1f837d11 Turned function back into define as that uses less bytes because gcc inlined the function. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11699 a1c6a512-1295-4272-9138-f99709370657
 2006-12-09 12:27:04 +00:00
Peter D'Hoye
552ac5a724 Fix crash in browser when using very big fonts and show path option together. Solves FS#6397. Patch created by Mark Arigo and modified by me. Minor code ploicing while in there. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11696 a1c6a512-1295-4272-9138-f99709370657
 2006-12-09 10:02:09 +00:00
Jonathan Gordon
4049d44b03 dont allow the ata callbacks to be run less than once every 30s unless 
explicitly forced to.
The sleep_after param is only true in the Q_SLEEP event, so its uneeded,
so removed


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11599 a1c6a512-1295-4272-9138-f99709370657
 2006-11-26 09:53:42 +00:00
Jens Arnold
38d716660e Fix bug in large-value handling of gui_scrollbar_draw() that went unnoticed for ages... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11587 a1c6a512-1295-4272-9138-f99709370657
 2006-11-25 00:20:53 +00:00
Magnus Holmgren
ea7992455a Make the updated %rg tag match playback behaviour (fall back to track gain if album gain requested but not available). Share the mode decision logic with playback code and simplify the %rg tag handling. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11532 a1c6a512-1295-4272-9138-f99709370657
 2006-11-15 20:26:33 +00:00
Martin Scarratt
442c0e663f Improved replaygain tags for WPS by Ian Webber fs#6223. Shows the current status of the gain rather than what the setting is set to. %?rg<off|track|album|shuffletrack|shufflealbum|notag>. Also, %rg will give the current gain adjustment. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11531 a1c6a512-1295-4272-9138-f99709370657
 2006-11-15 17:29:03 +00:00
Jens Arnold
0297873f6a Backdrop support for greyscale targets. WPS backdrop is untested. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11520 a1c6a512-1295-4272-9138-f99709370657
 2006-11-13 00:45:21 +00:00
Jens Arnold
780f79e7a4 Removed the Gmini 120 and Gmini SP code. These ports are dead, unfortunately. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11504 a1c6a512-1295-4272-9138-f99709370657
 2006-11-10 20:26:01 +00:00
Jonathan Gordon
d9f7ac24f4 fix booboo in ata.c (SYS_POWEROFF falling into SYS_USB_CONNECTED) 
enable ata_idle callbacks in ata_mmc.c (calls the callbacks after 10s of
real inactivity)
fix builds


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11462 a1c6a512-1295-4272-9138-f99709370657
 2006-11-08 02:23:01 +00:00
Michael Sevakis
0f5cb94aa4 Big Patch adds primarily: Samplerate and format selection to recording for SWCODEC. Supprort for samplerates changing in playback (just goes with the recording part inseparably). Samplerates to all encoders. Encoders can be configured individually on a menu specific to the encoder in the recording menu. File creation is delayed until flush time to reduce spinups when splitting. Misc: statusbar icons for numbers are individual digits to display any number. Audio buffer was rearranged to maximize memory available to recording and properly reinitialized when trashed. ColdFire PCM stuff moved to target tree to avoid a complicated mess when adding samplerate switching. Some needed API changes and to neaten up growing gap between hardware and software codecs. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11452 a1c6a512-1295-4272-9138-f99709370657
 2006-11-06 18:07:30 +00:00
Jonathan Gordon
6a1161b634 dont allow the volume setting to wrap 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11445 a1c6a512-1295-4272-9138-f99709370657
 2006-11-06 10:11:51 +00:00
Jonathan Gordon
717f63e8e2 fixes fs# 5938 - scrollbar with title enabled shows one less than it should 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11412 a1c6a512-1295-4272-9138-f99709370657
 2006-11-01 12:03:27 +00:00
Jens Arnold
c1767ddf4a Remove format_align from the format_lines array, as it's unnecessary. Saves code & memory. Patch by Mark Arigo. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11388 a1c6a512-1295-4272-9138-f99709370657
 2006-10-30 00:23:32 +00:00
Michael Sevakis
e0710b2af1 More color adjustments. Better translation to and from native colors with even distribution of levels. Macros for extracting native depth components and packing them. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11227 a1c6a512-1295-4272-9138-f99709370657
 2006-10-15 17:51:00 +00:00
Michael Sevakis
6aa12c11f7 Added a small interface to screens to translate colors into remote gray levels on the x5. Splash screens paint properly with light gray. Should be adapted to a more general approach in the future. A few trailing whitespace trimmings got into a couple files but that is fine. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11218 a1c6a512-1295-4272-9138-f99709370657
 2006-10-14 01:32:58 +00:00
Michael Sevakis
e627e35439 More visual annoyance fixes. Backdrops no longer show though on centered splash screens. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11213 a1c6a512-1295-4272-9138-f99709370657
 2006-10-13 11:53:57 +00:00
Michael Sevakis
6e46bc2c19 One little thing needed changing in gui_bitmap_scrollbar_draw. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11211 a1c6a512-1295-4272-9138-f99709370657
 2006-10-13 04:25:47 +00:00
Michael Sevakis
661c3406a9 Added inner fill option to normal scrollbar and foreground only option. Added a left-pointing cursor for using pointer. Updated color picker and now sliders look very good on color, grayscale and mono screens when using bar selector. Some misc. changes for appearance. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11210 a1c6a512-1295-4272-9138-f99709370657
 2006-10-13 04:16:49 +00:00
Dave Chapman
fc865cb5a8 Revert change to screen_access.c (adding the native-bitmap drawing function) that caused warnings on the H3x0. We now draw the USB logo using the normal lcd_bitmap() and lcd_remote_bitmap() functions instead of the screens API, which doesn't handle the differing bitmaps types well. Remove apps/gui/logo.[ch] as they are now longer used. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11208 a1c6a512-1295-4272-9138-f99709370657
 2006-10-12 20:45:31 +00:00
Michael Sevakis
a7c8c71dad Corrected the calculation to determine to display three sliders or one in the colorpicker. Same wonderment as before... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11197 a1c6a512-1295-4272-9138-f99709370657
 2006-10-12 00:50:13 +00:00
Michael Sevakis
fa0ea19d5a Fixed the problem with the backdrops on iPod. The same problem was in the updated color picker and that is fixed too. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11195 a1c6a512-1295-4272-9138-f99709370657
 2006-10-11 23:26:17 +00:00
Michael Sevakis
cc66aea55d Made color picker work on x5 remote and display nicely when using backdrops. Also tweaked the appearance in general. Keymap still does not entirely function however (no inc/dec yet). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11193 a1c6a512-1295-4272-9138-f99709370657
 2006-10-11 20:34:25 +00:00
Jens Arnold
803331841e Splash function: Fixed several bugs and problems: (1) Off-by-one bug caused a buffer overflow with splash text longer than the screen. (2) Last line wasn't centered properly in the same situation. (3) On player, string display length must be calculated using utf8length() instead of strlen() since unicode support was added (old bug). (4) Handle splash texts with multiple spaces properly, including correct length calculation and stripping on wrap. (5) Don't reset fg/bg colours to default if not centering (old bug). * Increased buffer sizes to account for (a) larger screens (b) utf-8 (c) words wider than the screen. * More efficient code. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11144 a1c6a512-1295-4272-9138-f99709370657
 2006-10-07 16:37:30 +00:00
Dave Chapman
da2bf53230 Move USB logo to an external (native-depth) bitmap. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11137 a1c6a512-1295-4272-9138-f99709370657
 2006-10-06 08:37:22 +00:00
Shachar Liberman
f5a3569899 Should fix yellow player buid. warning only occurred on the real target so I've missed it 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11116 a1c6a512-1295-4272-9138-f99709370657
 2006-10-03 15:02:49 +00:00
Shachar Liberman
f5452c0bde Improved code for the splash function: spare some calculation, fix a bug for screens wider then 255 (ipod 5g), fix FS#5775 by displaying complete lines instead of word by word. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11113 a1c6a512-1295-4272-9138-f99709370657
 2006-10-02 23:54:28 +00:00
Martin Scarratt
183499a2d4 Recording screen statusbar: Improved channel icon by Paul Louden and improved Q value display for Hardware codec targets 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11062 a1c6a512-1295-4272-9138-f99709370657
 2006-09-26 11:56:59 +00:00
Martin Scarratt
4a1d8d272a fix warning 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11043 a1c6a512-1295-4272-9138-f99709370657
 2006-09-25 11:06:54 +00:00
Martin Scarratt
1ab1f02dfe fix the bug where when scrolling text left in the filebrowser you could suddenly find yourself in the root directory. A long press on the left scrolling button will still take you to the root quickly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11042 a1c6a512-1295-4272-9138-f99709370657
 2006-09-25 10:56:38 +00:00
Jonathan Gordon
4553069f9d holding left in the tree will quickly get back to root, as long as the text is in the left-most position (like before) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10965 a1c6a512-1295-4272-9138-f99709370657
 2006-09-17 08:30:17 +00:00
Magnus Holmgren
1ecdbcced2 Save a few bytes on hwcodec targets... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10937 a1c6a512-1295-4272-9138-f99709370657
 2006-09-12 20:32:06 +00:00
Martin Scarratt
98f78870f8 fix some sim warnings 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10936 a1c6a512-1295-4272-9138-f99709370657
 2006-09-12 19:11:51 +00:00
Martin Scarratt
d7fa569df6 Improved statusbar icons in recording screen by Davide Gentile 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10935 a1c6a512-1295-4272-9138-f99709370657
 2006-09-12 18:26:27 +00:00
Martin Scarratt
617b67e769 Display bitrate (Q value for Archos), samplerate, channels and recording format (M = MP3) in the statusbar in the recording screen. This is all new info for archos targets and I-river targets now have this info on the remote as well as the main screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10856 a1c6a512-1295-4272-9138-f99709370657
 2006-09-02 17:30:30 +00:00
Magnus Holmgren
606f745c7c WPS: Fix problem with transparancy in the first image of an enum. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10793 a1c6a512-1295-4272-9138-f99709370657
 2006-08-29 12:54:22 +00:00
Magnus Holmgren
ed1a26d567 1 is the correct value here. Not that it makes any difference... :) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10760 a1c6a512-1295-4272-9138-f99709370657
 2006-08-26 15:52:44 +00:00
Magnus Holmgren
dd87c364a0 Make volume and battery level enums dynamic, inspired by patch 4802. Almost backwards compatible; for the battery level, the first enum is used when the level is unknown, while the remaining enums are used as before. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10756 a1c6a512-1295-4272-9138-f99709370657
 2006-08-26 13:25:33 +00:00
Mark Arigo
34301bb37b Add optional icon to list title, current path display shows a dir icon, and list titles now left-justified. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10726 a1c6a512-1295-4272-9138-f99709370657
 2006-08-23 20:02:06 +00:00
Jonathan Gordon
66c4bd6e63 Stop lists wrapping when using page up/down 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10712 a1c6a512-1295-4272-9138-f99709370657
 2006-08-23 08:35:31 +00:00
Jonathan Gordon
cbcc9db1a8 initial (re)support for F3 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10689 a1c6a512-1295-4272-9138-f99709370657
 2006-08-22 08:23:24 +00:00
Jonathan Gordon
89ed855b89 directory navigation in wps works as before (short then long next/prev) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10687 a1c6a512-1295-4272-9138-f99709370657
 2006-08-22 07:57:40 +00:00
Jonathan Gordon
d12f81ddd4 fixed the settings action context, time/eq/colour chooser/dbug screens 
should all work correctly again


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10670 a1c6a512-1295-4272-9138-f99709370657
 2006-08-21 07:03:15 +00:00
Jonathan Gordon
f1781318d3 software keylock works again 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10632 a1c6a512-1295-4272-9138-f99709370657
 2006-08-17 12:33:36 +00:00
Jonathan Gordon
07d3db2dec really fix the yes/no screen now, also id3 viewer shows the status bar 
correctly


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10630 a1c6a512-1295-4272-9138-f99709370657
 2006-08-17 09:28:04 +00:00
Jonathan Gordon
f7db043fbc * fix pitchscreen 
* stop yes/no screen eating the first press sometimes
* add enter id3 button from wps in irivier
* update keymap-h10 from Barry Wardell


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10614 a1c6a512-1295-4272-9138-f99709370657
 2006-08-16 14:14:16 +00:00
Jonathan Gordon
5e5bfabf67 * fixed the pitch screen key mappings for all targets, targets require a 
mapping to access the screen from the wps


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10611 a1c6a512-1295-4272-9138-f99709370657
 2006-08-16 13:25:45 +00:00
Linus Nielsen Feltzing
75765df6df Prevent accidental track skip when entering the WPS 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10610 a1c6a512-1295-4272-9138-f99709370657
 2006-08-16 13:03:50 +00:00
Dan Everton
98c9f959e5 Clear file view title if the user turns it off. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10596 a1c6a512-1295-4272-9138-f99709370657
 2006-08-15 22:14:35 +00:00
Jonathan Gordon
599fa9a627 fix "off-by-one" bug in paginated scrolling with the title 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10589 a1c6a512-1295-4272-9138-f99709370657
 2006-08-15 14:06:29 +00:00
Linus Nielsen Feltzing
224c0a13eb Finally, the new button action system is here, thanks to Jonathan Gordon. Some button mappings have changed and other things may break. Comments should go to the forum, http://forums.rockbox.org/index.php?topic=5829.0 or the mailing list. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10582 a1c6a512-1295-4272-9138-f99709370657
 2006-08-15 12:27:07 +00:00
Dan Everton
c0f8b18770 A few changes and fixes for the title in the file view: disable title string in tagcache view, strip leading / from current directory title, center title properly, scroll title if it's too long. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10581 a1c6a512-1295-4272-9138-f99709370657
 2006-08-15 12:23:55 +00:00
Dave Chapman
079ad11896 Patch #5795 from Jonathan Gordon - change the settings display for enumerations and integers to use the list widget. Patch also adds an optional title to the list widget which is used in the settings. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10576 a1c6a512-1295-4272-9138-f99709370657
 2006-08-15 08:14:46 +00:00
Shachar Liberman
f53779d2f4 Committing FS#5182 - One button hold for Horizontal screen scrolling. 
=>hold RIGHT or LEFT button on a GUI based list to scroll horizontally.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10545 a1c6a512-1295-4272-9138-f99709370657
 2006-08-12 13:40:49 +00:00
Martin Scarratt
6c30b95504 Oops...Stupid text editor! 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10459 a1c6a512-1295-4272-9138-f99709370657
 2006-08-05 12:47:42 +00:00
Daniel Stenberg
1e88be518a Barry Wardell's keymappings for H10 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10446 a1c6a512-1295-4272-9138-f99709370657
 2006-08-03 20:17:25 +00:00
Martin Scarratt
aa6ce70ba2 fix crossfeed tag 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10440 a1c6a512-1295-4272-9138-f99709370657
 2006-08-03 17:56:24 +00:00
Martin Scarratt
d68ae6a7a6 WPS tags: Crossfade %?xf<off|shuffle|skip|always>, Replay gain %?rg<off|track|album|shuffle>, Crossfeed %xd<off|on>. Bits and bobs from patches 2740, 2684 and 2680 by Myself, Stephan Wezel and Robert Kukla. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10414 a1c6a512-1295-4272-9138-f99709370657
 2006-08-02 17:35:41 +00:00
Jens Arnold
05ddd9a44e X5 remote LCD drawing. This will break target linking atm - lcd_remote_update[_rect]() are not yet implemented. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10347 a1c6a512-1295-4272-9138-f99709370657
 2006-07-28 07:35:45 +00:00
Dave Chapman
91d2678de8 Oops - fix warning and ensure bg_col is always set to a value. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10248 a1c6a512-1295-4272-9138-f99709370657
 2006-07-19 15:07:08 +00:00
Dave Chapman
3ea74cc1b4 Patch #5584 from Jonathan Gordon - fix the remote support for the colour picker 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10247 a1c6a512-1295-4272-9138-f99709370657
 2006-07-19 14:31:24 +00:00
Martin Scarratt
aeefeab54b Ensure long press of stop button in WPS stops play thanks to Slasheri and Amiconn 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10233 a1c6a512-1295-4272-9138-f99709370657
 2006-07-18 15:12:49 +00:00
Linus Nielsen Feltzing
df1df9560b Fixed a bug introduced in patch #5630 which caused the battery icon to disappear in the engineeer2 WPS 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10229 a1c6a512-1295-4272-9138-f99709370657
 2006-07-18 12:59:16 +00:00
Linus Nielsen Feltzing
aea41cc221 Patch #5630 by Andreas Mattsson - Minimize WPS subline swap time shift 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10211 a1c6a512-1295-4272-9138-f99709370657
 2006-07-13 21:34:36 +00:00
Kevin Ferrare
f64280ff00 OOPS Forgot remote keys bindings for the ID3 info screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10176 a1c6a512-1295-4272-9138-f99709370657
 2006-07-02 16:18:59 +00:00
Kevin Ferrare
f77ac7a6a7 added support remote support for the id3 infos screen (had to slightly change the list engine to use it here as well), corrected a mistake in the french translation 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10175 a1c6a512-1295-4272-9138-f99709370657
 2006-07-02 12:28:27 +00:00
Linus Nielsen Feltzing
c26a085162 Restore the WPS display correctly after leaving the F3 quick screen on Archos devices 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10172 a1c6a512-1295-4272-9138-f99709370657
 2006-07-01 14:03:07 +00:00
Jens Arnold
b89bb31281 Recorder, Player: * Fix remote up/down in lists (browser, menu). * Add remote butons for settings. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10146 a1c6a512-1295-4272-9138-f99709370657
 2006-06-22 06:38:57 +00:00
Jens Arnold
c129f21586 Ondio, iPods (except video): Fix disappearing volume icon when plugging USB power. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10142 a1c6a512-1295-4272-9138-f99709370657
 2006-06-21 18:41:57 +00:00
Jens Arnold
0dd1f8ec11 Work-in-progress rework of charging status reading & display: * Changed several charging related HAVE_* macros into one multi-value CONFIG_CHARGING. * Always use proper macros for charging states. * Battery symbol charging animation now starts from current level on all targets with charging. Two-colour animation kept for non-b&w targets. Round down fill level while charging as before, but round to nearest pixel value for discharging on all targets. * Charging anim fixed on player. * Some code cleanup. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10080 a1c6a512-1295-4272-9138-f99709370657
 2006-06-06 22:23:52 +00:00
Hardeep Sidhu
d2a4762847 Added a yield() after each pgup/pgdn similar to what is done for prev/next. Fixes B#5354. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10054 a1c6a512-1295-4272-9138-f99709370657
 2006-06-04 17:14:17 +00:00
Peter D'Hoye
93b899d0fe Reworked backdrop handling. Fixes a bug that wasn't in the tracker yet ;) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9970 a1c6a512-1295-4272-9138-f99709370657
 2006-05-21 11:00:02 +00:00
Peter D'Hoye
965e824923 Check if backdrop available at wps load. Clear old backdrop pointer when the user has removed it while being in the menu. Fixes bug 5351 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9961 a1c6a512-1295-4272-9138-f99709370657
 2006-05-18 22:00:28 +00:00
Linus Nielsen Feltzing
264d8f69ab Enable next-dir skip on platforms with no directly mapped button combos (click-longclick of next/prev) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9933 a1c6a512-1295-4272-9138-f99709370657
 2006-05-15 06:59:18 +00:00
Peter D'Hoye
23aa325d1d Caption-backlight: don't keep backlight on if paused as this keeps the backlight on forever. Fixes bug 5050. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9854 a1c6a512-1295-4272-9138-f99709370657
 2006-05-01 19:50:44 +00:00
Peter D'Hoye
9fe9a4f347 Also clear WPS backdrop when shutting down (same fix as in usb event handling). Fixes bug 5222 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9851 a1c6a512-1295-4272-9138-f99709370657
 2006-05-01 14:24:06 +00:00
Peter D'Hoye
4bfdd1fca1 Clear wps backdrop on USB event when in wps. Fix for bug report 4752 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9831 a1c6a512-1295-4272-9138-f99709370657
 2006-04-29 10:56:57 +00:00
Dave Chapman
9f34872df0 Make the get_image_id() function more robust, and catch a parsing error when parsing the %x tags. This prevents Rockbox crashing when presented with an incorrect %x|filename.bmp| WPS line. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9755 a1c6a512-1295-4272-9138-f99709370657
 2006-04-22 09:02:59 +00:00
Zakk Roberts
8a0ea50ee2 Updated pitch screen again. *Back to old behavior of only coming up on ON+UP/DOWN (Archos) or PLAY+UP/DOWN (iriver) - fixes FS#4928. *Button mappings changed: Up/Down = +/- 0.1%; holding Up/Down = +/- 2%; Left/Right = 'temporary' +/- 2% (old behavior). *SWCODEC: pcmbuf_set_low_latency, now you can hear pitch adjustments quicker. *Broke pitchscreen code into two parts; one to draw and one to deal with buttons. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9751 a1c6a512-1295-4272-9138-f99709370657
 2006-04-21 06:11:24 +00:00
Brandon Low
2b18727a8a Fix dir skipping with new playback arch. Enable dir skipping on ipod with a couple of difficult combos (select|right/left) or short-long left / short-long right. The latter causes stuck in pause sometimes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9720 a1c6a512-1295-4272-9138-f99709370657
 2006-04-18 18:33:09 +00:00
Zakk Roberts
a0a01b38e2 Readjusted quickscreen code so that it now actually scales to larger LCDs. Get rid of 'left_right_text' argument - this also means that 'scroll bar' and 'status bar' look better in some languages. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9602 a1c6a512-1295-4272-9138-f99709370657
 2006-04-11 06:38:10 +00:00
Brandon Low
574c5242e0 Quick bugfix for skip-to-beginning behavior 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9599 a1c6a512-1295-4272-9138-f99709370657
 2006-04-11 01:41:40 +00:00
Zakk Roberts
2f943b054c Enabled the quickscreen for iAudio X5. Globally, REC enters the menu and holding REC enters the quickscreen. Also moved the quickscreen #define to model config files, which simplifies the checking for it and makes checking more consistent. Cleaned up keymappings in quickscreen.h. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9590 a1c6a512-1295-4272-9138-f99709370657
 2006-04-10 03:51:17 +00:00
Brandon Low
bf6f9c66a1 Enable AB repeat on ipods with 4g keypad, requires quick fingers or you get the context menu instead of a marker. Thanks to Mikachu on IRC. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9589 a1c6a512-1295-4272-9138-f99709370657
 2006-04-10 00:39:48 +00:00
Miika Pekkarinen
bd39c25586 Now define the _PRE-function correctly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9585 a1c6a512-1295-4272-9138-f99709370657
 2006-04-09 19:17:32 +00:00
Magnus Holmgren
92ff0e292d Back out the 'do not stop playback until stop button has been released' change, because of interaction issues with exiting menus using the same button, causing the wps to exit. (Also, the '_PRE' suffix is for 'preceeding' events (e.g., button presses), not button releases.) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9584 a1c6a512-1295-4272-9138-f99709370657
 2006-04-09 17:08:32 +00:00
Miika Pekkarinen
6b7dff6e77 Do not stop playback until stop button has been released or shutdown 
triggered.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9532 a1c6a512-1295-4272-9138-f99709370657
 2006-04-06 09:01:30 +00:00
Brandon Low
857db456af Fix seeking on swcodec, but probably break some cases of skipping. Another important rework here, buffer management is serialized along with most other operations on the audio thread. This has some minor performance issues on ipod that can lead to audio skips during buffer fill as well. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9529 a1c6a512-1295-4272-9138-f99709370657
 2006-04-06 04:07:06 +00:00
Brandon Low
a69c495e5d Patches from bug #5001 by Rani Hod, should make settings more resiliant to having 'off-step' values in a general way, but specifically fixes that bug report, and also round the current sleep timer value up when entering settings for sleep timer 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9527 a1c6a512-1295-4272-9138-f99709370657
 2006-04-05 22:36:42 +00:00
Brandon Low
6cd6a447e0 Fix buggy WPS change from earlier 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9524 a1c6a512-1295-4272-9138-f99709370657
 2006-04-05 20:48:44 +00:00
Brandon Low
686fc085f1 Remove wasted instruction 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9521 a1c6a512-1295-4272-9138-f99709370657
 2006-04-05 16:14:38 +00:00
Brandon Low
a482da3692 Inspired by patch 4784 by Dominik, add pitch to WPS 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9517 a1c6a512-1295-4272-9138-f99709370657
 2006-04-05 14:22:40 +00:00
Hristo Kovachev
23dc42ce45 Use the display->width property instead of the hardcoded LCD_WIDTH. Now the quickscreen is displayed correctly on the LCD remotes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9482 a1c6a512-1295-4272-9138-f99709370657
 2006-04-04 07:01:24 +00:00
Hristo Kovachev
38deb8f13a Patch #4864 by Jonathan Gordon: text editor plugin, with some changes by me. 
Also correct a var clash between the rockbox's gui api and doom plugin


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9451 a1c6a512-1295-4272-9138-f99709370657
 2006-04-03 08:51:08 +00:00
Zakk Roberts
15b2eefd6b Updated quickscreens, now they look better than before while still retaining the ability to scroll - this is about as good as it gets until viewports are implemented. Also enabled the quickscreen for iPods. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9421 a1c6a512-1295-4272-9138-f99709370657
 2006-04-02 10:41:16 +00:00
Daniel Stenberg
02c540da41 Moved main menu button to REC for both file browser and WPS 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9333 a1c6a512-1295-4272-9138-f99709370657
 2006-03-28 21:35:18 +00:00
Linus Nielsen Feltzing
93b5f24083 Patch #2854 by David Dent - %bs WPS tag for sleep timer 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9303 a1c6a512-1295-4272-9138-f99709370657
 2006-03-28 10:07:34 +00:00
Dan Everton
b66477adcc Support the recording screen on the LCD remote. Also adds support for the peakmeter in the rremote WPS. Patch from Martin Scarratt (task 4818). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9246 a1c6a512-1295-4272-9138-f99709370657
 2006-03-25 13:35:31 +00:00
Linus Nielsen Feltzing
ab1019a1e8 Patch #4843 by Nicolas Pennequin - Correct status bar and backdrop in ID3 info screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9156 a1c6a512-1295-4272-9138-f99709370657
 2006-03-21 11:31:53 +00:00
Zakk Roberts
87afd0b050 Reworked pitch screen for easier adjustment and better looks. Added some button definitions for iPods - coming soon to a Sound Settings menu near you... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9146 a1c6a512-1295-4272-9138-f99709370657
 2006-03-21 07:59:23 +00:00
Zakk Roberts
28cb5e732d Fix the iPod button mappings for the settings menus so that Left accepts and leaves the current setting screen instead of Right (Select still works too). This makes more sense and conforms to the config of other targets. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9144 a1c6a512-1295-4272-9138-f99709370657
 2006-03-21 02:23:27 +00:00
Zakk Roberts
b81f596486 Patch by Jonathan Gordon for bug report FS#4861 - map Select (Navi) to save the settings in the color picker in addition to Play. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9143 a1c6a512-1295-4272-9138-f99709370657
 2006-03-21 02:02:04 +00:00
Björn Stenberg
fc390af3e8 Added 'Party Mode': Unstoppable playback 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9114 a1c6a512-1295-4272-9138-f99709370657
 2006-03-19 08:40:31 +00:00
Brandon Low
ddf7c70a45 Real Time Clock support in the WPS 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9105 a1c6a512-1295-4272-9138-f99709370657
 2006-03-18 22:42:02 +00:00
Brandon Low
211d827c0a Fix ifdefing for wps hold button tags, enables hold button in wps for ipod 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9052 a1c6a512-1295-4272-9138-f99709370657
 2006-03-15 20:16:21 +00:00
Linus Nielsen Feltzing
2499601955 Correct a problem with WPS backdrops not loading correctly, and semi-prepare for remote WPS backdrops 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9035 a1c6a512-1295-4272-9138-f99709370657
 2006-03-14 12:05:22 +00:00
Miika Pekkarinen
451ee0b11c Charging state reporting for iriver players. Values calibrated with 
1900 mAh Ionity battery; might need recalibration with the stock
battery.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9030 a1c6a512-1295-4272-9138-f99709370657
 2006-03-13 16:11:30 +00:00
Zakk Roberts
b1b0e42ddd Redesigned F2/F3 quick screens to put each option and its value on its own, scrolling line - fixes the problems with long strings the old design had. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9017 a1c6a512-1295-4272-9138-f99709370657
 2006-03-12 23:45:40 +00:00
Linus Nielsen Feltzing
1a66809ce1 Patch #4739 by Matthias Mohr - Clear WPS backdrop when loading new WPS 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9007 a1c6a512-1295-4272-9138-f99709370657
 2006-03-11 22:06:43 +00:00
Dan Everton
5b854a9a23 Fix player target and sim. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8984 a1c6a512-1295-4272-9138-f99709370657
 2006-03-09 22:26:22 +00:00
Dan Everton
4a9ac1497f Reset font before calculating number of lines to display in the list. Fixes returning to a list display from a plugin that changes the display font. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8982 a1c6a512-1295-4272-9138-f99709370657
 2006-03-09 22:03:13 +00:00
Tomas Salfischberger
0b6bb8d8cc Woops, that button was already in use on those targets. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8903 a1c6a512-1295-4272-9138-f99709370657
 2006-03-04 15:52:21 +00:00
Tomas Salfischberger
625454b690 Patch FS#4744 - This patch maps the "Off" button in the pitch screen to reset the playing speed. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8902 a1c6a512-1295-4272-9138-f99709370657
 2006-03-04 15:35:29 +00:00
Zakk Roberts
87142ab6bb Patch 4765 by Jonathan Gordon - don't allow the same colors to be selected for foreground and background. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8900 a1c6a512-1295-4272-9138-f99709370657
 2006-03-04 10:55:54 +00:00
Brandon Low
6d19a569be Improved battery status reporting for units which support usb power / charge 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8886 a1c6a512-1295-4272-9138-f99709370657
 2006-03-02 13:37:51 +00:00
Marcoen Hirschberg
8d0a32eb4b gigabeat related changes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8885 a1c6a512-1295-4272-9138-f99709370657
 2006-03-02 13:28:24 +00:00