Create a new widget which holds the contents of the manual tab and its logic.
Unify its display / download code. Fixes FS#12587, which was caused by
duplicated code.
Change-Id: I5721d2a95ebeaf80481c1fd149eda22cf1328501
Instead of passing a parameter to decide if a dialog box should be shown pass a
pointer to the parent widget and make it static. This allows calling it from
outside while keeping the possibility to not show a warning.
Change-Id: I72fa53a7e8a83d527c22b698dfa434c24100ac29
1) On all non PLA plugin, power button is used for exit. For consistency,
we set PLA_EXIT to power button.
2) Manual updated accordingly
Change-Id: Ia4b8fce13bad2f8dc0710cdb29ccf6c74b3fd9c4
Reviewed-on: http://gerrit.rockbox.org/91
Reviewed-by: Thomas Martitz <kugel@rockbox.org>
Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
Since smoothing was enabled for battery_status_update() in 109084d, the simulated charge/ discharge cycle was so fast that the battery level never really dropped much below 90%.
Change-Id: Ide5c7ceef97bc9ed62d45e3a0afd99ff6f0550ea
On Windows /dev/random does not exist, so trying to open it will fail. Replace
it with rand() which is available on all supported platforms and sufficient.
Fixes mkimxboot not working, as well as Rockbox Utility "crashing" (which is in
fact its error handler calling exit(), thus terminating Rockbox Utility) on
Windows.
Change-Id: Ia164f937f329877e8f80f473f27be8c5df2a0a68
1) this patch replace all keymaps with PLA ones. It also clean some optionnal
compiling that are not needed anymore througt PLA
2) the patch also made required change to the manual in order to match code's
change.
Change-Id: I54ec953f79a419a6bb2f78877ca8b82f572fb510
Reviewed-on: http://gerrit.rockbox.org/86
Reviewed-by: Thomas Martitz <kugel@rockbox.org>
Tested-by: Thomas Martitz <kugel@rockbox.org>
This is the case if either the player has lots of lifes or a high score
Change-Id: Ic4c7011e9fa582d2ae552b28474ba260f2b4cab0
Reviewed-on: http://gerrit.rockbox.org/88
Reviewed-by: Jonathan Gordon <rockbox@jdgordon.info>
It wasn't only a52 but also a52_rm that didn't reset the elapsed counter on
each new track. The problems seemed obvious enough so fixes are being added
blind. Will leave task open for feedback from bug reporter.
Change-Id: Ic6d8eb98690ff4be47547d13b6bbafeadf4da745
Use these tags to stop having multiple conditionals.. e.g:
OLD: %?C<%?Ia<something>>
NEW: %?and(%C, %Ia)<something>
Change-Id: Ia3bbe4611cf808e87dcd1b1147181461fa08294a
Fixes a crash when leaving the encoder settings dialog with the Ok button but
the dynamically loaded library missing, in which case no settings will be
available.
Change-Id: I889a0bbcde6bed2df658b5df57341edf6802daad
Windows requires files to be explicitly opened as binaries, otherwise it will
perform line ending translations. We really don't want the OS to mess with
that.
Change-Id: Id56de354b7ad0e5b056540755f7108456f3263ed
Remove svn information from the version string as well, since we don't have
this information anymore.
Change-Id: I0055e6cd9e5e6cb1aaf678d91db183f4bc2117fe
First and rather rough adjustment for git. There are still a lot of places
referring to svn, and various functionality might be broken which needs fixing
later.
Change-Id: Ia628f06e99f527e01f131ce674746fba77d97d23
With git it's not possible to simply export a set of paths from the server
directly. This module offers a similar functionality, but requires a local
clone of the repository. It calls git directly for maximum portability.
This is a prerequisite to making the deployment script used for Rockbox Utility
work again.
Change-Id: I1aca8ddd40d16b6268c1d6a2fc23ac59e964c3c6
- For V2 and FM Recorders, don't recommend bootloader upgrade
due to FS#12426 BootBox bugs.
- When rockbox.ucl can't fit and the bootloader is old, the
bootloader needs to be upgraded.
- When RomBox start address differs, the bootloader is
not compatible with RomBox.
Change-Id: I7ca910805a64eb81faa21b2dde4842cd3b640f5a
Reviewed-on: http://gerrit.rockbox.org/71
Reviewed-by: Marcin Bukat <marcin.bukat@gmail.com>
- PCM playback DMA doesn't need the discard. Only recording DMA would
need it.
- When creating threads for another core, the core creating the thread only
needs to commit. The discard on the other core is handled elsewhere.
Change-Id: I864a0777e22f221a66218efd2c02ff3ad3889736
The former gives 0-based indexes, which is what our implementation returns,
making the "- 1" unnecessary.
Change-Id: I172ab5e06695be62e4a18d4fd0415b8314f5dc26
The headphone volume register value reads differently in Line1 and DAC mode.
Since the volume is not set again when switching between playback and radio,
we need to remember the hp volume and reapply setting when changing the mode.
Change-Id: I8fbd344f78653c19d81a39dd3f680ec6885cb1ec
